Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/carriers-deliveries/7.0-change-class-name-to-avoid-error_rde into lp:carriers-deliveries

Review: Approve code review, no test LGTM -- https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-change-class-name-to-avoid-error_rde/+merge/213881 Your team Stock and Logistic Core Editors is subscribed to branch lp:carriers-deliveries. -- Mailing list:

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/carriers-deliveries/6.1-change-class-name-to-avoid-error_rde into lp:carriers-deliveries/6.1

Review: Approve code review, no test LGTM -- https://code.launchpad.net/~camptocamp/carriers-deliveries/6.1-change-class-name-to-avoid-error_rde/+merge/213883 Your team Stock and Logistic Core Editors is subscribed to branch lp:carriers-deliveries/6.1. -- Mailing list:

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/partner-contact-management/partner_firstname_vre_firstname_crm into lp:partner-contact-management

Review: Approve code review, no test OK. I'd still like to see tests in the near future for this one. -- https://code.launchpad.net/~camptocamp/partner-contact-management/partner_firstname_vre_firstname_crm/+merge/213673 Your team Partner and Contact Core Editors is subscribed to branch

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/carriers-deliveries/6.1-change-class-name-to-avoid-error_rde into lp:carriers-deliveries/6.1

Review: Approve code review thanks! -- https://code.launchpad.net/~camptocamp/carriers-deliveries/6.1-change-class-name-to-avoid-error_rde/+merge/213883 Your team Stock and Logistic Core Editors is subscribed to branch lp:carriers-deliveries/6.1. -- Mailing list:

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/carriers-deliveries/7.0-change-class-name-to-avoid-error_rde into lp:carriers-deliveries

Review: Approve thanks -- https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-change-class-name-to-avoid-error_rde/+merge/213881 Your team Stock and Logistic Core Editors is subscribed to branch lp:carriers-deliveries. -- Mailing list:

[Openerp-community-reviewer] [Bug 1182111] Re: [trunk/7.0] multicompany: error message when creating a stock.move

** Changed in: openobject-addons Status: Confirmed = Fix Released -- You received this bug notification because you are a member of OpenERP Community Backports Team, which is subscribed to OpenERP Community Backports (Addons). https://bugs.launchpad.net/bugs/1182111 Title: [trunk/7.0]

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/6.1-fix-1182111-lep into lp:ocb-addons/6.1

Review: Approve Thanks, lgtm. -- https://code.launchpad.net/~camptocamp/ocb-addons/6.1-fix-1182111-lep/+merge/213979 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-addons/6.1. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to :

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/carriers-deliveries/7.0-change-class-name-to-avoid-error_rde into lp:carriers-deliveries

Review: Approve code review A frequent problem if you put a common python class name... Thanks for the patch. Regards. -- https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-change-class-name-to-avoid-error_rde/+merge/213881 Your team Stock and Logistic Core Editors is subscribed to

[Openerp-community-reviewer] [Merge] lp:~camptocamp/purchase-report/purchase_report_carriage_return_vre into lp:purchase-report

Vincent Renaville@camptocamp has proposed merging lp:~camptocamp/purchase-report/purchase_report_carriage_return_vre into lp:purchase-report. Requested reviews: Purchase Core Editors (purchase-core-editors) For more details, see:

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/account-financial-report/add_aged_partner_ledger-nbi into lp:account-financial-report

Hi Nicolas, I'm working as a business analyst for Acsone and Stéphane Bidoul asked me to make a functional test regarding the new Aged Partner Balance report . I noticed that the amounts are classified in the different columns (30, 60, etc.) based on the clearance Date. By default, this

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/carriers-deliveries/7.0-change-class-name-to-avoid-error_rde into lp:carriers-deliveries

Sure, but the mapping from class 'CarrierFile' (instead of 'carrier_file') to model 'carrier.file' is still equally obvious. -- https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-change-class-name-to-avoid-error_rde/+merge/213881 Your team Stock and Logistic Core Editors is

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/carriers-deliveries/7.0-change-class-name-to-avoid-error_rde into lp:carriers-deliveries

Stefan, what I mean is that I prefer CamelCase too, but I abstain here because SA uses underscores all over the place. -- https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-change-class-name-to-avoid-error_rde/+merge/213881 Your team Stock and Logistic Core Editors is subscribed to

[Openerp-community-reviewer] [Merge] lp:~camptocamp/sale-financial/7.0-port-sale_markup into lp:sale-financial

Yannick Vaucher @ Camptocamp has proposed merging lp:~camptocamp/sale-financial/7.0-port-sale_markup into lp:sale-financial. Requested reviews: Sale Core Editors (sale-core-editors) For more details, see: https://code.launchpad.net/~camptocamp/sale-financial/7.0-port-sale_markup/+merge/214061

[Openerp-community-reviewer] [Merge] lp:~camptocamp/sale-financial/7.0-port-sale_floor_price into lp:sale-financial

Yannick Vaucher @ Camptocamp has proposed merging lp:~camptocamp/sale-financial/7.0-port-sale_floor_price into lp:sale-financial. Requested reviews: Sale Core Editors (sale-core-editors) For more details, see:

[Openerp-community-reviewer] [Merge] lp:~camptocamp/sale-financial/7.0-port-sale_line_watcher into lp:sale-financial

Yannick Vaucher @ Camptocamp has proposed merging lp:~camptocamp/sale-financial/7.0-port-sale_line_watcher into lp:sale-financial. Requested reviews: Sale Core Editors (sale-core-editors) For more details, see:

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/sale-financial/7.0-port-sale_line_watcher into lp:sale-financial

Review: Needs Fixing code review Hi, Yannick, several things: - Instead of replacing a field, it's better to put position=attributes and only overwrite attribute on_change, so that you don't replace another attributes of the field. - I think it's better to use module web_context_tunnel to

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/carriers-deliveries/7.0-change-class-name-to-avoid-error_rde into lp:carriers-deliveries

ok for CapWords convention, thanks Stefan. -- https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-change-class-name-to-avoid-error_rde/+merge/213881 Your team Stock and Logistic Core Editors is subscribed to branch lp:carriers-deliveries. -- Mailing list:

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/margin-analysis/7.0-product_price_history-index-1301847 into lp:margin-analysis

Review: Approve code review, no test Good catch LGTM -- https://code.launchpad.net/~camptocamp/margin-analysis/7.0-product_price_history-index-1301847/+merge/214001 Your team Margin Analysis Core Editors is subscribed to branch lp:margin-analysis. -- Mailing list:

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/account-invoicing/adding_stock_invoice_picking_incoterm_7 into lp:account-invoicing

Review: Needs Fixing code review Hi, Alex, thank you very much for the contribution. Some remarks: - l.137: Please close string before \ to avoid that spaces on translations (you will have to export again translations): help=International Commercial Terms are a series of predefined \

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/web-addons/7.0-web_translate_dialog-sync-current-view-1301218-gbr into lp:web-addons

Review: Approve code review and test Hi, Guewen, thanks for the catch. I have tested your bug conditions and now it works as intended. Do you think it's possible to make a test for this condition to avoid future regressions? Another ask I made from my JS ignorance. Do you think it's possible

[Openerp-community-reviewer] [Merge] lp:~sylvain-legal/web-addons/7.0-web_easy_switch_company into lp:web-addons

The proposal to merge lp:~sylvain-legal/web-addons/7.0-web_easy_switch_company into lp:web-addons has been updated. Status: Needs review = Merged For more details, see: https://code.launchpad.net/~sylvain-legal/web-addons/7.0-web_easy_switch_company/+merge/210289 --

[Openerp-community-reviewer] [Merge] lp:~dreis-pt/project-service/7.0-project_issue_reassign-dr into lp:project-service

Daniel Reis has proposed merging lp:~dreis-pt/project-service/7.0-project_issue_reassign-dr into lp:project-service. Requested reviews: Project Core Editors (project-core-editors) For more details, see:

Re: [Openerp-community-reviewer] [Merge] lp:~dreis-pt/project-service/7.0-project_issue_reassign-dr into lp:project-service

It's ready to be reviewed. A new feature was added, to generate a notification when the Issue's responsibility changes. -- https://code.launchpad.net/~dreis-pt/project-service/7.0-project_issue_reassign-dr/+merge/195275 Your team Project Core Editors is requested to review the proposed merge of

[Openerp-community-reviewer] [Merge] lp:~acsone-openerp/account-financial-tools/account_credit_control_portal_portal_lp1248906 into lp:account-financial-tools

The proposal to merge lp:~acsone-openerp/account-financial-tools/account_credit_control_portal_portal_lp1248906 into lp:account-financial-tools has been updated. Status: Needs review = Work in progress For more details, see: