Review: Approve code review, no test
Thanks a lot !
--
https://code.launchpad.net/~stefan-therp/ocb-addons/7.0-lp1311628-dont_overwrite_empty_mail_catchall_domain/+merge/216877
Your team OpenERP Community Backports Team is subscribed to branch
lp:ocb-addons.
--
Mailing list: https://launchpa
** Changed in: ocb-addons/7.0
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of OpenERP
Community Backports Team, which is subscribed to OpenERP Community
Backports (Addons).
https://bugs.launchpad.net/bugs/1281290
Title:
Wrong curre
** Changed in: ocb-server/7.0
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of OpenERP
Community Backports Team, which is subscribed to OpenERP Community
Backports (Addons).
https://bugs.launchpad.net/bugs/1281290
Title:
Wrong curre
The proposal to merge lp:~camptocamp/ocb-server/7.0-fix_1281290-afe into
lp:ocb-server has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~camptocamp/ocb-server/7.0-fix_1281290-afe/+merge/215612
--
https://code.launchpad.net/~camptocamp/ocb-se
The proposal to merge lp:~camptocamp/ocb-addons/7.0-fix_1281290-afe into
lp:ocb-addons has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~camptocamp/ocb-addons/7.0-fix_1281290-afe/+merge/215614
--
https://code.launchpad.net/~camptocamp/ocb-ad
** Changed in: ocb-server/7.0
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of OpenERP
Community Backports Team, which is subscribed to OpenERP Community
Backports (Server).
https://bugs.launchpad.net/bugs/1204920
Title:
[trunk] Unb
Review: Approve
--
https://code.launchpad.net/~camptocamp/ocb-addons/7.0-fix_1281290-afe/+merge/215614
Your team OpenERP Community Backports Team is subscribed to branch
lp:ocb-addons.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@
Review: Approve
Approve as per http://en.wikipedia.org/wiki/Polish_z%C5%82oty.
--
https://code.launchpad.net/~camptocamp/ocb-server/7.0-fix_1281290-afe/+merge/215612
Your team OpenERP Community Backports Team is subscribed to branch
lp:ocb-server.
--
Mailing list: https://launchpad.net/~opene
The proposal to merge lp:~camptocamp/ocb-server/ocb-7.0-fix_1204920-afe into
lp:ocb-server has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~camptocamp/ocb-server/ocb-7.0-fix_1204920-afe/+merge/208390
--
https://code.launchpad.net/~camptocam
Review: Approve code review
LGTM.
Regards.
--
https://code.launchpad.net/~stefan-therp/ocb-addons/7.0-lp1311628-dont_overwrite_empty_mail_catchall_domain/+merge/216877
Your team OpenERP Community Backports Team is subscribed to branch
lp:ocb-addons.
--
Mailing list: https://launchpad.net/~ope
** Changed in: openobject-addons
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of OpenERP
Community Backports Team, which is subscribed to OpenERP Community
Backports (Addons).
https://bugs.launchpad.net/bugs/1180773
Title:
[7.0] hr
Review: Approve
--
https://code.launchpad.net/~camptocamp/ocb-server/ocb-7.0-fix_1204920-afe/+merge/208390
Your team OpenERP Community Backports Team is subscribed to branch
lp:ocb-server.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-revie
I see the upstream branch is green on runbot, and Holger's old comment has been
honoured.
Thanks!
--
https://code.launchpad.net/~camptocamp/ocb-server/ocb-7.0-fix_1204920-afe/+merge/208390
Your team OpenERP Community Backports Team is subscribed to branch
lp:ocb-server.
--
Mailing list: http
Review: Approve code review, no test
Ok LGTM
In view all commands are array of 3 elements:
http://bazaar.launchpad.net/~openerp/openerp-web/7.0/view/head:/addons/web/static/src/js/view_form.js#L3446
--
https://code.launchpad.net/~camptocamp/openerp-rma/rma-fix-lp1311509_rde/+merge/216824
Your te
Review: Needs Fixing
Ruchir, thanks for taking this dangling branch of Holger and propose it. I
assume you have tested it thoroughly. To qualify for a merge in OCB, you need
to prepare a branch that proposes the same change into upstream openerp-web.
Setting to needs-fixing to indicate that thi
Alex Comba - Agile BG has proposed merging
lp:~agilebg/openerp-product-attributes/adding_product_supplier_info_7 into
lp:openerp-product-attributes.
Commit message:
[ADD] module product_supplier_info
Requested reviews:
Product Core Editors (product-core-editors)
For more details, see:
https:
Just add a test to check invoice refund action
--
https://code.launchpad.net/~camptocamp/openerp-rma/rma-fix-lp1311509_rde/+merge/216824
Your team OpenERP RMA is subscribed to branch lp:openerp-rma.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-communit
Ruchir Shukla(BizzAppDev) has proposed merging
lp:~therp-nl/ocb-web/7.0-form_destroy_buttons into lp:ocb-web.
Requested reviews:
OpenERP Community Backports Team (ocb)
Related bugs:
Bug #1311076 in OpenERP Community Backports (Web): "multiple popup weird
behavior"
https://bugs.launchpad.ne
Review: Approve code review, no test
Thanks, you saved some kittens
--
https://code.launchpad.net/~camptocamp/account-budgeting/7.0-fix-store-fields-mdh/+merge/216849
Your team Account Core Editors is subscribed to branch lp:account-budgeting.
--
Mailing list: https://launchpad.net/~openerp-com
** Changed in: ocb-addons/7.0
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of OpenERP
Community Backports Team, which is subscribed to OpenERP Community
Backports (Addons).
https://bugs.launchpad.net/bugs/1311004
Title:
missing dat
Stefan Rijnhart (Therp) has proposed merging
lp:~stefan-therp/ocb-addons/7.0-lp1311628-dont_overwrite_empty_mail_catchall_domain
into lp:ocb-addons.
Requested reviews:
Lara (Therp) (lfreeke): test
OpenERP Community Backports Team (ocb)
Related bugs:
Bug #1311628 in OpenERP Community Backpo
** Changed in: ocb-addons/7.0
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of OpenERP
Community Backports Team, which is subscribed to OpenERP Community
Backports (Addons).
https://bugs.launchpad.net/bugs/1308364
Title:
[7.0] [trun
Review: Approve code review, no test
Thanks Alexandre, looks good now.
--
https://code.launchpad.net/~camptocamp/ocb-addons/6.1-fix_1311004_account_move_line_index-afe/+merge/216820
Your team OpenERP Community Backports Team is subscribed to branch
lp:ocb-addons/6.1.
--
Mailing list: https://l
The proposal to merge
lp:~camptocamp/ocb-addons/ocb-7.0-fix_1311004_account_move_line_index-afe into
lp:ocb-addons has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~camptocamp/ocb-addons/ocb-7.0-fix_1311004_account_move_line_index-afe/+merge/216
The proposal to merge lp:~camptocamp/ocb-addons/fix-1308364-nbi into
lp:ocb-addons has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~camptocamp/ocb-addons/fix-1308364-nbi/+merge/216023
--
https://code.launchpad.net/~camptocamp/ocb-addons/fix-130
Review: Approve
--
https://code.launchpad.net/~camptocamp/ocb-addons/fix-1308364-nbi/+merge/216023
Your team OpenERP Community Backports Team is subscribed to branch
lp:ocb-addons.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@list
The proposal to merge
lp:~camptocamp/ocb-addons/ocb-7.0-fix_1311004_account_move_line_index-afe into
lp:ocb-addons has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~camptocamp/ocb-addons/ocb-7.0-fix_1311004_account_move_line_index-afe/+mer
That was fast :)
--
https://code.launchpad.net/~camptocamp/ocb-addons/7.0-fix-1309105/+merge/216681
Your team OpenERP Community Backports Team is requested to review the proposed
merge of lp:~camptocamp/ocb-addons/7.0-fix-1309105 into lp:ocb-addons.
--
Mailing list: https://launchpad.net/~opene
** Branch linked: lp:~stefan-therp/ocb-
addons/7.0-lp1311628-dont_overwrite_empty_mail_catchall_domain
** Also affects: ocb-addons
Importance: Undecided
Status: New
** Also affects: ocb-addons/7.0
Importance: Undecided
Status: New
** Changed in: ocb-addons/7.0
Status:
Hello,
I added the YAML test, in order to verify that the amounts are updated after a
new analytic line on the same analytic account was added.
Regards,
Matthieu
--
https://code.launchpad.net/~camptocamp/account-budgeting/7.0-fix-store-fields-mdh/+merge/216849
Your team Account Core Editors is
Review: Approve test
--
https://code.launchpad.net/~stefan-therp/ocb-addons/7.0-lp1311628-dont_overwrite_empty_mail_catchall_domain/+merge/216877
Your team OpenERP Community Backports Team is requested to review the proposed
merge of
lp:~stefan-therp/ocb-addons/7.0-lp1311628-dont_overwrite_emp
** No longer affects: ocb-addons/7.0
** No longer affects: ocb-addons
--
You received this bug notification because you are a member of OpenERP
Community Backports Team, which is subscribed to OpenERP Community
Backports (Addons).
https://bugs.launchpad.net/bugs/1309105
Title:
stock.picking.o
** Also affects: ocb-web
Importance: Undecided
Status: New
--
You received this bug notification because you are a member of OpenERP
Community Backports Team, which is subscribed to OpenERP Community
Backports (Web).
https://bugs.launchpad.net/bugs/1311076
Title:
multiple popup weird
The proposal to merge lp:~camptocamp/ocb-addons/7.0-fix-1309105 into
lp:ocb-addons has been updated.
Status: Needs review => Rejected
For more details, see:
https://code.launchpad.net/~camptocamp/ocb-addons/7.0-fix-1309105/+merge/216681
--
https://code.launchpad.net/~camptocamp/ocb-addons/7
Rejecting, as merged upstream
http://bazaar.launchpad.net/~openerp/openobject-addons/7.0/revision/10010
--
https://code.launchpad.net/~camptocamp/ocb-addons/7.0-fix-1309105/+merge/216681
Your team OpenERP Community Backports Team is requested to review the proposed
merge of lp:~camptocamp/ocb-ad
Hello,
Thanks for the report and the patch, it was merged in 7.0
revno: 10010 [merge]
revision-id: m...@openerp.com-20140423132552-hpnr2skutqranvsj
** Changed in: openobject-addons
Status: New => Fix Released
** Changed in: openobject-addons
Importance: Undecided => Low
--
You rece
Review: Approve code review
LGTM
Thanks.
--
https://code.launchpad.net/~stefan-therp/ocb-addons/7.0-lp1311628-dont_overwrite_empty_mail_catchall_domain/+merge/216872
Your team OpenERP Community Backports Team is subscribed to branch
lp:ocb-addons.
--
Mailing list: https://launchpad.net/~opene
thanks Matthieu.
I'm also not a fan of the SQL if I don't have a gun pointed at me. Hopefully
with the test it will be easier to improve that.
--
https://code.launchpad.net/~camptocamp/account-budgeting/7.0-fix-store-fields-mdh/+merge/216849
Your team Account Core Editors is subscribed to branch
@Alexandre, Leonardo:
I went back for a classical ORM approach. I don't think a store condition's
function is called by another user than the SUPERUSER, but it's better to be
safe.
I'm still refining a YAML test as well to add to this MP.
Regards,
Matthieu
--
https://code.launchpad.net/~campt
Stefan Rijnhart (Therp) has proposed merging
lp:~stefan-therp/ocb-addons/7.0-lp1311628-dont_overwrite_empty_mail_catchall_domain
into lp:ocb-addons.
Requested reviews:
OpenERP Community Backports Team (ocb)
Related bugs:
Bug #1311628 in OpenERP Addons: "Mail catchall domain parameter being r
Review: Needs Fixing code review, no test
Your SQL request maybe works but it is not written in an efficient way (2
DISTINCT, 1 subquery). This should be written with EXISTS.
And, each time you bypass the ORM to write raw SQL, $DEITY kills a kitten.
$DEITY also maims a puppy if you don't ensur
** No longer affects: ocb-addons/7.0
** No longer affects: ocb-addons
--
You received this bug notification because you are a member of OpenERP
Community Backports Team, which is subscribed to OpenERP Community
Backports (Addons).
https://bugs.launchpad.net/bugs/1210195
Title:
[trunk/7.0][add
@Leonardo: here is a SQL version of the request.
Tell me if that's okay for you.
Regards,
Matthieu Dietrich
--
https://code.launchpad.net/~camptocamp/account-budgeting/7.0-fix-store-fields-mdh/+merge/216849
Your team Account Core Editors is requested to review the proposed merge of
lp:~camptoca
Competing fix was merged in upstream 7.0:
https://code.launchpad.net/~openerp-dev/openobject-addons/7.0-opw-596679-rgo/+merge/186294.
Setting to rejected.
--
https://code.launchpad.net/~camptocamp/ocb-addons/7.0-fix-lp-1210195-RDE/+merge/181227
Your team OpenERP Community Backports Team is subs
Leonardo,
thanks for the review. For your questions:
1. yes, that field needs to be stored. The initial commit mentions that a sum
of the lines is used in a groupby view, which is the default view for budget
lines, coming from a project.
2. I think the optimal solution would be to retrieve all
I also noticed that only 20-25% of process log lines have the model field
filled. Why is this?
--
https://code.launchpad.net/~camptocamp/server-env-tools/7.0-monitoring/+merge/215138
Your team Server Environment And Tools Core Editors is subscribed to branch
lp:server-env-tools.
--
Mailing lis
Hello,
Ravi's fix was integrated into 7.0.
revno: 10007 [merge]
revision-id: m...@openerp.com-20140423100324-6stypg5uapnl1s5f
** Changed in: openobject-addons
Status: Fix Committed => Fix Released
** Changed in: openobject-addons
Importance: Undecided => Low
--
You received this bu
Review: Needs Fixing
Excellent addition. In fact, so good I'm trying it out in a production instance
:-)
Comments and suggestions:
L68: Explain in description that the Database scheduled logging must be
manually activated.
L73: Explain that logs can be viewed through menu Reporting -> Server
Matthieu Dietrich @ camptocamp has proposed merging
lp:~camptocamp/account-budgeting/7.0-fix-store-fields-mdh into
lp:account-budgeting.
Commit message:
[FIX] fixed store condition on fields 'analytic_amount', 'analytic_real_amount'
and 'analytic_diff_amount' + fixed function called by the stor
Review: Needs Fixing code review
I wonder if that trigger would impact performance.
As the code stands, a trigger like that does a search for every analytic line
we write. If we write 1000 analytic lines, same analytic account, we get 1000
queries.
This raises a few questions:
1. Do we actual
The proposal to merge lp:~camptocamp/account-budgeting/7.0-fix-store-fields-mdh
into lp:account-budgeting has been updated.
Description changed to:
The object in the store condition was the wrong one. I fixed it for the correct
one + fixed the now-called function.
For more details, see:
https:
Romain Deheele - Camptocamp has proposed merging
lp:~camptocamp/openerp-rma/rma-fix-lp1311520_rde into lp:openerp-rma.
Requested reviews:
OpenERP RMA (openerprma)
Related bugs:
Bug #1311520 in OpenERP RMA: "In Product Return, link Invoice with a line
without product_id raises an error"
htt
this depends on
https://code.launchpad.net/~camptocamp/purchase-wkfl/7.0-merge-po-hooks-lep/+merge/216745
--
https://code.launchpad.net/~camptocamp/sale-wkfl/7.0-dropshipping-merge-po-lep/+merge/216756
Your team Sale Core Editors is requested to review the proposed merge of
lp:~camptocamp/sale-w
The proposal to merge lp:~camptocamp/openerp-rma/rma-fix-lp1311520_rde into
lp:openerp-rma has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~camptocamp/openerp-rma/rma-fix-lp1311520_rde/+merge/216839
--
https://code.launchpad.net/~
Pedro, I proposed this to core trunk:
https://code.launchpad.net/~camptocamp/openobject-addons/trunk-refactor-po-merge-lep/+merge/216841
--
https://code.launchpad.net/~camptocamp/purchase-wkfl/7.0-merge-po-hooks-lep/+merge/216745
Your team Purchase Core Editors is subscribed to branch lp:purchase
Review: Approve code review
LGTM
Regards.
--
https://code.launchpad.net/~camptocamp/openerp-rma/rma-fix-lp1311509_rde/+merge/216824
Your team OpenERP RMA is subscribed to branch lp:openerp-rma.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-r
Romain Deheele - Camptocamp has proposed merging
lp:~camptocamp/openerp-rma/rma-fix-lp1311509_rde into lp:openerp-rma.
Requested reviews:
OpenERP RMA (openerprma)
Related bugs:
Bug #1311509 in OpenERP RMA: "Error when we try to create a refund"
https://bugs.launchpad.net/openerp-rma/+bug/13
Review: Needs Fixing code review, no tests
Hi,
Thanks for improving the module. I may not have the time to read all carefully,
just what I saw in a few minutes here:
* L269 : For the method "_get_default_warehouse", I prefer to get the WH
through the user because take one from get_object_ref
Just adding a small comment to say that Raphaël Valyi discovered a bug when
doing a "-u crm_claim_rma" with that branch (it breaks on the duplicate
constraint). We started digging to find a solution, but we didn't had time to
implement it yet.
--
https://code.launchpad.net/~akretion-team/opener
Review: Approve
Tnx!
--
https://code.launchpad.net/~pedro.baeza/ocb-addons/fix-lp_1254631/+merge/216728
Your team OpenERP Community Backports Team is subscribed to branch
lp:ocb-addons.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@
Review: Approve code review, no tests
Hi Alexis,
Thanks for that contrib. LGTM.
--
https://code.launchpad.net/~akretion-team/openerp-rma/add-crm-claim-rma-repair/+merge/215976
Your team OpenERP RMA is subscribed to branch lp:openerp-rma.
--
Mailing list: https://launchpad.net/~openerp-commun
The proposal to merge
lp:~camptocamp/openerp-rma/7.0-crm_claim_rma-add-picking-buttons into
lp:openerp-rma has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~camptocamp/openerp-rma/7.0-crm_claim_rma-add-picking-buttons/+merge/208334
--
https
Review: Approve code review, no tests
LGTM. Thanks !
--
https://code.launchpad.net/~camptocamp/openerp-rma/7.0-crm_claim_rma-add-picking-buttons/+merge/208334
Your team OpenERP RMA is subscribed to branch lp:openerp-rma.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to
The proposal to merge lp:~camptocamp/openerp-rma/7.0-fix-1282584 into
lp:openerp-rma has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~camptocamp/openerp-rma/7.0-fix-1282584/+merge/207450
--
https://code.launchpad.net/~camptocamp/openerp-rma
Review: Approve code review
LGTM
--
https://code.launchpad.net/~camptocamp/ocb-addons/6.1-fix_1311004_account_move_line_index-afe/+merge/216820
Your team OpenERP Community Backports Team is subscribed to branch
lp:ocb-addons/6.1.
--
Mailing list: https://launchpad.net/~openerp-community-review
Alexandre Fayolle - camptocamp has proposed merging
lp:~camptocamp/ocb-addons/6.1-fix_1311004_account_move_line_index-afe into
lp:ocb-addons/6.1.
Requested reviews:
OpenERP Core Team (openerp)
Guewen Baconnier @ Camptocamp (gbaconnier-c2c): code review
Yannick Vaucher @ Camptocamp (yvauche
66 matches
Mail list logo
