Review: Approve code review, no test
--
https://code.launchpad.net/~akretion-team/server-env-tools/web-context-tunnel/+merge/198599
Your team Server Environment And Tools Core Editors is subscribed to branch
lp:server-env-tools.
--
Mailing list:
Review: Approve code review
@Guewen,
as you can see with my last commits:
1) I removed the console.log statement
2) I added a web unit tests + instruction on how to run it
3) I added a section explaining how to run standard YAML tests for a module
using web_context_tunnel and gave a
The proposal to merge lp:~akretion-team/server-env-tools/web-context-tunnel
into lp:server-env-tools has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~akretion-team/server-env-tools/web-context-tunnel/+merge/198599
--
The proposal to merge lp:~akretion-team/server-env-tools/web-context-tunnel
into lp:server-env-tools has been updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~akretion-team/server-env-tools/web-context-tunnel/+merge/198599
--
Review: Approve code review, no test
A great way to avoid signature changes!
When approved, please promote its usage among known community modules with
these signature problems... ;-)
--
https://code.launchpad.net/~akretion-team/server-env-tools/web-context-tunnel/+merge/198599
Your team
Review: Needs Fixing
It could deserve a test.
You should remove the console.log()
What about the yaml tests? They use the views to apply automatically the
onchanges, so the tests will fail because they won't take the extra attributes
in account.
--
To help for the review, it's probably helpful to mention that the original
build_context method is defined this way:
https://github.com/akretion/openerp-web/blob/ocb-7.0/addons/web/static/src/js/view_form.js#L1866
Also, I'm redefining build_context on the prototype directly (instead of using
Review: Needs Fixing code review, no test
could you please:
* wrap the lines in __openerp__.py
* line 28-29: fix the newline
* line 39: s/Ad/And/
--
https://code.launchpad.net/~akretion-team/server-env-tools/web-context-tunnel/+merge/198599
Your team Server Environment And Tools Core Editors
Raphaël Valyi - http://www.akretion.com has proposed merging
lp:~akretion-team/server-env-tools/web-context-tunnel into lp:server-env-tools.
Requested reviews:
Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c): code review, no test
For more details, see:
@Alexandre Fayolle
Done. How is it now? Thanks.
--
https://code.launchpad.net/~akretion-team/server-env-tools/web-context-tunnel/+merge/198599
Your team Server Environment And Tools Core Editors is subscribed to branch
lp:server-env-tools.
--
Mailing list:
Review: Approve
This is a great workaround for a very very annoying problem of OpenERP : 2
modules inherit the same on_change to add arguments and it makes the 2 modules
incompatible. Almost all experienced OpenERP developers were already confronted
to this headache. This seems a clever and
11 matches
Mail list logo
