The proposal to merge
lp:~camptocamp/account-financial-tools/add-manual-line-and-fees-nbi into
lp:account-financial-tools has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~camptocamp/account-financial-tools/add-manual-line-and-fees-nbi/+me
The proposal to merge
lp:~camptocamp/account-financial-tools/add-manual-line-and-fees-nbi into
lp:account-financial-tools has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~camptocamp/account-financial-tools/add-manual-line-and-fees-nbi/+merge/21
Review: Needs Fixing
Thanks Nicolas. A few small remarks up to line 1300:
- l138 typo
- l143 seems like you are copying twice
Hello thanks for the review.
I fixed you remarks.
for l145 as I'm copying data, I want to stay polite and do not remove an
expected key ba an other piece of code.
Regards
Nicolas
--
https://code.launchpad.net/~camptocamp/account-financial-tools/add-manual-line-and-fees-nbi/+merge/218584
You
Review: Approve code review
Last few remarks to the end of the diff:
- 1407 the line is perhaps unintentional?
- 1299 typo "initialize"
- 2343 typo bypasses.
These are just small doc typos, so I'm appr
Review: Needs Fixing code review
Hello,
Just little things as:
- I see deprecated attribute type on form views (l.869, 906)
- l.2221: s/Euro policy level/Usd policy level
- l.1310, 1311: '==' instead of '='
Otherwise, few little typos:
- l.1709: s/writen/written
- l.1709: s/fields/field
- l.219
Review: Approve code review
Thanks for the changes,
Romain
--
https://code.launchpad.net/~camptocamp/account-financial-tools/add-manual-line-and-fees-nbi/+merge/218584
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:account-financial-tools.
--
Mailing list: https://
7 matches
Mail list logo
