[9] review request: 8150109: Cannot build FX apps or tests with JDK 9

2016-02-17 Thread Kevin Rushforth
Chien & Dave, Please review the following webrev to fix "gradle apps" and "gradle test" so they can compile when using JDK 9 as the boot JDK. https://bugs.openjdk.java.net/browse/JDK-8150109 http://cr.openjdk.java.net/~kcr/8150109/webrev.00/ Most of these are a result of old NB-generated buil

[9] review request: 8134709: Cannot compile FXDnD with JDK 9: DropTargetContext::addNotify, removeNotify not found

2016-02-17 Thread Kevin Rushforth
[fixed cut-and-paste error in the URL of the webrev and added bug description to subject line] Sergey & Alexander, Please review the following, which will allow the FX sdk to build with JDK 9. https://bugs.openjdk.java.net/browse/JDK-8134709 http://cr.openjdk.java.net/~kcr/8134709/webrev.00/

[9] review request: 8134709

2016-02-17 Thread Kevin Rushforth
Sergey & Alexander, Please review the following, which will allow the FX sdk to build with JDK 9. https://bugs.openjdk.java.net/browse/JDK-8134709 http://cr.openjdk.java.net/~kcr/8150109/webrev.00/ The premise of the fix, which just comments out the calls to the removed methods, is that sinc

Re: [9] review request: 8149967: Cannot compile JFXPanel with JDK 9: SurfaceData::getDefaultScale not found

2016-02-17 Thread Kevin Rushforth
Ah, I see. I missed that point. -- Kevin Jim Graham wrote: I think what Sergey was getting at is that in the short term you could use GC.getDefaultTransform() without any reflection as a workaround, but if you've already done the reflection work and it's going away shortly it doesn't really

Re: [9] review request: 8149967: Cannot compile JFXPanel with JDK 9: SurfaceData::getDefaultScale not found

2016-02-17 Thread Jim Graham
I think what Sergey was getting at is that in the short term you could use GC.getDefaultTransform() without any reflection as a workaround, but if you've already done the reflection work and it's going away shortly it doesn't really matter. In the end you would want to use the getScaleXY() met

Re: [Review request] 8088853: Applying dashed border to separator makes whole application hang

2016-02-17 Thread Jim Graham
Looks great. Approved... ...jim On 2/17/2016 1:11 AM, Andrey Rusakov wrote: Updated that: http://cr.openjdk.java.net/~arusakov/8088853/webrev.01 17.02.2016 01:22, Jim Graham пишет: [I believe you sent this to t

Re: plans to make JavaFX 8 platform independent again?

2016-02-17 Thread Tom Schindl
Hi, In general I think this whole Spinner thing is completely bogus Suppose the following: > Spinner s = new Spinner<>(0.0, 1.0, 0.0); > s.valueProperty().addListener( new > ChangeListener() { > > @Override >

Re: plans to make JavaFX 8 platform independent again?

2016-02-17 Thread Kevin Rushforth
Hi Stefan, Java and JavaFX are platform-independent, so asking whether we will "make it platform-independent again" is asking the wrong question. Really, your question should be: can a fix for a serious bug be backported to JDK 8 after it is fixed in JDK 9. The answer to that question is "ye

plans to make JavaFX 8 platform independent again?

2016-02-17 Thread Stefan Endrullis
Dear JavaFX team, over years one of the key features of Java was its platform independence. A Java application would run under Windows, Mac OS, and Linux (if well programmed). Since https://bugs.openjdk.java.net/browse/JDK-8146325 this is no longer the case. Once you use the JavaFX Spinner c

MOVE cursor not visible on Mac OS

2016-02-17 Thread Fisher, Robert
Hello, It seems the MOVE cursor is not displayed on Mac OS. You just get the default cursor. You can reproduce this easily e.g. using a ScrollPane with setPannable(true). Is this a bug or a restriction of Mac OS itself? I think there is an appropriate cursor available somehow, because in Google

Re: [9] review request: 8149967: Cannot compile JFXPanel with JDK 9: SurfaceData::getDefaultScale not found

2016-02-17 Thread Kevin Rushforth
Also, I plan to fix all remaining issues in the next day or two such that developers could switch to a JDK 9 boot JDK by the end of this week, which should make the fact that the JFXPanel scale is wrong when testing with JDK 8 less of a concern. -- Kevin Kevin Rushforth wrote: Thanks. I'll s

Re: [9] review request: 8149967: Cannot compile JFXPanel with JDK 9: SurfaceData::getDefaultScale not found

2016-02-17 Thread Kevin Rushforth
Thanks, Sergey. I will file a follow-up issue to remove the reflection code and provide a suitable replacement. -- Kevin Sergey Bylokhov wrote: Note that in jdk9 the same data can be obtained via GraphicsConfiguration.getDefaultTransform(); On 17.02.16 2:53, Jim Graham wrote: I added a c

Re: [9] review request: 8149967: Cannot compile JFXPanel with JDK 9: SurfaceData::getDefaultScale not found

2016-02-17 Thread Kevin Rushforth
Thanks. I'll send out a formal "heads-up" later today about moving to JDK 9 as the boot JDK. I hope to do this within two weeks if no issues arise. -- Kevin Jim Graham wrote: I added a comment on the bug about BC, but it sounds like you already considered it. I'm fine with this as is, but w

Re: [9] review request: 8149967: Cannot compile JFXPanel with JDK 9: SurfaceData::getDefaultScale not found

2016-02-17 Thread Sergey Bylokhov
Note that in jdk9 the same data can be obtained via GraphicsConfiguration.getDefaultTransform(); On 17.02.16 2:53, Jim Graham wrote: I added a comment on the bug about BC, but it sounds like you already considered it. I'm fine with this as is, but would push for moving to JDK9 ASAP...

Re: [Review request] 8088853: Applying dashed border to separator makes whole application hang

2016-02-17 Thread Andrey Rusakov
Updated that: http://cr.openjdk.java.net/~arusakov/8088853/webrev.01 17.02.2016 01:22, Jim Graham пишет: [I believe you sent this to the wrong mailing list - the "-request" list is for changing your membership to the mailing list, not f