Re: Webkit: Conversion from string literal loses const qualifier

2016-04-14 Thread Ali Ebrahimi
Hi, On Thu, Apr 14, 2016 at 11:30 AM, Murali Billa wrote: > Hi Ali, > > Are you getting error due to 2nd OR 3rd parameter?As per your error, > you are getting error for 3rd parameter right? As you already know, we > fixed the issue for 3rd parameter. > > ..\..\..\..\src\main\native\Source\We

Re: status behind JDK-8149738

2016-04-14 Thread Matthieu BROUILLARD
Many thanks to you and all the OpenJDK commiters for the great work & support that you provide. Matthieu On Wed, Apr 13, 2016 at 7:49 PM, Guru Hb wrote: > Hi Matthieu, > > I could re-produce the crash as you have mentioned. Thanks for helping out > to for the html test content. > > Please keep

Glass: CGLCreateContext error: 10002: empty window on MacOSX VM

2016-04-14 Thread Ali Ebrahimi
On macosx vm: We running with software pipeline user get CGLCreateContext error: 10002 in glass native code so this error causes empty window without any controls in app window. The following patch fixes this issue and I can run Ensemple8 application successfully. diff -r 3f15f2e59063 modules/gr

review: quiet Prism warnings

2016-04-14 Thread David Hill
Kevin, Chien, would you review this quick fix to quiet some warnings ? Tested on OEL, Ubuntu, Mac Windows. https://bugs.openjdk.java.net/browse/JDK-8154256 http://cr.openjdk.java.net/~ddhill/8154256/ -- David Hill Java Embedded Development "A man's feet should be planted in his country, but

[9] Review request: 8088916: Replace sun.net.www.ParseUtil#decode with public API

2016-04-14 Thread Alexander Zvegintsev
Hi Kevin, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8088916/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8088916 -- -- Thanks, Alexander.

Jvm crash: es2 pipeline crashs jvm on macosx vm

2016-04-14 Thread Ali Ebrahimi
When running javafx apps with es2 pipeline on macosx vm I get jvm crash. The following patch fixes this issue and I can run Ensemple8 application with es2 pipeline successfully. The good news is that 3D support is works fine. diff -r 3f15f2e59063 modules/graphics/src/main/native-prism-es2/macosx/

[9] Review request for 8154161: Webkit: Conversion from string literal loses const qualifier

2016-04-14 Thread Murali Billa
Hi Kevin, Alexander & Arun, Can you please review below fix. JBS : https://bugs.openjdk.java.net/browse/JDK-8154161 Webrev : http://cr.openjdk.java.net/~mbilla/8154161/webrev.00/ Thanks, Murali

[9] Review request: 8154203: Use StackWalker instead of the now-deprecated sun.reflect.Reflection class

2016-04-14 Thread Kevin Rushforth
Hi Vadim, Please review: https://bugs.openjdk.java.net/browse/JDK-8154203 http://cr.openjdk.java.net/~kcr/8154203/webrev.00/ It's a straight-forward fix to replace Reflection::getCallerClass with StackWalker::getCallerClass and remove the (no longer needed) CallerSensitive annotation. -- Ke

Re: [9] Review request: 8154203: Use StackWalker instead of the now-deprecated sun.reflect.Reflection class

2016-04-14 Thread Alan Bateman
On 14/04/2016 21:27, Kevin Rushforth wrote: Hi Vadim, Please review: https://bugs.openjdk.java.net/browse/JDK-8154203 http://cr.openjdk.java.net/~kcr/8154203/webrev.00/ It's a straight-forward fix to replace Reflection::getCallerClass with StackWalker::getCallerClass and remove the (no long

Re: Jvm crash: es2 pipeline crashs jvm on macosx vm

2016-04-14 Thread Chien Yang
Thanks reporting your finding and suggestion. Do you mind filing a bug report? Please include the steps and your system configuration that we may reproduce the crash on our end. https://wiki.openjdk.java.net/display/OpenJFX/Submitting+a+Bug+Report Thanks, - Chien On 4/14/2016 12:16 PM, Ali

Re: Glass: CGLCreateContext error: 10002: empty window on MacOSX VM

2016-04-14 Thread Chien Yang
We are interested in knowing how and when you use the software pipe of JavaFX on Mac. Can you please submit a bug report and provide those information? https://wiki.openjdk.java.net/display/OpenJFX/Submitting+a+Bug+Report Thanks, - Chien On 4/14/2016 11:41 AM, Ali Ebrahimi wrote: On macosx v

Re: [9] Review request: 8154203: Use StackWalker instead of the now-deprecated sun.reflect.Reflection class

2016-04-14 Thread Mandy Chung
> On Apr 14, 2016, at 3:27 PM, Kevin Rushforth > wrote: > > Hi Vadim, > > Please review: > > https://bugs.openjdk.java.net/browse/JDK-8154203 > http://cr.openjdk.java.net/~kcr/8154203/webrev.00/ > > It's a straight-forward fix to replace Reflection::getCallerClass with > StackWalker::getCal

Re: Jvm crash: es2 pipeline crashs jvm on macosx vm

2016-04-14 Thread Ali Ebrahimi
Hi Chien, I googled and found there are already similar crash reports in javafx8 timeframe for this problem: https://bugs.openjdk.java.net/browse/JDK-8096072 https://bugs.openjdk.java.net/browse/JDK-8092559 Since I can't comment on this issues on jira to add my patch, should I report new bug repo

Re: Glass: CGLCreateContext error: 10002: empty window on MacOSX VM

2016-04-14 Thread Ali Ebrahimi
Done. Review ID: JI-9035391 On Fri, Apr 15, 2016 at 2:47 AM, Chien Yang wrote: > We are interested in knowing how and when you use the software pipe of > JavaFX on Mac. Can you please submit a bug report and provide those > information? > > https://wiki.openjdk.java.net/display/OpenJFX/Submittin