Re: [9] Review request: 8178015: Clarify requirement for app modules to export/open packages to javafx modules

2017-04-17 Thread Mandy Chung
> On Apr 17, 2017, at 5:00 PM, Kevin Rushforth > wrote: > > Please review the following javadoc change: > > https://bugs.openjdk.java.net/browse/JDK-8178015 > http://cr.openjdk.java.net/~kcr/8178015/webrev.00/ > + * Applications in a Module : + * {@link Module#isOpen(String,Module) open} the

HEADS-UP: Bump the minimum buildnum for the boot JDK used by FX 9 (and FX 10) to build 165

2017-04-17 Thread Kevin Rushforth
The last module system refresh that went into build 165 moved the Module and Layer class from java.lang.reflect to java.lang. This is both a source and binary incompatible change, and since we want to reference Module in our javadocs (at least) it's time to bump the minimum build number to 165.

[9] Review request: 8178015: Clarify requirement for app modules to export/open packages to javafx modules

2017-04-17 Thread Kevin Rushforth
Please review the following javadoc change: https://bugs.openjdk.java.net/browse/JDK-8178015 http://cr.openjdk.java.net/~kcr/8178015/webrev.00/ This restores the links to the Module class that had to be removed during the transition period for the move of Module and Layer from java.lang.reflec

Re: [8u121] Review request for JDK-8177077: Constructing multiple Image objects using animated GIFs concurrently can fail with AIOOBE

2017-04-17 Thread Kevin Rushforth
One correction: All code reviews need to be done for JDK 10. This applies to the fix for 8178837 as well. Please resubmit the webrevs against FX 10-dev. Separately, once the fix is done, and if the fix is safe enough and important enough, we might consider it for a backport to JDK 9u (which i

[8u121] Review request for JDK-8177077: Constructing multiple Image objects using animated GIFs concurrently can fail with AIOOBE

2017-04-17 Thread Markus KARG
https://bugs.openjdk.java.net/browse/JDK-8177077 Please review the patch attached to JDK-8177077 I simply wrapped invocations to Timeline.play() and Timeline.stop() by Platform.runLater, so it should be thread safe now.

[10] Review request for 8176729: com.sun.webkit.dom.NodeImpl#SelfDisposer is not called

2017-04-17 Thread Murali Billa
    Hi Kevin, Arun, Guru Please review the fix for ­ JDK-8176729. JIRA: https://bugs.openjdk.java.net/browse/JDK-8176729   Webrev: http://cr.openjdk.java.net/~mbilla/8176729/webrev.00/   Thanks, Murali