Re: [RFR][8u-dev] : JDK-8189689 : JavaFX build fails with gcc 6

2018-10-11 Thread Kevin Rushforth
Looks good. +1 I'll push it tomorrow morning my time. -- Kevin On 10/11/2018 12:53 PM, Pankaj Bansal wrote: Hi Kevin, Please review the backport fix for JDK-8189689 . Webrev: http://cr.openjdk.java.net/~pbansal/8189689/webrev.00/

[RFR][8u-dev] : JDK-8189689 : JavaFX build fails with gcc 6

2018-10-11 Thread Pankaj Bansal
Hi Kevin, Please review the backport fix for HYPERLINK "https://bugs.openjdk.java.net/browse/JDK-8189689"JDK-8189689. Webrev: http://cr.openjdk.java.net/~pbansal/8189689/webrev.00/ Thanks, Pankaj

Re: Window opening glitch on ubuntu 18.04

2018-10-11 Thread Sverre Moe
Den tor. 11. okt. 2018 kl. 19:32 skrev Sverre Moe : > Den tor. 11. okt. 2018 kl. 19:17 skrev Kevin Rushforth < > kevin.rushfo...@oracle.com>: > >> https://bugs.openjdk.java.net/browse/JDK-8212060 >> >> > I have not noticed this on OpenSUSE Leap 15. The window pop up right in > the center of my

Re: Window opening glitch on ubuntu 18.04

2018-10-11 Thread Sverre Moe
Den tor. 11. okt. 2018 kl. 19:17 skrev Kevin Rushforth < kevin.rushfo...@oracle.com>: > https://bugs.openjdk.java.net/browse/JDK-8212060 > > I have not noticed this on OpenSUSE Leap 15. The window pop up right in the center of my screen in an instant. NVIDIA graphics with NVIDIA proprietary

Re: Window opening glitch on ubuntu 18.04

2018-10-11 Thread Kevin Rushforth
And this was reported even earlier at: https://github.com/javafxports/openjdk-jfx/issues/129 also with Ubuntu 18.04. I have added a pointer to both in the JBS bug. -- Kevin On 10/11/2018 10:16 AM, Kevin Rushforth wrote: https://bugs.openjdk.java.net/browse/JDK-8212060 On 10/11/2018 10:10

Re: Window opening glitch on ubuntu 18.04

2018-10-11 Thread Kevin Rushforth
https://bugs.openjdk.java.net/browse/JDK-8212060 On 10/11/2018 10:10 AM, Kevin Rushforth wrote: Someone reported a similar issue with a differrent Linux distro (Manjaro 17.1.12) also related to GTK 3: https://github.com/javafxports/openjdk-jfx/issues/217 I'll file a JBS bug for this. In the

Re: Window opening glitch on ubuntu 18.04

2018-10-11 Thread Kevin Rushforth
Someone reported a similar issue with a differrent Linux distro (Manjaro 17.1.12) also related to GTK 3: https://github.com/javafxports/openjdk-jfx/issues/217 I'll file a JBS bug for this. In the mean time, you can add a comment to the above GitHub issue if you like. -- Kevin On

Window opening glitch on ubuntu 18.04

2018-10-11 Thread Thiago Milczarek Sayão
I have migrated our development environment from java-10 javafx to java-11 and openjfx-11. One thing I have noticed is that windows opens on the top left corner of the screen and than moves to a center location. The weird thing is that we can see the window moving. It appears to be a glitch.

Re: [8u-backport] JDK-8087516 : [JavaFX] Conditional support for GTK 3 on Linux

2018-10-11 Thread Kevin Rushforth
I used the wrong bug ID below. Here is the right one: 8189689: JavaFX build fails with gcc 6 [1] Pankaj will send a backport request for this tomorrow. We should get this one in ASAP since 8u-dev is unable to compile on Ubuntu 18.04 today. -- Kevin [1]

Re: [8u-backport] JDK-8087516 : [JavaFX] Conditional support for GTK 3 on Linux

2018-10-11 Thread Kevin Rushforth
We use gcc 7.3 (and Oracle Linux 6 / 7) for our Hudson builds of FX 8 and don't see this problem. Pankaj asked about backporting the fix for that JDK-8203884, but I suggested it wasn't needed, since it is unrelated to this change. It sounds like we should backport JDK-8203884, though I prefer

Re: Compiling using javac

2018-10-11 Thread Graham Norris
** Reply to message from Abhinay Agarwal on Wed, 10 Oct 2018 09:49:06 + Abhinay, I've found I actually had two problems. The later one was while trying to get the sample to compile: --module-path will not tolerate a trailing "\" on the path. It doesn't reject it, it just makes it not work.

RE: [8u-backport] JDK-8087516 : [JavaFX] Conditional support for GTK 3 on Linux

2018-10-11 Thread Pankaj Bansal
Hi Johan,   Thanks for the review.   I used same gcc 7.3 and I was getting the compilation error in fxpackager. I used to build by making these changes locally on 18.04.   I discussed this with Kevin about backporting https://bugs.openjdk.java.net/browse/JDK-8189689. This fixes the issue

Re: [8u-backport] JDK-8087516 : [JavaFX] Conditional support for GTK 3 on Linux

2018-10-11 Thread Johan Vos
Hi Pankaj, What gcc version did you use to build on Ubuntu 18.04? Default, I think gcc 7.3 is used in 18.04 and that has the issue with wait() in modules/fxpackager/src/main/native/library/common/PosixPlatform.cpp (which was later replaced with wait(); ) This is blocking me to build 8u-dev on