Re: RFR: 8234150: Address ignored tests in ComboBoxTest, LabeledTest, HyperLinkTest and TextInputControlTest

2019-11-14 Thread Ajit Ghaisas
On Thu, 14 Nov 2019 18:49:18 GMT, Kevin Rushforth wrote: > On Thu, 14 Nov 2019 09:33:39 GMT, Ajit Ghaisas wrote: > >> This PR is to address ignored tests in ComboBoxTest, LabeledTest, >> HyperLinkTest and TextInputControlTest. >> >> strategy is as follows - >> >> 1) Enable tests marked with

Re: RFR: 8234194: [TEST_BUG] Reenable few graphics unit tests

2019-11-14 Thread Kevin Rushforth
On Thu, 14 Nov 2019 19:56:16 GMT, Ambarish Rapte wrote: > Following graphics unit tests can be re-enabled. > > 1. > test.com.sun.javafx.scene.layout.region.BackgroundRepeatConverterTest.scenario2 > RepeatStructConverter.convert() is an internal method and does not verify the > parameters. Pas

Re: [Approved] RFR: 8233421: Upgrade to Visual Studio 2017 version 15.9.16

2019-11-14 Thread Phil Race
On Thu, 14 Nov 2019 23:31:34 GMT, Kevin Rushforth wrote: > [JDK-8233421](https://bugs.openjdk.java.net/browse/JDK-8233421) > > This bumps the windows compiler version to VS2017 version 15.9.16 to match > JDK 14. I have run a full build and test, including WebKit and media. > >

Re: RFR: 8233420: Upgrade to gcc 8.3 on Linux

2019-11-14 Thread Kevin Rushforth
On Thu, 14 Nov 2019 23:34:49 GMT, Kevin Rushforth wrote: > [JDK-8233420](https://bugs.openjdk.java.net/browse/JDK-8233420) > > This bumps the Linux compiler version to gcc 8.3 to match JDK 14. I have run > a full build and test, including WebKit and media. > > > > Commits: >

RFR: 8233420: Upgrade to gcc 8.3 on Linux

2019-11-14 Thread Kevin Rushforth
[JDK-8233420](https://bugs.openjdk.java.net/browse/JDK-8233420) This bumps the Linux compiler version to gcc 8.3 to match JDK 14. I have run a full build and test, including WebKit and media. Commits: - ab06dc58: 8233420: Upgrade to gcc 8.3 on Linux Changes: https://git.openj

Re: RFR: 8233421: Upgrade to Visual Studio 2017 version 15.9.16

2019-11-14 Thread Kevin Rushforth
On Thu, 14 Nov 2019 23:31:34 GMT, Kevin Rushforth wrote: > [JDK-8233421](https://bugs.openjdk.java.net/browse/JDK-8233421) > > This bumps the windows compiler version to VS2017 version 15.9.16 to match > JDK 14. I have run a full build and test, including WebKit and media. > >

RFR: 8233421: Upgrade to Visual Studio 2017 version 15.9.16

2019-11-14 Thread Kevin Rushforth
[JDK-8233421](https://bugs.openjdk.java.net/browse/JDK-8233421) This bumps the windows compiler version to VS2017 version 15.9.16 to match JDK 14. I have run a full build and test, including WebKit and media. Commits: - aab19fa8: 8233421: Upgrade to Visual Studio 2017 version

Re: Ad NashornScriptEngine (Re: FXMLLoader: not supplying filename to script engine, not supplying event object as argument to script

2019-11-14 Thread Kevin Rushforth
On 11/14/2019 10:12 AM, Rony G. Flatscher wrote: On 14.11.2019 16:34, Rony G. Flatscher wrote: On 13.11.2019 19:50, Kevin Rushforth wrote: On 11/13/2019 9:42 AM, Rony G. Flatscher wrote: ... cut ... To reproduce the testcase one would need ooRexx and the Java bridge BSF4ooRexx (all openso

Re: HighDPI Scaling Bug On Linux With JavaFX Interoperability With SWT (Possible Solution)

2019-11-14 Thread Kevin Rushforth
Btw, the direct pointer to the JBS bug is: https://bugs.openjdk.java.net/browse/JDK-8233181 You're right that FXCanvas Hi-DPI support doesn't handle Linux at all. As for building JavaFX on Ubuntu 19.10, I just did that, but needed to disable warnings as errors, likely due to the fact that gcc

HighDPI Scaling Bug On Linux With JavaFX Interoperability With SWT (Possible Solution)

2019-11-14 Thread marcel Austenfeld
I filed this bug regarding the high dpi scaling on Linux when using the FXCanvas for SWT:   https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8233181   I think I found the problem in the FXCancas class whereas the Linux case is simply not handled:   https://github.com/openjdk/jfx/blob/mast

HighDPI Scaling Bug On Linux With JavaFX Interoperability With SWT (Possible Solution)

2019-11-14 Thread marcel Austenfeld

RFR: 8234194: [TEST_BUG] Reenable few graphics unit tests

2019-11-14 Thread Ambarish Rapte
Following graphics unit tests can be re-enabled. 1. test.com.sun.javafx.scene.layout.region.BackgroundRepeatConverterTest.scenario2 RepeatStructConverter.convert() is an internal method and does not verify the parameters. Passing null value to this method results in NPE. 2. test.javafx.scene.l

Re: RFR: 8234150: Address ignored tests in ComboBoxTest, LabeledTest, HyperLinkTest and TextInputControlTest

2019-11-14 Thread Kevin Rushforth
On Thu, 14 Nov 2019 09:33:39 GMT, Ajit Ghaisas wrote: > This PR is to address ignored tests in ComboBoxTest, LabeledTest, > HyperLinkTest and TextInputControlTest. > > strategy is as follows - > > 1) Enable tests marked with @Ignore by removing that tag > 2) Run the test > 3) If test Passes -

Re: RFR: 8193445: JavaFX CSS is applied redundantly leading to significant performance degradation

2019-11-14 Thread Kevin Rushforth
On Tue, 12 Nov 2019 16:45:04 GMT, Ajit Ghaisas wrote: > **Issue :** > https://bugs.openjdk.java.net/browse/JDK-8193445 > > **Background :** > The CSS performance improvement done in > [JDK-8151756](https://bugs.openjdk.java.net/browse/JDK-8151756) had to be > backed out due to functional regre

Re: [Approved] RFR: 8234189: [TEST_BUG] Remove ignored and invalid graphics unit tests

2019-11-14 Thread Kevin Rushforth
On Thu, 14 Nov 2019 17:53:29 GMT, Ambarish Rapte wrote: > Following unit tests are to be removed: > 1. test.com.sun.javafx.iio.ImageLoaderScalingTest.testAllTheScalesJPG: > Color of a pixel in original and scaled jpg image can not be guarantted to be > same. > > 2. test.javafx.scene.layout.Back

Re: Ad NashornScriptEngine (Re: FXMLLoader: not supplying filename to script engine, not supplying event object as argument to script

2019-11-14 Thread Rony G. Flatscher
On 14.11.2019 16:34, Rony G. Flatscher wrote: > On 13.11.2019 19:50, Kevin Rushforth wrote: >> On 11/13/2019 9:42 AM, Rony G. Flatscher wrote: ... cut ... >>> To reproduce the testcase one would need ooRexx and the Java bridge >>> BSF4ooRexx (all opensource) for >>> which I could come up with a zi

RFR: 8234189: [TEST_BUG] Remove ignored and invalid graphics unit tests

2019-11-14 Thread Ambarish Rapte
Following unit tests are to be removed: 1. test.com.sun.javafx.iio.ImageLoaderScalingTest.testAllTheScalesJPG: Color of a pixel in original and scaled jpg image can not be guarantted to be same. 2. test.javafx.scene.layout.BackgroundSizeTest.negativeWidthThrowsException3 test.javafx.scene.layout.

Re: [Approved] RFR: 8234174: Change IDEA VCS mapping to Git

2019-11-14 Thread Kevin Rushforth
On Thu, 14 Nov 2019 15:30:09 GMT, Alexander Scherbatiy wrote: > The pull request has been updated with additional changes. > > > > Added commits: > - c55e4d81: Restore new line in the end of .idea/vcs.xml file > > Changes: > - all: https://git.openjdk.java.net/jfx/pull/37/

Re: RFR: 8193445: JavaFX CSS is applied redundantly leading to significant performance degradation

2019-11-14 Thread David Grieve
On Thu, 14 Nov 2019 15:02:40 GMT, Dean Wookey wrote: > On Thu, 14 Nov 2019 14:27:24 GMT, Kevin Rushforth wrote: > >> On Thu, 14 Nov 2019 12:34:56 GMT, Kevin Rushforth wrote: >> >>> On Thu, 14 Nov 2019 11:33:24 GMT, Dean Wookey wrote: >>> On Wed, 13 Nov 2019 19:10:45 GMT, David Grieve

Correct diff (Re: FXMLLoader: not supplying filename to script engine, not supplying event object as argument to script

2019-11-14 Thread Rony G. Flatscher
Just for the record: attached the wrong diff, so attaching the correct one to this posting. Sorry for the confusion. ---rony On 13.11.2019 15:14, Rony G. Flatscher wrote: > Hmm, not getting any feedback so far, so wondering if there are currently any > Java developers who > take advantage of t

Ad NashornScriptEngine (Re: FXMLLoader: not supplying filename to script engine, not supplying event object as argument to script

2019-11-14 Thread Rony G. Flatscher
On 13.11.2019 19:50, Kevin Rushforth wrote: > > On 11/13/2019 9:42 AM, Rony G. Flatscher wrote: >> Will come up with a short reproducible testcase in ooRexx with brief >> comments such that the testcase >> could be understood without the runtime (ooRexx reads almost like >> pseudo-code). >> >> To

Re: [Rev 01] RFR: 8234174: Change IDEA VCS mapping to Git

2019-11-14 Thread Alexander Scherbatiy
The pull request has been updated with additional changes. Added commits: - c55e4d81: Restore new line in the end of .idea/vcs.xml file Changes: - all: https://git.openjdk.java.net/jfx/pull/37/files - new: https://git.openjdk.java.net/jfx/pull/37/files/f0f1866a..c55e4d81 W

Re: RFR: 8234174: Change IDEA VCS mapping to Git

2019-11-14 Thread Alexander Scherbatiy
On Thu, 14 Nov 2019 15:06:07 GMT, Kevin Rushforth wrote: > On Thu, 14 Nov 2019 14:35:26 GMT, Alexander Scherbatiy > wrote: > >> Allow IDEA to correctly detect Git version control system when opening JFX >> project. >> >> >> >> Commits: >> - f0f1866a: 8234174: Change IDEA V

Re: RFR: 8234174: Change IDEA VCS mapping to Git

2019-11-14 Thread Alexander Scherbatiy
On Thu, 14 Nov 2019 15:18:15 GMT, Alexander Scherbatiy wrote: > On Thu, 14 Nov 2019 15:06:07 GMT, Kevin Rushforth wrote: > >> On Thu, 14 Nov 2019 14:35:26 GMT, Alexander Scherbatiy >> wrote: >> >>> Allow IDEA to correctly detect Git version control system when opening JFX >>> project. >>>

Re: RFR: 8234174: Change IDEA VCS mapping to Git

2019-11-14 Thread Alexander Scherbatiy
On Thu, 14 Nov 2019 15:06:07 GMT, Kevin Rushforth wrote: > On Thu, 14 Nov 2019 14:35:26 GMT, Alexander Scherbatiy > wrote: > >> Allow IDEA to correctly detect Git version control system when opening JFX >> project. >> >> >> >> Commits: >> - f0f1866a: 8234174: Change IDEA V

Re: RFR: 8234174: Change IDEA VCS mapping to Git

2019-11-14 Thread Kevin Rushforth
On Thu, 14 Nov 2019 14:35:26 GMT, Alexander Scherbatiy wrote: > Allow IDEA to correctly detect Git version control system when opening JFX > project. > > > > Commits: > - f0f1866a: 8234174: Change IDEA VCS mapping to Git > > Changes: https://git.openjdk.java.net/jfx/pull/37

Re: RFR: 8193445: JavaFX CSS is applied redundantly leading to significant performance degradation

2019-11-14 Thread Dean Wookey
On Thu, 14 Nov 2019 14:27:24 GMT, Kevin Rushforth wrote: > On Thu, 14 Nov 2019 12:34:56 GMT, Kevin Rushforth wrote: > >> On Thu, 14 Nov 2019 11:33:24 GMT, Dean Wookey wrote: >> >>> On Wed, 13 Nov 2019 19:10:45 GMT, David Grieve >>> wrote: >>> On Tue, 12 Nov 2019 16:55:45 GMT, Ajit Gha

Re: RFR: 8234174: Change IDEA VCS mapping to Git

2019-11-14 Thread Thiago Milczarek Sayao
On Thu, 14 Nov 2019 14:35:28 GMT, Alexander Scherbatiy wrote: > On Thu, 14 Nov 2019 14:35:27 GMT, Kevin Rushforth wrote: > >> On Thu, 14 Nov 2019 14:35:26 GMT, Alexander Scherbatiy >> wrote: >> >>> Allow IDEA to correctly detect Git version control system when opening JFX >>> project. >>>

Re: RFR: 8234174: Change IDEA VCS mapping to Git

2019-11-14 Thread Alexander Scherbatiy
On Thu, 14 Nov 2019 14:35:27 GMT, Kevin Rushforth wrote: > On Thu, 14 Nov 2019 14:35:26 GMT, Alexander Scherbatiy > wrote: > >> Allow IDEA to correctly detect Git version control system when opening JFX >> project. >> >> >> >> Commits: >> - f0f1866a: 8234174: Change IDEA V

RFR: 8234174: Change IDEA VCS mapping to Git

2019-11-14 Thread Alexander Scherbatiy
Allow IDEA to correctly detect Git version control system when opening JFX project. Commits: - f0f1866a: 8234174: Change IDEA VCS mapping to Git Changes: https://git.openjdk.java.net/jfx/pull/37/files Webrev: https://webrevs.openjdk.java.net/jfx/37/webrev.00 Issue: https://

Re: RFR: 8234174: Change IDEA VCS mapping to Git

2019-11-14 Thread Kevin Rushforth
On Thu, 14 Nov 2019 14:35:26 GMT, Alexander Scherbatiy wrote: > Allow IDEA to correctly detect Git version control system when opening JFX > project. > > > > Commits: > - f0f1866a: 8234174: Change IDEA VCS mapping to Git > > Changes: https://git.openjdk.java.net/jfx/pull/37

Re: RFR: 8193445: JavaFX CSS is applied redundantly leading to significant performance degradation

2019-11-14 Thread Kevin Rushforth
On Thu, 14 Nov 2019 12:34:56 GMT, Kevin Rushforth wrote: > On Thu, 14 Nov 2019 11:33:24 GMT, Dean Wookey wrote: > >> On Wed, 13 Nov 2019 19:10:45 GMT, David Grieve >> wrote: >> >>> On Tue, 12 Nov 2019 16:55:45 GMT, Ajit Ghaisas wrote: >>> On Tue, 12 Nov 2019 16:52:54 GMT, Ajit Ghaisas

Re: RFR: 8193445: JavaFX CSS is applied redundantly leading to significant performance degradation

2019-11-14 Thread Kevin Rushforth
On Thu, 14 Nov 2019 11:33:24 GMT, Dean Wookey wrote: > On Wed, 13 Nov 2019 19:10:45 GMT, David Grieve > wrote: > >> On Tue, 12 Nov 2019 16:55:45 GMT, Ajit Ghaisas wrote: >> >>> On Tue, 12 Nov 2019 16:52:54 GMT, Ajit Ghaisas wrote: >>> On Tue, 12 Nov 2019 16:45:04 GMT, Ajit Ghaisas >

Re: [Integrated] RFR: 8234110: SwingFXUtilsTest is unsuitable for unit test framework

2019-11-14 Thread Kevin Rushforth
Changeset: dc013094 Author:Kevin Rushforth Date: 2019-11-14 11:59:08 + URL: https://git.openjdk.java.net/jfx/commit/dc013094 8234110: SwingFXUtilsTest is unsuitable for unit test framework Reviewed-by: aghaisas = tests/system/src/test/java/test/javafx/embed/swing/SwingFXUtils

Re: [Integrated] RFR: 8231188: Update SQLite to version 3.30.1

2019-11-14 Thread Kevin Rushforth
Changeset: 5b96ee42 Author:Arun Joseph Committer: Kevin Rushforth Date: 2019-11-14 11:57:24 + URL: https://git.openjdk.java.net/jfx/commit/5b96ee42 8231188: Update SQLite to version 3.30.1 Reviewed-by: kcr, jvos ! modules/javafx.web/src/main/native/Source/ThirdParty/sqlite/V

Re: RFR: 8231188: Update SQLite to version 3.30.1

2019-11-14 Thread Kevin Rushforth
On Thu, 14 Nov 2019 08:18:17 GMT, Johan Vos wrote: > On Wed, 13 Nov 2019 19:23:03 GMT, Kevin Rushforth wrote: > >> On Wed, 6 Nov 2019 10:17:05 GMT, Arun Joseph >> wrote: >> >>> We currently use SQLite version 3.28.0. We should update to the latest >>> stable release version 3.30.1 released.

Re: RFR: 8193445: JavaFX CSS is applied redundantly leading to significant performance degradation

2019-11-14 Thread Dean Wookey
On Wed, 13 Nov 2019 19:10:45 GMT, David Grieve wrote: > On Tue, 12 Nov 2019 16:55:45 GMT, Ajit Ghaisas wrote: > >> On Tue, 12 Nov 2019 16:52:54 GMT, Ajit Ghaisas wrote: >> >>> On Tue, 12 Nov 2019 16:45:04 GMT, Ajit Ghaisas wrote: >>> **Issue :** https://bugs.openjdk.java.net/brow

Re: [Approved] RFR: 8234110: SwingFXUtilsTest is unsuitable for unit test framework

2019-11-14 Thread Ajit Ghaisas
On Wed, 13 Nov 2019 22:54:01 GMT, Kevin Rushforth wrote: > This fixes [JDK-8234110](https://bugs.openjdk.java.net/browse/JDK-8234110) by > moving `SwingFXUtilsTest` from the `:swing` project to the `:systemTests` > project. As explained in the JBS issue, `SwingFXUtilsTest` must be run in its >

Re: [Approved] RFR: 8231188: Update SQLite to version 3.30.1

2019-11-14 Thread Johan Vos
On Wed, 6 Nov 2019 10:17:05 GMT, Arun Joseph wrote: > We currently use SQLite version 3.28.0. We should update to the latest stable > release version 3.30.1 released. > https://www.sqlite.org/index.html > > > > Commits: > - 24c6375d: 8231188: Update SQLite to version 3.30.1

RFR: 8234150: Address ignored tests in ComboBoxTest, LabeledTest, HyperLinkTest and TextInputControlTest

2019-11-14 Thread Ajit Ghaisas
This PR is to address ignored tests in ComboBoxTest, LabeledTest, HyperLinkTest and TextInputControlTest. strategy is as follows - 1) Enable tests marked with @Ignore by removing that tag 2) Run the test 3) If test Passes - remove the @Ignore tag 4) If test fails - if test is invalid - remove it

Re: RFR: 8231188: Update SQLite to version 3.30.1

2019-11-14 Thread Johan Vos
On Wed, 13 Nov 2019 19:23:03 GMT, Kevin Rushforth wrote: > On Wed, 6 Nov 2019 10:17:05 GMT, Arun Joseph > wrote: > >> We currently use SQLite version 3.28.0. We should update to the latest >> stable release version 3.30.1 released. >> https://www.sqlite.org/index.html >> >>