Re: [Approved] RFR: 8230610: Upgrade GStreamer to the latest 1.16.1

2019-11-21 Thread Alexander Matveev
On Thu, 21 Nov 2019 23:39:36 GMT, Kevin Rushforth wrote: > On Thu, 21 Nov 2019 01:00:33 GMT, Alexander Matveev > wrote: > >> - Upgraded GStreamer to 1.16.1 >> - Upgraded GLib to 2.62.2. >> - Removed glib-liteD.def, since it almost identical to release version >> glib-lite.def. Debug build wil

Re: [Approved] RFR: 8230610: Upgrade GStreamer to the latest 1.16.1

2019-11-21 Thread Kevin Rushforth
On Thu, 21 Nov 2019 01:00:33 GMT, Alexander Matveev wrote: > - Upgraded GStreamer to 1.16.1 > - Upgraded GLib to 2.62.2. > - Removed glib-liteD.def, since it almost identical to release version > glib-lite.def. Debug build will use glib-lite.def. > - No changes to other parts of code, except mi

Re: JavaFX-Bugs on GraalVM 19.3 (Java 11)

2019-11-21 Thread Michael Paus
I have filed this issue as: https://github.com/oracle/graal/issues/1867 This issue can be seen if you just use the GraalVM 19.3(11) in JIT mode as well as with a native-image via --force-fallback. When trying to create a real native-image of my application via the gluon client-plugin I just get

Re: JavaFX-Bugs on GraalVM 19.3 (Java 11)

2019-11-21 Thread Johan Vos
We're running pretty complex apps already, way beyond HelloFX. Startup time is amazing. GraalVM itself is already great. Tooling and configuration are the area where lots of work is still needed, and where Gluon Substrate is filling the gap. It still requires much more work, and documentation -- f

RE: JavaFX-Bugs on GraalVM 19.3 (Java 11)

2019-11-21 Thread Thiago Milczarek Sayao
Well, GraalVM page says it's production ready. By production ready I understand something way beyond "Hello, FX". Although, I would not expert perfection, since it's new technology. The blue text also happens on my machine, running Linux. Probably a bug on graalvm, as it does not happen with st

Re: JavaFX-Bugs on GraalVM 19.3 (Java 11)

2019-11-21 Thread Johan Vos
As I said a number of times, this is ground-breaking new area, and still work in progress. There is a reason we start with "Hello, FX" and not with "Launch Apollo 11". If you expect a 100,000 lines of code application to run without any issue from day 1 on a new platform, yes, you might be disappoi

Re: JavaFX-Bugs on GraalVM 19.3 (Java 11)

2019-11-21 Thread Dirk Lemmermann
OK, I understand. But a real world application that already consists of say 10 lines of code with tons of dependencies would require an enormous amount of work before the list of classes that need to be added to the reflections list is complete. This would be a trial and error approach. Laun

Re: JavaFX-Bugs on GraalVM 19.3 (Java 11)

2019-11-21 Thread Johan Vos
Please file issues if you run into them: * JavaFX related: http://bugs.openjdk.java.net/ * GraalVM related: https://github.com/oracle/graal/issues/ * Substrate related: https://github.com/gluonhq/substrate/issues Keep in mind that with these new approaches come new docs, so make sure to read them.

Re: [Integrated] RFR: 8234593: Mark LeakTest.testGarbageCollectability as unstable

2019-11-21 Thread Kevin Rushforth
Changeset: 4d3c723e Author:Arun Joseph Committer: Kevin Rushforth Date: 2019-11-21 18:12:26 + URL: https://git.openjdk.java.net/jfx/commit/4d3c723e 8234593: Mark LeakTest.testGarbageCollectability as unstable Reviewed-by: kcr ! modules/javafx.web/src/test/java/test/javafx/sc

Re: JavaFX-Bugs on GraalVM 19.3 (Java 11)

2019-11-21 Thread Dirk Lemmermann
After experimenting a lot today with the Gluon client plugin I must assume that currently not all of Java is supported via the substrate / GraalVM duo. For example I was unable to use the java.util.Preferences API. I also got an error that said Integer.parseInt() does not exist. Is that correct?

Re: [Approved] RFR: 8234593: Mark LeakTest.testGarbageCollectability as unstable

2019-11-21 Thread Kevin Rushforth
On Thu, 21 Nov 2019 16:56:06 GMT, Arun Joseph wrote: > The test.javafx.scene.web.LeakTest.testGarbageCollectability unit test is > failing intermittently. > > > > Commits: > - 1f7c5c8e: 8234593: Mark LeakTest.testGarbageCollectability as unstable > > Changes: https://git.ope

Re: JavaFX-Bugs on GraalVM 19.3 (Java 11)

2019-11-21 Thread Johan Vos
We have samples showing how to build and run JavaFX applications using GraalVM. See our blog post [1] with samples [2]. Keep in mind that JavaFX has some characteristics that make it non-trivial to apply native-image out of the box (reflection/jni configuration, platform-specific static libraries,

RFR: 8234593: Mark LeakTest.testGarbageCollectability as unstable

2019-11-21 Thread Arun Joseph
The test.javafx.scene.web.LeakTest.testGarbageCollectability unit test is failing intermittently. Commits: - 1f7c5c8e: 8234593: Mark LeakTest.testGarbageCollectability as unstable Changes: https://git.openjdk.java.net/jfx/pull/49/files Webrev: https://webrevs.openjdk.java.net

Re: [Rev 05] RFR: 8207957: TableSkinUtils should not contain actual code implementation

2019-11-21 Thread Jeanette Winzenburg
On Wed, 13 Nov 2019 11:26:35 GMT, Hadzic Samir wrote: > The pull request has been updated with additional changes. > > > > Added commits: > - e1a9d2d0: Add more unit tests upon review > > Changes: > - all: https://git.openjdk.java.net/jfx/pull/6/files > - new: https://git

Re: "Internal review ID : 9062887" (Re: FXMLLoader: not supplying filename to script engine, not supplying event object as argument to script

2019-11-21 Thread Rony G. Flatscher
As the zip-archive attachment got stripped, for a brief time the zip-archive can be fetched from . ---rony On 21.11.2019 15:29, Rony G. Flatscher wrote: > On 15.11.2019 16:08, Rony G. Flatscher wrote: >> On 14.11

"Internal review ID : 9062887" (Re: FXMLLoader: not supplying filename to script engine, not supplying event object as argument to script

2019-11-21 Thread Rony G. Flatscher
On 15.11.2019 16:08, Rony G. Flatscher wrote: > On 14.11.2019 22:57, Kevin Rushforth wrote: >> On 11/14/2019 10:12 AM, Rony G. Flatscher wrote: >>> On 14.11.2019 16:34, Rony G. Flatscher wrote: On 13.11.2019 19:50, Kevin Rushforth wrote: > On 11/13/2019 9:42 AM, Rony G. Flatscher wrote: >>

Re: [Integrated] RFR: 8234056: Upgrade to libxslt 1.1.34

2019-11-21 Thread Kevin Rushforth
Changeset: 5a398244 Author:Arun Joseph Committer: Kevin Rushforth Date: 2019-11-21 14:17:35 + URL: https://git.openjdk.java.net/jfx/commit/5a398244 8234056: Upgrade to libxslt 1.1.34 Reviewed-by: kcr, jvos ! modules/javafx.web/src/main/legal/libxslt.md ! modules/javafx.web/s

Re: Typo in native-glass/win/OleUtils.h checkJavaException

2019-11-21 Thread Nir Lisker
I can fix the typo via https://bugs.openjdk.java.net/browse/JDK-8228867. On Wed, Nov 20, 2019 at 5:07 PM Scott Palmer wrote: > I discovered this by accident while trying to figure out where a certain > console message was coming from while debugging. > > I saw this printed to the console when te

Re: RFR: 8230610: Upgrade GStreamer to the latest 1.16.1

2019-11-21 Thread Kevin Rushforth
On Thu, 21 Nov 2019 01:00:33 GMT, Alexander Matveev wrote: > - Upgraded GStreamer to 1.16.1 > - Upgraded GLib to 2.62.2. > - Removed glib-liteD.def, since it almost identical to release version > glib-lite.def. Debug build will use glib-lite.def. > - No changes to other parts of code, except mi

Re: [Approved] RFR: 8234056: Upgrade to libxslt 1.1.34

2019-11-21 Thread Johan Vos
On Mon, 18 Nov 2019 13:29:32 GMT, Arun Joseph wrote: > We need to update the version of libxslt to the latest version, 1.1.34. > > > > Commits: > - 2d9c0bf3: 8234056: Upgrade to libxslt 1.1.34 > > Changes: https://git.openjdk.java.net/jfx/pull/45/files > Webrev: https://webr

RFR: 8230610: Upgrade GStreamer to the latest 1.16.1

2019-11-21 Thread Alexander Matveev
- Upgraded GStreamer to 1.16.1 - Upgraded GLib to 2.62.2. - Removed glib-liteD.def, since it almost identical to release version glib-lite.def. Debug build will use glib-lite.def. - No changes to other parts of code, except minor changes to makefiles. Commits: - 98e1157b: 82306

Re: JavaFX-Bugs on GraalVM 19.3 (Java 11)

2019-11-21 Thread Kevin Rushforth
In thinking about it further, since these are likely Graal bugs, it seems better to file them with the Graal team. -- Kevin On 11/21/2019 5:45 AM, Kevin Rushforth wrote: My guess is that these are GraalVM bugs rather than JavaFX bugs, but without debugging them it's hard to know for sure. J

Re: JavaFX-Bugs on GraalVM 19.3 (Java 11)

2019-11-21 Thread Kevin Rushforth
My guess is that these are GraalVM bugs rather than JavaFX bugs, but without debugging them it's hard to know for sure. Johan has spent a fair bit of time looking into running JavaFX on GraalVM, so might have some additional insights. As for bug tracking, I don't have a problem with using the