RFR: 8227808: Make GTK3 libraries mandatory for building on Linux

2019-12-04 Thread Ambarish Rapte
Need for the change [[JDK-8227808](https://bugs.openjdk.java.net/browse/JDK-8227808)]: Currently GTK3 is the default on Linux. However, there is build logic that will skip building glassgtk3 if the gtk3 development libraries are not installed. This creates a situation where the build will

Re: RFR: 8233747: JVM crash in com.sun.webkit.dom.DocumentImpl.createAttribute

2019-12-04 Thread Arun Joseph
On Thu, 28 Nov 2019 13:16:19 GMT, Arun Joseph wrote: > On Wed, 20 Nov 2019 15:04:07 GMT, Kevin Rushforth wrote: > >> On Wed, 20 Nov 2019 07:05:40 GMT, Arun Joseph wrote: >> >>> Issue: Native part of WebView throws a DOMException and then, continues >>> executing the rest of the function

Re: [Rev 03] RFR: 8233747: JVM crash in com.sun.webkit.dom.DocumentImpl.createAttribute

2019-12-04 Thread Arun Joseph
The pull request has been updated with additional changes. Added commits: - 472d77cf: Added spaces Changes: - all: https://git.openjdk.java.net/jfx/pull/47/files - new: https://git.openjdk.java.net/jfx/pull/47/files/7f6ed5bf..472d77cf Webrevs: - full:

Re: RFR: 8232524: SynchronizedObservableMap cannot be be protected for copying/iterating

2019-12-04 Thread Kevin Rushforth
On Wed, 4 Dec 2019 15:29:50 GMT, Kevin Rushforth wrote: > On Wed, 4 Dec 2019 14:50:21 GMT, Robert Lichtenberger > wrote: > >> On Tue, 3 Dec 2019 05:08:49 GMT, Ambarish Rapte wrote: >> >>> On Mon, 21 Oct 2019 10:19:04 GMT, Robert Lichtenberger >>> wrote: >>> By using the collection

Re: RFR: 8220722: ProgressBarSkin: adds strong listener to control's width property

2019-12-04 Thread Kevin Rushforth
On Wed, 4 Dec 2019 15:51:42 GMT, Jeanette Winzenburg wrote: > On Wed, 4 Dec 2019 15:49:47 GMT, Jeanette Winzenburg > wrote: > >> fix for https://bugs.openjdk.java.net/browse/JDK-8220722 >> >> - replaces the manually registered listener with registerChangeListener(...) >> - added test that's

Re: [Approved] RFR: 8233747: JVM crash in com.sun.webkit.dom.DocumentImpl.createAttribute

2019-12-04 Thread Kevin Rushforth
On Wed, 4 Dec 2019 14:07:27 GMT, Arun Joseph wrote: > The pull request has been updated with additional changes. > > > > Added commits: > - 7f6ed5bf: Added test for createAttribute > > Changes: > - all: https://git.openjdk.java.net/jfx/pull/47/files > - new:

Re: [Integrated] RFR: 8210955: DOMTest::testEventListenerCascade fails

2019-12-04 Thread Kevin Rushforth
Changeset: 1c27fbd2 Author:Arun Joseph Committer: Kevin Rushforth Date: 2019-12-04 16:36:40 + URL: https://git.openjdk.java.net/jfx/commit/1c27fbd2 8210955: DOMTest::testEventListenerCascade fails Reviewed-by: kcr !

Re: [Approved] RFR: 8232524: SynchronizedObservableMap cannot be be protected for copying/iterating

2019-12-04 Thread Ambarish Rapte
On Wed, 4 Dec 2019 14:50:19 GMT, Robert Lichtenberger wrote: > The pull request has been updated with additional changes. > > > > Added commits: > - 7c5cf198: 8232524: Test cleanup: terminate background thread upon failure. > > Changes: > - all:

Re: [Approved] RFR: 8232524: SynchronizedObservableMap cannot be be protected for copying/iterating

2019-12-04 Thread Ambarish Rapte
On Wed, 4 Dec 2019 14:50:19 GMT, Robert Lichtenberger wrote: > The pull request has been updated with additional changes. > > > > Added commits: > - 7c5cf198: 8232524: Test cleanup: terminate background thread upon failure. > > Changes: > - all:

Re: RFR: 8220722: ProgressBarSkin: adds strong listener to control's width property

2019-12-04 Thread Jeanette Winzenburg
On Wed, 4 Dec 2019 15:49:47 GMT, Jeanette Winzenburg wrote: > fix for https://bugs.openjdk.java.net/browse/JDK-8220722 > > - replaces the manually registered listener with registerChangeListener(...) > - added test that's failing before and passing after the fix (plus a sanity > test that the

RFR: 8220722: ProgressBarSkin: adds strong listener to control's width property

2019-12-04 Thread Jeanette Winzenburg
fix for https://bugs.openjdk.java.net/browse/JDK-8220722 - replaces the manually registered listener with registerChangeListener(...) - added test that's failing before and passing after the fix (plus a sanity test that the skin still is listening to changes) Commits: -

Re: [Approved] RFR: 8210955: DOMTest::testEventListenerCascade fails

2019-12-04 Thread Kevin Rushforth
On Tue, 19 Nov 2019 07:11:40 GMT, Arun Joseph wrote: > Modified the test to work with WebView's ordering of capturing and bubbling > event listeners. > > > > Commits: > - cbef0069: DOMTest::testEventListenerCascade fails > > Changes:

Re: RFR: 8232524: SynchronizedObservableMap cannot be be protected for copying/iterating

2019-12-04 Thread Kevin Rushforth
On Wed, 4 Dec 2019 14:50:21 GMT, Robert Lichtenberger wrote: > On Tue, 3 Dec 2019 05:08:49 GMT, Ambarish Rapte wrote: > >> On Mon, 21 Oct 2019 10:19:04 GMT, Robert Lichtenberger >> wrote: >> >>> By using the collection itself as synchronization lock we achieve behaviour >>> that matches

Re: [Approved] RFR: 8232524: SynchronizedObservableMap cannot be be protected for copying/iterating

2019-12-04 Thread Kevin Rushforth
On Wed, 4 Dec 2019 14:50:19 GMT, Robert Lichtenberger wrote: > The pull request has been updated with additional changes. > > > > Added commits: > - 7c5cf198: 8232524: Test cleanup: terminate background thread upon failure. > > Changes: > - all:

Re: [Rev 01] RFR: 8232524: SynchronizedObservableMap cannot be be protected for copying/iterating

2019-12-04 Thread Robert Lichtenberger
The pull request has been updated with additional changes. Added commits: - 7c5cf198: 8232524: Test cleanup: terminate background thread upon failure. Changes: - all: https://git.openjdk.java.net/jfx/pull/17/files - new:

Re: RFR: 8232524: SynchronizedObservableMap cannot be be protected for copying/iterating

2019-12-04 Thread Robert Lichtenberger
On Tue, 3 Dec 2019 05:08:49 GMT, Ambarish Rapte wrote: > On Mon, 21 Oct 2019 10:19:04 GMT, Robert Lichtenberger > wrote: > >> By using the collection itself as synchronization lock we achieve behaviour >> that matches java.util.Collections classes. >> >> I've create test cases that fail

Re: [Rev 02] RFR: 8233747: JVM crash in com.sun.webkit.dom.DocumentImpl.createAttribute

2019-12-04 Thread Arun Joseph
The pull request has been updated with additional changes. Added commits: - 7f6ed5bf: Added test for createAttribute Changes: - all: https://git.openjdk.java.net/jfx/pull/47/files - new: https://git.openjdk.java.net/jfx/pull/47/files/2bd56c11..7f6ed5bf Webrevs: - full:

Re: [Approved] RFR: 8235150: IosApplication does not pass the required object in _leaveNestedEventLoopImpl

2019-12-04 Thread Johan Vos
On Sat, 30 Nov 2019 18:23:07 GMT, Jose Pereda wrote: > In `GlassApplication.m` for iOS, the method > `Java_com_sun_glass_ui_ios_IosApplication__1leaveNestedEventLoopImpl` has > signature `(Ljava/lang/Object;)V`, however in `IosApplication.java`, > `_leaveNestedEventLoopImpl()` signature

Re: [Integrated] RFR: 8235151: Inexistent notifyQuit method referred from iOS GlassHelper.m

2019-12-04 Thread Johan Vos
Changeset: 2d4096a8 Author:Jose Pereda Committer: Johan Vos Date: 2019-12-04 12:17:44 + URL: https://git.openjdk.java.net/jfx/commit/2d4096a8 8235151: Nonexistent notifyQuit method referred from iOS GlassHelper.m Reviewed-by: jvos !