Re: RFR: 8233942: Update to 609.1 version of WebKit

2020-01-22 Thread Arun Joseph
On Mon, 20 Jan 2020 16:39:15 GMT, Guru Hb wrote: > Updated GTK Webkit 2.26 (609.1) into jfx. Marked as reviewed by ajoseph (Author). - PR: https://git.openjdk.java.net/jfx/pull/91

Re: [Rev 13] RFR: WIP: 8236651: Simplify and update glass gtk backend

2020-01-22 Thread Thiago Milczarek Sayao
> This proposed change does the following: > > - Ports DND target to use GTK reducing code size and adding extra text / > image formats (such as .gif); > - Use gtk signals instead of gdk events (also to reduce code size); > - Simplifies geometry (sizing/positioning) with a more straightforward co

Re: RFR: 8232824: Removing TabPane with strong referenced content causes memory leak from weak one

2020-01-22 Thread Kevin Rushforth
On Wed, 22 Jan 2020 17:53:38 GMT, Ambarish Rapte wrote: >> The fix looks good. I'll take a closer look at the unit test later. >> >> Speaking of tests...since the addition of the `TabPane` reordering logic was >> a victim of the already-existing leak in the `viewOrderChildren` list in >> `Pare

Re: [Integrated] RFR: 8236753: Animations do not play backwards after being stopped

2020-01-22 Thread Nir Lisker
Changeset: 9ae37f1f Author:Nir Lisker Date: 2020-01-22 20:58:12 + URL: https://git.openjdk.java.net/jfx/commit/9ae37f1f 8236753: Animations do not play backwards after being stopped Reviewed-by: kcr, arapte ! modules/javafx.graphics/src/main/java/javafx/animation/Animation.ja

Re: RFR: 8233942: Update to 609.1 version of WebKit

2020-01-22 Thread Johan Vos
On Mon, 20 Jan 2020 16:39:15 GMT, Guru Hb wrote: > Updated GTK Webkit 2.26 (609.1) into jfx. Marked as reviewed by jvos (Reviewer). - PR: https://git.openjdk.java.net/jfx/pull/91

Re: [Rev 01] RFR: 8236753: Animations do not play backwards after being stopped

2020-01-22 Thread Ambarish Rapte
On Wed, 22 Jan 2020 17:55:27 GMT, Nir Lisker wrote: >> The private field `lastPlayFinished` is responsible for 2 cases where an >> animation in `STOPPED` status does not play after `play()` is called if the >> rate is negative: >> >> 1. When the animation is created, it is `STOPPED` and `lastP

Re: RFR: 8232824: Removing TabPane with strong referenced content causes memory leak from weak one

2020-01-22 Thread Ambarish Rapte
On Fri, 17 Jan 2020 23:40:18 GMT, Kevin Rushforth wrote: >>> >>> >>> @arapte - This bug looks like a good candidate for JavaFX 14. Can you >>> retarget this PR to the jfx14 branch? >> >> Thanks for guiding Kevin, PR is now targeted to jfx14. > > The fix looks good. I'll take a closer look at

Re: [Rev 01] RFR: 8232824: Removing TabPane with strong referenced content causes memory leak from weak one

2020-01-22 Thread Ambarish Rapte
> This PR is a fix for > [JDK-8232824](https://bugs.openjdk.java.net/browse/JDK-8232824) > This issue is regression of > [JDK-8187074](https://bugs.openjdk.java.net/browse/JDK-8187074). > > Issue. > - `Parent.viewOrderChildren` is a list of children sorted according to view > order. > - `Parent

Re: "Internal review ID : 9062887" (Re: FXMLLoader: not supplying filename to script engine, not supplying event object as argument to script

2020-01-22 Thread Rony G. Flatscher
Hi Anthony, On 22.01.2020 17:07, Anthony Vanelverdinghe wrote: > Your issue has been converted into a JDK issue, with your testcase attached > [1]. Thank you *very* much for this information! > Normally you should’ve received an e-mail at the time of this conversion, Just searched all my e-mai

Re: [Rev 01] RFR: 8237469: CssStyleHelper reuse check fixed

2020-01-22 Thread David Grieve
On Wed, 22 Jan 2020 17:03:49 GMT, Dean Wookey wrote: >> Everything passes with the fix and 5 of the new tests fail without the fix. >> >> removingThenAddingNodeToDifferentBranchGetsNewFontStyleTest >> movingBranchToDifferentBranchGetsNewCssVariableTest >> removingThenAddingNodeToDifferentBranchG

Re: [Rev 01] RFR: 8237469: CssStyleHelper reuse check fixed

2020-01-22 Thread Dean Wookey
> Everything passes with the fix and 5 of the new tests fail without the fix. > > removingThenAddingNodeToDifferentBranchGetsNewFontStyleTest > movingBranchToDifferentBranchGetsNewCssVariableTest > removingThenAddingNodeToDifferentBranchGetsCorrectInheritedValue > removingThenAddingNodeToDifferent

RE: "Internal review ID : 9062887" (Re: FXMLLoader: not supplying filename to script engine, not supplying event object as argument to script

2020-01-22 Thread Anthony Vanelverdinghe
Hi Rony Your issue has been converted into a JDK issue, with your testcase attached [1]. Normally you should’ve received an e-mail at the time of this conversion, but you can check this yourself by using the internal review ID as in [2]. If you’d like to contribute a fix, see [3]. Kind regards

Re: RFR: 8237469: CssStyleHelper reuse check fixed

2020-01-22 Thread Dean Wookey
On Wed, 22 Jan 2020 15:00:14 GMT, David Grieve wrote: >> Everything passes with the fix and 5 of the new tests fail without the fix. >> >> removingThenAddingNodeToDifferentBranchGetsNewFontStyleTest >> movingBranchToDifferentBranchGetsNewCssVariableTest >> removingThenAddingNodeToDifferentBranch

Re: RFR: 8237469: CssStyleHelper reuse check fixed

2020-01-22 Thread David Grieve
On Fri, 17 Jan 2020 14:09:54 GMT, Dean Wookey wrote: > Everything passes with the fix and 5 of the new tests fail without the fix. > > removingThenAddingNodeToDifferentBranchGetsNewFontStyleTest > movingBranchToDifferentBranchGetsNewCssVariableTest > removingThenAddingNodeToDifferentBranchGetsCo

Re: "Internal review ID : 9062887" (Re: FXMLLoader: not supplying filename to script engine, not supplying event object as argument to script

2020-01-22 Thread Rony G. Flatscher
Last November I submitted an appropriate bug report and mailed the testcase on November 27th per Oracle's request without hearing anything to this date. Therefore I was wondering how long such an assessment usually takes place and what to do? (Maybe it "fell off the desk" due to the end-of-year

Re: [Integrated] RFR: 8237078: Media build code broken on XCode 11

2020-01-22 Thread Johan Vos
Changeset: be22e853 Author:Johan Vos Date: 2020-01-22 12:26:17 + URL: https://git.openjdk.java.net/jfx/commit/be22e853 8237078: [macOS] Media build broken on XCode 11 Reviewed-by: kcr, almatvee ! modules/javafx.media/src/main/native/jfxmedia/platform/osx/avf/AVFAudioProcesso

Re: RFR: 8237372: NullPointerException in TabPaneSkin.stopDrag

2020-01-22 Thread Ambarish Rapte
On Mon, 20 Jan 2020 10:00:55 GMT, Robert Lichtenberger wrote: > Test simulates a single mouse-released event. > Fix simply guards against the null case. The scenario mentioned in [JDK-8237372](https://bugs.openjdk.java.net/browse/JDK-8237372) seems valid scenario. However I am not sure if the