Re: TableView slow vertical scrolling with 300+ columns

2020-01-25 Thread Martin Desruisseaux
Doesn't ControlsFX have that already, or some other 3rd party library? Yes ControlsFX has a GridView class. But it is based on Skin in "com.sun.javafx" packages (replaced by "javafx.scene.control.skin" packages since JavaFX 9). I have not tested if it would still work with JavaFX more recent t

Re: [Rev 03] RFR: 8088198: Exception thrown from snapshot if dimensions are larger than max texture size

2020-01-25 Thread Nir Lisker
On Sat, 25 Jan 2020 19:55:23 GMT, Nir Lisker wrote: >> With regard as to why the tiling version is significantly slower, though, I >> do have a pretty good idea; as Kevin hinted, the pixel copy into a temporary >> buffer before copying into the final image is where most the extra time is >> sp

Re: [Rev 03] RFR: 8088198: Exception thrown from snapshot if dimensions are larger than max texture size

2020-01-25 Thread Nir Lisker
On Fri, 24 Jan 2020 17:16:13 GMT, Frederic Thevenet wrote: >> I don't, to be honest. >> The results for some dimensions (not always the same) can vary pretty >> widely from one run to another, despite all my effort to repeat results and >> remove outliers. >> Out of curiosity, I also tried t

Re: TableView slow vertical scrolling with 300+ columns

2020-01-25 Thread Ed Kennard
I did previously look at the ControlsFX SpreadsheetView, but it wasn’t a good match, at least at that time. Off the top of my head, I’m not sure it supports nested column headers, which is essential for our purposes. Furthermore, in my travels around the internet on this subject I’ve seen comme

Re: TableView slow vertical scrolling with 300+ columns

2020-01-25 Thread Ed Kennard
Hi Martin, Big thank you for your message, and for sharing your code. I took a look and it could definitely be a great starting point for me. The content we need to display is very simple, every cell just needs to display text, occasionally with an expand/collapse button on the left. So I th

Re: TableView slow vertical scrolling with 300+ columns

2020-01-25 Thread Nir Lisker
> > So might it be better to submit a new feature request to develop a > separate and leaner control entirely, geared much more towards viewing > large datasets without all the bells and whistles of a TableView? > Doesn't ControlsFX have that already, or some other 3rd party library? On Sat, Jan

Re: TableView slow vertical scrolling with 300+ columns

2020-01-25 Thread Ed Kennard
Hi Kevin, Nir, I also dug out those two bug reports and agree neither are close enough. However, it seems to be general consensus that in order to properly address the issue, TableView's virtualisation would need to be changed to support columns in addition to rows, and that the extra complexi

Re: TableView slow vertical scrolling with 300+ columns

2020-01-25 Thread Martin Desruisseaux
Hello Ed At the center of our product is an extension of the TableView control that's responsible for displaying all the output from our pivot reporting engine. Depending on how the user configures the layout of their pivot reports, sometimes there are a legitimately large number of columns

Re: "Internal review ID 9063426: "FXMLLoader: if script engines implement javax.script.Compilabel compile scripts"

2020-01-25 Thread Rony G. Flatscher
On 24.01.2020 16:26, Kevin Rushforth wrote: > Thank you for filing this enhancement request. As an enhancement it should be > discussed on this > list before proceeding with a pull request (although a "WIP" or Draft PR can > be used to illustrate > the concept). Sure, will do after creating an ap

Re: TableView slow vertical scrolling with 300+ columns

2020-01-25 Thread Kevin Rushforth
I took a quick look and didn't see one that was close enough to this, so I think it's worth submitting a new bug report. The closest I found were JDK-8166956 [1] and JDK-8185887 [2]. I also would be interested to know whether others have run into this in their applications. -- Kevin [1] htt

Re: "Internal review ID : 9062887" (Re: FXMLLoader: not supplying filename to script engine, not supplying event object as argument to script

2020-01-25 Thread Rony G. Flatscher
Hi Kevin, On 24.01.2020 16:50, Kevin Rushforth wrote: > This bug was transferred to the JDK project on 28-Nov-2019. I don't know why > you didn't get an > email at that time, but I will inquire of the team who processes incoming > bugs. > > Also, I'll keep an eye out for the RFE you filed today,

Re: TableView slow vertical scrolling with 300+ columns

2020-01-25 Thread Nir Lisker
Hi Ed, Try to search JBS [1] for this issue. If you don't find one, you can submit it through bugs.java.com, though I suspect this is known. I don't know the technicalities of VirtualFlow in TableView, so can't help there. - Nir [1] https://bugs.openjdk.java.net/issues/?jql=component %3D javafx