Re: Monocle as a replacement

2020-02-18 Thread Danny Gonzalez
Hi Tres, We also are suffering from this crash when running our TestFX unit tests, particularly on Java 11. It is due to a concurrency issue between the JavaFX thread and the QuantumRenderer thread and there is an OpenJDK bug here: https://bugs.openjdk.java.net/browse/JDK-8201567 Quoting from

Re: Monocle as a replacement

2020-02-18 Thread Dan Howard
I don't know if any jpro.one people are here but they implemented a JavaFX to SVG rendering so they may have had some experience with this. On 2/18/2020 6:54 PM, Tres Finocchiaro wrote: Thanks. I'm working with Gluon (commercially) to see if changing that moving forward is possible, I'll focus

Re: Monocle as a replacement

2020-02-18 Thread Tres Finocchiaro
Thanks. My focus will be initially on adding Desktop (Linux, macOS, Windows) support for the WebView (and thus probably Node, Stage) capture functions. As FX stands today these capture functions -- from a WebView perspective -- have some issues for use in a mission critical production environment

Re: Monocle as a replacement

2020-02-18 Thread Kevin Rushforth
OK. FWIW, proper headless support, along the lines of AWT's headless mode, would be a very useful enhancement to JavaFX. I suspect that Monocle, at least in its current form, is not entirely suitable, at least not without some refactoring. -- Kevin On 2/18/2020 3:54 PM, Tres Finocchiaro wrot

Re: Monocle as a replacement

2020-02-18 Thread Tres Finocchiaro
Thanks. I'm working with Gluon (commercially) to see if changing that moving forward is possible, I'll focus my energy over there. On Tue, Feb 18, 2020, 6:49 PM Kevin Rushforth wrote: > For desktop platforms, Monocle is only used as a testing framework. It > isn't really suitable for proper hea

Re: Monocle as a replacement

2020-02-18 Thread Kevin Rushforth
For desktop platforms, Monocle is only used as a testing framework. It isn't really suitable for proper headless support (as I guess you noticed), and isn't shipped on desktop platforms with the release. -- Kevin On 2/17/2020 11:12 AM, Tres Finocchiaro wrote: Hi, I'm the developer of a prin

Re: [jfx14] [Rev 02] RFR: 8228867: Fix mistakes in FX API docs

2020-02-18 Thread Kevin Rushforth
On Tue, 18 Feb 2020 21:59:07 GMT, Nir Lisker wrote: >> Docs fixes for OpenJFX 14. We can wait with integrating this in case there >> are last minute fixes, but reviews can start. > > The pull request has been updated with 2 additional commits. Looks good. - Marked as reviewed by

Re: [jfx14] [Rev 02] RFR: 8228867: Fix mistakes in FX API docs

2020-02-18 Thread Nir Lisker
> Docs fixes for OpenJFX 14. We can wait with integrating this in case there > are last minute fixes, but reviews can start. The pull request has been updated with 2 additional commits. - Added commits: - 6ef5518c: Revert copyright year change - 200ac8c3: Revert extra } Changes:

Re: RFR: 8196586: Remove use of deprecated finalize methods from javafx property objects

2020-02-18 Thread Kevin Rushforth
On Sun, 16 Feb 2020 01:24:43 GMT, Nir Lisker wrote: >> I'll be the 2nd reviewer. > >> the referent to the created property object has been garbage collected >> before the `finalize` method is called > > I'm confused. What is that referent exactly and why is it guaranteed to have > been GC'd b

Re: [jfx14] [Rev 01] RFR: 8228867: Fix mistakes in FX API docs

2020-02-18 Thread Tom Schindl
IIRC I had filed a bugzilla a while ago at Eclipse on a javadoc Problem like that Tom Von meinem iPhone gesendet > Am 18.02.2020 um 20:09 schrieb Nir Lisker : > > On Tue, 18 Feb 2020 18:15:30 GMT, Kevin Rushforth wrote: > >>> The pull request has been updated with 2 additional commits. >>

Re: [jfx14] [Rev 01] RFR: 8228867: Fix mistakes in FX API docs

2020-02-18 Thread Kevin Rushforth
On Tue, 18 Feb 2020 19:06:26 GMT, Nir Lisker wrote: >> modules/javafx.base/src/main/java/javafx/collections/ListChangeListener.java >> line 234: >> >>> 233: * >>> 234: * for (Node n : change.getAddedSubList()) { >>> 235: * // do something >> >> What is the pro

Re: [jfx14] [Rev 01] RFR: 8228867: Fix mistakes in FX API docs

2020-02-18 Thread Nir Lisker
On Tue, 18 Feb 2020 18:15:30 GMT, Kevin Rushforth wrote: >> The pull request has been updated with 2 additional commits. > > modules/javafx.base/src/main/java/javafx/collections/ListChangeListener.java > line 234: > >> 233: * >> 234: * for (Node n : change.getAddedSubList())

Re: [jfx14] [Rev 01] RFR: 8228867: Fix mistakes in FX API docs

2020-02-18 Thread Kevin Rushforth
On Tue, 18 Feb 2020 02:21:38 GMT, Nir Lisker wrote: >> Docs fixes for OpenJFX 14. We can wait with integrating this in case there >> are last minute fixes, but reviews can start. > > The pull request has been updated with 2 additional commits. modules/javafx.base/src/main/java/javafx/collectio

publishToMavenLocal not publishing source jars

2020-02-18 Thread Danny Gonzalez
I am using the command "./gradlew publishToMavenLocal” to publish the sdk to my local maven repository. I don’t seem to be getting the sources jar files published along with each module. Do I have to configure something specifically in build.gradle? I couldn’t see anything obvious. Thanks Dan

Re: [Integrated] RFR: 8238434: Ensemble: Update version of Lucene to 7.7.2

2020-02-18 Thread Kevin Rushforth
Changeset: b5e65ecc Author:Kevin Rushforth Date: 2020-02-18 14:41:22 + URL: https://git.openjdk.java.net/jfx/commit/b5e65ecc 8238434: Ensemble: Update version of Lucene to 7.7.2 Reviewed-by: aghaisas ! apps/samples/.classpath ! apps/samples/Ensemble8/UPDATING-lucene.txt ! app

Ad suggested test unit for "JDK-8234959 FXMLLoader does not populate ENGINE_SCOPE Bindings with FILENAME and ARGV"

2020-02-18 Thread Rony G. Flatscher
For creating a test unit to test whether [1] is present or not, it is necessary to have a Java script engine to test again. As discussed in a different thread it is not advisable to use any concrete, existing Java script engine that is not part of the JDK. Therefore it becomes necessary to come

PixelBuffer API threading model?

2020-02-18 Thread Neil C Smith
Hi, I'm working on a project at the moment that is integrating GStreamer with the new JavaFX PixelBuffer API. The threading behaviour of that seems somewhat under documented. Assuming an Image backed by an externally provided ByteBuffer, when is it actually safe to free that native memory? Usin

Ad suggested fix for "JDK-8234959 FXMLLoader does not populate ENGINE_SCOPE Bindings with FILENAME and ARGV"

2020-02-18 Thread Rony G. Flatscher
[1] reports a bug related to FXMLLoader for FXML controllers being implemented in any one of the javax.script languages: the invoked scripts are not supplied the standardized entries "javax.script.filename" (a string denoting the filename that hosts the script) and "javax.script.argv" (an Object

Re: RFR: 8185886: Improve scrolling performance of TableView and TreeTableView

2020-02-18 Thread Jeanette Winzenburg
On Wed, 12 Feb 2020 12:43:58 GMT, dannygonzalez wrote: >>> >>> Although that does seem odd behaviour to me. Obviously as the original >>> implementation was using an array I can see how the implementation drove >>> that specification. >>> >> >> whatever drove it (had been so since the begin

Re: RFR: 8185886: Improve scrolling performance of TableView and TreeTableView

2020-02-18 Thread dannygonzalez
On Wed, 12 Feb 2020 12:22:15 GMT, Jeanette Winzenburg wrote: >>> hmm ... wouldn't the change violate spec of adding listeners: >>> >>> > If the same listener is added more than once, then it will be notified >>> > more than once. >> >> True, I hadn't read that spec in ObservableValueBase. >>

Re: RFR: 8185886: Improve scrolling performance of TableView and TreeTableView

2020-02-18 Thread Kevin Rushforth
On Wed, 12 Feb 2020 13:06:00 GMT, Jeanette Winzenburg wrote: >> The listeners are called back in the order they were registered in my >> implementation although I didn’t see this requirement in the spec unless I >> missed something. >> >> The performance unregistering thousands of listeners b

Re: RFR: 8185886: Improve scrolling performance of TableView and TreeTableView

2020-02-18 Thread Jeanette Winzenburg
On Thu, 6 Feb 2020 16:22:28 GMT, dannygonzalez wrote: >> https://bugs.openjdk.java.net/browse/JDK-8185886 >> >> Optimisation to ExpressionHelper.Generic class to use Sets rather than >> Arrays to improve listener removal speed. >> >> This was due to the removal of listeners in TableView takin

Re: RFR: 8185886: Improve scrolling performance of TableView and TreeTableView

2020-02-18 Thread dannygonzalez
On Mon, 17 Feb 2020 13:51:49 GMT, Kevin Rushforth wrote: >>> >>> The listeners are called back in the order they were registered in my >>> implementation although I didn’t see this requirement in the spec unless I >>> missed something. >> >> yeah, you are right can't find that spec on sequen

Re: RFR: 8185886: Improve scrolling performance of TableView and TreeTableView

2020-02-18 Thread dannygonzalez
On Wed, 12 Feb 2020 11:29:24 GMT, Jeanette Winzenburg wrote: >> /signed >> >> I have signed the Oracle Contributor Agreement today. Have not received back >> any confirmation yet though. > > hmm ... wouldn't the change violate spec of adding listeners: > >> If the same listener is added more

Re: RFR: 8185886: Improve scrolling performance of TableView and TreeTableView

2020-02-18 Thread Jeanette Winzenburg
On Wed, 12 Feb 2020 12:01:03 GMT, dannygonzalez wrote: >> hmm ... wouldn't the change violate spec of adding listeners: >> >>> If the same listener is added more than once, then it will be notified more >>> than once. > >> hmm ... wouldn't the change violate spec of adding listeners: >> >> >

Re: RFR: 8185886: Improve scrolling performance of TableView and TreeTableView

2020-02-18 Thread dannygonzalez
On Thu, 6 Feb 2020 16:13:33 GMT, dannygonzalez wrote: > https://bugs.openjdk.java.net/browse/JDK-8185886 > > Optimisation to ExpressionHelper.Generic class to use Sets rather than Arrays > to improve listener removal speed. > > This was due to the removal of listeners in TableView taking up t

RFR: 8185886: Improve scrolling performance of TableView and TreeTableView

2020-02-18 Thread dannygonzalez
https://bugs.openjdk.java.net/browse/JDK-8185886 Optimisation to ExpressionHelper.Generic class to use Sets rather than Arrays to improve listener removal speed. This was due to the removal of listeners in TableView taking up to 50% of CPU time on the JavaFX Application thread when scrolling/ad