Re: RFR: 8185886: Improve scrolling performance of TableView and TreeTableView

On Thu, 6 Feb 2020 16:13:33 GMT, dannygonzalez wrote: > https://bugs.openjdk.java.net/browse/JDK-8185886 > > Optimisation to ExpressionHelper.Generic class to use Sets rather than Arrays > to improve listener removal speed. > > This was due to the removal of listeners in TableView taking up

Re: RFR: 8185886: Improve scrolling performance of TableView and TreeTableView

On Tue, 18 Feb 2020 09:02:36 GMT, dannygonzalez wrote: >> @dannygonzalez the reason for the `jcheck` failure is that you have commits >> with two different email addresses in your branch. At this point, it's >> probably best to squash the commits into a single commit with `git rebase -i >>

Re: RFR: 8239822: Intermittent unit test failures in RegionCSSTest

On Sat, 22 Feb 2020 15:54:16 GMT, Kevin Rushforth wrote: >> This is a fix for an intermittent test failure affecting >> `test.javafx.scene.layout.RegionCSSTest`. This turns out to be a test bug in >> `test.javafx.scene.CssStyleHelperTest`, which was added as part of >>

Re: RFR: 8239109: Update SQLite to version 3.31.1

On Thu, 20 Feb 2020 05:58:03 GMT, Guru Hb wrote: > Updating SQLite to version 3.31.1 (Currently used version is 3.30.1). Marked as reviewed by jvos (Reviewer). - PR: https://git.openjdk.java.net/jfx/pull/119

Re: Request for adding my github userid ..

You should be all set now. Dalibor will likely take care of this early next week. -- Kevin On 2/22/2020 8:42 AM, Rony G. Flatscher wrote: On 22.02.2020 17:33, Philip Race wrote: What openjdk ID would this be associated with ? 8234959: FXMLLoader does not populate ENGINE_SCOPE Bindings with

Re: Request for adding my github userid ..

Well I didn't know that ... -phil. On 2/22/20, 8:38 AM, Kevin Rushforth wrote: Rony isn't an Author, meaning he doesn't have an OpenJDK ID. Nevertheless, all Contributors need to have their GitHub username registered. It's a different process for those who do have an OpenJDK ID versus those

Re: Request for adding my github userid ..

On 22.02.2020 17:33, Philip Race wrote: > What openjdk ID would this be associated with ? 8234959: FXMLLoader does not populate ENGINE_SCOPE Bindings with FILENAME and ARGV #122 One PR is the fix another one is dubbed as WIP and has the test unit for this bug (such that one can apply it before

Re: Request for adding my github userid ..

Rony isn't an Author, meaning he doesn't have an OpenJDK ID. Nevertheless, all Contributors need to have their GitHub username registered. It's a different process for those who do have an OpenJDK ID versus those who don't. Those who do will file an issue in JBS in the SKARA project to

Re: Request for adding my github userid ..

What openjdk ID would this be associated with ? I don't see a Rony Flatscher in the census : https://openjdk.java.net/census Rony, Have you made contributions and been granted author status ? If yes, where is it on that page ? If not, then you need to make contributions (not just sign the OCA)

Re: Request for adding my github userid ..

What you need to do is this: > Once you have signed the OCA, please let us know by writing `/signed` in a comment in this pull request. Omit the quotes in the command. This will alert the Skara maintainers to check your OCA status and make the association. -- Kevin On 2/22/2020 8:20 AM,

Request for adding my github userid ..

Trying to place my first pull requests via github and received the following e-mail: --- cut --- Hi ronyfla, welcome to this OpenJDK project and thanks for contributing! We do not recognize you as Contributor and need to ensure you have signed the

Re: [Rev 01] RFR: 8239822: Intermittent unit test failures in RegionCSSTest

> This is a fix for an intermittent test failure affecting > `test.javafx.scene.layout.RegionCSSTest`. This turns out to be a test bug in > `test.javafx.scene.CssStyleHelperTest`, which was added as part of > [JDK-8237469](https://bugs.openjdk.java.net/browse/JDK-8237469). > RegionCSSTest is a

Re: RFR: 8239822: Intermittent unit test failures in RegionCSSTest

On Sat, 22 Feb 2020 15:51:24 GMT, Kevin Rushforth wrote: > This is a fix for an intermittent test failure affecting > `test.javafx.scene.layout.RegionCSSTest`. This turns out to be a test bug in > `test.javafx.scene.CssStyleHelperTest`, which was added as part of >

RFR: 8239822: Intermittent unit test failures in RegionCSSTest

This is a fix for an intermittent test failure affecting `test.javafx.scene.layout.RegionCSSTest`. This turns out to be a test bug in `test.javafx.scene.CssStyleHelperTest`, which was added as part of [JDK-8237469](https://bugs.openjdk.java.net/browse/JDK-8237469). RegionCSSTest is a victim of