> This bug can be reproduced when the screen resolution is at 125%, 150% and
> 175% for Windows, which correpsonds to `pixelScale` values of 1.25, 1.5 and
> 1.75, respectively.
>
> Issue: The rectangle inside canvas is rendered on `pixelScale` while the
> borders are rendered on
On Mon, 24 Feb 2020 23:45:03 GMT, Nir Lisker wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8185886
>>
>> Optimisation to ExpressionHelper.Generic class to use Sets rather than
>> Arrays to improve listener removal speed.
>>
>> This was due to the removal of listeners in TableView taking
On Sat, 22 Feb 2020 08:42:52 GMT, yosbits
wrote:
>> @kevinrushforth just a note to say there are other ExpressionHelper classes
>> (i.e. MapExpressionHelper, SetExpressionHelper and ListExpressionHelper)
>> that also use arrays and suffer from the linear search issue when removing
>>
On Thu, 6 Feb 2020 16:13:33 GMT, dannygonzalez
wrote:
> https://bugs.openjdk.java.net/browse/JDK-8185886
>
> Optimisation to ExpressionHelper.Generic class to use Sets rather than Arrays
> to improve listener removal speed.
>
> This was due to the removal of listeners in TableView taking up
On Mon, 24 Feb 2020 11:04:26 GMT, dannygonzalez
wrote:
>> Just wanted to keep a similar behaviour as before using the same calculation
>> based originally on the size of the listeners array list and now based on
>> the size of the map. So in theory the weak listeners should be trimmed at
>>
On Mon, 24 Feb 2020 16:00:31 GMT, Kevin Rushforth wrote:
>> test.javafx.css.Node_cssStateTransition_Test may also need the same
>> treatment.
>
> Thanks for pointing that out. In addition to
> `test.javafx.css.Node_cssStateTransition_Test`, the following test has a
> similar pattern:
>
>
> This is a fix for an intermittent test failure affecting
> `test.javafx.scene.layout.RegionCSSTest`. This turns out to be a test bug in
> `test.javafx.scene.CssStyleHelperTest`, which was added as part of
> [JDK-8237469](https://bugs.openjdk.java.net/browse/JDK-8237469).
> RegionCSSTest is a
On Sat, 15 Feb 2020 14:59:30 GMT, Kevin Rushforth wrote:
>> The pull request has been updated with 1 additional commit.
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/TableViewKeyInputTest.java
> line 102:
>
>> 101:
>> 102: private NodeOrientation orientation;
>>
On Fri, 14 Feb 2020 11:18:12 GMT, Jeanette Winzenburg
wrote:
>> The pull request has been updated with 1 additional commit.
>
> modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/behavior/TableViewBehaviorBase.java
> line 139:
>
>> 138: boolean rtl = isRTL();
>> 139:
> Bug : https://bugs.openjdk.java.net/browse/JDK-8235480
>
> Fix : Added the missed out RTL checks to the key mappings in
> TableViewBehaviorBase class.
>
> Testing : Modified unit tests in TableViewKeyInputTest to take orientation as
> a parameter. The Left/Right key press tests have been
> Bug : https://bugs.openjdk.java.net/browse/JDK-8235480
>
> Fix : Added the missed out RTL checks to the key mappings in
> TableViewBehaviorBase class.
>
> Testing : Modified unit tests in TableViewKeyInputTest to take orientation as
> a parameter. The Left/Right key press tests have been
On Sat, 22 Feb 2020 20:23:38 GMT, Dean Wookey wrote:
>> @aghaisas Can you review this?
>>
>> @DeanWookey You are also welcome to review it if you like.
>
> test.javafx.css.Node_cssStateTransition_Test may also need the same treatment.
Thanks for pointing that out. In addition to
On Mon, 24 Feb 2020 11:32:25 GMT, Nir Lisker wrote:
>> Nope, actually:
>> `listeners.keySet().removeIf(p::test) `
>>
>> is not the same as:
>> `listeners.entrySet().removeIf(e -> p.test(e.getKey()));`
>>
>> We need to test against the entrySet.key not the entrySet itself.
>
>> We need to test
On Mon, 24 Feb 2020 11:09:30 GMT, dannygonzalez
wrote:
>> Agreed, will change.
>
> Nope, actually:
> `listeners.keySet().removeIf(p::test) `
>
> is not the same as:
> `listeners.entrySet().removeIf(e -> p.test(e.getKey()));`
>
> We need to test against the entrySet.key not the entrySet
On Mon, 24 Feb 2020 08:11:40 GMT, dannygonzalez
wrote:
>> modules/javafx.base/src/main/java/com/sun/javafx/binding/ExpressionHelperBase.java
>> line 64:
>>
>>> 63:
>>> 64: listeners.entrySet().removeIf(e -> p.test(e.getKey()));
>>> 65: }
>>
>> This can be
On Mon, 24 Feb 2020 10:16:55 GMT, dannygonzalez
wrote:
>>> So we need to keep the original behaviour from before where a count was
>>> checked on every addListener call and the weak references were purged from
>>> the array using the original calculation for this count.
>>
>> The GC'd weak
On Mon, 24 Feb 2020 09:59:28 GMT, Nir Lisker wrote:
>> As far as I know a LinkedHashMap doesn't automatically remove weak listener
>> entries. The listener maps can be holding weak listeners as well as normal
>> listeners.
>> So we need to keep the original behaviour from before where a count
On Mon, 24 Feb 2020 09:14:51 GMT, dannygonzalez
wrote:
>> I agree, I kept these in as I wasn't sure if there was a need to manually
>> force the garbage collection of weak listeners at the same rate as the
>> original implementation.
>> Removing this would make sense to me also.
>>
>>
On Mon, 24 Feb 2020 08:14:02 GMT, dannygonzalez
wrote:
>> modules/javafx.base/src/main/java/com/sun/javafx/binding/ExpressionHelper.java
>> line 197:
>>
>>> 196: private int weakChangeListenerGcCount = 2;
>>> 197: private int weakInvalidationListenerGcCount = 2;
>>> 198:
>>
On Sun, 23 Feb 2020 01:05:25 GMT, Nir Lisker wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8185886
>>
>> Optimisation to ExpressionHelper.Generic class to use Sets rather than
>> Arrays to improve listener removal speed.
>>
>> This was due to the removal of listeners in TableView taking
On Sun, 23 Feb 2020 02:54:55 GMT, Nir Lisker wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8185886
>>
>> Optimisation to ExpressionHelper.Generic class to use Sets rather than
>> Arrays to improve listener removal speed.
>>
>> This was due to the removal of listeners in TableView taking
On Sun, 23 Feb 2020 03:09:28 GMT, Nir Lisker wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8185886
>>
>> Optimisation to ExpressionHelper.Generic class to use Sets rather than
>> Arrays to improve listener removal speed.
>>
>> This was due to the removal of listeners in TableView taking
On Sun, 23 Feb 2020 04:20:55 GMT, Nir Lisker wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8185886
>>
>> Optimisation to ExpressionHelper.Generic class to use Sets rather than
>> Arrays to improve listener removal speed.
>>
>> This was due to the removal of listeners in TableView taking
23 matches
Mail list logo
