On Tue, 10 Mar 2020 18:52:23 GMT, Nir Lisker wrote:
>> Looks like the `jcheck` bot removed the `rfr` label because the CSR isn't
>> complete. An incomplete CSR should be treated
>> the same way as an insufficient number of reviewers. I filed
>>
On Tue, 10 Mar 2020 18:37:50 GMT, Kevin Rushforth wrote:
> As noted in the JBS issue, this is a follow-on bug to
> [https://bugs.openjdk.java.net/browse/JDK-8232589](https://bugs.openjdk.java.net/browse/JDK-8232589)
> to remove the
> applecoreaudio.md third-party legal file now that we no
On Wed, 5 Feb 2020 13:48:45 GMT, Kevin Rushforth wrote:
>> We have a few performance tests in apps/performance, but I don't know how up
>> to date they are. They might give you a
>> starting point on how to measure FPS, but really the harder part is going to
>> be coming up with a workload --
On Tue, 10 Mar 2020 18:37:50 GMT, Kevin Rushforth wrote:
> As noted in the JBS issue, this is a follow-on bug to
> [https://bugs.openjdk.java.net/browse/JDK-8232589](https://bugs.openjdk.java.net/browse/JDK-8232589)
> to remove the
> applecoreaudio.md third-party legal file now that we no
As noted in the JBS issue, this is a follow-on bug to
[https://bugs.openjdk.java.net/browse/JDK-8232589](https://bugs.openjdk.java.net/browse/JDK-8232589)
to remove the
applecoreaudio.md third-party legal file now that we no longer include or use
CoreAudio.
-
Commit messages:
-
The flickering is happening because of the way VirtualFlow reuses cells. The
selected state gets cleared and reset, which is the flicker.
This change fixed the flickering for me. I'm not sure why the index of a cell
was being set to -1, but the effect of doing so is that when the
cell is pulled
On Tue, 10 Mar 2020 16:28:03 GMT, Kevin Rushforth wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> JDK-8200224
>> cleaned up code based on code review
>
> Marked as reviewed by kcr (Lead).
@arapte or
On Tue, 10 Mar 2020 14:35:59 GMT, Florian Kirmaier
wrote:
>> Hi everyone,
>>
>> ticket: https://bugs.openjdk.java.net/browse/JDK-8236259
>>
>> The fix itself is quite straight forward.
>> It basically just removed the listener which causes the leak.
>>
>> The unit-test for the fix is a bit
On Tue, 10 Mar 2020 14:34:57 GMT, Florian Kirmaier
wrote:
>> The fix looks good to me. I've verified that it fixes the leak.
>>
>> The newly added test looks good as well, with some comments left inline
>> (formatting, a missing copyright header, and a
>> couple other suggestions).
>
>
> Hi everyone,
>
> ticket: https://bugs.openjdk.java.net/browse/JDK-8236259
>
> The fix itself is quite straight forward.
> It basically just removed the listener which causes the leak.
>
> The unit-test for the fix is a bit more complicated.
>
> I added a library JMemoryBuddy
On Thu, 5 Mar 2020 22:15:07 GMT, Kevin Rushforth wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> JDK-8236259
>> readded unit-test without any dependency
>
>
On Thu, 5 Mar 2020 22:19:45 GMT, Kevin Rushforth wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> JDK-8236259
>> readded unit-test without any dependency
>
> The fix looks good to me. I've verified that it
On Thu, 5 Mar 2020 22:11:26 GMT, Kevin Rushforth wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> JDK-8236259
>> readded unit-test without any dependency
>
>
Changeset: 50e15fce
Author:Kevin Rushforth
Date: 2020-03-10 12:42:02 +
URL: https://git.openjdk.java.net/jfx/commit/50e15fce
8240466: AppJSCallback* apps launched by ModuleLauncherTest intermittently hang
Reviewed-by: aghaisas
!
On Tue, 10 Mar 2020 11:13:54 GMT, Frederic Thevenet
wrote:
>> ### 15-internal:
>>
>>
>> || 1024 |2048 |3072 |4096 |5120 |6144 |7168 |8192 |9216 |
>> |---|---|---|---|---|---|---|---|---|---|
>> | 1024 | 5.381051 | 9.261115 | 14.033219 | 20.608201 | 26.159817 | 33.599632
>> |
On Fri, 6 Mar 2020 19:53:04 GMT, Kevin Rushforth wrote:
>> Please ignore this comment as well, it is also for debugging issues with
>> Skara and mailman :email:
>
> @aghaisas can you review this?
I executed these tests without this patch. They did not hang on my Macbook.
I applied patch and
On Tue, 10 Mar 2020 10:29:38 GMT, Frederic Thevenet
wrote:
>> ### 14-internal
>>
>>
>> || 1024 |2048 |3072 |4096 |5120 |6144 |7168 |8192 |9216 |
>> |---|---|---|---|---|---|---|---|---|---|
>> | 1024 | 5.740508 | 9.337537 | 13.489849 | 17.611105 | 38.898909 | 48.165735
>> |
On Tue, 3 Mar 2020 22:51:43 GMT, Kevin Rushforth wrote:
> While testing JavaFX using gradle 6.3-nightly and JDK 14, I ran into what
> turned out to be a latent test bug in the
> AppJSCallback* apps that are launched by ModuleLauncherTest. The launched
> apps construct a WebView instance,
On Tue, 10 Mar 2020 10:29:31 GMT, Frederic Thevenet
wrote:
>> ### 14-ea+9
>>
>>
>> || 1024 |2048 |3072 |4096 |5120 |6144 |7168 |8192 |9216 |
>> |---|---|---|---|---|---|---|---|---|---|
>> | 1024 | 5.607827 | 9.380503 | 13.835523 | 17.514362 | 21.776304 | 27.918815
>> | 36.929480
On Tue, 10 Mar 2020 10:29:11 GMT, Frederic Thevenet
wrote:
>> On My windows10 machine, I can observe 20 to 30 % reduction in time to take
>> snapshot.
>> Can you please capture the time the way you did
>> [here](https://github.com/openjdk/jfx/pull/68#issuecomment-578192074)
>> for previous PR
On Tue, 10 Mar 2020 06:05:53 GMT, Ambarish Rapte wrote:
>> I finally got a chance to do some more extensive testing when running this
>> patch with the es2 pipeline on Linux.
>> It works as expected, and from what I saw, using a IntARGB pixelBuffer when
>> no WritableImage is provided avoids
On Mon, 2 Mar 2020 11:47:03 GMT, Nir Lisker wrote:
>>>
>>>
>>> I think that a starting point would be to decide on a spec for the listener
>>> notification order: is it specified by
>>> their registration order, or that is it unspecified, in which case we can
>>> take advantage of this for
On Fri, 28 Feb 2020 18:06:30 GMT, Frederic Thevenet
wrote:
>> I've marked this PR as a WIP for the time being because I've only tested it
>> on the d3d rendering pipeline so far, so I
>> think it is too early to call for a formal review yet. Still, I welcome
>> feedback if someone wants to
23 matches
Mail list logo
