Are you behind a proxy? I had problems with another application which required
registering certificates and related credentials keys to be added for java.
Eric Bresie
ebre...@gmail.com
> On April 2, 2020 at 2:20:44 PM CDT, Johan Vos wrote:
> I have no scientific evidence for this, but I remember
> This proposed change does the following:
>
> - Ports DND target to use GTK reducing code size and adding extra text /
> image formats (such as .gif);
> - Use gtk signals instead of gdk events (also to reduce code size);
> - Simplifies geometry (sizing/positioning) with a more straightforward co
Jeanette,
Thank you! Much appreciated and a much better approach than a manual test.
Well on my way now!
Thanks,
Craig
On Fri, Apr 3, 2020 at 7:48 AM Jeanette Winzenburg
wrote:
>
> Hi Craig,
>
> no manual test needed - you can implement a normal (unit) test with
> the help or VirtualFlowTestU
On Fri, 3 Apr 2020 15:21:29 GMT, Kevin Rushforth wrote:
>> I will keep testing it, but I think it's looking good.
>
> I see a lot of work going into this.
>
> In order for this to progress beyond the prototype or concept phase, we will
> need to have a discussion on the
> openjfx-dev mailing li
Thanks! That was the trick!
On Fri, Apr 3, 2020 at 6:52 AM Ajit Ghaisas wrote:
> Hi Craig,
>
> Here is how I run the ButtonMnemonicPositionTest.
>
> $ export FX_LIB=/Users/AG/aaa/jfx/build/sdk/lib
> $ cd /Users/AG/aaa/jfx/tests/manual/UI
> $ javac --module-path $FX_LIB --add-mod
That's a fair question. Hard to say, but my guess is that if we do the
first, the incremental improvements of the second might not be worth the
effort or risk.
And if we go with the second, we would need another test case that hits
the slow iteration problem when removing a listener from a lar
Assuming testing and performance/memory analysis leads to the conclusion that
the risks are worth it, would it make sense to do both? Would we get a greater
benefit from the combined effects? Or is the incremental improvement of
including the second fix (whichever it may be) no longer significan
We now have two pull requests under review that propose to solve the
poor scrolling performance of TableView and TreeTableView, as tracked by
JDK-8185886 [1]
The first one, PR #108 [2], proposes a change in the bindings
ExpressionHelper code relating to the cleaning up of listeners (changing
Regarding the CSR, that's usually done after the enhancement is agreed
upon in principle, and the review is far enough along that you are ready
to write up the spec changes, new API, and/or new interfaces.
Since you don't have direct JBS access you will need a sponsor to do
that part for you,
Hi Kevin,
thank you for your feedback and actions!
Ad "please create a CSR request and add link to it in JDK-8238080":
preliminarily researching [CSR
FAQ] (https://wiki.openjdk.java.net/display/csr/CSR+FAQs) the question "Q: How
do I create a CSR ?"
gets answered with:
> "A: _Do not directly c
On Fri, 3 Apr 2020 02:11:12 GMT, Thiago Milczarek Sayao
wrote:
>> Test on 16.04 (without Webkit - it does not build on 16.04 anymore)
>>
>> Updated April 2nd.
>>
>> 
>>
>> Note: DateP
On Thu, 2 Apr 2020 14:55:35 GMT, Kevin Rushforth wrote:
> As noted in the JBS issue, this bug is a result of a deliberate change by
> Apple that affects applications (in this case
> the JDK) linked against MacOSX 10.11 SDK or later -- they no longer call two
> methods that we are relying on,
>
On Fri, 3 Apr 2020 14:14:36 GMT, Michael Paus wrote:
>> These are all separate issues that could be explored with follow-on bugs.
>> I'm not sure what the right behavior is for
>> these or whether there is enough information from the OS to do anything
>> about them (e.g., I suspect there is no
On Fri, 3 Apr 2020 12:35:35 GMT, Kevin Rushforth wrote:
>> I've built a fresh JFX, with your changes applied to master, this morning. I
>> can confirm that the primary bug seems to
>> be fixed with these changes but I have observed some behaviour where I am
>> not sure whether it is correct or
On Fri, 3 Apr 2020 11:32:12 GMT, Michael Paus wrote:
>> @arapte Can you be one of the reviewers?
>>
>> @mipastgt I ran it against your test application, but if you have other
>> tests you could run, that would be helpful.
>
> I've built a fresh JFX, with your changes applied to master, this mor
On Fri, 3 Apr 2020 12:03:33 GMT, Jeanette Winzenburg
wrote:
>>> Can you please provide a unit test? One that fails before your fix and
>>> passes after your fix.
>>
>> I can provide a manual test the next couple of days that demonstrates it
>> before and after, but I'm not sure how to
>> crea
On Thu, 2 Apr 2020 23:28:19 GMT, Craig Cavanaugh
wrote:
>> Can you please provide a unit test? One that fails before your fix and
>> passes after your fix.
>
>> Can you please provide a unit test? One that fails before your fix and
>> passes after your fix.
>
> I can provide a manual test the
Hi Craig,
no manual test needed - you can implement a normal (unit) test with
the help or VirtualFlowTestUtils: grab the flow, get its first/last
visible cell and check whether their range includes to cell we want to
see, something like:
@Test
public void testScrollInSkin() {
On Thu, 2 Apr 2020 22:04:55 GMT, Kevin Rushforth wrote:
>> As noted in the JBS issue, this bug is a result of a deliberate change by
>> Apple that affects applications (in this case
>> the JDK) linked against MacOSX 10.11 SDK or later -- they no longer call two
>> methods that we are relying on
If there are many columns, the current TableView will stall scrolling.
Resolving this performance issue requires column
virtualization. Virtualization mode is enabled when the row height is fixed by
the following method.
`tableView.setFixedCellSize(height)`
This proposal includes a fix because
On Mon, 9 Mar 2020 17:00:06 GMT, Nir Lisker wrote:
>> I took the liberty of pointing out some formatting errors
>
> The title of your PR should match the title of the JBS issue. Moreover, #108
> already tackles this issue with a
> different approach and 2 PRs on the same issue can't be intetgrat
On Mon, 24 Feb 2020 07:39:43 GMT, yosbits
wrote:
> If there are many columns, the current TableView will stall scrolling.
> Resolving this performance issue requires column
> virtualization. Virtualization mode is enabled when the row height is fixed
> by the following method.
> `tableView.set
On Wed, 26 Feb 2020 07:37:06 GMT, yosbits
wrote:
> https://bugs.openjdk.java.net/browse/JDK-8197991
>
> The performance of the selectAll and selectRange methods of the
> MultiSelectionModel class has been greatly improved.
>
> This greatly improves the response when selecting multiple items i
On Thu, 2 Apr 2020 17:38:00 GMT, Dalibor Topic wrote:
>> The title of your PR should match the title of the JBS issue. Moreover, #108
>> already tackles this issue with a
>> different approach and 2 PRs on the same issue can't be intetgrated. Since
>> I'm not familiar with this code, I can't
>>
On Thu, 27 Feb 2020 21:29:27 GMT, Martin Polakovic
wrote:
>> If there are many columns, the current TableView will stall scrolling.
>> Resolving this performance issue requires column
>> virtualization. Virtualization mode is enabled when the row height is fixed
>> by the following method.
>>
On Mon, 24 Feb 2020 07:39:43 GMT, yosbits
wrote:
> If there are many columns, the current TableView will stall scrolling.
> Resolving this performance issue requires column
> virtualization. Virtualization mode is enabled when the row height is fixed
> by the following method.
> `tableView.set
Hi Craig,
Here is how I run the ButtonMnemonicPositionTest.
$ export FX_LIB=/Users/AG/aaa/jfx/build/sdk/lib
$ cd /Users/AG/aaa/jfx/tests/manual/UI
$ javac --module-path $FX_LIB --add-modules javafx.controls
ButtonMnemonicPositionTest.java
$ java --module-path $FX_LIB --add-mo
https://bugs.openjdk.java.net/browse/JDK-8197991
The performance of the selectAll and selectRange methods of the
MultiSelectionModel class has been greatly improved.
This greatly improves the response when selecting multiple items in ListView
and TableView.
However, in TreeView / TreeTableView
I am trying to create a manual unit test for RFR: 8129123 and I'm using the
existing ButtonMnemonicPositionTest.java as a template to make sure
everything is working correctly.
I'm using an Ubuntu 18.04.4 build environment using the default 11.0.6
openjdk.
openjfx is successfully compiling and pas
On Thu, 2 Apr 2020 09:11:57 GMT, Jeanette Winzenburg
wrote:
>> Several controls with selection/focusModels leave memory leaks on replacing
>> the model.
>>
>> Added tests for all such, those for the misbehaving models fail before and
>> pass after the fix.
>>
>> for convenience, the bug refe
30 matches
Mail list logo
