This is a solution for 8242548. There was zero test coverage, so I added a few
tests for this as well.
-
Commit messages:
- 8242548: Honor line spacing in Labeled reflow calculation
Changes: https://git.openjdk.java.net/jfx/pull/173/files
Webrev:
Extract keystate and add to the existing modifier mask, to support eg
multi-select
https://bugs.openjdk.java.net/browse/JDK-8202296
-
Commit messages:
- 8202296: Monocle MouseInput doesn't send keyboard modifiers in events.
Changes: https://git.openjdk.java.net/jfx/pull/170/files
It contains:
-source
14
-target
14
Looks like I'll have to do some digging.
Thanks
On Tue, Apr 14, 2020 at 2:38 AM Kevin Rushforth
wrote:
> Not sure, but you might check here:
>
> modules/javafx.base/build/tmp/compileJava/java-compiler-args.txt
>
> That's the list of args that gradle
On Mon, 13 Apr 2020 23:07:12 GMT, Alexander Matveev
wrote:
> https://bugs.openjdk.java.net/browse/JDK-8241629
>
> We used to link with system provided libffi (due to a bug in Makefile) and
> for some reason GLib signals did not work
> correctly and thus we did not able to build dynamic
https://bugs.openjdk.java.net/browse/JDK-8241629
We used to link with system provided libffi (due to a bug in Makefile) and for
some reason GLib signals did not work
correctly and thus we did not able to build dynamic pipelines. We did not
switch to AVFoundation until timeout is
reached while
Not sure, but you might check here:
modules/javafx.base/build/tmp/compileJava/java-compiler-args.txt
That's the list of args that gradle generates to pass to javac (using
@.../java-compiler-args.txt)
-- Kevin
On 4/13/2020 4:10 PM, Nir Lisker wrote:
Thanks, yes, testing on JavaFX itself.
I
Thanks, yes, testing on JavaFX itself.
I made these changes. I'm getting "error: invalid source release: 14" when
trying to build. These are the settings that are output during the task:
Gradle Distribution: Gradle wrapper from target build
Gradle Version: 6.3
Java Home: C:\Program
I guess you mean modifying the FX build in your local repo so that you
can test the use of JDK 14 preview features in FX itself? (if you were
just trying to use it from your app you wouldn't need any build changes
in FX). At a minimum you would need to add the "--enable-preview" flag
to
Hi,
I would like to test the preview features in Java 14 on JavaFX. What
changes should I make in the build files to get it working?
- Nir
On Sat, 11 Apr 2020 08:19:16 GMT, Johan Vos wrote:
>> Marked as reviewed by kcr (Lead).
>
> The root cause for this issue is not the unnecessary logging, but the fact
> that the Quantum Renderer keeps running when
> the app is not in the foreground (causing a long list of debug lines). I'll
>
On Mon, 13 Apr 2020 16:12:38 GMT, Kevin Rushforth wrote:
> This is a compiler upgrade on Linux from the current gcc 8.3 compiler to gcc
> 9.2. This will match a recent upgrade done
> for JDK 15 -- see
> [JDK-8241721](https://bugs.openjdk.java.net/browse/JDK-8241721).
> On a related note, using
On Mon, 13 Apr 2020 16:13:42 GMT, Kevin Rushforth wrote:
>> This is a compiler upgrade on Linux from the current gcc 8.3 compiler to gcc
>> 9.2. This will match a recent upgrade done
>> for JDK 15 -- see
>> [JDK-8241721](https://bugs.openjdk.java.net/browse/JDK-8241721).
>> On a related note,
This is a compiler upgrade on Linux from the current gcc 8.3 compiler to gcc
9.2. This will match a recent upgrade done
for JDK 15 -- see
[JDK-8241721](https://bugs.openjdk.java.net/browse/JDK-8241721).
On a related note, using the gcc 9 compiler produces many (harmless) warnings
that will be
On Mon, 13 Apr 2020 08:03:09 GMT, Ambarish Rapte wrote:
> `TabPaneSkin` adds a listener to `SelectionModel.selectedItemProperty()`
> which holds the `SelectionModel` from being
> GCed. Fix is to add and remove the listener when a `SelectionModel` is
> changed.
> If the fix looks good, We can
On Fri, 10 Apr 2020 21:57:43 GMT, Kevin Rushforth wrote:
>> Thiago Milczarek Sayao has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Gstreamer build
>
> Looks good.
@johanvos or @arapte Can one of you be the second reviewer on this?
On Mon, 13 Apr 2020 10:36:51 GMT, Jeanette Winzenburg
wrote:
> Macroscopic issue is that initially, the toggle is not sync'ed to the
> selection state. Root reason is an missing else
> block when updating toggle selection state (see report for details).
> Fixed by introducing the else block
Not that I know of. FWIW, I'm not too bothered by this, since I run a
script 2-3 times a year to update the copyright years for those files
fixed in the current year.
-- Kevin
On 4/13/2020 3:48 AM, Jeanette Winzenburg wrote:
Seeing that missing to update of copyright year in the header is
Macroscopic issue is that initially, the toggle is not sync'ed to the selection
state. Root reason is an missing else
block when updating toggle selection state (see report for details).
Fixed by introducing the else block and removing all follow-up errors that
tried to amend the consequences
Seeing that missing to update of copyright year in the header is
rather common (in my own pull requests as well as in others :) is
there any means to do so automatically or some source tool (for me
that would be for Eclipse) that would do on request?
-- Jeanette
`TabPaneSkin` adds a listener to `SelectionModel.selectedItemProperty()` which
holds the `SelectionModel` from being
GCed. Fix is to add and remove the listener when a `SelectionModel` is changed.
If the fix looks good, We can change all the
`getSkinnable().getSelectionModel()` calls to use the
Issue : https://bugs.openjdk.java.net/browse/JDK-8193286
Root Cause :
Incorrect implementation.
Current implementation of int wrapValue(int,int,int) in Spinner.java works well
if min is 0.
Hence this implementation works with ListSpinnerValueFactory, but fails with
IntegerSpinnerValueFactory.
21 matches
Mail list logo
