On Wed, 15 Apr 2020 07:11:27 GMT, dannygonzalez
wrote:
>> @dannygonzalez You mentioned "There are multiple change listeners on a Node
>> for example, so you can imagine with the
>> number of nodes in a TableView this is going to be a problem if the
>> unregistering is slow.".
>> Your changes i
On Wed, 15 Apr 2020 23:17:56 GMT, Alexander Matveev
wrote:
> https://bugs.openjdk.java.net/browse/JDK-8242530
>
> - GstElementClass which is base class for all elements has same instance
> between all spectrum elements (not sure if it is
> same for all elements) and thus post_message was sen
On Wed, 15 Apr 2020 23:17:56 GMT, Alexander Matveev
wrote:
> https://bugs.openjdk.java.net/browse/JDK-8242530
>
> - GstElementClass which is base class for all elements has same instance
> between all spectrum elements (not sure if it is
> same for all elements) and thus post_message was sen
https://bugs.openjdk.java.net/browse/JDK-8242530
- GstElementClass which is base class for all elements has same instance
between all spectrum elements (not sure if it is
same for all elements) and thus post_message was sending events to
AVFoundation callback from GStreamer platform. This
is
On Mon, 13 Apr 2020 06:59:08 GMT, Ajit Ghaisas wrote:
> Issue : https://bugs.openjdk.java.net/browse/JDK-8193286
>
> Root Cause :
> Incorrect implementation.
> Current implementation of int wrapValue(int,int,int) in Spinner.java works
> well if min is 0.
> Hence this implementation works with L
I just took another look at the SpinnerValueFactory API docs. The use of
the term "circular" heavily implies modulo arithmetic as the expected
behavior if wrapAround is true. That the usual meaning of "wrap" versus
"clamp" when you have a range bounded on both ends. Maybe the confusion
comes fr
On Wed, 15 Apr 2020 17:20:55 GMT, Frederic Thevenet
wrote:
>> At first glance, the NPE in
>> [JDK-8189082](https://bugs.openjdk.java.net/browse/JDK-8189082) occurs in
>> the Prism layer,
>> which is one level _below_ Quantum where the tiling is currently
>> implemented, so I'm not sure tit is
On Wed, 15 Apr 2020 20:59:29 GMT, Kevin Rushforth wrote:
>> I think @arapte has a similar MacBookPro model to mine.
>>
>> I think @prrace might be able to test it (I'll sync with him offline).
>
> Here are the results on Phil's machine, which is a Mac Book Pro with a
> graphics accelerator (Nvi
On Tue, 7 Apr 2020 23:03:21 GMT, Kevin Rushforth wrote:
>> @arapte Can you please test the performance changes too?
>
> I think @arapte has a similar MacBookPro model to mine.
>
> I think @prrace might be able to test it (I'll sync with him offline).
Here are the results on Phil's machine, whic
On Wed, 15 Apr 2020 15:14:49 GMT, Arun Joseph wrote:
>> Issue: Assuming the pixelScale is 2, the tile image size is doubled at the
>> native side which is propagated to the java
>> side as well. But, as transform initialization takes place after scaling,
>> the transform is reset to default val
On Tue, 17 Mar 2020 15:31:20 GMT, Frederic Thevenet
wrote:
>>>
>>>
>>> Now that the tiling is done in the `QuantumRenderer` level, I'll bring back
>>> [JDK-8189082](https://bugs.openjdk.java.net/browse/JDK-8189082). Can't this
>>> tiling be used to fix that?
>>
>> It won't help with things i
On Wed, 15 Apr 2020 10:02:47 GMT, Jeanette Winzenburg
wrote:
>> Macroscopic issue is that initially, the toggle is not sync'ed to the
>> selection state. Root reason is an missing else
>> block when updating toggle selection state (see report for details).
>> Fixed by introducing the else block
> Issue: Assuming the pixelScale is 2, the tile image size is doubled at the
> native side which is propagated to the java
> side as well. But, as transform initialization takes place after scaling, the
> transform is reset to default value.
> Fix: Override scale() method in WCBufferedContext cla
On Fri, 10 Apr 2020 16:29:57 GMT, Guru Hb wrote:
>> Arun Joseph has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update copyright year
>
> Looks good to me. Tested on Windows and mac OS X.
> If feasible can we have Unit test for this.
As
You can find all tags for each release at
https://github.com/openjdk/jfx/tags
For OpenJFX versions 11, 12 and 13, you can find them in the previous
repository: https://github.com/javafxports/openjdk-jfx/tags
Greetings,
Joeri
On Wed, Apr 15, 2020 at 1:18 PM Florian Kirmaier
wrote:
> Hi everyone,
On Wed, 15 Apr 2020 10:17:41 GMT, Ambarish Rapte wrote:
>> Looked again, and actually seeing two different issues ;)
>>
>> A) your test - that is with firing the pulse: fails for both not/removing
>> the listener
>> B) basically same test, but not firing the pulse - it fails without removing
>
On Wed, 15 Apr 2020 10:52:26 GMT, Ambarish Rapte wrote:
>> `TabPaneSkin` adds a listener to `SelectionModel.selectedItemProperty()`
>> which holds the `SelectionModel` from being
>> GCed. Fix is to add and remove the listener when a `SelectionModel` is
>> changed.
>> If the fix looks good, We c
Hi everyone,
I can't see any tags in the GitHub project for the various releases of
JavaFX.
I would like to know which commit is the base for various releases.
Specifically, I'm interested in the version 14 and 15-ea3.
Is there a place where I can look it up?
Thanks,
Florian Kirmaier
On Wed, 15 Apr 2020 10:02:47 GMT, Jeanette Winzenburg
wrote:
>> Macroscopic issue is that initially, the toggle is not sync'ed to the
>> selection state. Root reason is an missing else
>> block when updating toggle selection state (see report for details).
>> Fixed by introducing the else block
> `TabPaneSkin` adds a listener to `SelectionModel.selectedItemProperty()`
> which holds the `SelectionModel` from being
> GCed. Fix is to add and remove the listener when a `SelectionModel` is
> changed.
> If the fix looks good, We can change all the
> `getSkinnable().getSelectionModel()` calls
On Tue, 14 Apr 2020 13:26:51 GMT, Jeanette Winzenburg
wrote:
> B) basically same test, but not firing the pulse - it fails without removing
> and passes with removing the listener
Seems like this test randomly crashes (not always) any other test from
`TabPaneTest`. It might be crashing the te
On Tue, 14 Apr 2020 14:09:13 GMT, Ajit Ghaisas wrote:
>> Jeanette Winzenburg has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> ChoiceBox: added FIXME with reference to issue
>
> modules/javafx.controls/src/main/java/javafx/scene/control/Ch
> Macroscopic issue is that initially, the toggle is not sync'ed to the
> selection state. Root reason is an missing else
> block when updating toggle selection state (see report for details).
> Fixed by introducing the else block and removing all follow-up errors that
> tried to amend the conseq
On Mon, 13 Apr 2020 10:36:51 GMT, Jeanette Winzenburg
wrote:
> Macroscopic issue is that initially, the toggle is not sync'ed to the
> selection state. Root reason is an missing else
> block when updating toggle selection state (see report for details).
> Fixed by introducing the else block and
Hi Ajit,
yes, I read the doc, probably a bit differently - could well be my
misunderstanding and misunderstandable wording :)
Trying again:
- I read your suggestion (in
https://bugs.openjdk.java.net/browse/JDK-8242553) to imply f.i. that
being at value and incrementing a full-cycle (that
> Extract keystate and add to the existing modifier mask, to support eg
> multi-select
>
> https://bugs.openjdk.java.net/browse/JDK-8202296
Tom Schindl has updated the pull request incrementally with one additional
commit since the last revision:
8202296: Monocle MouseInput doesn't send keybo
> Extract keystate and add to the existing modifier mask, to support eg
> multi-select
>
> https://bugs.openjdk.java.net/browse/JDK-8202296
Tom Schindl has updated the pull request incrementally with two additional
commits since the last revision:
- 8202296: Monocle MouseInput doesn't send key
> Extract keystate and add to the existing modifier mask, to support eg
> multi-select
>
> https://bugs.openjdk.java.net/browse/JDK-8202296
Tom Schindl has updated the pull request incrementally with one additional
commit since the last revision:
8202296: Monocle MouseInput doesn't send keybo
On Tue, 14 Apr 2020 12:20:10 GMT, John Hendrikx wrote:
>> In a minimal test I wrote (not a microbenchmark that removes listeners), I
>> tried this PR code, but did not reproduce
>> the performance improvement. I have attached a test program in my PR(#125)
>
> @dannygonzalez You mentioned "There
29 matches
Mail list logo
