Re: Arabic letters are not displayed correctly in MacOS 10.15.3

2020-05-27 Thread Philip Race
> I tried that as well. nothing changes if i changed the font using the tinkertool Not sure what you did but it is probably more complex than that. Arabic is likely supported by one of the cascading fallback fonts macOS reports, although it could be via a primary if locale is Arabic. -phil.

Re: Arabic letters are not displayed correctly in MacOS 10.15.3

2020-05-27 Thread Abu Abdullah
On Wed, May 27, 2020 at 7:53 PM Philip Race wrote: > > Is Latin displaying correctly for you ? yes, the GUI contains just few words in English which seems to be OK > I can't see anything at all in that screen shot that looks likely to be > correct, > but I also don't know if it is supposed to be

Re: Arabic letters are not displayed correctly in MacOS 10.15.3

2020-05-27 Thread Philip Race
Is Latin displaying correctly for you ? I can't see anything at all in that screen shot that looks likely to be correct, but I also don't know if it is supposed to be entirely Arabic or a mixture of scripts, although clearly it is all laid out RTL. In an arm-wavy sort of way, it looks like

Re: [Rev 03] RFR: WIP: 8176270: Adding ChangeListener to TextField.selectedTextProperty causes StringOutOfBoundsException

2020-05-27 Thread Robert Lichtenberger
> This PR fixes JDK-8176270 by clamping the end index of the selected text to > the length of the text. Robert Lichtenberger has updated the pull request incrementally with one additional commit since the last revision: 8176270: Adding ChangeListener to TextField.selectedTextProperty causes

Re: RFR: WIP: 8176270: Adding ChangeListener to TextField.selectedTextProperty causes StringOutOfBoundsException

2020-05-27 Thread Robert Lichtenberger
On Wed, 27 May 2020 10:09:52 GMT, Jeanette Winzenburg wrote: >> Clearing the selection temporarily works fine to prevent the >> StringOutOfBoundsException but will also change >> selectionProperty to reflect the selection being 0/0 for a short time. > > you are hacking around ;) > > doSelect

Re: [Rev 02] RFR: 8176270: Adding ChangeListener to TextField.selectedTextProperty causes StringOutOfBoundsException

2020-05-27 Thread Robert Lichtenberger
> This PR fixes JDK-8176270 by clamping the end index of the selected text to > the length of the text. Robert Lichtenberger has updated the pull request incrementally with one additional commit since the last revision: 8176270: Adding ChangeListener to TextField.selectedTextProperty causes

Re: RFR: 8176270: Adding ChangeListener to TextField.selectedTextProperty causes StringOutOfBoundsException

2020-05-27 Thread Jeanette Winzenburg
On Wed, 27 May 2020 07:50:00 GMT, Robert Lichtenberger wrote: >> Reopening the pull request, since PR #73 has been closed. > > Clearing the selection temporarily works fine to prevent the > StringOutOfBoundsException but will also change > selectionProperty to reflect the selection being 0/0

Re: [Integrated] RFR: 8245499: Text input controls should show handles on iOS

2020-05-27 Thread Jose Pereda
On Thu, 21 May 2020 17:41:02 GMT, Jose Pereda wrote: > After JDK-8242167, a JavaFX control is used for text input on iOS instead of > the native control, on a touch enabled > device. However, selection handles are not enabled and currently text > selection is not possible at all. > This PR

Re: RFR: 8176270: Adding ChangeListener to TextField.selectedTextProperty causes StringOutOfBoundsException

2020-05-27 Thread Robert Lichtenberger
On Wed, 27 May 2020 07:37:13 GMT, Robert Lichtenberger wrote: >> We're in the process of finishing our products' release. If I find time >> I will try and give this (rather nasty) Problem another shot. >> >> On 2020-05-08 20:51, Kevin Rushforth wrote: >>> >>> @effad

Arabic letters are not displayed correctly in MacOS 10.15.3

2020-05-27 Thread Abu Abdullah
Hi, i have started testing my app using Javafx on MacOS 10.15.3 and arabic letters are not displayed correctly. only title bar is correct. the rest are just random characters (not arabic). please have a look at the snapshot: https://ibb.co/Yk6m3Pj im using jfx 15-ea-5 on MacOS 10.15.3 normal

Re: [Rev 01] RFR: 8245499: Text input controls should show handles on iOS

2020-05-27 Thread Johan Vos
On Tue, 26 May 2020 17:33:20 GMT, Jose Pereda wrote: >> After JDK-8242167, a JavaFX control is used for text input on iOS instead of >> the native control, on a touch enabled >> device. However, selection handles are not enabled and currently text >> selection is not possible at all. >> This

Re: [Rev 01] RFR: 8176270: Adding ChangeListener to TextField.selectedTextProperty causes StringOutOfBoundsException

2020-05-27 Thread Robert Lichtenberger
> This PR fixes JDK-8176270 by clamping the end index of the selected text to > the length of the text. Robert Lichtenberger has updated the pull request incrementally with one additional commit since the last revision: 8176270: Adding ChangeListener to TextField.selectedTextProperty causes

Re: RFR: 8176270: Adding ChangeListener to TextField.selectedTextProperty causes StringOutOfBoundsException

2020-05-27 Thread Robert Lichtenberger
On Mon, 11 May 2020 04:54:31 GMT, Robert Lichtenberger wrote: >> @effad I just closed PR #73 due to inactivity. If you are interested >> interested in pursuing this, go ahead and reopen >> this (although you would need to address the feedback that clamping is >> insufficient). > > We're in

RFR: 8245634: [TestBug] Enable and fix tests ignored with message "impl_cssSet API removed"

2020-05-27 Thread Ajit Ghaisas
This is a simple test fix. Issue : https://bugs.openjdk.java.net/browse/JDK-8245634 After fixing [JDK-8245457,](https://bugs.openjdk.java.net/browse/JDK-8245457) I found that there are more ignored tests of similar nature that can be enabled and fixed. A search for ignored tests with message

Re: [Integrated] RFR: 8234540: javafx.web LeakTest.testGarbageCollectability fails intermittently

2020-05-27 Thread Arun Joseph
On Tue, 26 May 2020 09:27:52 GMT, Arun Joseph wrote: > Cause: The test assumes that WebView/WebPage will be GCed right after > `System.gc()` > > Fix: Use `runFinalization()` and `sleep()` to wait for objects to get GCed This pull request has now been integrated. Changeset: 8914bd2a Author: