Re: [Integrated] RFR: 8244195: [TEST_BUG] Convert the system tests TabPanePermuteGetTabsTest to unit test

2020-05-29 Thread Ambarish Rapte
On Thu, 21 May 2020 07:55:16 GMT, Ambarish Rapte wrote: > As discussed > [here](https://github.com/openjdk/jfx/pull/201#issuecomment-621772586) during > #201 , This PR converts the > system tests in TabPanePermuteGetTabsTest.java to unit test. > Thanks @kleopatra , for providing the test. I hav

Re: RFR: 8239095: Upgrade libFFI to the latest 3.3 version

2020-05-29 Thread Kevin Rushforth
On Fri, 29 May 2020 22:41:25 GMT, Kevin Rushforth wrote: >> - Updated libffi to 3.3. > > @arapte Can you review as well? Initial testing looks good. I'll finish my testing & review on Monday. - PR: https://git.openjdk.java.net/jfx/pull/242

Re: RFR: 8239095: Upgrade libFFI to the latest 3.3 version

2020-05-29 Thread Kevin Rushforth
On Fri, 29 May 2020 01:24:29 GMT, Alexander Matveev wrote: > - Updated libffi to 3.3. @arapte Can you review as well? - PR: https://git.openjdk.java.net/jfx/pull/242

RFR: 8239095: Upgrade libFFI to the latest 3.3 version

2020-05-29 Thread Alexander Matveev
- Updated libffi to 3.3. - Commit messages: - 8239095: Fixed jcheck - 8239095: Upgrade libFFI to the latest 3.3 version Changes: https://git.openjdk.java.net/jfx/pull/242/files Webrev: https://webrevs.openjdk.java.net/jfx/242/webrev.00 Issue: https://bugs.openjdk.java.net/browse

Re: [Integrated] RFR: 8243110: SVGTest.testSVGRenderingWithPattern fails intermittently

2020-05-29 Thread Arun Joseph
On Thu, 28 May 2020 08:45:36 GMT, Arun Joseph wrote: > Issue: Snapshot taken before webpage is rendered > > Fix: Use stateProperty and sleep to wait for the page to finish rendering This pull request has now been integrated. Changeset: 9edba9cc Author:Arun Joseph URL: https://git.op

Re: [Rev 01] RFR: 8243110: SVGTest.testSVGRenderingWithPattern fails intermittently

2020-05-29 Thread Kevin Rushforth
On Fri, 29 May 2020 07:58:21 GMT, Arun Joseph wrote: >> Issue: Snapshot taken before webpage is rendered >> >> Fix: Use stateProperty and sleep to wait for the page to finish rendering > > Arun Joseph has updated the pull request incrementally with one additional > commit since the last revisio

Re: [Integrated] RFR: 8246099: Intermittent test failures in SandboxAppTest

2020-05-29 Thread Kevin Rushforth
On Thu, 28 May 2020 21:02:08 GMT, Kevin Rushforth wrote: > This is a fix for an intermittent test failure, due to a timeout, in > `SandboxAppTest` that we are starting to see on > some of our test machines. > The failure is happening because of a 10 second timeout in the launched > application.

Re: [Rev 01] RFR: 8244195: [TEST_BUG] Convert the system tests TabPanePermuteGetTabsTest to unit test

2020-05-29 Thread Kevin Rushforth
On Fri, 22 May 2020 12:15:04 GMT, Ambarish Rapte wrote: >> As discussed >> [here](https://github.com/openjdk/jfx/pull/201#issuecomment-621772586) >> during #201 , This PR converts the >> system tests in TabPanePermuteGetTabsTest.java to unit test. >> Thanks @kleopatra , for providing the test.

Re: RFR: 8246099: Intermittent test failures in SandboxAppTest

2020-05-29 Thread Johan Vos
On Thu, 28 May 2020 21:02:08 GMT, Kevin Rushforth wrote: > This is a fix for an intermittent test failure, due to a timeout, in > `SandboxAppTest` that we are starting to see on > some of our test machines. > The failure is happening because of a 10 second timeout in the launched > application.

Re: [Rev 03] RFR: 8245053: Keyboard doesn't show when TextInputControl has focus

2020-05-29 Thread Johan Vos
On Fri, 29 May 2020 15:09:30 GMT, Abhinay Agarwal wrote: >> In Android, TextInputControls (TextField and TextArea) are responsible for >> showing and hiding software keyboard. >> Currently, a focus listener is attached to these controls and is used to >> toggle the visibility of keyboard. This

Re: [Rev 03] RFR: 8245053: Keyboard doesn't show when TextInputControl has focus

2020-05-29 Thread Abhinay Agarwal
> In Android, TextInputControls (TextField and TextArea) are responsible for > showing and hiding software keyboard. > Currently, a focus listener is attached to these controls and is used to > toggle the visibility of keyboard. This > condition fails in cases where the control already has focus

Re: [Rev 02] RFR: 8245053: Keyboard doesn't show when TextInputControl has focus

2020-05-29 Thread Michael Paus
On Fri, 29 May 2020 12:48:29 GMT, Johan Vos wrote: >> Abhinay Agarwal has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Skin implementation must maintain the contract of dispose > > Looks good. > A test strategy for Android is a good idea

Re: Arabic letters are not displayed correctly in MacOS 10.15.3

2020-05-29 Thread Abu Abdullah
On Fri, May 29, 2020 at 4:47 PM Philip Race wrote: > > > > On 5/29/20, 5:38 AM, Kevin Rushforth wrote: > > > >> CoreText note: Client requested name ".ArabicUIText-Regular", it will > >> get Times-Roman rather than the intended font. All system UI font > >> access should be through proper APIs suc

Re: Arabic letters are not displayed correctly in MacOS 10.15.3

2020-05-29 Thread Abu Abdullah
On Fri, May 29, 2020 at 5:00 PM Philip Race wrote: > > From https://jdk.java.net/15/ ? Yes

Re: Arabic letters are not displayed correctly in MacOS 10.15.3

2020-05-29 Thread Abu Abdullah
On Fri, May 29, 2020 at 4:42 PM Philip Race wrote: > > The interesting thing about you seeing : > > I can see in the console this message: > CoreText note: Client requested name ".ArabicUIText-Regular", it will > get Times-Roman rather than the intended font. All system UI font > access should be

Re: Arabic letters are not displayed correctly in MacOS 10.15.3

2020-05-29 Thread Philip Race
From https://jdk.java.net/15/ ? -phil. On 5/29/20, 5:53 AM, Abu Abdullah wrote: openjdk version "15-ea" 2020-09-15 OpenJDK Runtime Environment (build 15-ea+24-1168) OpenJDK 64-Bit Server VM (build 15-ea+24-1168, mixed mode, sharing)

Re: Arabic letters are not displayed correctly in MacOS 10.15.3

2020-05-29 Thread Abu Abdullah
> What JDK are you running? This looks like it is caused by > https://bugs.openjdk.java.net/browse/JDK-8244621 which affects JDKs > built with Xcode 11 / MacOSX SDK 10.15. openjdk version "15-ea" 2020-09-15 OpenJDK Runtime Environment (build 15-ea+24-1168) OpenJDK 64-Bit Server VM (build 15-ea+24-

Re: [Rev 02] RFR: 8245053: Keyboard doesn't show when TextInputControl has focus

2020-05-29 Thread Johan Vos
On Tue, 19 May 2020 10:19:42 GMT, Abhinay Agarwal wrote: >> In Android, TextInputControls (TextField and TextArea) are responsible for >> showing and hiding software keyboard. >> Currently, a focus listener is attached to these controls and is used to >> toggle the visibility of keyboard. This

Re: Arabic letters are not displayed correctly in MacOS 10.15.3

2020-05-29 Thread Philip Race
On 5/29/20, 5:38 AM, Kevin Rushforth wrote: CoreText note: Client requested name ".ArabicUIText-Regular", it will get Times-Roman rather than the intended font. All system UI font access should be through proper APIs such as CTFontCreateUIFontForLanguage() or +[NSFont systemFontOfSize:]. I

Re: Arabic letters are not displayed correctly in MacOS 10.15.3

2020-05-29 Thread Philip Race
The interesting thing about you seeing : I can see in the console this message: CoreText note: Client requested name ".ArabicUIText-Regular", it will get Times-Roman rather than the intended font. All system UI font access should be through proper APIs such as CTFontCreateUIFontForLanguage() or +

Re: Arabic letters are not displayed correctly in MacOS 10.15.3

2020-05-29 Thread Kevin Rushforth
On 5/28/2020 5:50 PM, Abu Abdullah wrote: On Fri, May 29, 2020 at 1:21 AM Philip Race wrote: Looks like this is not a Catalina problem. It is a regression in openjfx 14 on macOS. And it is caused by https://bugs.openjdk.java.net/browse/JDK-8234916 I can see in the console this message: Cor

Re: RFR: 8246099: Intermittent test failures in SandboxAppTest

2020-05-29 Thread Ambarish Rapte
On Thu, 28 May 2020 21:02:08 GMT, Kevin Rushforth wrote: > This is a fix for an intermittent test failure, due to a timeout, in > `SandboxAppTest` that we are starting to see on > some of our test machines. > The failure is happening because of a 10 second timeout in the launched > application.

Re: [Rev 01] RFR: 8243110: SVGTest.testSVGRenderingWithPattern fails intermittently

2020-05-29 Thread Arun Joseph
> Issue: Snapshot taken before webpage is rendered > > Fix: Use stateProperty and sleep to wait for the page to finish rendering Arun Joseph has updated the pull request incrementally with one additional commit since the last revision: Review comments - Changes: - all: https:/