Re: RFR: 8201567: QuantumRenderer modifies buffer in use by JavaFX Application Thread [v2]

2020-06-30 Thread John Neffenger
On Tue, 30 Jun 2020 06:05:08 GMT, John Neffenger wrote: >> At first glance the fix looks fine (aside from the `assert` statements that >> need to be removed). It will also need to >> be tested using the SW pipeline on all platforms. > >> It will also need to be tested using the SW pipeline on

Re: RFR: 8201567: QuantumRenderer modifies buffer in use by JavaFX Application Thread

2020-06-30 Thread Ty Young
On 6/25/20 10:56 PM, John Neffenger wrote: Fixes [JDK-8201567](https://bugs.openjdk.java.net/browse/JDK-8201567). - Commit messages: - 8201567: QuantumRenderer modifies buffer in use by JavaFX Application Thread Changes: https://git.openjdk.java.net/jfx/pull/255/files

Re: RFR: 8176270: Adding ChangeListener to TextField.selectedTextProperty causes StringOutOfBoundsException [v6]

2020-06-30 Thread Kevin Rushforth
On Tue, 16 Jun 2020 09:03:35 GMT, Robert Lichtenberger wrote: >> This PR fixes JDK-8176270 by clamping the end index of the selected text to >> the length of the text. > > Robert Lichtenberger has updated the pull request incrementally with one > additional commit since the last revision: >

Re: RFR: 8201567: QuantumRenderer modifies buffer in use by JavaFX Application Thread [v2]

2020-06-30 Thread John Neffenger
> Fixes [JDK-8201567](https://bugs.openjdk.java.net/browse/JDK-8201567). John Neffenger has updated the pull request incrementally with one additional commit since the last revision: Remove assert statements - Changes: - all: https://git.openjdk.java.net/jfx/pull/255/files -

Re: RFR: 8201567: QuantumRenderer modifies buffer in use by JavaFX Application Thread

2020-06-30 Thread Kevin Rushforth
On Sun, 28 Jun 2020 02:35:16 GMT, John Neffenger wrote: >> modules/javafx.graphics/src/main/java/com/sun/glass/ui/Pixels.java line 194: >> >>> 193: public final Buffer getBuffer() { >>> 194: assert this.bytes != null || this.ints != null; >>> 195: return this.bytes != null

Re: RFR: 8248317: Change JavaFX release version to 16

2020-06-30 Thread Ambarish Rapte
On Tue, 30 Jun 2020 15:30:31 GMT, Kevin Rushforth wrote: > Bump the version number of JavaFX to 16. I will integrate this immediately > after forking the `jfx15` stabilization > branch. Marked as reviewed by arapte (Reviewer). - PR: https://git.openjdk.java.net/jfx/pull/260

Re: RFR: 8238954: Improve performance of tiled snapshot rendering [v14]

2020-06-30 Thread Ambarish Rapte
On Tue, 30 Jun 2020 09:44:33 GMT, Frederic Thevenet wrote: >> Issue JDK-8088198, where an exception would be thrown when trying to capture >> a snapshot whose final dimensions would be >> larger than the running platform's maximum supported texture size, was >> addressed in openjfx14. The

Integrated: 8247947: Build DirectShow Samples (Base Classes) from source checked into repo

2020-06-30 Thread Alexander Matveev
On Thu, 25 Jun 2020 23:19:05 GMT, Alexander Matveev wrote: > - Added DirectShow baseclasses to repository. > - Dependency on Windows SDK 7.1 DirectShow baseclasses was removed. This pull request has now been integrated. Changeset: 62f8cee7 Author:Alexander Matveev URL:

Re: RFR: 8238954: Improve performance of tiled snapshot rendering [v14]

2020-06-30 Thread Kevin Rushforth
On Tue, 30 Jun 2020 09:44:33 GMT, Frederic Thevenet wrote: >> Issue JDK-8088198, where an exception would be thrown when trying to capture >> a snapshot whose final dimensions would be >> larger than the running platform's maximum supported texture size, was >> addressed in openjfx14. The

Re: RFR: 8220484: JFXPanel renders a slanted image with a hidpi monitor scale of 125% or 175% [v2]

2020-06-30 Thread Oliver Schmidtmer
On Wed, 17 Jun 2020 07:32:46 GMT, Prasanta Sadhukhan wrote: >> Oliver Schmidtmer has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Change to Math.ceil and add test > > In 2D, we normally use sun.java2d.pipe.Region.clipRound as it also

Re: RFR: 8220484: JFXPanel renders a slanted image with a hidpi monitor scale of 125% or 175% [v2]

2020-06-30 Thread Oliver Schmidtmer
> In edge cases where monitor scaling of 1.25 or 1.75 is active, Math.ceil and > Math.round produce different results and > EmbeddedScene#getPixels in JFXPanel#paintComponent causes an off-by-one error > on the line width and therefore sheared > rendering. The changes were already proposed by

Re: RFR: 8248317: Change JavaFX release version to 16

2020-06-30 Thread Kevin Rushforth
The message from this sender included one or more files which could not be scanned for virus detection; do not open these files unless you are certain of the sender's intent. -- On Tue, 30 Jun 2020 15:30:31 GMT, Kevin Rushforth

RFR: 8248317: Change JavaFX release version to 16

2020-06-30 Thread Kevin Rushforth
Bump the version number of JavaFX to 16. I will integrate this immediately after forking the `jfx15` stabilization branch. - Commit messages: - 8248317: Change JavaFX release version to 16 Changes: https://git.openjdk.java.net/jfx/pull/260/files Webrev:

Re: RFR: 8247947: Build DirectShow Samples (Base Classes) from source checked into repo

2020-06-30 Thread Ambarish Rapte
The message from this sender included one or more files which could not be scanned for virus detection; do not open these files unless you are certain of the sender's intent. -- On Thu, 25 Jun 2020 23:19:05 GMT, Alexander Matveev

RFR: 8248551: [TestBug] Ignore two failing FXML unit tests which use Nashorn script engine

2020-06-30 Thread Ajit Ghaisas
Issue : https://bugs.openjdk.java.net/browse/JDK-8248551 Fix : Added a check whether 'Nashorn' script engine is available before running the identified tests, otherwise tests are ignored. Testing : 1) With JDK-14, these tests pass- but they log a warning (same as existing behavior without this

Integrated: 8248551: [TestBug] Ignore two failing FXML unit tests which use Nashorn script engine

2020-06-30 Thread Ajit Ghaisas
On Tue, 30 Jun 2020 11:11:12 GMT, Ajit Ghaisas wrote: > Issue : https://bugs.openjdk.java.net/browse/JDK-8248551 > Fix : Added a check whether 'Nashorn' script engine is available before > running the identified tests, otherwise tests > are ignored. > Testing : > 1) With JDK-14, these tests

Re: RFR: 8248551: [TestBug] Ignore two failing FXML unit tests which use Nashorn script engine

2020-06-30 Thread Kevin Rushforth
On Tue, 30 Jun 2020 11:11:12 GMT, Ajit Ghaisas wrote: > Issue : https://bugs.openjdk.java.net/browse/JDK-8248551 > Fix : Added a check whether 'Nashorn' script engine is available before > running the identified tests, otherwise tests > are ignored. > Testing : > 1) With JDK-14, these tests

Integrated: 8238080: FXMLLoader: if script engines implement javax.script.Compilable compile scripts

2020-06-30 Thread Rony G . Flatscher
On Mon, 20 Apr 2020 12:45:30 GMT, Rony G. Flatscher wrote: > This PR adds a "compile" process instruction to FXML files with the optional > PI data "true" (default) and "false". The > PI data is turned into a boolean value using "Boolean.parseBoolean(String)". > This makes it possible to

Re: RFR: 8238954: Improve performance of tiled snapshot rendering [v14]

2020-06-30 Thread Frederic Thevenet
The message from this sender included one or more files which could not be scanned for virus detection; do not open these files unless you are certain of the sender's intent. -- > Issue JDK-8088198, where an exception would be

Re: RFR: 8238954: Improve performance of tiled snapshot rendering [v13]

2020-06-30 Thread Frederic Thevenet
On Mon, 29 Jun 2020 22:46:26 GMT, Kevin Rushforth wrote: >> I think I found the problem in the tiling logic that leads to the macOS >> failures. You need to check that the remainder >> width or height is > 0. Also, it looks like you have the "B" and "R" loops >> backwards, which is a bit

Re: RFR: 8238954: Improve performance of tiled snapshot rendering [v13]

2020-06-30 Thread Frederic Thevenet
On Mon, 29 Jun 2020 21:32:33 GMT, Kevin Rushforth wrote: >> Frederic Thevenet has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fill test image with a bilinear gradient instead of random noise. > >

Re: RFR: 8238080: FXMLLoader: if script engines implement javax.script.Compilable compile scripts [v6]

2020-06-30 Thread Rony G Flatscher
Hi Ajit, Kevin looked into it already yesterday. There was some problem at github at the time I submitted the /integrate comment, which merely needs to be reissued by me. Having been on the road I was not able to do it yesterday, will be first thing after arriving at the office today. Also,

Re: RFR: 8201567: QuantumRenderer modifies buffer in use by JavaFX Application Thread

2020-06-30 Thread John Neffenger
On Sat, 27 Jun 2020 15:37:52 GMT, Kevin Rushforth wrote: > It will also need to be tested using the SW pipeline on all platforms. Thanks for the reminder. I managed to build JavaFX on Windows and macOS today, so I'll test this pull request on those platforms in addition to Linux desktop and

Re: RFR: 8238080: FXMLLoader: if script engines implement javax.script.Compilable compile scripts [v6]

2020-06-30 Thread Ajit Ghaisas
On Sat, 27 Jun 2020 14:07:24 GMT, Rony G. Flatscher wrote: >> This PR adds a "compile" process instruction to FXML files with the optional >> PI data "true" (default) and "false". The >> PI data is turned into a boolean value using "Boolean.parseBoolean(String)". >> This makes it possible to

Re: RFR: 8238080: FXMLLoader: if script engines implement javax.script.Compilable compile scripts [v6]

2020-06-30 Thread Ajit Ghaisas
The message from this sender included one or more files which could not be scanned for virus detection; do not open these files unless you are certain of the sender's intent. -- On Sat, 27 Jun 2020 14:41:29 GMT, Kevin Rushforth