[jfx15] Integrated: 8228570: Add various documentation clarifications

2020-08-12 Thread Nir Lisker
On Mon, 27 Jul 2020 20:32:46 GMT, Nir Lisker wrote: > Adds clarifications to the documentation in various places. Some notes: > > * Point 6 should probably be deferred until it is verified that the tutorials > are correct enough, seeing as they were > updated to Java 8 only. > * Point 8 has b

Re: [jfx15] RFR: 8228570: Add various documentation clarifications [v5]

2020-08-12 Thread Ambarish Rapte
On Wed, 12 Aug 2020 10:26:06 GMT, Nir Lisker wrote: >> Adds clarifications to the documentation in various places. Some notes: >> >> * Point 6 should probably be deferred until it is verified that the >> tutorials are correct enough, seeing as they were >> updated to Java 8 only. >> * Point 8

Re: RFR: 8202990: javafx webview css filter property with display scaling

2020-08-12 Thread Kevin Rushforth
On Tue, 11 Aug 2020 16:18:37 GMT, Bhawesh Choudhary wrote: > ImageJava.cpp ignores CompositeOperator parameter in drawImage function due > to which shadow was getting drawn on top of > actual image. apply given composite operator to graphics context before > drawing image to fix this issue. an

Re: [jfx15] RFR: 8228570: Add various documentation clarifications [v5]

2020-08-12 Thread Kevin Rushforth
On Wed, 12 Aug 2020 10:26:06 GMT, Nir Lisker wrote: >> Adds clarifications to the documentation in various places. Some notes: >> >> * Point 6 should probably be deferred until it is verified that the >> tutorials are correct enough, seeing as they were >> updated to Java 8 only. >> * Point 8

Re: [jfx15] RFR: 8228570: Add various documentation clarifications [v4]

2020-08-12 Thread Nir Lisker
On Tue, 11 Aug 2020 20:37:54 GMT, Kevin Rushforth wrote: >> Nir Lisker has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Reverted transforms-related changes and added API note for getProperties > > modules/javafx.controls/src/main/java/jav

Re: [jfx15] RFR: 8228570: Add various documentation clarifications [v5]

2020-08-12 Thread Nir Lisker
> Adds clarifications to the documentation in various places. Some notes: > > * Point 6 should probably be deferred until it is verified that the tutorials > are correct enough, seeing as they were > updated to Java 8 only. > * Point 8 has been deferred until all the animation bugs have been re

Enter, Non-Push-Button, Mac - popposing change

2020-08-12 Thread Florian Kirmaier
Hi everyone, related ticket from the past: https://bugs.openjdk.java.net/browse/JDK-8139509 Examples for ButtonTypes: non-push-buttons: RadioButton, CheckBox pushButtons: Button, ToggleButton CurrentStatus: Consumes EnterEventWindows Mac PushButton true false NotPushButt