Re: RFR: 8242861: Update ImagePattern to apply SVG pattern transforms [v4]

2020-08-19 Thread Arun Joseph
> fillPath() and fillRect() functions in > [GraphicsContextJava.cpp](https://github.com/openjdk/jfx/blob/master/modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/java/GraphicsContextJava.cpp) > use Image::drawPattern() for applying patterns as fill. But drawPattern() > doesn't us

Re: JPackage and JavaFX

2020-08-19 Thread Tobias Oelgarte
I have no problem using jpackage together with JDK 14 and JavaFX 14/16 under Ubuntu 18.04. My guess is that you run the jpackage command from a different JDK version, which loads it's own module "java.base" and references it's own module "jdk.management.jfr". This is different from the one fou

Re: HID multitouch display support in JavaFX

2020-08-19 Thread jfx user2
HID support specifically would be good b/c there seem to be lots of cases where the OS's are properly recognizing HID compatible displays with touch events working through the HID APIs but do not work in JavaFX since it relies on the OS's (native?) support. For example, I have multiple HID display

Re: JPackage and JavaFX

2020-08-19 Thread Kevin Rushforth
I've not seen the module FindException with jfr before, but one thing I do see is that you will need to use the JavaFX jmods rather than the sdk. Otherwise, jlink (which is invoked by jpackage) won't produce a runnable application. -- Kevin On 8/19/2020 5:52 PM, Davide Perini wrote: Hi all,

JPackage and JavaFX

2020-08-19 Thread Davide Perini
Hi all, is there someone able to use JPackage with JavaFX under ubuntu with JDK14? When I try to use jpackage on ubuntu I get this error: jpackage -n TestFX -i target --main-jar tmyjar-jar-with-dependencies.jar -d output --module-path /home/sblantipodi/dev/jdk/javafx-sdk-14.0.2.1/lib WARNING:

RE: TabPane - initial select tab not working properly?

2020-08-19 Thread Ambarish Rapte
Hello Daniel, The behavior seems like a bug to me. Looks like the first layout of TabHeader fails to bring the selected tab header into view. You can report it here https://bugs.java.com/bugdatabase/ Reason why it works with Platform.runLater(): Wrapping the select() call inside a Platfrom.run

Integrated: 8251241: macOS: iconify property doesn't change after minimize when resizable is false

2020-08-19 Thread Florian Kirmaier
On Thu, 13 Aug 2020 12:37:11 GMT, Florian Kirmaier wrote: > ticket: https://bugs.openjdk.java.net/browse/JDK-8251241 > > This small change fixing the minimize for mac. > Changes are property registered. > Calling setIconize(true) no longer resets to false. This pull request has now been integr

Re: RFR: 8251241: macOS: iconify property doesn't change after minimize when resizable is false [v3]

2020-08-19 Thread Ambarish Rapte
On Thu, 13 Aug 2020 19:45:49 GMT, Florian Kirmaier wrote: >> ticket: https://bugs.openjdk.java.net/browse/JDK-8251241 >> >> This small change fixing the minimize for mac. >> Changes are property registered. >> Calling setIconize(true) no longer resets to false. > > Florian Kirmaier has updated

TabPane - initial select tab not working properly?

2020-08-19 Thread Daniel Peintner
All, I just stumbled over a problem which I think is a bug in JavaFX. In a program I create several tabs and initialize a selected tab upfront. The 'select' command works fine for the tab pane content but unfortunately not for the header that shows the current active tab (somehow the tab header d

Re: RFR: 8209788: Left/Right/Ctrl+A keys not working in editor of ComboBox if popup showing [v3]

2020-08-19 Thread Ambarish Rapte
On Thu, 6 Aug 2020 09:39:35 GMT, Jeanette Winzenburg wrote: > okay, I still favor the not-adding-if-not-needed approach I have updated the PR to use this approach. I did not think that all of `FocusTraversalInputMap.getFocusTraversalMappings()` can be removed. But looks like they can be remov

Re: RFR: 8251241: macOS: iconify property doesn't change after minimize when resizable is false

2020-08-19 Thread Dirk Lemmermann
On Thu, 13 Aug 2020 12:52:37 GMT, Florian Kirmaier wrote: >>> JDK-8251241: macOS: iconify property doesn't change after minimize when >>> resizable is false ⚠️ Title mismatch between PR >>> and JBS. >> >> Can you change the title to match the JBS title? > > Done! I've changed the title. Thank

Re: RFR: 8251241: macOS: iconify property doesn't change after minimize when resizable is false [v3]

2020-08-19 Thread Kevin Rushforth
On Thu, 13 Aug 2020 20:29:47 GMT, Kevin Rushforth wrote: >> Florian Kirmaier has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8251241 >> applied tests from kevinrushforth > > Looks good. Thanks for fixing this long-standing bug. > > I

Re: RFR: 8209788: Left/Right/Ctrl+A keys not working in editor of ComboBox if popup showing [v6]

2020-08-19 Thread Ambarish Rapte
> The issue occurs because the key events are consumed by the `ListView` in > `Popup`, which displays the items. > This is a regression of > [JDK-8077916](https://bugs.openjdk.java.net/browse/JDK-8077916). This change > aadded several > `KeyMapping`s for focus traversals to `ListView`, which con