Re: RFR: 8169501: GIF animation is too fast

2020-09-14 Thread Bhawesh Choudhary
On Thu, 23 Jul 2020 17:42:57 GMT, Kevin Rushforth wrote: >> issue is caused by the threshold value for frame duration used by javaFx >> before it gets normalized. JavaFx is using >> threshold value 10 while other browser (Safari, Firefox) is using 50 due to >> which, value between 10 and 50 don

Re: RFR: 8231601: Update CONTRIBUTING.md to clarify process for contributing features plus Skara changes [v2]

2020-09-14 Thread Kevin Rushforth
On Mon, 14 Sep 2020 11:22:42 GMT, Nir Lisker wrote: >> Kevin Rushforth has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fixed URL to WEBKIT-MEDIA-STUBS.md > > Additional comments: > > 1. "Use Unix-style (LF) line endings not DOS-style (C

Re: RFR: 8231601: Update CONTRIBUTING.md to clarify process for contributing features plus Skara changes [v2]

2020-09-14 Thread Kevin Rushforth
> This PR updates the `CONTRIBUTING.md` guide to address the following: > > 1. Clarify the process for adding new features / API changes, specifically > that they must be discussed on the mailing > list as the first step. 2. Add a link to the mailing list in the section > regarding contributing

RFR: 8231601: Update CONTRIBUTING.md to clarify process for contributing features plus Skara changes

2020-09-14 Thread Kevin Rushforth
This PR updates the `CONTRIBUTING.md` guide to address the following: 1. Clarify the process for adding new features / API changes, specifically that they must be discussed on the mailing list as the first step. 2. Add a link to the mailing list in the section regarding contributing bug fixes. 3

Re: Media Player Failure When Speakers Not Present

2020-09-14 Thread Kevin Rushforth
That's still the right place to report bugs. You can find this in the project README [1] on GItHub. -- Kevin [1] https://github.com/openjdk/jfx#issue-tracking On 9/14/2020 1:27 PM, omnip...@gmail.com wrote: I am a little confused. The url you sent appears to be for Java SE bug reporting and

Re: RFR: 8231601: Update CONTRIBUTING.md to clarify process for contributing features plus Skara changes

2020-09-14 Thread Kevin Rushforth
On Mon, 14 Sep 2020 10:18:05 GMT, Nir Lisker wrote: >> This PR updates the `CONTRIBUTING.md` guide to address the following: >> >> 1. Clarify the process for adding new features / API changes, specifically >> that they must be discussed on the mailing >> list as the first step. 2. Add a link to

Re: RFR: 8231601: Update CONTRIBUTING.md to clarify process for contributing features plus Skara changes

2020-09-14 Thread Nir Lisker
On Sat, 12 Sep 2020 17:16:38 GMT, Kevin Rushforth wrote: > This PR updates the `CONTRIBUTING.md` guide to address the following: > > 1. Clarify the process for adding new features / API changes, specifically > that they must be discussed on the mailing > list as the first step. 2. Add a link to

Re: Media Player Failure When Speakers Not Present

2020-09-14 Thread Nir Lisker
The issues database is the same for all OpenJDK projects, including JDK and OpenJFX. When you submit the issue, it is triaged internally and transferred to the public JBS at https://bugs.openjdk.java.net. On Mon, Sep 14, 2020 at 11:27 PM wrote: > I am a little confused. The url you sent appears

Re: Media Player Failure When Speakers Not Present

2020-09-14 Thread Michael Paus
The URL is correct. JavaFX is still tracked by the normal JDK bug tracking system. Am 14.09.20 um 22:27 schrieb omnip...@gmail.com: I am a little confused. The url you sent appears to be for Java SE bug reporting and I thought that JavaFX as OpenJFX is not part of the Java SE distribution. If

RE: Media Player Failure When Speakers Not Present

2020-09-14 Thread omniprof
I am a little confused. The url you sent appears to be for Java SE bug reporting and I thought that JavaFX as OpenJFX is not part of the Java SE distribution. If so then this may not be where I report my issue. Ken From: Nir Lisker Sent: September 14, 2020 4:19 PM To: omnip...@gmail.

Re: Media Player Failure When Speakers Not Present

2020-09-14 Thread Nir Lisker
> > PS: If someone can send me the URL for OpenJFX's JIRA or equivalent, I will > submit a bug report. > bugreport.java.com On Mon, Sep 14, 2020 at 11:03 PM wrote: > While I am still looking for where I can file this problem I thought I'd > bring it to the list. A program I use in my course pla

Media Player Failure When Speakers Not Present

2020-09-14 Thread omniprof
While I am still looking for where I can file this problem I thought I'd bring it to the list. A program I use in my course plays a short video. Have used it for a few years and it works fine. EXCEPT, if there is not a connected audio out device such as speakers or headphones. The video does not pl

Re: RFR: 8197991: Selecting many items in a TableView is very slow

2020-09-14 Thread yosbits
On Mon, 14 Sep 2020 10:03:59 GMT, Ajit Ghaisas wrote: >> Any progress with having this merged? > > This is a very good attempt to improve selection performance. I have few > review comments. > I ran the manual test that you have provided. It does show the improvement. > Can you please provide an

Re: RFR: 8218973: SVG with masking is not rendering image with mask effect [v12]

2020-09-14 Thread Bhawesh Choudhary
On Fri, 11 Sep 2020 00:13:48 GMT, Kevin Rushforth wrote: >> Bhawesh Choudhary has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Added unit test for strokes > > modules/javafx.web/src/main/java/com/sun/javafx/webkit/prism/WCGraphicsPrismCon

Re: RFR: 8218973: SVG with masking is not rendering image with mask effect [v12]

2020-09-14 Thread Bhawesh Choudhary
On Fri, 11 Sep 2020 00:10:29 GMT, Kevin Rushforth wrote: >> Bhawesh Choudhary has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Added unit test for strokes > > modules/javafx.web/src/main/java/com/sun/javafx/webkit/prism/WCGraphicsPrismCon

Re: RFR: 8218973: SVG with masking is not rendering image with mask effect [v7]

2020-09-14 Thread Bhawesh Choudhary
On Fri, 11 Sep 2020 06:48:35 GMT, Bhawesh Choudhary wrote: >> This question is still outstanding. It seems like the call to `setCTM` is >> either needed before all of the `setGradient` >> calls or none of them. Can you comment? > > i believe setCTM call is needed for none of them. it is a worka

Re: RFR: 8218973: SVG with masking is not rendering image with mask effect [v13]

2020-09-14 Thread Bhawesh Choudhary
> Root cause of issue is Specifying a image mask from GraphicsContextJava.cpp > in WebKit was not implemented, so masking > doesn't take place at all while rendering SVGRect. to fix this issue add > implementation of function clipToImageBuffer() > in GraphicsContextJava.cpp and send clip image to

Re: RFR: 8197991: Selecting many items in a TableView is very slow

2020-09-14 Thread Ajit Ghaisas
On Wed, 26 Feb 2020 07:37:06 GMT, yosbits wrote: > https://bugs.openjdk.java.net/browse/JDK-8197991 > > The performance of the selectAll and selectRange methods of the > MultiSelectionModel class has been greatly improved. > > This greatly improves the response when selecting multiple items i

Re: RFR: 8197991: Selecting many items in a TableView is very slow

2020-09-14 Thread Ajit Ghaisas
On Mon, 7 Sep 2020 18:14:03 GMT, Timm wrote: >> @aghaisas can you also review this? > > Any progress with having this merged? This is a very good attempt to improve selection performance. I have few review comments. I ran the manual test that you have provided. It does show the improvement. Ca

RFR: 8253086: Optimization of removeAll and retainAll of ObservableListWrapper

2020-09-14 Thread yosbits
https://bugs.openjdk.java.net/browse/JDK-8253086 ObservableListWrapper.java * public boolean removeAll(Collection c) * public boolean retainAll(Collection c) These two methods use BitSet, but it doesn't make sense. By rewriting to the equivalent behavior that does not use BitSet, it is possible

Integrated: 8252547: Correct transformations docs in Node

2020-09-14 Thread Nir Lisker
On Mon, 31 Aug 2020 23:28:51 GMT, Nir Lisker wrote: > Correction to the order of transforms specified in the docs of `Node`. This pull request has now been integrated. Changeset: d6dee348 Author:Nir Lisker URL: https://git.openjdk.java.net/jfx/commit/d6dee348 Stats: 45 lines in 1

Re: RFR: 8252236: TabPane - initial select tab not working properly

2020-09-14 Thread Jeanette Winzenburg
On Mon, 14 Sep 2020 07:09:01 GMT, Ambarish Rapte wrote: >> the issue is that the header of the selected tab is not always visible (or >> kept visible, see report for details) >> >> - initially >> - after changing side >> - after resizing stage/tabPane >> >> Fixed in TabPaneSkin to notify its T

Re: RFR: 8240499: Enforce whitespace checking for additional source files

2020-09-14 Thread Johan Vos
On Fri, 11 Sep 2020 13:21:29 GMT, Kevin Rushforth wrote: > The `.jcheck/conf` file is configured to check the same set of files as the > old HG jcheck, namely files with the > following extensions: > .java, .c, .h, .cpp, .hpp > > The Skara git jcheck allows us to evolve the rules for white

Re: RFR: 8252547: Correct transformations docs in Node [v5]

2020-09-14 Thread Ambarish Rapte
On Sat, 12 Sep 2020 15:21:35 GMT, Nir Lisker wrote: >> Correction to the order of transforms specified in the docs of `Node`. > > Nir Lisker has updated the pull request incrementally with one additional > commit since the last revision: > > Replaced a link change looks good to me, javadoc b

Re: RFR: 8252236: TabPane - initial select tab not working properly

2020-09-14 Thread Ambarish Rapte
On Thu, 10 Sep 2020 12:03:34 GMT, Jeanette Winzenburg wrote: > the issue is that the header of the selected tab is not always visible (or > kept visible, see report for details) > > - initially > - after changing side > - after resizing stage/tabPane > > Fixed in TabPaneSkin to notify its Tab