Integrated: 8255002: Many javafx.controls unit tests have incorrect name containing impl_*

2020-10-21 Thread Ajit Ghaisas
On Tue, 20 Oct 2020 12:18:10 GMT, Ajit Ghaisas wrote: > It is a test cleanup work. > > Issue : > Many unit tests in javafx.controls module have incorrect naming that use text > "impl_" in names and comments. > The test code correctly avoids using impl_* methods (as they were removed in > JDK 9

Re: RFR: 8255002: Many javafx.controls unit tests have incorrect name containing impl_* [v2]

2020-10-21 Thread Ambarish Rapte
On Wed, 21 Oct 2020 11:54:24 GMT, Ajit Ghaisas wrote: >> It is a test cleanup work. >> >> Issue : >> Many unit tests in javafx.controls module have incorrect naming that use >> text "impl_" in names and comments. >> The test code correctly avoids using impl_* methods (as they were removed in >

Re: Re: Can't load fxml on Macos

2020-10-21 Thread Eric Bresie
What is fxml set to? Could maybe be a “classpath” type issue where it’s looking on the classpath and can’t find it. Eric Bresie ebre...@gmail.com (mailto:ebre...@gmail.com) > On October 20, 2020 at 8:56:52 AM CDT, Davide Perini > mailto:perini.dav...@dpsoftware.org)> wrote: > I'm creating my b

RFR: 8252596: [TESTBUG] WebPageShim::paint is not thread-safe

2020-10-21 Thread Arun Joseph
Issue: Tests using `WebPageShim::paint` fails around 1/10 times. Fix: Execute `WebPageShim::paint` in the render thread using `PrismInvoker`. Ran tests over 100 times, no failures. Used the initial unit test in the PR for [JDK-8202990](https://bugs.openjdk.java.net/browse/JDK-8202990). ---

Re: RFR: 8211294: [windows] TextArea content is blurry with 125% scaling

2020-10-21 Thread Kevin Rushforth
On Wed, 21 Oct 2020 07:01:46 GMT, Frederic Thevenet wrote: >>> >>> >>> The visual representation corresponds with digits, so there can be tests >>> that check if the numbers are what we expect them to be. >>> It's good that this is not windows-only, so that it can be tackled on linux >>> as

Re: RFR: 8255002: Many javafx.controls unit tests have incorrect name containing impl_* [v2]

2020-10-21 Thread Ajit Ghaisas
On Wed, 21 Oct 2020 08:23:25 GMT, Ambarish Rapte wrote: >> Ajit Ghaisas has updated the pull request incrementally with one additional >> commit since the last revision: >> >> JDK-8255002 - review fixes > > modules/javafx.controls/src/test/java/test/javafx/scene/control/ControlTest.java > li

Re: RFR: 8255002: Many javafx.controls unit tests have incorrect name containing impl_* [v2]

2020-10-21 Thread Ajit Ghaisas
> It is a test cleanup work. > > Issue : > Many unit tests in javafx.controls module have incorrect naming that use text > "impl_" in names and comments. > The test code correctly avoids using impl_* methods (as they were removed in > JDK 9), but test names still have "impl_" in them. > > Fix :

Re: RFR: 8255002: Many javafx.controls unit tests have incorrect name containing impl_*

2020-10-21 Thread Ambarish Rapte
On Tue, 20 Oct 2020 12:18:10 GMT, Ajit Ghaisas wrote: > It is a test cleanup work. > > Issue : > Many unit tests in javafx.controls module have incorrect naming that use text > "impl_" in names and comments. > The test code correctly avoids using impl_* methods (as they were removed in > JDK 9

Re: Can't load fxml on Macos

2020-10-21 Thread Michael Paus
With so little information nobody will be able to answer your question and I am pretty sure that not macOS is the black sheep here. Such questions are also better posted on Stackoverflow and not here on the OpenJFX development mailing list. Michael Am 20.10.20 um 12:28 schrieb Davide Perini: Hi

Re: RFR: 8211294: [windows] TextArea content is blurry with 125% scaling

2020-10-21 Thread Frederic Thevenet
On Fri, 25 Sep 2020 09:32:46 GMT, Frederic Thevenet wrote: >> The visual representation corresponds with digits, so there can be tests >> that check if the numbers are what we expect >> them to be. It's good that this is not windows-only, so that it can be >> tackled on linux as well. But wha