Re: [jfx15] RFR: 8255272: Create release notes for JavaFX 15.0.1 [v2]

2020-10-23 Thread Johan Vos
On Thu, 22 Oct 2020 20:46:04 GMT, Kevin Rushforth wrote: >> Johan Vos has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Refer to original backport issues > > doc-files/release-notes-15.0.1.md line 16: > >> 14: [JDK-8255064](https://bugs.o

Re: [jfx15] RFR: 8255272: Create release notes for JavaFX 15.0.1 [v2]

2020-10-23 Thread Johan Vos
> releasenotes for JavaFX 15.0.1 Johan Vos has updated the pull request incrementally with one additional commit since the last revision: Refer to original backport issues - Changes: - all: https://git.openjdk.java.net/jfx/pull/335/files - new: https://git.openjdk.java.net/jf

RFR: 8199592: Control labels truncated at certain DPI scaling levels

2020-10-23 Thread Jose Pereda
As discussed in the [JBS issue](https://bugs.openjdk.java.net/browse/JDK-8199592), when snapping an already snapped value (either intentionally or by mistake), the result should be the same, otherwise we'll be jumping unnecessary from a valid pixel to another pixel. This PR provides a fix to

Re: [jfx15] RFR: 8255272: Create release notes for JavaFX 15.0.1 [v2]

2020-10-23 Thread Kevin Rushforth
On Fri, 23 Oct 2020 07:13:46 GMT, Johan Vos wrote: >> releasenotes for JavaFX 15.0.1 > > Johan Vos has updated the pull request incrementally with one additional > commit since the last revision: > > Refer to original backport issues Marked as reviewed by kcr (Lead). - PR: http

Re: RFR: 8255241: [TestBug] Re-enable few ignored tests in javafx.controls module that pass with latest code [v2]

2020-10-23 Thread Kevin Rushforth
On Thu, 22 Oct 2020 17:48:25 GMT, Ajit Ghaisas wrote: >> Some of the ignored unit tests in javafx.controls module pass with latest >> code. >> This bug is to address - >> - removal of ignored tag >> - fixing the test if fix is minor > > Ajit Ghaisas has updated the pull request incrementally wit

RFR: 8255337: [TestBug] Controls unit tests - ButtonTest and ComboBoxTest - log ClassCastException

2020-10-23 Thread Ajit Ghaisas
This is a test fix. Root cause: - For ButtonTest - Incorrect use of MouseEventFirer - which puts Button on to the stage and shows it before firing mouse event - For ComboBoxTest - adding ComboBox to a Stage, not showing the Stage but trying to show the ComboBox Fix : - For ButtonTest - Moved M

Integrated: 8255241: [TestBug] Re-enable few ignored tests in javafx.controls module that pass with latest code

2020-10-23 Thread Ajit Ghaisas
On Thu, 22 Oct 2020 12:13:11 GMT, Ajit Ghaisas wrote: > Some of the ignored unit tests in javafx.controls module pass with latest > code. > This bug is to address - > - removal of ignored tag > - fixing the test if fix is minor This pull request has now been integrated. Changeset: 243b1a50 Aut

[jfx15] Integrated: 8255272: Create release notes for JavaFX 15.0.1

2020-10-23 Thread Johan Vos
On Thu, 22 Oct 2020 20:36:40 GMT, Johan Vos wrote: > releasenotes for JavaFX 15.0.1 This pull request has now been integrated. Changeset: f4c348fe Author:Johan Vos URL: https://git.openjdk.java.net/jfx/commit/f4c348fe Stats: 22 lines in 1 file changed: 22 ins; 0 del; 0 mod 82552

Re: RFR: 8213573: MouseLocationOnScreenTest fails intermittently

2020-10-23 Thread Kevin Rushforth
On Thu, 22 Oct 2020 14:22:32 GMT, Pankaj Bansal wrote: > The test test.robot.javafx.scene.MouseLocationOnScreenTest fails > intermittently on Windows and Mac system though it fails on Windows more > often than Mac. > > The test uses robot to move the mouse at different positions on screen usin

Re: RFR: 8213573: MouseLocationOnScreenTest fails intermittently [v2]

2020-10-23 Thread Pankaj Bansal
> The test test.robot.javafx.scene.MouseLocationOnScreenTest fails > intermittently on Windows and Mac system though it fails on Windows more > often than Mac. > > The test uses robot to move the mouse at different positions on screen using > mouseMove and then validates the mouse coordinates b

Re: RFR: 8213573: MouseLocationOnScreenTest fails intermittently [v2]

2020-10-23 Thread Pankaj Bansal
On Fri, 23 Oct 2020 13:33:35 GMT, Kevin Rushforth wrote: >> Pankaj Bansal has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fixing review comments > > tests/system/src/test/java/test/robot/javafx/scene/MouseLocationOnScreenTest.java > lin

Re: RFR: 8213573: MouseLocationOnScreenTest fails intermittently [v2]

2020-10-23 Thread Kevin Rushforth
On Fri, 23 Oct 2020 13:57:46 GMT, Pankaj Bansal wrote: >> The test test.robot.javafx.scene.MouseLocationOnScreenTest fails >> intermittently on Windows and Mac system though it fails on Windows more >> often than Mac. >> >> The test uses robot to move the mouse at different positions on screen

Integrated: 8213573: MouseLocationOnScreenTest fails intermittently

2020-10-23 Thread Pankaj Bansal
On Thu, 22 Oct 2020 14:22:32 GMT, Pankaj Bansal wrote: > The test test.robot.javafx.scene.MouseLocationOnScreenTest fails > intermittently on Windows and Mac system though it fails on Windows more > often than Mac. > > The test uses robot to move the mouse at different positions on screen usin

CFV: New OpenJFX Committer: Pankaj Bansal

2020-10-23 Thread Kevin Rushforth
I hereby nominate Pankaj Bansal [1] to OpenJFX Committer. Pankaj is a member of Java client team at Oracle, who has contributed 11 commits [2] to OpenJFX. Votes are due by November 6, 2020. Only current OpenJFX Committers [3] are eligible to vote on this nomination. Votes must be cast in the

Re: CFV: New OpenJFX Committer: Pankaj Bansal

2020-10-23 Thread Kevin Rushforth
Vote: YES On 10/23/2020 7:38 AM, Kevin Rushforth wrote: I hereby nominate Pankaj Bansal [1] to OpenJFX Committer.

Re: CFV: New OpenJFX Committer: Pankaj Bansal

2020-10-23 Thread Nir Lisker
Vote: YES On Fri, Oct 23, 2020 at 5:40 PM Kevin Rushforth wrote: > Vote: YES > > On 10/23/2020 7:38 AM, Kevin Rushforth wrote: > > I hereby nominate Pankaj Bansal [1] to OpenJFX Committer. > > > >

Re: CFV: New OpenJFX Committer: Pankaj Bansal

2020-10-23 Thread Philip Race
Vote: yes -phil.

Re: RFR: 8255337: [TestBug] Controls unit tests - ButtonTest and ComboBoxTest - log ClassCastException

2020-10-23 Thread Jeanette Winzenburg
On Fri, 23 Oct 2020 11:35:50 GMT, Ajit Ghaisas wrote: > This is a test fix. > > Root cause: > - For ButtonTest - Incorrect use of MouseEventFirer - which puts Button on to > the stage and shows it before firing mouse event > - For ComboBoxTest - adding ComboBox to a Stage, not showing the Stage

Re: CFV: New OpenJFX Committer: Pankaj Bansal

2020-10-23 Thread Jeanette Winzenburg
Vote: YES Zitat von Kevin Rushforth : I hereby nominate Pankaj Bansal [1] to OpenJFX Committer. Pankaj is a member of Java client team at Oracle, who has contributed 11 commits [2] to OpenJFX. Votes are due by November 6, 2020. Only current OpenJFX Committers [3] are eligible to vote on

Re: CFV: New OpenJFX Committer: Pankaj Bansal

2020-10-23 Thread Guru
Vote: YES > On 23-Oct-2020, at 8:08 PM, Kevin Rushforth > wrote: > > I hereby nominate Pankaj Bansal [1] to OpenJFX Committer. > > Pankaj is a member of Java client team at Oracle, who has contributed 11 > commits [2] to OpenJFX. > > Votes are due by November 6, 2020. > > Only current OpenJ

Re: CFV: New OpenJFX Committer: Pankaj Bansal

2020-10-23 Thread Arun Joseph
Vote: YES > On 23-Oct-2020, at 8:08 PM, Kevin Rushforth > wrote: > > I hereby nominate Pankaj Bansal [1] to OpenJFX Committer. > > Pankaj is a member of Java client team at Oracle, who has contributed 11 > commits [2] to OpenJFX. > > Votes are due by November 6, 2020. > > Only current OpenJ