Re: RFR: 8262276: Debug build of WebKit fails

2021-03-08 Thread PrimosK
On Tue, 9 Mar 2021 06:30:46 GMT, PrimosK wrote: >>> > The build failed again. The only difference I can spot at this time is >>> > the line at which the build failed (it changed from 3445 to 3453): >>> > ... >>> > Please let me know if you need any further information. >>> >>> You might be

Re: RFR: 8262276: Debug build of WebKit fails

2021-03-08 Thread PrimosK
On Mon, 8 Mar 2021 16:20:21 GMT, PrimosK wrote: >> when passing `--info` to gradle, the build succeeds. Without passing >> `--info` it fails. I'll do more testing later. > >> > The build failed again. The only difference I can spot at this time is the >> > line at which the build failed (it

Re: RFR: 8206253: No/Wrong scroll events from touch input in window mode

2021-03-08 Thread Jose Pereda
On Mon, 8 Mar 2021 23:47:32 GMT, Kevin Rushforth wrote: >> This PR changes the parameter names to accommodate class calculations >> related to screen event coordinates (AbsX, AbsY). >> >> As >>

Re: RFR: 8206253: No/Wrong scroll events from touch input in window mode

2021-03-08 Thread Kevin Rushforth
On Mon, 8 Mar 2021 23:43:10 GMT, Jose Pereda wrote: > This PR changes the parameter names to accommodate class calculations related > to screen event coordinates (AbsX, AbsY). > > As >

RFR: 8206253: No/Wrong scroll events from touch input in window mode

2021-03-08 Thread Jose Pereda
This PR changes the parameter names to accommodate class calculations related to screen event coordinates (AbsX, AbsY). As [discussed](https://bugs.openjdk.java.net/browse/JDK-8206253?focusedCommentId=14405707=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14405707),

Re: RFR: 8263204: Add Gradle Wrapper Validation Action

2021-03-08 Thread John Neffenger
On Mon, 8 Mar 2021 22:37:10 GMT, John Neffenger wrote: >> If it isn't too hard to make the running of the other three jobs dependent >> on the wrapper validation job, that would be good, as long as the validation >> job is fast. The other three still need to run in parallel with each other.

Re: RFR: 8263204: Add Gradle Wrapper Validation Action

2021-03-08 Thread Kevin Rushforth
On Mon, 8 Mar 2021 22:55:18 GMT, John Neffenger wrote: >> Okay, this is looking better! The validation took only 23 seconds, and >> GitHub shows the following results: >> >>

Re: RFR: 8263204: Add Gradle Wrapper Validation Action [v4]

2021-03-08 Thread John Neffenger
> See the [Gradle Wrapper Validation > Action](https://github.com/marketplace/actions/gradle-wrapper-validation) for > details on this pull request. I'll test the changes with the following > sequence of commits: > > 1. This commit adds a tampered Gradle Wrapper JAR file, which should go >

Re: RFR: 8263204: Add Gradle Wrapper Validation Action

2021-03-08 Thread John Neffenger
On Mon, 8 Mar 2021 22:13:09 GMT, Kevin Rushforth wrote: >> Thanks, Kevin. I'll merge the two workflow files. >> >> The test results aren't what I expected: >> >>

Re: RFR: 8263204: Add Gradle Wrapper Validation Action [v3]

2021-03-08 Thread John Neffenger
> See the [Gradle Wrapper Validation > Action](https://github.com/marketplace/actions/gradle-wrapper-validation) for > details on this pull request. I'll test the changes with the following > sequence of commits: > > 1. This commit adds a tampered Gradle Wrapper JAR file, which should go >

Re: RFR: 8263204: Add Gradle Wrapper Validation Action

2021-03-08 Thread Kevin Rushforth
On Mon, 8 Mar 2021 22:00:14 GMT, John Neffenger wrote: >> It might be better to include the validation task in the same >> [`submit.yml`](https://github.com/openjdk/jfx/blob/master/.github/workflows/submit.yml) >> file as the pre-submit tests, as a separate job. That way it will get the >>

Re: RFR: 8263204: Add Gradle Wrapper Validation Action

2021-03-08 Thread John Neffenger
On Mon, 8 Mar 2021 21:44:03 GMT, Kevin Rushforth wrote: >> So far, so good. The tampered file was not detected: >> >> ![all-checks-have-passed](https://user-images.githubusercontent.com/1413266/110383521-411ab200-8011-11eb-88ee-27102e0b6d81.png) >> >> The next commit will add the Official

Re: RFR: 8263204: Add Gradle Wrapper Validation Action

2021-03-08 Thread Kevin Rushforth
On Mon, 8 Mar 2021 21:23:47 GMT, John Neffenger wrote: >>> 1. This commit adds a tampered Gradle Wrapper JAR file, which should go >>> undetected. >>> 2. The next commit will add the Official Gradle Wrapper Validation Action, >>> which should detect the tampered file. >>> 3. The final commit

Re: RFR: 8263204: Add Gradle Wrapper Validation Action

2021-03-08 Thread John Neffenger
On Mon, 8 Mar 2021 20:38:09 GMT, Kevin Rushforth wrote: >> See the [Gradle Wrapper Validation >> Action](https://github.com/marketplace/actions/gradle-wrapper-validation) >> for details on this pull request. I'll test the changes with the following >> sequence of commits: >> >> 1. This

Re: RFR: 8263204: Add Gradle Wrapper Validation Action [v2]

2021-03-08 Thread John Neffenger
> See the [Gradle Wrapper Validation > Action](https://github.com/marketplace/actions/gradle-wrapper-validation) for > details on this pull request. I'll test the changes with the following > sequence of commits: > > 1. This commit adds a tampered Gradle Wrapper JAR file, which should go >

Re: RFR: 8263204: Add Gradle Wrapper Validation Action

2021-03-08 Thread Kevin Rushforth
On Mon, 8 Mar 2021 20:34:05 GMT, John Neffenger wrote: > 1. This commit adds a tampered Gradle Wrapper JAR file, which should go > undetected. > 2. The next commit will add the Official Gradle Wrapper Validation Action, > which should detect the tampered file. > 3. The final commit will

RFR: 8263204: Add Gradle Wrapper Validation Action

2021-03-08 Thread John Neffenger
See the [Gradle Wrapper Validation Action](https://github.com/marketplace/actions/gradle-wrapper-validation) for details on this pull request. I'll test the changes with the following sequence of commits: 1. This commit adds a tampered Gradle Wrapper JAR file, which should go undetected. 2.

Integrated: 8204568: Relative CSS-Attributes don't work all time

2021-03-08 Thread Ambarish Rapte
On Mon, 8 Feb 2021 11:37:35 GMT, Ambarish Rapte wrote: > Issue is that the size of properties that are relatively(`em`) sized is not > computed correctly when the reference `-fx-font-size` is also specified > relatively and is nested. > > Fix is a slight variation of an earlier suggestion in

Re: RFR: 8262276: Debug build of WebKit fails

2021-03-08 Thread PrimosK
On Mon, 8 Mar 2021 15:07:30 GMT, Johan Vos wrote: >>> The build failed again. The only difference I can spot at this time is the >>> line at which the build failed (it changed from 3445 to 3453): >>> ... >>> >>> Please let me know if you need any further information. >> >> You might be

Integrated: 8089913: CSS pseudo classes missing by default for some controls

2021-03-08 Thread mstr2
On Fri, 26 Feb 2021 15:17:23 GMT, mstr2 wrote: > The Slider control does not have the ":horizontal" CSS pseudo-class set by > default. The pseudo-class is only set once the "orientation" property is > changed. This PR fixes that. This pull request has now been integrated. Changeset:

Re: RFR: 8262276: Debug build of WebKit fails

2021-03-08 Thread Johan Vos
On Mon, 8 Mar 2021 14:06:02 GMT, Kevin Rushforth wrote: >> Hi dear OpenJdk team, >> >> At first I would like to thank you for looking into this. I am the author of >> original `8262276` ticket. >> >> I would just like to share some additional information with you. I've >> fetched and checked

Re: Layering JavaFX onto an external rendering context

2021-03-08 Thread Neil C Smith
On Sun, 7 Mar 2021 at 15:36, Mark Raynsford wrote: > The basic primitive > that would be required is "transfer this image to this other image". > You'd need to expose that operation in way that would work for every > possible pair of rendering APIs ... The complexity of handling that would >

Re: RFR: 8204568: Relative CSS-Attributes don't work all time [v5]

2021-03-08 Thread David Grieve
On Mon, 8 Mar 2021 07:49:23 GMT, Ambarish Rapte wrote: >> Issue is that the size of properties that are relatively(`em`) sized is not >> computed correctly when the reference `-fx-font-size` is also specified >> relatively and is nested. >> >> Fix is a slight variation of an earlier

Re: RFR: 8262276: Debug build of WebKit fails

2021-03-08 Thread Kevin Rushforth
On Mon, 8 Mar 2021 08:16:51 GMT, PrimosK wrote: >> Fixing the Debug build of WebKit. >> >> Test: Build JavaFX using `-PCOMPILE_WEBKIT=true -PCONF=DebugNative` and test >> using a simple HelloWebView app. > > Hi dear OpenJdk team, > > At first I would like to thank you for looking into this.

Re: RFR: 8257895: Allow building of JavaFX media libs for Apple Silicon

2021-03-08 Thread Johan Vos
On Fri, 26 Feb 2021 03:58:17 GMT, Alexander Matveev wrote: > - Added support to compile media on arm. > - libffi is based on 3.3. Marked as reviewed by jvos (Reviewer). I didn't test it on real hardware, but it looks good and doesn't cause regression. - PR:

Re: RFR: 8204568: Relative CSS-Attributes don't work all time [v5]

2021-03-08 Thread Kevin Rushforth
On Mon, 8 Mar 2021 07:49:23 GMT, Ambarish Rapte wrote: >> Issue is that the size of properties that are relatively(`em`) sized is not >> computed correctly when the reference `-fx-font-size` is also specified >> relatively and is nested. >> >> Fix is a slight variation of an earlier

Re: RFR: 8089913: CSS pseudo classes missing by default for some controls [v5]

2021-03-08 Thread Ajit Ghaisas
On Fri, 5 Mar 2021 16:07:59 GMT, mstr2 wrote: >> The Slider control does not have the ":horizontal" CSS pseudo-class set by >> default. The pseudo-class is only set once the "orientation" property is >> changed. This PR fixes that. > > mstr2 has updated the pull request incrementally with one

Re: RFR: 8204568: Relative CSS-Attributes don't work all time [v5]

2021-03-08 Thread Ajit Ghaisas
On Mon, 8 Mar 2021 07:49:23 GMT, Ambarish Rapte wrote: >> Issue is that the size of properties that are relatively(`em`) sized is not >> computed correctly when the reference `-fx-font-size` is also specified >> relatively and is nested. >> >> Fix is a slight variation of an earlier

Re: RFR: 8262276: Debug build of WebKit fails

2021-03-08 Thread PrimosK
On Thu, 4 Mar 2021 06:41:53 GMT, Arun Joseph wrote: > Fixing the Debug build of WebKit. > > Test: Build JavaFX using `-PCOMPILE_WEBKIT=true -PCONF=DebugNative` and test > using a simple HelloWebView app. Hi dear OpenJdk team, At first I would like to thank you for looking into this. I am the