Re: RFR: 8239589: JavaFX UI will not repaint after reconnecting via Remote Desktop [v2]

2021-03-18 Thread Kevin Rushforth
On Thu, 18 Mar 2021 22:08:29 GMT, Oliver Schmidtmer wrote: >> I did a pass over the review and left a few inline comments pointing out >> minor changes that I plan to make (in print statements and comments). > > I can confirm the reinitialization after RDP reconnect works for me, > standalone

Re: RFR: 8239589: JavaFX UI will not repaint after reconnecting via Remote Desktop [v2]

2021-03-18 Thread Oliver Schmidtmer
On Thu, 18 Mar 2021 15:30:13 GMT, Kevin Rushforth wrote: >> Kevin Rushforth has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains six additional >> co

Re: RFR: 8239589: JavaFX UI will not repaint after reconnecting via Remote Desktop [v3]

2021-03-18 Thread Kevin Rushforth
> This is a fix for a long-standing bug where the D3D pipeline will stop > rendering when a Windows remote desktop session is disconnected and then > reconnected. > > A preliminary Draft PR #315 by @Schmidor was a good first step in solving > this. I took that and continued the work in my Draft

Re: RFR: 8239589: JavaFX UI will not repaint after reconnecting via Remote Desktop [v2]

2021-03-18 Thread Kevin Rushforth
On Wed, 17 Mar 2021 20:47:09 GMT, Kevin Rushforth wrote: >> This is a fix for a long-standing bug where the D3D pipeline will stop >> rendering when a Windows remote desktop session is disconnected and then >> reconnected. >> >> A preliminary Draft PR #315 by @Schmidor was a good first step in

Integrated: 8263759: Update boot JDK to 15.0.2

2021-03-18 Thread Kevin Rushforth
On Thu, 18 Mar 2021 12:17:58 GMT, Kevin Rushforth wrote: > Simple fix to updated the boot JDK version to 15.0.2. Tested locally, and > with the GitHub Actions build, both of which passed. This pull request has now been integrated. Changeset: e23a2feb Author:Kevin Rushforth URL: http

RFR: 8263807: Button types of a DialogPane are set twice, returns a wrong button

2021-03-18 Thread Marius Hanl
When DialogPane#getButtonTypes().setAll() is called twice with the same argument(s), DialogPane#lookupButton does not return the node which is shown inside the button bar. This is due DialogPane adding two list change listeners to 'buttons' (#getButtonTypes). They have the wrong order, which wil

Building OpenJFX locally

2021-03-18 Thread Jacky Guo
Hi there, I've cloned OpenJFX locally, but I can't build it, because I need to define the environment variable WINSDK_DIR. What do I need to set this to and what do I need to put in that folder Thanks! - Jacky Guo P.S. I only have Windows on a laptop, so I don't know how I can test for Linux and/

Re: RFR: 8263759: Update boot JDK to 15.0.2

2021-03-18 Thread Johan Vos
On Thu, 18 Mar 2021 12:17:58 GMT, Kevin Rushforth wrote: > Simple fix to updated the boot JDK version to 15.0.2. Tested locally, and > with the GitHub Actions build, both of which passed. Marked as reviewed by jvos (Reviewer). - PR: https://git.openjdk.java.net/jfx/pull/431

Re: RFR: 8208088: Memory Leak in ControlAcceleratorSupport [v2]

2021-03-18 Thread Ambarish Rapte
> The method `ControlAcceleratorSupport.doAcceleratorInstall(final List extends MenuItem> items, final Scene scene)` adds a `ChangeListener` on > `MenuItem.acceleratorProperty()`. This listener is not removed when the > MenuItem is removed from scenegraph. > Adding and removing a MenuItem results

Re: RFR: 8208088: Memory Leak in ControlAcceleratorSupport

2021-03-18 Thread Ambarish Rapte
On Wed, 17 Mar 2021 18:28:44 GMT, Kevin Rushforth wrote: > Is there a unit test that can validate this fix? I have added a unit test using a new shim class. Test verifies size of the map that is added as part of this fix. So the test won't compile without this PR. - PR: https://gi

RFR: 8263759: Update boot JDK to 15.0.2

2021-03-18 Thread Kevin Rushforth
Simple fix to updated the boot JDK version to 15.0.2. Tested locally, and with the GitHub Actions build, both of which passed. - Commit messages: - 8263759: Update boot JDK to 15.0.2 Changes: https://git.openjdk.java.net/jfx/pull/431/files Webrev: https://webrevs.openjdk.java.net/

Dialog contentText does not wrap correctly always

2021-03-18 Thread Daniel Peintner
Hello, Thank you all for your work. I believe JavaFX is getting better and better. Some recent updates like [1] fixed some issues I was having with certain scaling levels. Today I stumbled over one issue that still exists with JavaFX version 16. It relates to dialog where the contentText usually

Re: [External] : Re: OpenJFX custom build - Java application crash (semi-related to 8262276)

2021-03-18 Thread Primož Kokol
Thanks for pointing us in the right direction. I wasn't aware that jfxwebkit.pdb will be generated also in the case of a production build. So after generating a production build we were able to produce a thread dump (using jfxwebkit.pdb symbols) at the time when the application freezes. The compl

Re: RFR: 8092439: [Monocle] Refactor monocle SPI to allow support for multiple screens

2021-03-18 Thread Johan Vos
On Wed, 17 Mar 2021 23:05:27 GMT, Kevin Rushforth wrote: >> Fix for JDK-8092439 and JDK-8092064 >> Monocle currently hard-codes a single Screen, and the >> `staticScreen_getScreens()` method will never return more than 1 Screen. >> >> This PR introduces the possibility to deal with multiple scr

Integrated: 8092439: [Monocle] Refactor monocle SPI to allow support for multiple screens

2021-03-18 Thread Johan Vos
On Tue, 16 Mar 2021 14:24:19 GMT, Johan Vos wrote: > Fix for JDK-8092439 and JDK-8092064 > Monocle currently hard-codes a single Screen, and the > `staticScreen_getScreens()` method will never return more than 1 Screen. > > This PR introduces the possibility to deal with multiple screens, which