Approved
On Thu, Apr 22, 2021 at 12:21 AM Kevin Rushforth
wrote:
> Hi Johan,
>
> I request approval to backport the following fixes to 11-dev in support
> of the transition to GIT:
>
> 8231735: gradle checkrepo is obsolete and doesn't work with git
> 8223719: Add .gitignore to repo
> 8223722: Cl
On Tue, 23 Mar 2021 20:19:08 GMT, Alexander Scherbatiy
wrote:
> This is a proposal for cross compiling JavaFX base modules (excluding media
> and webkit) for Windows AArch64 (ARM64).
>
> Main changes:
> - prismES2 native compilation is moved under IS_INCLUDE_ES2 condition
> - HOST_ARCH and TAR
> As mentioned in JBS the unit test execution fails when tests have a duplicate
> package name.
> This was introduced by JDK-8204568: it created a test in a new package
> `test.javafx.css` in controls tests. A similar package already existed in
> graphics unit tests.
> This is a simple fix to re
On Wed, 21 Apr 2021 11:37:30 GMT, Jeanette Winzenburg
wrote:
>> Ambarish Rapte has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> change package
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/PropertySizeTest.java
> l
On Thu, 22 Apr 2021 09:24:48 GMT, Ambarish Rapte wrote:
>> As mentioned in JBS the unit test execution fails when tests have a
>> duplicate package name.
>> This was introduced by JDK-8204568: it created a test in a new package
>> `test.javafx.css` in controls tests. A similar package already e
This PR fixes controls unit test failures that are observed with German locale.
Fix :
Code added to use US locale while running SpinnerTest and DatePicker test &
restore locale to default after these tests are executed.
test.javafx.scene.control.ControlTest.testRT18097 fails for DatePicker contr
On Wed, 21 Apr 2021 17:53:34 GMT, Johan Vos wrote:
>> hmm .. don't quite understand your comment: it's a flag to tell cancelEdit
>> to not update control's editing state (that whole block is simply extracted
>> from the pre-fix state .. where it has been for ages ;) So the answer is
>> most pr
> Fixing ListCell editing status is true, when index changes while editing.
Florian Kirmaier has updated the pull request incrementally with one additional
commit since the last revision:
8264127:
Fixed another index case based on code review
-
Changes:
- all: https://git.ope
On Wed, 21 Apr 2021 14:25:53 GMT, Florian Kirmaier
wrote:
>> Fixing ListCell editing status is true, when index changes while editing.
>
> Florian Kirmaier has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8264127:
> Small update to the te
On Sat, 17 Apr 2021 16:21:20 GMT, Tor (torbuntu)
wrote:
> For building on aarch64 linux systems we need it added to the buuld.gradle to
> stop ignoring it.
I can't seem to sign the OCA because the page is stuck in some weird loop with
a connection error. Is there any other way to do this?
I'
On Sat, 17 Apr 2021 16:21:20 GMT, Tor (torbuntu)
wrote:
> For building on aarch64 linux systems we need it added to the buuld.gradle to
> stop ignoring it.
Hi,
Alternatively, you can fill out the form at
https://www.oracle.com/technetwork/oca-405177.pdf out, and send an e-mail with
the scan
On Tue, 20 Apr 2021 10:35:43 GMT, Tor (torbuntu)
wrote:
>> For building on aarch64 linux systems we need it added to the buuld.gradle
>> to stop ignoring it.
>
> I've sent the email with an attached signed PDF for the OCA. I also
> apparently did not have my github account on my Oracle account
For building on aarch64 linux systems we need it added to the buuld.gradle to
stop ignoring it.
-
Commit messages:
- Add aarch64 support to linux
Changes: https://git.openjdk.java.net/jfx/pull/465/files
Webrev: https://webrevs.openjdk.java.net/?repo=jfx&pr=465&range=00
Issue: ht
On Sat, 17 Apr 2021 16:21:20 GMT, Tor (torbuntu)
wrote:
> For building on aarch64 linux systems we need it added to the buuld.gradle to
> stop ignoring it.
Approving this so it can be integrated as soon as OCA label is gone.
This is a required change for Linux AArch64, so if the OCA can be so
On Thu, 22 Apr 2021 11:00:43 GMT, Florian Kirmaier
wrote:
>> Fixing ListCell editing status is true, when index changes while editing.
>
> Florian Kirmaier has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8264127:
> Fixed another index ca
On Thu, 22 Apr 2021 09:24:48 GMT, Ambarish Rapte wrote:
>> As mentioned in JBS the unit test execution fails when tests have a
>> duplicate package name.
>> This was introduced by JDK-8204568: it created a test in a new package
>> `test.javafx.css` in controls tests. A similar package already e
This PR removes the single ignored test from CustomMenuItemTest.
The test unsetContentButNotNull() was incorrectly asserting on not null
content. I have remove this test.
The assert for null content has been added to another test
getUnspecifiedContentProperty1().
-
Commit messages:
Hi,
Many times when I want to create a simple solid Background or Border, it is
quite a hassle because of the configurability these classes have:
new Border(new BorderStroke(Color. BLACK, BorderStrokeStyle.SOLID, null,
null));
new Background(new BackgroundFill(Color.BLACK, null, null));
I was th
I would like this, I am not a big fan of CSS everywhere and this would make
small examples easier to read/write.
Am Do., 22. Apr. 2021 um 15:47 Uhr schrieb Nir Lisker :
> Hi,
>
> Many times when I want to create a simple solid Background or Border, it is
> quite a hassle because of the configura
On Thu, 22 Apr 2021 13:05:57 GMT, Ajit Ghaisas wrote:
> This PR removes the single ignored test from CustomMenuItemTest.
>
> The test unsetContentButNotNull() was incorrectly asserting on not null
> content. I have remove this test.
> The assert for null content has been added to another test
On Thu, 22 Apr 2021 13:05:57 GMT, Ajit Ghaisas wrote:
> This PR removes the single ignored test from CustomMenuItemTest.
>
> The test unsetContentButNotNull() was incorrectly asserting on not null
> content. I have remove this test.
> The assert for null content has been added to another test
On Thu, 22 Apr 2021 10:36:40 GMT, Ajit Ghaisas wrote:
> This PR fixes controls unit test failures that are observed with German
> locale.
>
> Fix :
> Code added to use US locale while running SpinnerTest and DatePicker test &
> restore locale to default after these tests are executed.
>
> tes
On Thu, 22 Apr 2021 10:36:40 GMT, Ajit Ghaisas wrote:
> This PR fixes controls unit test failures that are observed with German
> locale.
>
> Fix :
> Code added to use US locale while running SpinnerTest and DatePicker test &
> restore locale to default after these tests are executed.
>
> tes
> `Tooltip` is no longer hiding upon receiving
> `MouseEvent.MOUSE_ENTERED_TARGET` event inside it. Pressing mouse on
> overlaying tooltip also kills the tooltip, so the infinite duration tooltip
> can be closed.
Paweł Kruszczyński has updated the pull request incrementally with one
additional
On Thu, 22 Apr 2021 18:41:43 GMT, Paweł Kruszczyński
wrote:
>> `Tooltip` is no longer hiding upon receiving
>> `MouseEvent.MOUSE_ENTERED_TARGET` event inside it. Pressing mouse on
>> overlaying tooltip also kills the tooltip, so the infinite duration tooltip
>> can be closed.
>
> Paweł Kruszc
On Wed, 21 Apr 2021 09:01:45 GMT, Ambarish Rapte wrote:
> The tests that are modified in this PR set a stylesheet using API
> `StyleManager.getInstance().setDefaultUserAgentStylesheet()`.
> This is a global state and should be reset after execution of each test.
> It does not cause any test fail
On Sat, 17 Apr 2021 16:21:20 GMT, Tor (torbuntu)
wrote:
> For building on aarch64 linux systems we need it added to the buuld.gradle to
> stop ignoring it.
This pull request has now been integrated.
Changeset: fab638ae
Author:Tor (torbuntu)
Committer: Kevin Rushforth
URL: https://
On Sat, 17 Apr 2021 16:21:20 GMT, Tor (torbuntu)
wrote:
> For building on aarch64 linux systems we need it added to the buuld.gradle to
> stop ignoring it.
Marked as reviewed by kcr (Lead).
-
PR: https://git.openjdk.java.net/jfx/pull/465
On Mon, 19 Apr 2021 19:57:50 GMT, Johan Vos wrote:
> Changes that allow to build linux configuration on Linux AArch64
> This PR introduces an `IS_AARCH64` parameter in build.gradle.
> This PR already contains the change from PR #465 so if this one gets
> integrated, that change needs to removed
The CSS specification includes some suggestions for the heuristics
used to determine whether or not focus should be indicated:
https://drafts.csswg.org/selectors-4/#focus-visible-pseudo
Here's how I think these suggestions apply to JavaFX:
> If the user has expressed a preference (such as via a
On Sat, 17 Apr 2021 13:48:23 GMT, Jeanette Winzenburg
wrote:
>> Changes in Lambda..Handler:
>> - added api and implemenation to support invalidation and listChange
>> listeners in the same way as changeListeners
>> - added java doc
>> - added tests
>>
>> Changes in SkinBase
>> - added api (an
On Mon, 19 Apr 2021 19:57:50 GMT, Johan Vos wrote:
> Changes that allow to build linux configuration on Linux AArch64
> This PR introduces an `IS_AARCH64` parameter in build.gradle.
> This PR already contains the change from PR #465 so if this one gets
> integrated, that change needs to removed
On Sun, 11 Apr 2021 15:48:45 GMT, Florian Kirmaier
wrote:
>> tests/system/src/test/java/test/javafx/scene/control/ProgressIndicatorLeakTest.java
>> line 79:
>>
>>> 77: indicator.setProgress(1.0);
>>> 78: checker.assertCollectable(detIndicator);
>>> 79:
On Mon, 1 Feb 2021 23:12:08 GMT, Jonathan Vusich
wrote:
>> As noted in the corresponding JBS issue, `Axis` does not properly compute
>> its preferred height when `autoRanging` is turned off. The simplest fix
>> seems to be changing `CategoryAxis` so that `tickLabelRotation` is set to 90
>> de
On Thu, 15 Apr 2021 02:21:50 GMT, Nir Lisker wrote:
>> Added a SpotLight only to the D3D pipeline currently.
>>
>> ### API discussion points
>>
>> - [X] Added `SpotLight` as a subclass of `LightBase`. However, it could
>> also be a subclass of `PointLight` as it's a point light with direction
On Wed, 21 Apr 2021 09:01:45 GMT, Ambarish Rapte wrote:
> The tests that are modified in this PR set a stylesheet using API
> `StyleManager.getInstance().setDefaultUserAgentStylesheet()`.
> This is a global state and should be reset after execution of each test.
> It does not cause any test fail
On Wed, 21 Apr 2021 10:49:25 GMT, Ambarish Rapte wrote:
> As mentioned in JBS the unit test execution fails when tests have a duplicate
> package name.
> This was introduced by JDK-8204568: it created a test in a new package
> `test.javafx.css` in controls tests. A similar package already exist
Fixes a bug in `ControlUtils.buildClearAndSelectChange` that reports a wrong
start index for the second range of a disjoint removed list.
-
Commit messages:
- ListChangeListener getRemoved() returns items that were not removed.
- Add failing test
Changes: https://git.openjdk.java.
> The documentation for `ObservableListBase.nextRemove` states that a single
> change always refers to the current state of the list, which likely means
> that multiple disjoint removed ranges need to be applied in order, otherwise
> the next change's `getFrom` doesn't refer to the correct index
On Mon, 19 Apr 2021 19:57:50 GMT, Johan Vos wrote:
> Changes that allow to build linux configuration on Linux AArch64
> This PR introduces an `IS_AARCH64` parameter in build.gradle.
> This PR already contains the change from PR #465 so if this one gets
> integrated, that change needs to removed
On Thu, 22 Apr 2021 16:45:15 GMT, Kevin Rushforth wrote:
> This looks good. Saving and restoring global state in this manner represents
> a best practice. Two questions:
>
> 1. In the description you said that
> `test.javafx.scene.control.ControlTest.testRT18097` fails without your fix
>
41 matches
Mail list logo
