Integrated: 8267418: IntelliJ build and test of JavaFX does not work

2021-06-29 Thread Marius Hanl
On Wed, 19 May 2021 16:12:45 GMT, Marius Hanl wrote: > ~~Question: I was wondering, should I create a ticket for this as well? Given > the fact that I don't have an https://bugs.openjdk.java.net account, I need > to use the official bug reporting tool, which looked a bit overkill to me >

Re: RFR: 8223717: javafx printing: Support Specifying Print to File in the API [v4]

2021-06-29 Thread Phil Race
On Mon, 28 Jun 2021 19:47:39 GMT, Phil Race wrote: >> This enhancement adds the String property outputFileProperty() to the >> JobSettings class. >> The value should be a string that references a local file encoded as a URL. >> If this is non-null and set to a location that the user has

Re: RFR: 8223717: javafx printing: Support Specifying Print to File in the API [v5]

2021-06-29 Thread Phil Race
> This enhancement adds the String property outputFileProperty() to the > JobSettings class. > The value should be a string that references a local file encoded as a URL. > If this is non-null and set to a location that the user has permission to > write to, > then the printer output will be

Re: RFR: 8268683: JavaFX MediaPlayer onEndOfMedia behaviour different from Javadoc [v2]

2021-06-29 Thread Alexander Matveev
On Tue, 29 Jun 2021 22:55:50 GMT, Kevin Rushforth wrote: >> Alexander Matveev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8268683: JavaFX MediaPlayer onEndOfMedia behaviour different from Javadoc >> [v2] > >

Re: RFR: 8268683: JavaFX MediaPlayer onEndOfMedia behaviour different from Javadoc [v2]

2021-06-29 Thread Alexander Matveev
> Fixed javadoc to indicate that onEndOfMedia is invoked each time when end of > cycle is reached regardless if it is repeating or not. Alexander Matveev has updated the pull request incrementally with one additional commit since the last revision: 8268683: JavaFX MediaPlayer onEndOfMedia

Re: RFR: 8269429: Linux: Only the last APPLICATION_MODAL window behaves correctly [v2]

2021-06-29 Thread Thiago Milczarek Sayao
On Tue, 29 Jun 2021 21:58:36 GMT, Thiago Milczarek Sayao wrote: >> The PR approach is to set `gtk_window_set_keep_above` to true on >> APPLICATION_MODAL windows, so they will not stay behind non >> APPLICATION_MODAL windows. >> >> This is passed on WindowStage.java:198 as a mask. >> >> The

Re: RFR: 8269429: Linux: Only the last APPLICATION_MODAL window behaves correctly [v2]

2021-06-29 Thread Thiago Milczarek Sayao
On Tue, 29 Jun 2021 21:58:36 GMT, Thiago Milczarek Sayao wrote: >> The PR approach is to set `gtk_window_set_keep_above` to true on >> APPLICATION_MODAL windows, so they will not stay behind non >> APPLICATION_MODAL windows. >> >> This is passed on WindowStage.java:198 as a mask. >> >> The

Re: RFR: 8268683: JavaFX MediaPlayer onEndOfMedia behaviour different from Javadoc

2021-06-29 Thread Kevin Rushforth
On Tue, 29 Jun 2021 03:07:11 GMT, Alexander Matveev wrote: > Fixed javadoc to indicate that onEndOfMedia is invoked each time when end of > cycle is reached regardless if it is repeating or not. Looks good with one suggested change.

Re: RFR: 8223717: javafx printing: Support Specifying Print to File in the API [v2]

2021-06-29 Thread Kevin Rushforth
On Mon, 28 Jun 2021 18:12:33 GMT, Phil Race wrote: >> It's still a good idea to follow the pattern, so yes let's make the new >> methods final. We can file a cleanup bug for the existing ones (and since >> the class is final, we can do it without compatibility concerns). >> >> Also, I built

Re: RFR: 8223717: javafx printing: Support Specifying Print to File in the API [v4]

2021-06-29 Thread Kevin Rushforth
On Mon, 28 Jun 2021 19:47:39 GMT, Phil Race wrote: >> This enhancement adds the String property outputFileProperty() to the >> JobSettings class. >> The value should be a string that references a local file encoded as a URL. >> If this is non-null and set to a location that the user has

Re: RFR: 8268683: JavaFX MediaPlayer onEndOfMedia behaviour different from Javadoc

2021-06-29 Thread Kevin Rushforth
On Tue, 29 Jun 2021 03:07:11 GMT, Alexander Matveev wrote: > Fixed javadoc to indicate that onEndOfMedia is invoked each time when end of > cycle is reached regardless if it is repeating or not. This looks like a good fix, but should have a CSR, since it changes the specification.

Re: RFR: 8269429: Linux: Only the last APPLICATION_MODAL window behaves correctly [v2]

2021-06-29 Thread Thiago Milczarek Sayao
On Tue, 29 Jun 2021 21:05:06 GMT, Kevin Rushforth wrote: > I tried the test program attached to the JBS bug, and I'm not seeing the > problem. Are there any special steps I need to take to see the bug? I also > left a question about `WINDOW_MODAL` vs `APPLICATION_MODAL` windows. > > Regarding

Re: RFR: 8269429: Linux: Only the last APPLICATION_MODAL window behaves correctly [v2]

2021-06-29 Thread Thiago Milczarek Sayao
> The PR approach is to set `gtk_window_set_keep_above` to true on > APPLICATION_MODAL windows, so they will not stay behind non APPLICATION_MODAL > windows. > > This is passed on WindowStage.java:198 as a mask. > > The weird thing is that `_enterModal()` is never called. This seems the right

Re: RFR: 8269429: Linux: Only the last APPLICATION_MODAL window behaves corretly

2021-06-29 Thread Kevin Rushforth
On Mon, 28 Jun 2021 16:56:44 GMT, Thiago Milczarek Sayao wrote: > The PR approach is to set `gtk_window_set_keep_above` to true on > APPLICATION_MODAL windows, so they will not stay behind non APPLICATION_MODAL > windows. > > This is passed on WindowStage.java:198 as a mask. > > The weird

Integrated: 8266224: GitHub actions: use gcc 10.3 on Linux

2021-06-29 Thread Johan Vos
On Tue, 29 Jun 2021 14:52:28 GMT, Johan Vos wrote: > install latest version of gcc/g++ (older specific versions are not available > anymore) This pull request has now been integrated. Changeset: b0d15862 Author:Johan Vos URL:

Re: RFR: 8269593: Different fontname on macos [v2]

2021-06-29 Thread Kevin Rushforth
On Tue, 29 Jun 2021 14:20:30 GMT, Johan Vos wrote: >> Make sure the returned fullName of a created font matches the requested >> name. Since the name is used as a key/identifier in some cases, some >> internal code relies on this. >> Added a test to check the case of "System Font Regular" on

Re: RFR: 8266224: GitHub actions: use gcc 10.3 on Linux

2021-06-29 Thread Kevin Rushforth
On Tue, 29 Jun 2021 14:52:28 GMT, Johan Vos wrote: > install latest version of gcc/g++ (older specific versions are not available > anymore) Marked as reviewed by kcr (Lead). - PR: https://git.openjdk.java.net/jfx/pull/555

Re: RFR: 8269601: Increase gcc-10 version for github workflow

2021-06-29 Thread Kevin Rushforth
On Tue, 29 Jun 2021 14:52:28 GMT, Johan Vos wrote: > install latest version of gcc/g++ (older specific versions are not available > anymore) Looks good, thanks for taking care of this. I note that [JDK-8266224](https://bugs.openjdk.java.net/browse/JDK-8266224) was already filed for this. I

RFR: 8269601: Increase gcc-10 version for github workflow

2021-06-29 Thread Johan Vos
install latest version of gcc/g++ (older specific versions are not available anymore) - Commit messages: - fix #8269601 Changes: https://git.openjdk.java.net/jfx/pull/555/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx=555=00 Issue:

Re: RFR: 8269593: Different fontname on macos [v2]

2021-06-29 Thread Johan Vos
> Make sure the returned fullName of a created font matches the requested name. > Since the name is used as a key/identifier in some cases, some internal code > relies on this. > Added a test to check the case of "System Font Regular" on MacOS, which fails > before and succeeds after the patch.

RFR: 8269593: Different fontname on macos

2021-06-29 Thread Johan Vos
Make sure the returned fullName of a created font matches the requested name. Since the name is used as a key/identifier in some cases, some internal code relies on this. Added a test to check the case of "System Font Regular" on MacOS, which fails before and succeeds after the patch.

Re: RFR: 8240506: TextFieldSkin/Behavior: misbehavior on switching skin

2021-06-29 Thread Jeanette Winzenburg
On Mon, 28 Jun 2021 15:42:47 GMT, Jeanette Winzenburg wrote: >> modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/behavior/TextFieldBehavior.java >> line 75: >> >>> 73: } >>> 74: >>> 75: focusListener = (observable, oldValue, newValue) -> { >> >> Shouldn't

Re: RFR: 8269429: Linux: Only the last APPLICATION_MODAL window behaves corretly

2021-06-29 Thread Thiago Milczarek Sayao
On Mon, 28 Jun 2021 16:56:44 GMT, Thiago Milczarek Sayao wrote: > The PR approach is to set `gtk_window_set_keep_above` to true on > APPLICATION_MODAL windows, so they will not stay behind non APPLICATION_MODAL > windows. > > This is passed on WindowStage.java:198 as a mask. > > The weird

RFR: 8269429: Linux: Only the last APPLICATION_MODAL window behaves corretly

2021-06-29 Thread Thiago Milczarek Sayao
The PR approach is to set `gtk_window_set_keep_above` to true on APPLICATION_MODAL windows, so they will not stay behind non APPLICATION_MODAL windows. This is passed on WindowStage.java:198 as a mask. The weird thing is that `_enterModal()` is never called. This seems the right function to

Re: RFR: 8269429: Linux: Only the last APPLICATION_MODAL window behaves corretly

2021-06-29 Thread Thiago Milczarek Sayao
On Mon, 28 Jun 2021 16:56:44 GMT, Thiago Milczarek Sayao wrote: > The PR approach is to set `gtk_window_set_keep_above` to true on > APPLICATION_MODAL windows, so they will not stay behind non APPLICATION_MODAL > windows. > > This is passed on WindowStage.java:198 as a mask. > > The weird

Re: RFR: 8269259: Remove obsolete apps, tests, and scripts

2021-06-29 Thread Kevin Rushforth
On Tue, 29 Jun 2021 03:58:10 GMT, Nir Lisker wrote: > Under tests/system/src there are several projects called "testappN". Are they > named cryptically on purpose? Not really, no. They are all added to `build.gradle` as separate source sets

Integrated: 8269259: Remove obsolete apps, tests, and scripts

2021-06-29 Thread Kevin Rushforth
On Fri, 25 Jun 2021 14:59:00 GMT, Kevin Rushforth wrote: > This PR deletes the following applications, tests, and scripts that are > either obsolete > or unmaintained: > > apps/performance/* > > apps/tests/HelloTest > > apps/toys/FXSlideShow > apps/toys/Industrial > apps/toys/Shape3DToy >

Integrated: 8269424: Some SuppressWarnings annotations can be more localized

2021-06-29 Thread Kevin Rushforth
On Sat, 26 Jun 2021 13:01:15 GMT, Kevin Rushforth wrote: > This is a follow-on fix to > [JDK-8264139](https://bugs.openjdk.java.net/browse/JDK-8264139), which added > `@SuppressWarning` annotations to usages of deprecated security manager > methods. @wangweij noticed that there was one

Re: RFR: 8269259: Remove obsolete apps, tests, and scripts

2021-06-29 Thread Ambarish Rapte
On Fri, 25 Jun 2021 14:59:00 GMT, Kevin Rushforth wrote: > This PR deletes the following applications, tests, and scripts that are > either obsolete > or unmaintained: > > apps/performance/* > > apps/tests/HelloTest > > apps/toys/FXSlideShow > apps/toys/Industrial > apps/toys/Shape3DToy >