RFR: 8253351: MediaPlayer does not display an mp4 if there no speakers connected to the PC's

2021-07-23 Thread Alexander Matveev
Fixed by not failing initialization if DSERR_NODRIVER is returned, which will be return if device is not present at all. Fixed format initialization even if DirectSound device was not created in case if audio device will arrive after playback started. Since we already handle correctly device

Re: [jfx17] RFR: 8240640: [macos] Wrong focus behaviour with multiple Alerts [v3]

2021-07-23 Thread Kevin Rushforth
On Fri, 23 Jul 2021 17:40:32 GMT, Pankaj Bansal wrote: >> The bug is a regression as a result of fix done for JDK-8227366 and is >> reproducible on Linux and Mac. This fix is being reverted in this change and >> a new bug (JDK-8271054) has been created to redo the JDK-8227366 >> >> An

Re: [jfx17] RFR: 8240640: [macos] Wrong focus behaviour with multiple Alerts [v2]

2021-07-23 Thread Pankaj Bansal
On Fri, 23 Jul 2021 16:35:58 GMT, Kevin Rushforth wrote: >> Pankaj Bansal has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fixed review comments 1) Increase delay 2) Fix Formatting 3) Make test >> stable on Windows according to

Re: [jfx17] RFR: 8240640: [macos] Wrong focus behaviour with multiple Alerts [v3]

2021-07-23 Thread Pankaj Bansal
> The bug is a regression as a result of fix done for JDK-8227366 and is > reproducible on Linux and Mac. This fix is being reverted in this change and > a new bug (JDK-8271054) has been created to redo the JDK-8227366 > > An automated testcase is being added to make sure similar regression is

Re: [jfx17] RFR: 8240640: [macos] Wrong focus behaviour with multiple Alerts [v2]

2021-07-23 Thread Pankaj Bansal
On Fri, 23 Jul 2021 00:16:33 GMT, Kevin Rushforth wrote: > The fix (reverting the earlier fix for JDK-8227366) looks fine to me. The > test runs fine on Mac (and mostly fine on Linux, but I need to test a couple > more things). > > I also see the failure on Windows frequently depending on

Re: [jfx17] RFR: 8240640: [macos] Wrong focus behaviour with multiple Alerts [v2]

2021-07-23 Thread Kevin Rushforth
On Fri, 23 Jul 2021 15:24:35 GMT, Pankaj Bansal wrote: >> The bug is a regression as a result of fix done for JDK-8227366 and is >> reproducible on Linux and Mac. This fix is being reverted in this change and >> a new bug (JDK-8271054) has been created to redo the JDK-8227366 >> >> An

Re: [jfx17] RFR: 8240640: [macos] Wrong focus behaviour with multiple Alerts [v2]

2021-07-23 Thread Pankaj Bansal
> The bug is a regression as a result of fix done for JDK-8227366 and is > reproducible on Linux and Mac. This fix is being reverted in this change and > a new bug (JDK-8271054) has been created to redo the JDK-8227366 > > An automated testcase is being added to make sure similar regression is

Re: [jfx17] RFR: 8240640: [macos] Wrong focus behaviour with multiple Alerts

2021-07-23 Thread Kevin Rushforth
On Mon, 19 Jul 2021 19:52:05 GMT, Pankaj Bansal wrote: > The bug is a regression as a result of fix done for JDK-8227366 and is > reproducible on Linux and Mac. This fix is being reverted in this change and > a new bug (JDK-8271054) has been created to redo the JDK-8227366 > > An automated

[jfx17] Integrated: 8270959: Update boot JDK to 16.0.2

2021-07-23 Thread Kevin Rushforth
On Tue, 20 Jul 2021 18:58:08 GMT, Kevin Rushforth wrote: > Update boot JDK used to build JavaFX to JDK 16.0.2, which supersedes 16.0.1. > > NOTE: this is targeted to `jfx17`. This pull request has now been integrated. Changeset: d5401095 Author:Kevin Rushforth URL:

Re: RFR: 8240506: TextFieldSkin/Behavior: misbehavior on switching skin [v2]

2021-07-23 Thread Marius Hanl
On Wed, 7 Jul 2021 09:48:20 GMT, Jeanette Winzenburg wrote: >> The issue is about memory leaks and side-effects (like NPEs) when switching >> skins. >> >> Details (copied from issue for convenience): >> >> memory leak in TextInputControlBehavior: >> - listener accidentally added twice

Re: [jfx17] RFR: 8270959: Update boot JDK to 16.0.2

2021-07-23 Thread Joeri Sykora
On Tue, 20 Jul 2021 18:58:08 GMT, Kevin Rushforth wrote: > Update boot JDK used to build JavaFX to JDK 16.0.2, which supersedes 16.0.1. > > NOTE: this is targeted to `jfx17`. Build succeeded on all platforms. - Marked as reviewed by sykora (Author). PR: