Re: RFR: 8264449: Enable reproducible builds with SOURCE_DATE_EPOCH [v5]

2021-09-17 Thread Kevin Rushforth
On Mon, 14 Jun 2021 20:53:50 GMT, John Neffenger wrote: >> This pull request allows for reproducible builds of JavaFX on Linux, macOS, >> and Windows by defining the `SOURCE_DATE_EPOCH` environment variable. For >> example, the following commands create a reproducible build: >> >> >> $

Re: Gtk4 and Wayland

2021-09-17 Thread Kevin Rushforth
I don't want to give up on the functionality of being able to move a window or control the stacking order for those platforms that can support it. So when running on an X11 server, which a gtk4 pipeline ought to be able to do, I think we need to continue to allow applications to move windows

Integrated: 8271398: GTK3 drag view image swaps red and blue color channels

2021-09-17 Thread Thiago Milczarek Sayao
On Fri, 6 Aug 2021 02:18:38 GMT, Thiago Milczarek Sayao wrote: > It seems raw images need to be converted BRGA -> RGBA. > > It was being converted on gtk2 code path, but gtk3 only uses > `gtk_drag_set_icon_pixbuf`. > > I have simplified the gtk2 `DragView::View::expose` to paint with >

Re: RFR: 8271398: GTK3 drag view image swaps red and blue color channels [v5]

2021-09-17 Thread Pankaj Bansal
On Fri, 17 Sep 2021 13:00:20 GMT, Thiago Milczarek Sayao wrote: >> It seems raw images need to be converted BRGA -> RGBA. >> >> It was being converted on gtk2 code path, but gtk3 only uses >> `gtk_drag_set_icon_pixbuf`. >> >> I have simplified the gtk2 `DragView::View::expose` to paint with

Re: RFR: 8271398: GTK3 drag view image swaps red and blue color channels [v3]

2021-09-17 Thread Kevin Rushforth
On Tue, 17 Aug 2021 13:12:41 GMT, Pankaj Bansal wrote: >> Thiago Milczarek Sayao has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Change test to manual > > The fix works fine and the test passes on all platforms. I have given minor >

Re: RFR: 8271398: GTK3 drag view image swaps red and blue color channels [v5]

2021-09-17 Thread Kevin Rushforth
On Fri, 17 Sep 2021 13:00:20 GMT, Thiago Milczarek Sayao wrote: >> It seems raw images need to be converted BRGA -> RGBA. >> >> It was being converted on gtk2 code path, but gtk3 only uses >> `gtk_drag_set_icon_pixbuf`. >> >> I have simplified the gtk2 `DragView::View::expose` to paint with

Re: RFR: 8271398: GTK3 drag view image swaps red and blue color channels [v5]

2021-09-17 Thread Thiago Milczarek Sayao
> It seems raw images need to be converted BRGA -> RGBA. > > It was being converted on gtk2 code path, but gtk3 only uses > `gtk_drag_set_icon_pixbuf`. > > I have simplified the gtk2 `DragView::View::expose` to paint with > `gdk_cairo_set_source_pixbuf` (that is available since Gtk 2.8)

Re: RFR: 8271398: GTK3 drag view image swaps red and blue color channels [v4]

2021-09-17 Thread Thiago Milczarek Sayao
On Thu, 16 Sep 2021 21:57:08 GMT, Kevin Rushforth wrote: >> Thiago Milczarek Sayao has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Review requests. > > modules/javafx.graphics/src/main/native-glass/gtk/glass_dnd.cpp line 916: > >> 914:

Re: RFR: 8273485: Deadlock when also using Swing and exiting Fullscreen on Mac [v4]

2021-09-17 Thread Kevin Rushforth
On Thu, 16 Sep 2021 13:22:32 GMT, Florian Kirmaier wrote: >> When using Swing it's possible to generate a Deadlock. >> It's related to the nested eventloop started in enterFullScreenExitingLoop >> - and the RenderLock aquired when using setView in Scene. >> Sample Programm and Threaddump are

Re: RFR: 8273485: Deadlock when also using Swing and exiting Fullscreen on Mac [v4]

2021-09-17 Thread Kevin Rushforth
On Thu, 16 Sep 2021 13:22:32 GMT, Florian Kirmaier wrote: >> When using Swing it's possible to generate a Deadlock. >> It's related to the nested eventloop started in enterFullScreenExitingLoop >> - and the RenderLock aquired when using setView in Scene. >> Sample Programm and Threaddump are

Re: RFR: 8090547: Allow for transparent backgrounds in WebView [v10]

2021-09-17 Thread Kevin Rushforth
On Thu, 16 Sep 2021 22:25:27 GMT, Jose Pereda wrote: >> Currently, `WebPage` has already a public `setBackgroundColor()` method, but >> the class is not public. Therefore, public API is needed in `WebView` to >> allow developers access to it. >> >> In line with the `fontSmoothingType`

Re: RFR: 8271054: [REDO] Wrong stage gets focused after modal stage creation

2021-09-17 Thread Kevin Rushforth
On Thu, 5 Aug 2021 23:38:06 GMT, Thiago Milczarek Sayao wrote: > Found the problem thru this path: > > **WindowStage.java** > > final void handleFocusDisabled() { > if (activeWindows.isEmpty()) { > return; > } > WindowStage window =

Running nested JUnit tests

2021-09-17 Thread John Hendrikx
I would like to provide some junit tests in a PR. These are written in a nested style for easy readability. For example: private StringProperty property = new SimpleStringProperty("A"); @Nested class When_map_Called { @Nested class WithNull { @Test

RFE: Style class for prompt text in text input controls

2021-09-17 Thread Dirk Lemmermann
I noticed that the „Text“ node used to display the prompt text of a text input control could definitely use its own style class. At least if you want to use a different font for it than for the normal text. Currently the prompt text node is bound to the same font property of the control as the