Re: RFR: 8272638: Update copyright header for files modified in 2021

2021-10-20 Thread Kevin Rushforth
On Wed, 20 Oct 2021 18:51:21 GMT, Ambarish Rapte wrote: > Change to update copyright year of files modified in 2021. Looks good. - Marked as reviewed by kcr (Lead). PR: https://git.openjdk.java.net/jfx/pull/648

Re: RFR: Draft: 8274274: Update JavaFX test framework to JUnit 5 [v5]

2021-10-20 Thread Kevin Rushforth
On Sat, 25 Sep 2021 13:55:15 GMT, John Hendrikx wrote: >> I've added JUnit 5 as a test dependency and made sure that the JUnit 4 tests >> still work. Also added a single JUnit 5 tests, and confirmed it works. >> >> I've updated the Eclipse project file for the base module only. > > John Hendri

Easier handling of ObservableList/Set/Map change events

2021-10-20 Thread Michael Strauß
I'd like to gauge interest on a small feature addition for JavaFX collections. ObservableList (and similarly, ObservableSet/ObservableMap) allows developers to register ListChangeListeners to observe changes to the list. In some cases, these changes are applied to another list or projected into a

RFR: 8272638: Update copyright header for files modified in 2021

2021-10-20 Thread Ambarish Rapte
Change to update copyright year of files modified in 2021. - Commit messages: - copyright-update Changes: https://git.openjdk.java.net/jfx/pull/648/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx&pr=648&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8272638 S

Integrated: 8274413: FX: Update copyright year in docs, readme files to 2022

2021-10-20 Thread Ambarish Rapte
On Wed, 20 Oct 2021 11:53:30 GMT, Ambarish Rapte wrote: > Copyright year in these 3 docs needs to be updated to 2022. This pull request has now been integrated. Changeset: 7be0abb9 Author:Ambarish Rapte URL: https://git.openjdk.java.net/jfx/commit/7be0abb9aa5e86e953b13d4ad1d88000e65

RFR: 8274854: Mnemonics for menu containing numeric text not working

2021-10-20 Thread Michael Strauß
This PR fixes an issue with mnemonic parsing by removing the restriction that a mnemonic symbol must be a letter. Now, it can be any character except whitespace. - Commit messages: - fixed mnemonic parsing - failing test Changes: https://git.openjdk.java.net/jfx/pull/647/files W

Integrated: 8236689: macOS 10.15 Catalina: LCD text renders badly

2021-10-20 Thread Phil Race
On Wed, 13 Oct 2021 23:59:40 GMT, Phil Race wrote: > On an external (non-retina) monitor JavaFX LCD text on macOS is painful on > the eyes. > Retina diminishes it rather than cures it. > > The problem is a mix of a couple of things > 1) CoreText no longer generates LCD glyphs (except perhaps if

Re: RFR: 8271091: Missing API docs in UI controls classes

2021-10-20 Thread Michael Strauß
On Wed, 20 Oct 2021 15:23:07 GMT, Nir Lisker wrote: >> This PR fixes javadoc warnings in javafx.controls and javafx.web modules. >> Note : >> - The javadoc needs to be generated with the JDK 18 EA build. >> - There are still 20 javadoc warnings remaining in javafx.controls module >> and 3 warni

Re: RFR: 8271091: Missing API docs in UI controls classes

2021-10-20 Thread Nir Lisker
On Wed, 20 Oct 2021 14:42:44 GMT, Ajit Ghaisas wrote: > This PR fixes javadoc warnings in javafx.controls and javafx.web modules. > Note : > - The javadoc needs to be generated with the JDK 18 EA build. > - There are still 20 javadoc warnings remaining in javafx.controls module and > 3 warnings

RFR: 8271091: Missing API docs in UI controls classes

2021-10-20 Thread Ajit Ghaisas
This PR fixes javadoc warnings in javafx.controls and javafx.web modules. Note : - The javadoc needs to be generated with the JDK 18 EA build. - There are still 20 javadoc warnings remaining in javafx.controls module and 3 warnings remaining in javafx.web module. The root cause is different and t

Integrated: 8275138: WebView: UserAgent string is empty for first request

2021-10-20 Thread Kevin Rushforth
On Thu, 14 Oct 2021 12:32:24 GMT, Kevin Rushforth wrote: > The failure was caused by a change that was done in connection with the > WebKit 610.2 update, > [JDK-8259635](https://bugs.openjdk.java.net/browse/JDK-8259635). The > `FrameLoaderClient::userAgent` function was changed in WebKit itsel

Re: [External] : Re: Eager Evaluation of Invalidation Listeners

2021-10-20 Thread Michael Strauß
1) The specification of Observable states that: "An implementation of {@code Observable} may support lazy evaluation [...]" It seems to me that this is an optional feature, and a user of this API must be aware that any particular Observable implementation may not support it, or that it chooses to

Re: RFR: 8274413: FX: Update copyright year in docs, readme files to 2022

2021-10-20 Thread Kevin Rushforth
On Wed, 20 Oct 2021 11:53:30 GMT, Ambarish Rapte wrote: > Copyright year in these 3 docs needs to be updated to 2022. Marked as reviewed by kcr (Lead). - PR: https://git.openjdk.java.net/jfx/pull/645

RFR: 8274413: FX: Update copyright year in docs, readme files to 2022

2021-10-20 Thread Ambarish Rapte
Copyright year in these 3 docs needs to be updated to 2022. - Commit messages: - copyright year to 2022 Changes: https://git.openjdk.java.net/jfx/pull/645/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx&pr=645&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8274

Re: RFR: 8275138: WebView: UserAgent string is empty for first request

2021-10-20 Thread Ambarish Rapte
On Thu, 14 Oct 2021 12:32:24 GMT, Kevin Rushforth wrote: > The failure was caused by a change that was done in connection with the > WebKit 610.2 update, > [JDK-8259635](https://bugs.openjdk.java.net/browse/JDK-8259635). The > `FrameLoaderClient::userAgent` function was changed in WebKit itsel