Re: RFR: 8277853: With Touch enabled devices scrollbar disappears and the table is scrolled to the beginning [v3]

2022-01-25 Thread meghanEmbrace
On Tue, 25 Jan 2022 14:34:09 GMT, meghanEmbrace wrote: >> With a touch-enabled device, the scrollbar disappears a short while after >> it's used. During the layout, updateHbar() checks the hbar visibility and >> resets the clip, causing the user to be scrolled fully to the left when >> trying

Re: RFR: 8277853: With Touch enabled devices scrollbar disappears and the table is scrolled to the beginning [v4]

2022-01-25 Thread meghanEmbrace
> With a touch-enabled device, the scrollbar disappears a short while after > it's used. During the layout, updateHbar() checks the hbar visibility and > resets the clip, causing the user to be scrolled fully to the left when > trying to access columns on the right. Using hbar.isVisible() is

Integrated: 8279013 : ES2Pipeline fails to detect AMD vega20 graphics card

2022-01-25 Thread Paul
On Mon, 20 Dec 2021 17:48:19 GMT, Paul wrote: > I have an AMD Radeon VII (vega20) series GPU which is identifying with a > vendor string of "AMD". > > This is not present in the `X11GLFactory` list of `preQualificationFilter` > vendor names, so my system (and probably any other vega20 based

Re: RFR: 8271054: [REDO] Wrong stage gets focused after modal stage creation [v9]

2022-01-25 Thread Thiago Milczarek Sayao
> Found the problem thru this path: > > **WindowStage.java** > > final void handleFocusDisabled() { > if (activeWindows.isEmpty()) { > return; > } > WindowStage window = activeWindows.get(activeWindows.size() - 1); > window.setIconified(false); >

Re: RFR: 8279013 : ES2Pipeline fails to detect AMD vega20 graphics card

2022-01-25 Thread Kevin Rushforth
On Mon, 20 Dec 2021 17:48:19 GMT, Paul wrote: > I have an AMD Radeon VII (vega20) series GPU which is identifying with a > vendor string of "AMD". > > This is not present in the `X11GLFactory` list of `preQualificationFilter` > vendor names, so my system (and probably any other vega20 based

Re: RFR: 8279013 : ES2Pipeline fails to detect AMD vega20 graphics card

2022-01-25 Thread Kevin Rushforth
On Mon, 20 Dec 2021 17:48:19 GMT, Paul wrote: > I have an AMD Radeon VII (vega20) series GPU which is identifying with a > vendor string of "AMD". > > This is not present in the `X11GLFactory` list of `preQualificationFilter` > vendor names, so my system (and probably any other vega20 based

Re: RFR: 8279013 : ES2Pipeline fails to detect AMD vega20 graphics card

2022-01-25 Thread Paul
On Tue, 21 Dec 2021 08:09:08 GMT, Paul wrote: > ... I signed the OCA **last year** ... Added some emphasis. Hope I get a year off for Christmas next year! ;-) - PR: https://git.openjdk.java.net/jfx/pull/698

Re: RFR: 8279013 : ES2Pipeline fails to detect AMD vega20 graphics card

2022-01-25 Thread Johan Vos
On Mon, 20 Dec 2021 17:48:19 GMT, Paul wrote: > I have an AMD Radeon VII (vega20) series GPU which is identifying with a > vendor string of "AMD". > > This is not present in the `X11GLFactory` list of `preQualificationFilter` > vendor names, so my system (and probably any other vega20 based

Re: RFR: 8279013 : ES2Pipeline fails to detect AMD vega20 graphics card

2022-01-25 Thread Paul
On Mon, 20 Dec 2021 17:48:19 GMT, Paul wrote: > I have an AMD Radeon VII (vega20) series GPU which is identifying with a > vendor string of "AMD". > > This is not present in the `X11GLFactory` list of `preQualificationFilter` > vendor names, so my system (and probably any other vega20 based

Re: RFR: 8279013 : ES2Pipeline fails to detect AMD vega20 graphics card

2022-01-25 Thread Kevin Rushforth
On Tue, 21 Dec 2021 08:09:08 GMT, Paul wrote: > I thought it was one OCA for all things Oracle? It is. There is a manual step to verify the connection between a user's GitHub account and their OCA, but it ordinarily happens quickly. Given that we are close to the holidays, there may be a

RFR: 8279013 : ES2Pipeline fails to detect AMD vega20 graphics card

2022-01-25 Thread Paul
I have an AMD Radeon VII (vega20) series GPU which is identifying with a vendor string of "AMD". This is not present in the `X11GLFactory` list of `preQualificationFilter` vendor names, so my system (and probably any other vega20 based cards under Linux) will always fall back to software

Re: RFR: 8271054: [REDO] Wrong stage gets focused after modal stage creation [v8]

2022-01-25 Thread Thiago Milczarek Sayao
> Found the problem thru this path: > > **WindowStage.java** > > final void handleFocusDisabled() { > if (activeWindows.isEmpty()) { > return; > } > WindowStage window = activeWindows.get(activeWindows.size() - 1); > window.setIconified(false); >

[jfx17u] Integrated: 8280490: Change JavaFX release version in jfx17u to 17.0.3

2022-01-25 Thread Kevin Rushforth
On Tue, 25 Jan 2022 01:19:11 GMT, Kevin Rushforth wrote: > Bump release version in `jfx17u` repo to 17.0.3 for the start of a new > release. This pull request has now been integrated. Changeset: d4973293 Author:Kevin Rushforth URL:

[jfx11u] Integrated: 8280489: Change JavaFX release version in jfx11u to 11.0.15

2022-01-25 Thread Kevin Rushforth
On Tue, 25 Jan 2022 01:20:04 GMT, Kevin Rushforth wrote: > Bump release version in `jfx11u` repo to 11.0.15 for the start of a new > release. This pull request has now been integrated. Changeset: cb0314b6 Author:Kevin Rushforth URL:

Re: RFR: 8277853: With Touch enabled devices scrollbar disappears and the table is scrolled to the beginning [v3]

2022-01-25 Thread Marius Hanl
On Tue, 25 Jan 2022 14:34:09 GMT, meghanEmbrace wrote: >> With a touch-enabled device, the scrollbar disappears a short while after >> it's used. During the layout, updateHbar() checks the hbar visibility and >> resets the clip, causing the user to be scrolled fully to the left when >> trying

Re: RFR: 8277853: With Touch enabled devices scrollbar disappears and the table is scrolled to the beginning [v3]

2022-01-25 Thread Kevin Rushforth
On Tue, 25 Jan 2022 14:34:09 GMT, meghanEmbrace wrote: >> With a touch-enabled device, the scrollbar disappears a short while after >> it's used. During the layout, updateHbar() checks the hbar visibility and >> resets the clip, causing the user to be scrolled fully to the left when >> trying

Re: RFR: 8277853: With Touch enabled devices scrollbar disappears and the table is scrolled to the beginning [v3]

2022-01-25 Thread Kevin Rushforth
On Tue, 25 Jan 2022 15:19:44 GMT, Marius Hanl wrote: >> meghanEmbrace has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Replaced the null test with an assert. > >

Re: RFR: 8277853: With Touch enabled devices scrollbar disappears and the table is scrolled to the beginning [v2]

2022-01-25 Thread meghanEmbrace
On Tue, 25 Jan 2022 07:54:21 GMT, meghanEmbrace wrote: >> With a touch-enabled device, the scrollbar disappears a short while after >> it's used. During the layout, updateHbar() checks the hbar visibility and >> resets the clip, causing the user to be scrolled fully to the left when >> trying

Re: RFR: 8277853: With Touch enabled devices scrollbar disappears and the table is scrolled to the beginning [v3]

2022-01-25 Thread meghanEmbrace
> With a touch-enabled device, the scrollbar disappears a short while after > it's used. During the layout, updateHbar() checks the hbar visibility and > resets the clip, causing the user to be scrolled fully to the left when > trying to access columns on the right. Using hbar.isVisible() is

Re: RFR: 8277122: SplitPane divider drag can hang the layout [v2]

2022-01-25 Thread Jeanette Winzenburg
On Mon, 22 Nov 2021 14:03:56 GMT, Marius Hanl wrote: >> When a divider is moved via drag or code it will call **requestLayout()** >> for the **SplitPane**. >> While this is fine, it is also called when the >> **SplitPaneSkin#layoutChildren(..)** method is repositioning the divider. >> >> This

Re: [jfx11u] RFR: 8280489: Change JavaFX release version in jfx11u to 11.0.15

2022-01-25 Thread Johan Vos
On Tue, 25 Jan 2022 01:20:04 GMT, Kevin Rushforth wrote: > Bump release version in `jfx11u` repo to 11.0.15 for the start of a new > release. Marked as reviewed by jvos (Reviewer). - PR: https://git.openjdk.java.net/jfx11u/pull/69

Re: [jfx17u] RFR: 8280490: Change JavaFX release version in jfx17u to 17.0.3

2022-01-25 Thread Johan Vos
On Tue, 25 Jan 2022 01:19:11 GMT, Kevin Rushforth wrote: > Bump release version in `jfx17u` repo to 17.0.3 for the start of a new > release. Marked as reviewed by jvos (Reviewer). - PR: https://git.openjdk.java.net/jfx17u/pull/29

Re: RFR: 8277853: With Touch enabled devices scrollbar disappears and the table is scrolled to the beginning [v2]

2022-01-25 Thread Kevin Rushforth
On Tue, 25 Jan 2022 07:54:21 GMT, meghanEmbrace wrote: >> With a touch-enabled device, the scrollbar disappears a short while after >> it's used. During the layout, updateHbar() checks the hbar visibility and >> resets the clip, causing the user to be scrolled fully to the left when >> trying

Re: RFR: 8251481: TableCell accessing row: NPE on auto-sizing

2022-01-25 Thread Jeanette Winzenburg
On Fri, 14 Jan 2022 00:04:49 GMT, Marius Hanl wrote: > This PR will fix a simple NPE which may happens when using the `TableRow` > inside a `TableCell` during the initial auto sizing. > In the auto sizing code, no `TableRow` is set, therefore `getTableRow()` will > return null and it is not

Re: [jfx18] RFR: 8279345: Realign class docs of LightBase and subclasses

2022-01-25 Thread Ambarish Rapte
On Sun, 16 Jan 2022 22:54:22 GMT, Nir Lisker wrote: > Now that the standard concrete light types were added, there is an > opportunity to rearrange and rewrite some of the class docs. Here is a > summary of the changes: > > * Moved the explanations of attenuation and direction up to

Re: [jfx18] RFR: 8279345: Realign class docs of LightBase and subclasses

2022-01-25 Thread Ambarish Rapte
On Tue, 25 Jan 2022 00:40:18 GMT, Kevin Rushforth wrote: >> Now that the standard concrete light types were added, there is an >> opportunity to rearrange and rewrite some of the class docs. Here is a >> summary of the changes: >> >> * Moved the explanations of attenuation and direction up to

Re: RFR: 8277853: With Touch enabled devices scrollbar disappears and the table is scrolled to the beginning [v2]

2022-01-25 Thread meghanEmbrace
On Tue, 25 Jan 2022 07:54:21 GMT, meghanEmbrace wrote: >> With a touch-enabled device, the scrollbar disappears a short while after >> it's used. During the layout, updateHbar() checks the hbar visibility and >> resets the clip, causing the user to be scrolled fully to the left when >> trying