Re: RFR: 8281953: NullPointer in InputMethod components in JFXPanel

2022-02-20 Thread eduardsdv
On Sat, 19 Feb 2022 17:40:54 GMT, delvh wrote: >> If the InputMethod's node is not in the scene, the default text location >> point is returned. > > modules/javafx.controls/src/main/java/javafx/scene/control/skin/TextInputControlSkin.java > line 340: > >> 338: if (window == nul

Re: RFR: 8280020: Underline and line-through not straight in WebView [v4]

2022-02-20 Thread Jay Bhaskar
> Issue: The end point of line in drawLinesForText , add thickness to the > endPoint.y(). In this case origin which is start point and the end point > would not be same, and line would be drawn not straight. > Solution: Do not add thickness to the y position of end point of line. > Start Point(x

Re: RFR: 8280020: Underline and line-through not straight in WebView [v3]

2022-02-20 Thread Jay Bhaskar
On Sat, 19 Feb 2022 15:03:38 GMT, Kevin Rushforth wrote: >> Jay Bhaskar has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update test case for line straightness check > > tests/system/src/test/java/test/javafx/scene/web/StraightLineTest.ja

Re: RFR: 8280020: Underline and line-through not straight in WebView [v3]

2022-02-20 Thread Jay Bhaskar
On Mon, 21 Feb 2022 04:19:29 GMT, Jay Bhaskar wrote: >> tests/system/src/test/java/test/javafx/scene/web/StraightLineTest.java line >> 163: >> >>> 161: >>> 162: // buttom start x position of underline ( startx + font >>> size + thickness -1) >>> 163: int line_start_x =

Re: RFR: 8280020: Underline and line-through not straight in WebView [v3]

2022-02-20 Thread Jay Bhaskar
On Sat, 19 Feb 2022 14:55:30 GMT, Kevin Rushforth wrote: >> Jay Bhaskar has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update test case for line straightness check > > tests/system/src/test/java/test/javafx/scene/web/StraightLineTest.ja

Re: RFR: 8280020: Underline and line-through not straight in WebView [v3]

2022-02-20 Thread Jay Bhaskar
On Sat, 19 Feb 2022 14:45:53 GMT, Kevin Rushforth wrote: >> Jay Bhaskar has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update test case for line straightness check > > tests/system/src/test/java/test/javafx/scene/web/StraightLineTest.ja

Re: RFR: 8280020: Underline and line-through not straight in WebView [v3]

2022-02-20 Thread Jay Bhaskar
On Sat, 19 Feb 2022 16:51:52 GMT, Kevin Rushforth wrote: >> Jay Bhaskar has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update test case for line straightness check > > tests/system/src/test/java/test/javafx/scene/web/StraightLineTest.ja

Re: RFR: 8280020: Underline and line-through not straight in WebView [v3]

2022-02-20 Thread Jay Bhaskar
On Sat, 19 Feb 2022 14:32:46 GMT, Kevin Rushforth wrote: >> Jay Bhaskar has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update test case for line straightness check > > tests/system/src/test/java/test/javafx/scene/web/StraightLineTest.ja