On Thu, 17 Jun 2021 14:52:53 GMT, Kevin Rushforth wrote:
> The JavaFX WebKit build fails with Xcode 12.5 + MacOS 11.3 SDK. This is
> related to the added C++20 support where some of the system include files now
> do `#include `. Because the macOS file system is case insensitive,
> it matches a
On Thu, 27 May 2021 17:25:27 GMT, Arun Joseph wrote:
> The title property is not guaranteed to be updated right after the page is
> loaded, but gets updated asynchronously.
This pull request has now been integrated.
Changeset: ca250364
Author: Arun Joseph
URL:
On Thu, 3 Jun 2021 23:53:48 GMT, Kevin Rushforth wrote:
>> modules/javafx.web/src/main/java/javafx/scene/web/WebEngine.java line 441:
>>
>>> 439:
>>> 440: /*
>>> 441: * The page title. This gets updated asynchronously.
>>
>> Is there any more information or guarantee when the update i
The title property is not guaranteed to be updated right after the page is
loaded, but gets updated asynchronously.
-
Commit messages:
- Fix javadoc comment
- Merge branch 'master' into 8267858
- 8267858: Document that title property in WebEngine gets updated
asynchronously
Chan
On Wed, 12 May 2021 13:18:25 GMT, Arun Joseph wrote:
> The system test test.com.sun.webkit.LocalStorageAccessTest fails on Windows
> as mentioned in
> [JDK-8265661](https://bugs.openjdk.java.net/browse/JDK-8265661). We should
> skip this test until it is fixed.
This pull request
The system test test.com.sun.webkit.LocalStorageAccessTest fails on Windows as
mentioned in [JDK-8265661](https://bugs.openjdk.java.net/browse/JDK-8265661).
We should skip this test until it is fixed.
-
Commit messages:
- 8266968: Ignore test.com.sun.webkit.LocalStorageAccessTest
On Thu, 4 Mar 2021 06:41:53 GMT, Arun Joseph wrote:
> Fixing the Debug build of WebKit.
>
> Test: Build JavaFX using `-PCOMPILE_WEBKIT=true -PCONF=DebugNative` and test
> using a simple HelloWebView app.
This pull request has now been integrated.
Changeset: ed080c82
Author:
On Fri, 23 Apr 2021 09:04:47 GMT, Johan Vos wrote:
>> Changes that allow to build linux configuration on Linux AArch64
>> This PR introduces an `IS_AARCH64` parameter in build.gradle.
>> This PR already contains the change from PR #465 so if this one gets
>> integrated, that change needs to remo
On Mon, 19 Apr 2021 19:57:50 GMT, Johan Vos wrote:
> Changes that allow to build linux configuration on Linux AArch64
> This PR introduces an `IS_AARCH64` parameter in build.gradle.
> This PR already contains the change from PR #465 so if this one gets
> integrated, that change needs to removed
> Fixing the Debug build of WebKit.
>
> Test: Build JavaFX using `-PCOMPILE_WEBKIT=true -PCONF=DebugNative` and test
> using a simple HelloWebView app.
Arun Joseph has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains t
On Mon, 12 Apr 2021 13:10:53 GMT, Arun Joseph wrote:
> Issue: Java application (with WebView) will completely freeze after using it
> for a while.
>
> Fix: Use native isMainThread functions instead of JNI call.
This pull request has now been integrated.
Changeset: 49d2126e
Aut
On Thu, 15 Apr 2021 16:43:08 GMT, Matthias Bläsing
wrote:
>> The functions from FileSystemJava are called from different threads the
>> root problem manifests because the JNI FindClass function behaves
>> differently when called from a context that is the ancestor of a java
>> frame compared to
On Thu, 15 Apr 2021 23:41:02 GMT, Kevin Rushforth wrote:
>> Issue: Java application (with WebView) will completely freeze after using it
>> for a while.
>>
>> Fix: Use native isMainThread functions instead of JNI call.
>
> modules/javafx.web/src/main/native/Source/WTF/wtf/java/MainThreadJava.cp
Issue: Java application (with WebView) will completely freeze after using it
for a while.
Fix: Use native isMainThread functions instead of JNI call.
-
Commit messages:
- Remove platform check in ThreadingWin
- Remove fwkIsMainThread
- 8263788: JavaFX application freezes complete
I’m marking the PR (https://github.com/openjdk/jfx/pull/461) as ready for
review. You can add your evaluation in the PR.
— Arun Joseph
On Fri, 9 Apr 2021 21:10:46 GMT, Matthias Bläsing
wrote:
>> The functions from FileSystemJava are called from different threads the
>> root problem manifests because the JNI FindClass function behaves
>> differently when called from a context that is the ancestor of a java
>> frame compared to w
I think the issue is caused by the JNI call in isMainThread() function in
MainThreadJava.cpp and one solution would be to use the respective native calls
for each platforms. I’ll create a PR with the above fix shortly after
performing a couple of sanity checks.
— Arun Joseph
On 12-Apr-2021
On Mon, 5 Apr 2021 18:14:36 GMT, Arun Joseph wrote:
> We currently use ICU4C version 64.2. We should update to the latest stable
> version 68.2.
> http://site.icu-project.org/home
This pull request has now been integrated.
Changeset: 808b1078
Author:Arun Joseph
URL:
On Sun, 4 Apr 2021 16:36:27 GMT, John Neffenger wrote:
>> This pull request allows for reproducible builds of JavaFX on Linux, macOS,
>> and Windows by defining the `SOURCE_DATE_EPOCH` environment variable. For
>> example, the following commands create a reproducible build:
>>
>> $ export SOUR
> We currently use ICU4C version 64.2. We should update to the latest stable
> version 68.2.
> http://site.icu-project.org/home
Arun Joseph has updated the pull request incrementally with one additional
commit since the last revision:
Add icuVersion
-
Changes:
- a
On Mon, 5 Apr 2021 19:09:19 GMT, Kevin Rushforth wrote:
>> We currently use ICU4C version 64.2. We should update to the latest stable
>> version 68.2.
>> http://site.icu-project.org/home
>
> Overall this looks good. I'll review / test it in detail later.
>
> Quick comments on the PR:
>
> 1. Yo
We currently use ICU4C version 64.2. We should update to the latest stable
version 68.2.
http://site.icu-project.org/home
-
Commit messages:
- Add UPDATING.txt file
- Update license
- Modify exec files
- Add icudt68l repo
- Remove icudt file
- 8260245: Update ICU4C to version 6
On Fri, 2 Apr 2021 15:37:38 GMT, Arun Joseph wrote:
> WebKit crashes during JavaScriptCore initialization code for Apple Silicon.
This pull request has now been integrated.
Changeset: b2f842de
Author: Arun Joseph
URL: https://git.openjdk.java.net/jfx/commit/b2f842de
Stats: 1 l
WebKit crashes during JavaScriptCore initialization code for Apple Silicon.
-
Commit messages:
- 8259555: Webkit crashes on Apple Silicon
Changes: https://git.openjdk.java.net/jfx/pull/452/files
Webrev: https://webrevs.openjdk.java.net/?repo=jfx&pr=452&range=00
Issue: https://bug
>> involve passing flags to cmake in `build.gradle`.
>>
>> @arun-Joseph might be able to comment on that.
>
> I should add that if changes are needed to the `Makefile.msvc` files to
> accept extra link flags to be passed in, then it would be fine to modify them.
> Fixing the Debug build of WebKit.
>
> Test: Build JavaFX using `-PCOMPILE_WEBKIT=true -PCONF=DebugNative` and test
> using a simple HelloWebView app.
Arun Joseph has updated the pull request incrementally with one additional
commit since the last revision:
Fix InternalFu
The thread dump doesn’t have enough details to locate where the problem occurs.
Using a debug build with assertions disabled (as mentioned in the previous
mail) may help in generating a thread dump for getting some more information.
— Arun Joseph
On 18-Mar-2021, at 3:39 PM, Primož Kokol
On Sat, 20 Mar 2021 13:40:51 GMT, Kevin Rushforth wrote:
>> This is a fix for a long-standing bug where the D3D pipeline will stop
>> rendering when a Windows remote desktop session is disconnected and then
>> reconnected.
>>
>> A preliminary Draft PR #315 by @Schmidor was a good first step in
On Fri, 19 Mar 2021 12:08:04 GMT, Kevin Rushforth wrote:
>> This is a fix for a long-standing bug where the D3D pipeline will stop
>> rendering when a Windows remote desktop session is disconnected and then
>> reconnected.
>>
>> A preliminary Draft PR #315 by @Schmidor was a good first step in
ASSERT_ENABLED are used interchangeably in the WebKit code. So, for
creating a build without asserts, you can either use the release build PDBs, or
set NDEBUG to 1 in WTF/wtf/PlatformEnable.h to generate a minimal debug build.
— Arun Joseph
On 15-Mar-2021, at 6:08 PM, Primož Kokol
mailto:primoz.ko
I’m currently looking into why the native debug build is crashing. This same
assert fails while running FileReaderTest using the native debug build. For the
time being, you can try building by removing this particular assert statement
for debugging.
— Arun Joseph
> On 12-Mar-2021, at 11:47
Vote: YES
— Arun Joseph
> On 10-Mar-2021, at 5:27 PM, Kevin Rushforth
> wrote:
>
> I hereby nominate John Neffenger [1] to OpenJFX Committer.
>
> John is an OpenJFX community member, who has contributed 10 commits [2] to
> OpenJFX.
>
> Votes are due by
On Tue, 9 Mar 2021 14:55:59 GMT, PrimosK
wrote:
>>> when passing `--info` to gradle, the build succeeds. Without passing
>>> `--info` it fails. I'll do more testing later.
>>
>> Interesting. I don't see this problem. I am able to build with or without
>> `--info`. I am also now (with this pat
Fixing the Debug build of WebKit.
Test: Build JavaFX using `-PCOMPILE_WEBKIT=true -PCONF=DebugNative` and test
using a simple HelloWebView app.
-
Commit messages:
- 8262276: Debug build of WebKit fails
Changes: https://git.openjdk.java.net/jfx/pull/417/files
Webrev: https://webre
On Mon, 22 Feb 2021 11:55:00 GMT, Arun Joseph wrote:
> Issue: Initial layout delay was removed and layout() is called from
> layoutTimer instead of WebPage::prePaint().
>
> Fix: Re-introduce the initial layout delay.
This pull request has now been integrated.
Changeset: 8ad
On Wed, 17 Feb 2021 14:14:35 GMT, Arun Joseph wrote:
> Timer in RunLoopGeneric has an open bug in WebKit
> (https://bugs.webkit.org/show_bug.cgi?id=189335) causing the timer to remain
> active even after firing.
>
> Reverting back to WebCore Timer for ScrollAnimation in Li
On Wed, 24 Feb 2021 13:33:39 GMT, Kevin Rushforth wrote:
>> Arun Joseph has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add system test
>
> tests/system/src/test/java/test/javafx/scene/web/WebPageTest.jav
> Timer in RunLoopGeneric has an open bug in WebKit
> (https://bugs.webkit.org/show_bug.cgi?id=189335) causing the timer to remain
> active even after firing.
>
> Reverting back to WebCore Timer for ScrollAnimation in Linux.
Arun Joseph has updated the pull request increme
On Wed, 24 Feb 2021 13:01:50 GMT, Kevin Rushforth wrote:
>> Issue: Initial layout delay was removed and layout() is called from
>> layoutTimer instead of WebPage::prePaint().
>>
>> Fix: Re-introduce the initial layout delay.
>
> This seems a safe enough fix to restore the layout delay that was
Issue: Initial layout delay was removed and layout() is called from layoutTimer
instead of WebPage::prePaint().
Fix: Re-introduce the initial layout delay.
-
Commit messages:
- Add comment
- 8260165: CSSFilterTest.testCSSFilterRendering system test fails
Changes: https://git.open
> Timer in RunLoopGeneric has an open bug in WebKit
> (https://bugs.webkit.org/show_bug.cgi?id=189335) causing the timer to remain
> active even after firing.
>
> Reverting back to WebCore Timer for ScrollAnimation in Linux.
Arun Joseph has updated the pull request increme
On Thu, 18 Feb 2021 13:25:14 GMT, Arun Joseph wrote:
> The WebKit build fails with Visual Studio 2017.
>
> Issue: Visual Studio 2017 doesn't support if constexpr in lambda
>
> Test: Build webkit with the VS2017 compiler with and without this fix. It
> should fail wi
The WebKit build fails with Visual Studio 2017.
Issue: Visual Studio 2017 doesn't support if constexpr in lamda
Test: Build webkit with the VS2017 compiler with and without this fix. It
should fail without the fix and build with the fix.
-
Commit messages:
- 8261927: WebKit build
Timer in RunLoopGeneric has an open bug in WebKit
(https://bugs.webkit.org/show_bug.cgi?id=189335) causing the timer to remain
active even after firing.
Reverting back to WebCore Timer for ScrollAnimation in Linux.
-
Commit messages:
- 8260257: [Linux] WebView no longer reacts to
On Wed, 3 Feb 2021 17:52:31 GMT, Arun Joseph wrote:
> Update to GTK WebKit 2.30.3
> https://webkitgtk.org/2020/11/20/webkitgtk2.30.3-released.html
This pull request has now been integrated.
Changeset: 425c3353
Author: Arun Joseph
URL: https://git.openjdk.java.net/jfx/commit/42
Update to GTK WebKit 2.30.3
https://webkitgtk.org/2020/11/20/webkitgtk2.30.3-released.html
-
Commit messages:
- 8254836: Cherry pick GTK WebKit 2.30.3 changes
Changes: https://git.openjdk.java.net/jfx/pull/392/files
Webrev: https://webrevs.openjdk.java.net/?repo=jfx&pr=392&range=00
On Mon, 1 Feb 2021 03:31:10 GMT, Arun Joseph wrote:
> Windows uses `WorkQueueGeneric` instead of `WorkQueueWin` from WebKit 610.2
> onwards. In `WorkQueueWin`, `WorkQueue::dispatchAfter()` had a 20 ms
> `slopAdjustment` as the timer (called from `::SetTimer`) sometimes fire a few
&
On Mon, 1 Feb 2021 16:55:50 GMT, Kevin Rushforth wrote:
>> Arun Joseph has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update comment
>
> modules/javafx.web/src/main/native/Source/WTF/wtf/generic/W
Generic` and needs to be added.
>
> Also removing `WorkQueueWin` as it's removed for WebKit as well.
Arun Joseph has updated the pull request incrementally with one additional
commit since the last revision:
Update comment
-
Changes:
- all: https://git.openjdk.java
Windows uses `WorkQueueGeneric` instead of `WorkQueueWin` from WebKit 610.2
onwards. In `WorkQueueWin`, `WorkQueue::dispatchAfter()` had a 20 ms
`slopAdjustment` as the timer (called from `::SetTimer`) sometimes fire a few
ms early. The same is not present in `WorkQueueGeneric` and needs to be a
On Thu, 21 Jan 2021 04:14:28 GMT, Arun Joseph wrote:
> Update JavaFX WebKit to GTK WebKit 2.30 (610.2)
This pull request has now been integrated.
Changeset: b0a404de
Author: Arun Joseph
URL: https://git.openjdk.java.net/jfx/commit/b0a404de
Stats: 257339 lines in 5451 fi
> Update JavaFX WebKit to GTK WebKit 2.30 (610.2)
Arun Joseph has updated the pull request incrementally with one additional
commit since the last revision:
Fix color in DefaultPlugin
-
Changes:
- all: https://git.openjdk.java.net/jfx/pull/382/files
- new: ht
On Thu, 21 Jan 2021 13:25:39 GMT, Kevin Rushforth wrote:
>> Update JavaFX WebKit to GTK WebKit 2.30 (610.2)
>
> I reviewed all of the changes outside `modules/javafx.web/src/main/native/`.
> Most look related to the change to use the Prism Color object instead of an
> int. I did have a question
Update JavaFX WebKit to GTK WebKit 2.30 (610.2)
-
Commit messages:
- 8259635: Update to 610.2 version of WebKit
Changes: https://git.openjdk.java.net/jfx/pull/382/files
Webrev: https://webrevs.openjdk.java.net/?repo=jfx&pr=382&range=00
Issue: https://bugs.openjdk.java.net/browse/
On Wed, 16 Dec 2020 19:07:17 GMT, Matthias Bläsing
wrote:
>> The code in WTF::scheduleDispatchFunctionsOnMainThread assumes, that
>> the java class com.sun.webkit.MainThread can be found be the JNI
>> function FindClass. This is only true if the class is loadable by the
>> system class loader.
>
On Tue, 15 Dec 2020 16:57:13 GMT, Matthias Bläsing
wrote:
>> The code in WTF::scheduleDispatchFunctionsOnMainThread assumes, that
>> the java class com.sun.webkit.MainThread can be found be the JNI
>> function FindClass. This is only true if the class is loadable by the
>> system class loader.
>
On Tue, 8 Dec 2020 17:29:56 GMT, Arun Joseph wrote:
> The WebKit build fails with recent Xcode 12.
>
> Bug: `getVTablePointer()` should return a const void*
>
> Fix: Use const void* and remove dependency on JavaVM.framework in Xcode
> Upstream fix: https://bugs.webkit.o
The WebKit build fails with recent Xcode 12.
Bug: `getVTablePointer()` should return a const void*
Fix: Use const void* and remove dependency on JavaVM.framework in Xcode
Upstream fix: https://bugs.webkit.org/show_bug.cgi?id=207871
Test: Build webkit with the Xcode 12 compiler with and without t
On Mon, 19 Oct 2020 04:29:13 GMT, Arun Joseph wrote:
> We should use the public_suffix_list.dat file in the JDK instead. Reading the
> public_suffix_list.dat file is modified to be similar to
> [DomainName.java](https://github.com/openjdk/jdk/blob/master/src/java.base/share/cl
not present, `isPublicSuffix()` returns `false`, which is
> similar to how WebKit ignores the public suffix check when it is disabled.
>
> Test: Run PublicSuffixesTest.java
Arun Joseph has updated the pull request incrementally with one additional
commit since the last revision:
not present, `isPublicSuffix()` returns `false`, which is
> similar to how WebKit ignores the public suffix check when it is disabled.
>
> Test: Run PublicSuffixesTest.java
Arun Joseph has updated the pull request incrementally with one additional
commit since the last revision:
A
not present, `isPublicSuffix()` returns `false`, which is
> similar to how WebKit ignores the public suffix check when it is disabled.
>
> Test: Run PublicSuffixesTest.java
Arun Joseph has updated the pull request incrementally with one additional
commit since the last revision:
Cr
not present, `isPublicSuffix()` returns `false`, which is
> similar to how WebKit ignores the public suffix check when it is disabled.
>
> Test: Run PublicSuffixesTest.java
Arun Joseph has updated the pull request incrementally with one additional
commit since the last revision:
C
On Tue, 27 Oct 2020 00:38:31 GMT, Kevin Rushforth wrote:
>> We should use the public_suffix_list.dat file in the JDK instead. Reading
>> the public_suffix_list.dat file is modified to be similar to
>> [DomainName.java](https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/sun/s
On Mon, 20 Apr 2020 05:40:51 GMT, Arun Joseph wrote:
> fillPath() and fillRect() functions in
> [GraphicsContextJava.cpp](https://github.com/openjdk/jfx/blob/master/modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/java/GraphicsContextJava.cpp)
> use Image::drawPatt
On Tue, 3 Nov 2020 12:01:38 GMT, Ambarish Rapte wrote:
>> Arun Joseph has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix incorrect concat param order
>
> modules/javafx.graphics/src/main/java/com/sun/
Vote: YES
> On 23-Oct-2020, at 8:08 PM, Kevin Rushforth
> wrote:
>
> I hereby nominate Pankaj Bansal [1] to OpenJFX Committer.
>
> Pankaj is a member of Java client team at Oracle, who has contributed 11
> commits [2] to OpenJFX.
>
> Votes are due by November 6, 2020.
>
> Only current OpenJ
On Wed, 21 Oct 2020 17:30:36 GMT, Arun Joseph wrote:
> Issue: Tests using `WebPageShim::paint` fails around 1/10 times.
>
> Fix: Execute `WebPageShim::paint` in the render thread using `PrismInvoker`.
> Ran tests over 100 times, no failures.
>
> Used the initial unit
Issue: Tests using `WebPageShim::paint` fails around 1/10 times.
Fix: Execute `WebPageShim::paint` in the render thread using `PrismInvoker`.
Ran tests over 100 times, no failures.
Used the initial unit test in the PR for
[JDK-8202990](https://bugs.openjdk.java.net/browse/JDK-8202990).
---
We should use the public_suffix_list.dat file in the JDK instead. Reading the
public_suffix_list.dat file is modified
to be similar to
[DomainName.java](https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/sun/security/util/DomainName.java).
If the file is not present, `isPublicS
On Mon, 19 Oct 2020 04:29:13 GMT, Arun Joseph wrote:
> We should use the public_suffix_list.dat file in the JDK instead. Reading the
> public_suffix_list.dat file is modified
> to be similar to
> [DomainName.java](https://github.com/openjdk/jdk/blob/master/src/java.base/share
On Mon, 12 Oct 2020 13:42:08 GMT, Kevin Rushforth wrote:
>> Instead of negation, it should have been at the opposite positions. I have
>> fixed this in the latest commit. The arg
>> list order for
>> [`concatenate`](https://github.com/openjdk/jfx/blob/a56ba63bef9b33c4ad5cc9e05ae5bdb0ee480a3f/mod
On Fri, 9 Oct 2020 22:14:15 GMT, Kevin Rushforth wrote:
>> Arun Joseph has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Update copyright year
>> - Minor refactoring
>
> modules/javafx.web/src/m
On Fri, 9 Oct 2020 21:48:40 GMT, Kevin Rushforth wrote:
>> Arun Joseph has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Update copyright year
>> - Minor refactoring
>
> modules/javafx.grap
> doesn't use patternTransform argument as
> ImagePattern doesn't have the same attribute. So, the final image won't be
> transformed.
Arun Joseph has updated the pull request incrementally with one additional
commit since the last revision:
Fix incorrect concat pa
On Mon, 5 Oct 2020 07:08:33 GMT, Arun Joseph wrote:
> Issue: In JDK15,
> [URLConnection](https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/sun/net/www/URLConnection.java)
> class overrode the getHeaderFields() methods to return properties, which
> previously
Issue: In JDK15,
[URLConnection](https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/sun/net/www/URLConnection.java)
class overrode the getHeaderFields() methods to return properties, which
previously returned an empty map from its
super class.
Fix: Extract headers only when it
On Thu, 17 Sep 2020 06:29:36 GMT, Arun Joseph wrote:
>> Bhawesh Choudhary has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Updates as per review comments
>
> The fix works when the shape is displayed init
On Mon, 14 Sep 2020 13:47:28 GMT, Bhawesh Choudhary
wrote:
>> Root cause of issue is Specifying a image mask from GraphicsContextJava.cpp
>> in WebKit was not implemented, so masking
>> doesn't take place at all while rendering SVGRect. to fix this issue add
>> implementation of function clipT
On Thu, 3 Sep 2020 06:07:10 GMT, Bhawesh Choudhary
wrote:
>> ImageJava.cpp ignores CompositeOperator parameter in drawImage function due
>> to which shadow was getting drawn on top of
>> actual image. apply given composite operator to graphics context before
>> drawing image to fix this issue.
On Wed, 2 Sep 2020 11:22:45 GMT, Arun Joseph wrote:
> The WebKit build fails with recent VS 2019 compiler.
>
> Bug: This MediaQueryEvaluator constructor takes a String parameter, but the
> conversion of char* to String is failing.
>
> Fix: Use the default constructor of M
The WebKit build fails with recent VS 2019 compiler.
Bug: This MediaQueryEvaluator constructor takes a String parameter, but the
conversion of char* to String is failing.
Fix: Use the default constructor of MediaQueryEvaluator, which also returns
true for "all".
Test: Build webkit with the rec
On Tue, 1 Sep 2020 06:29:17 GMT, Bhawesh Choudhary
wrote:
>> ImageJava.cpp ignores CompositeOperator parameter in drawImage function due
>> to which shadow was getting drawn on top of
>> actual image. apply given composite operator to graphics context before
>> drawing image to fix this issue.
On Tue, 1 Sep 2020 06:29:17 GMT, Bhawesh Choudhary
wrote:
>> ImageJava.cpp ignores CompositeOperator parameter in drawImage function due
>> to which shadow was getting drawn on top of
>> actual image. apply given composite operator to graphics context before
>> drawing image to fix this issue.
On Thu, 27 Aug 2020 14:59:56 GMT, Arun Joseph wrote:
> Update to GTK WebKit 2.28.4
> https://webkitgtk.org/2020/07/28/webkitgtk2.28.4-released.html
This pull request has now been integrated.
Changeset: 88c0f978
Author: Arun Joseph
URL: https://git.openjdk.java.net/jfx/commit/88
On Tue, 11 Aug 2020 16:18:37 GMT, Bhawesh Choudhary
wrote:
> ImageJava.cpp ignores CompositeOperator parameter in drawImage function due
> to which shadow was getting drawn on top of
> actual image. apply given composite operator to graphics context before
> drawing image to fix this issue. an
Update to GTK WebKit 2.28.4
https://webkitgtk.org/2020/07/28/webkitgtk2.28.4-released.html
-
Commit messages:
- 8252381: Cherry pick GTK WebKit 2.28.4 changes
Changes: https://git.openjdk.java.net/jfx/pull/289/files
Webrev: https://webrevs.openjdk.java.net/jfx/289/webrev.00
Issue
On Wed, 12 Aug 2020 15:59:20 GMT, Kevin Rushforth wrote:
> With your patch installed, I see a race condition that manifests in one of
> two ways:
I couldn't reproduce the race condition or crash with the fix.
> I suspect this might be related to the gc.setCompositeOperation call.
This may not
> doesn't use patternTransform argument as
> ImagePattern doesn't have the same attribute. So, the final image won't be
> transformed.
Arun Joseph has updated the pull request incrementally with two additional
commits since the last revision:
- Update co
> doesn't use patternTransform argument as
> ImagePattern doesn't have the same attribute. So, the final image won't be
> transformed.
Arun Joseph has updated the pull request incrementally with three additional
commits since the last revision:
- Exclude TYPE_IDENTITY
> doesn't use patternTransform argument as
> ImagePattern doesn't have the same attribute. So, the final image won't be
> transformed.
Arun Joseph has updated the pull request incrementally with one additional
commit since the last revision:
Incorect axis of rotational
On Fri, 14 Aug 2020 06:23:18 GMT, Tobias Diez
wrote:
>> Currently, loading a style sheet file using
>> `WebView.getEngine().setUserStyleSheetLocation(url)` fails if the url
>> start's with `jrt`, i.e. if the file is packaged in an application image
>> using jlink. This is fixed with this PR.
>
On Thu, 23 Jul 2020 09:43:36 GMT, Bhawesh Choudhary
wrote:
>> root cause of issue is prism's fillRoundedRect() API doesn't allow rendering
>> of rounded corner rectangle if four
>> corners have different radii. but same can be achieved via Path. to fix the
>> issue, in GraphicsContextJava.cpp
On Mon, 27 Jul 2020 21:16:41 GMT, Nir Lisker wrote:
>> Fixes https://bugs.openjdk.java.net/browse/JDK-8246343 and some additional
>> fixes in the vicinity.
>
> Nir Lisker has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Addressed review com
On Thu, 23 Jul 2020 05:34:50 GMT, Arun Joseph wrote:
> Update to GTK WebKit 2.28.3
> https://webkitgtk.org/2020/07/09/webkitgtk2.28.3-released.html
This pull request has now been integrated.
Changeset: 926b5b6b
Author: Arun Joseph
URL: https://git.openjdk.java.net/jfx/commit/92
On Tue, 21 Jul 2020 21:50:39 GMT, Bhawesh Choudhary
wrote:
>> Root cause of issue is Specifying a image mask from GraphicsContextJava.cpp
>> in WebKit was not implemented, so masking
>> doesn't take place at all while rendering SVGRect. to fix this issue add
>> implementation of function clipT
Update to GTK WebKit 2.28.3
https://webkitgtk.org/2020/07/09/webkitgtk2.28.3-released.html
-
Commit messages:
- Cherry pick GTK WebKit 2.28.3 changes
Changes: https://git.openjdk.java.net/jfx/pull/271/files
Webrev: https://webrevs.openjdk.java.net/jfx/271/webrev.00
Issue: https:/
> doesn't use patternTransform argument as
> ImagePattern doesn't have the same attribute. So, the final image won't be
> transformed.
Arun Joseph has updated the pull request incrementally with one additional
commit since the last revision:
Modify SW pipeline
-
On Fri, 10 Jul 2020 05:26:39 GMT, Arun Joseph wrote:
> Update JavaFX WebKit to GTK WebKit 2.28 (610.1)
This pull request has now been integrated.
Changeset: 5e7e452c
Author: Arun Joseph
URL: https://git.openjdk.java.net/jfx/commit/5e7e452c
Stats: 300855 lines in 5370 fi
Update JavaFX WebKit to GTK WebKit 2.28 (610.1)
-
Commit messages:
- Fix exec files
- 8245284: Update to 610.1 version of WebKit
Changes: https://git.openjdk.java.net/jfx/pull/263/files
Webrev: https://webrevs.openjdk.java.net/jfx/263/webrev.00
Issue: https://bugs.openjdk.java.n
1 - 100 of 161 matches
Mail list logo
