Re: CFV: New OpenJFX Committer: Rajath Kamath

2018-02-13 Thread Semyon Sadetsky
Vote: yes --Semyon On 02/12/2018 02:02 PM, Kevin Rushforth wrote: I hereby nominate Rajath Kamath [1] to OpenJFX Committer. Rajath is a member of JavaFX team at Oracle, who has contributed 11 changesets [2][3] to OpenJFX. Votes are due by February 26, 2018. Only current OpenJFX

Re: [8u-Backport] Review request for 8185634, 8187803 : Java Fx-Swing dialogs appearing behind main stage

2018-01-19 Thread Semyon Sadetsky
Hi Phil, Dipak, The 8021961 fix was about invisible parent window. The current fix is independent from it so the change looks good. --Semyon On 01/17/2018 09:48 PM, Dipak Kumar wrote: Hi Semyon, Could you please review the changes (also have a look at Phil's comment in trailing mail) and

Re: [10] Review request for 8185634, 8185634: Java Fx-Swing dialogs appearing behind main stage

2017-11-08 Thread Semyon Sadetsky
as simple as possible. Thanks, Alexander. On 08/11/2017 02:45, Semyon Sadetsky wrote: Hi Alexander, In CPlatformWindow.java change you used addChildWindow(), but we get rig of addChildWindow() in 8080729 and start to manage windows order on java side. Can you test that this change doesn't

Re: [10] Review request for 8185634, 8185634: Java Fx-Swing dialogs appearing behind main stage

2017-11-07 Thread Semyon Sadetsky
Hi Alexander, In CPlatformWindow.java change you used addChildWindow(), but we get rig of addChildWindow() in 8080729 and start to manage windows order on java side. Can you test that this change doesn't cause any ordering issues with modal and non-modal child and sibling windows on mac?

Re: CFV: New OpenJFX Committer: Ambarish Rapte

2017-11-01 Thread semyon . sadetsky
Vote: YES --Semyon On 10/31/17 1:18 PM, Kevin Rushforth wrote: I hereby nominate Ambarish Rapte [1] to OpenJFX Committer. Ambarish is a member of JavaFX team at Oracle, who has contributed 10 changesets [2][3] to OpenJFX. Votes are due by November 14, 2017. Only current OpenJFX Committers

Re: CFV: New OpenJFX Committer: Prasanta Sadhukhan

2017-09-28 Thread Semyon Sadetsky
Vote: YES On 9/27/2017 6:10 PM, Kevin Rushforth wrote: I hereby nominate Prasanta Sadhukhan [1] to OpenJFX Committer. Prasanta is a member of JavaFX team at Oracle, who has contributed 12 changesets [2] to OpenJFX. Votes are due by October 11, 2017. Only current OpenJFX Committers [3] are

Re: [10] Review request for 8185634, 8185634: Java Fx-Swing dialogs appearing behind main stage

2017-09-25 Thread Semyon Sadetsky
Hi Alexander, On the Windows platform you've only modified the dialog native peer while on other platforms all window types are modified to use FX window as a parent. Shouldn't the frame native peer be modified too on the Windows platform? --Semyon On 09/21/2017 10:56 PM, Alexander

Re: CFV: New OpenJFX Committer: Ajit Ghaisas

2017-05-26 Thread Semyon Sadetsky
Vote: YES --Semyon On 05/26/2017 05:20 AM, Kevin Rushforth wrote: I hereby nominate Ajit Ghaisas [1] to OpenJFX Committer. Ajit is a member of JavaFX team at Oracle, who has contributed 10 changesets to OpenJFX. A list of these changesets is available by the following link:

Re: [10] Review request for 8179597: Handle cut and paste of 1, 2 and 4 byte characters

2017-05-08 Thread Semyon Sadetsky
yes, that was a typo. Actually, the fix is for 10. --Semyon On 5/8/2017 8:20 AM, Kevin Rushforth wrote: Please review the fix for jfx9: I presume this is a typo and you meant to say jfx10? -- Kevin Semyon Sadetsky wrote: Hello Kevin & David, Please review the fix for jfx9: bug: h

[10] Review request for 8179597: Handle cut and paste of 1, 2 and 4 byte characters

2017-05-05 Thread Semyon Sadetsky
Hello Kevin & David, Please review the fix for jfx9: bug: https://bugs.openjdk.java.net/browse/JDK-8179597 webrev: http://cr.openjdk.java.net/~ssadetsky/8179597/webrev.00/ --Semyon

Re: [10] Review request for 8176844: Menus not always selected properly with GTK 3

2017-04-05 Thread Semyon Sadetsky
On 04/05/2017 11:23 AM, David Hill wrote: On 4/5/17, 12:52 PM, Semyon Sadetsky wrote: Okay. Thank you to you all! The root cause why we need to add sync is a new way to grab/ungrab focus used in the GTK3 glass implementation. The GTK2 way to grab/ungrab is still applicable in GTK3 though

Re: [10] Review request for 8176844: Menus not always selected properly with GTK 3

2017-04-05 Thread Semyon Sadetsky
to measure the effect of such change, remote display to your desktop from a machine in a geographically distant site. It is the latency that kills performance, not the bandwidth. -phil. On 4/4/17, 3:43 PM, David Hill wrote: On 4/4/17, 1:27 PM, Semyon Sadetsky wrote: Hello Kevin & David, Please rev

Re: [10] Review request for 8176844: Menus not always selected properly with GTK 3

2017-04-04 Thread Semyon Sadetsky
Sorry. The fix is for JFX *10*. On 04/04/2017 10:27 AM, Semyon Sadetsky wrote: Hello Kevin & David, Please review the fix for jfx9: bug: https://bugs.openjdk.java.net/browse/JDK-8176844 webrev: http://cr.openjdk.java.net/~ssadetsky/8176844/ --Semyon

[10] Review request for 8176844: Menus not always selected properly with GTK 3

2017-04-04 Thread Semyon Sadetsky
Hello Kevin & David, Please review the fix for jfx9: bug: https://bugs.openjdk.java.net/browse/JDK-8176844 webrev: http://cr.openjdk.java.net/~ssadetsky/8176844/ --Semyon

[9] Review request for 8175822: Pulldown position regression and not painting correctly tooltips regression

2017-03-14 Thread Semyon Sadetsky
Hello Kevin & David, Please review the fix for jfx9: bug: https://bugs.openjdk.java.net/browse/JDK-8175822 webrev: http://cr.openjdk.java.net/~ssadetsky/8175822/webrev.00/ --Semyon

[9] Review request for 8175204: Linux: Dialog windows come up 1-pixel wide

2017-02-21 Thread Semyon Sadetsky
Hello Kevin & David, Please review the fix for jfx9: bug: https://bugs.openjdk.java.net/browse/JDK-8175204 webrev: http://cr.openjdk.java.net/~ssadetsky/8175204/webrev.00/ --Semyon

[9] Review request for 8175205: Linux: Stage initially in full-screen mode not shown when exiting full-screen

2017-02-20 Thread Semyon Sadetsky
Hello Kevin & David, Please review the fix for jfx9: bug: https://bugs.openjdk.java.net/browse/JDK-8175205 webrev: http://cr.openjdk.java.net/~ssadetsky/8175205/webrev.00/ --Semyon

[9] Review request for 8174154: NPE in JFXPanel$HostContainer#setEmbeddedStage

2017-02-10 Thread Semyon Sadetsky
Hello Kevin, Please review fix for jfx9: bug: https://bugs.openjdk.java.net/browse/JDK-8174154 webrev: http://cr.openjdk.java.net/~ssadetsky/8174154/webrev.00/ --Semyon

[9] Review request for 8173901: Linux: Position of Stage is not restored after exiting full screen

2017-02-06 Thread Semyon Sadetsky
Hello Kevin & David, Please review the fix for jfx9: bug: https://bugs.openjdk.java.net/browse/JDK-8173901 webrev: http://cr.openjdk.java.net/~ssadetsky/8173901/webrev.00/ --Semyon

[9] Review request for 8090249: [Linux] Restoring owner stage after minimize does not restore position of child stage

2017-02-03 Thread Semyon Sadetsky
Hello Kevin & David, Please review the fix for jfx9: bug: https://bugs.openjdk.java.net/browse/JDK-8090249 webrev: http://cr.openjdk.java.net/~ssadetsky/8090249/webrev.00/ --Semyon

[9] Review request for 8152421: After initing the modality of a non-primary stage to MODAL, closing that stage causes the primary stage to become non-resizable

2017-01-30 Thread Semyon Sadetsky
Hello Kevin & David, Please review the fix for jfx9: bug: https://bugs.openjdk.java.net/browse/JDK-8152421 webrev: http://cr.openjdk.java.net/~ssadetsky/8152421/webrev.01/ Set window enabled logic is updated to restore window resizability correctly. --Semyon

[9] Review request for 8172554: [macos] deadlock on JFXPanel startup

2017-01-25 Thread Semyon Sadetsky
Hello Kevin & David, Please review the fix for jfx9: bug: https://bugs.openjdk.java.net/browse/JDK-8172554 webrev: http://cr.openjdk.java.net/~ssadetsky/8172554/webrev.01/ JFXPanel initializes JFX on EDT as result EDT and Toolkit thread may block each other. The proposed solution do not

[9] Review request for 8172096: SwingNode, Linux: certain mnemonics don't work on Unity

2017-01-11 Thread Semyon Sadetsky
Hello Kevin & David, Please review the fix for jfx9: bug: https://bugs.openjdk.java.net/browse/JDK-8172096 webrev: http://cr.openjdk.java.net/~ssadetsky/8172096/webrev.00/ The details are in the bug. --Semyon

[9] Review request for 8171330: Issues with transparent stage and GTK

2016-12-16 Thread Semyon Sadetsky
Hello Kevin & David, Please review the fix for jfx9: bug: https://bugs.openjdk.java.net/browse/JDK-8171330 webrev: http://cr.openjdk.java.net/~ssadetsky/8171330/webrev.00/ By the logic of scene painting the compositing method should be "source over destination" in both cases GTK2 and GTK3.

[9] Review request for 8166147: Ubuntu 16.04: expandable content goes outside of the alert dialog

2016-12-14 Thread Semyon Sadetsky
Hello Kevin & David, Please review the fix for jfx9: bug: https://bugs.openjdk.java.net/browse/JDK-8166147 webrev: http://cr.openjdk.java.net/~ssadetsky/8166147/webrev.00/ XLib size requests and hints was mixed up with GTK ones. --Semyon

[9] Review request for 8166414: Scene returns incorrect coordinates

2016-12-09 Thread Semyon Sadetsky
Hello Kevin & David, Please review the fix for jfx9: bug: https://bugs.openjdk.java.net/browse/JDK-8166414 webrev: http://cr.openjdk.java.net/~ssadetsky/8166414/webrev.00/ According to GTK iib documentation on X11 WMs the gtk_window_get_position() function doesn't return the exact window

[9] Review request for 8151170: WINDOW_MODAL dialog does not popup when restoring iconified owner window, which causes application freeze

2016-11-30 Thread Semyon Sadetsky
Hello Kevin & David, Please review the fix for jfx9: bug: https://bugs.openjdk.java.net/browse/JDK-8151170 webrev: http://cr.openjdk.java.net/~ssadetsky/8151170/webrev.00/ Win32 API ::GetWindowRect() call returns fake -32000,-32000 location for iconified window. Solution: skip WM_MOVE if

Re: [9] Review request for 8157002: Toggle gtk version if SWT used via FXCanvas

2016-11-23 Thread Semyon Sadetsky
hierarchies. --Semyon b) one loads a JavaFX UI c) loads an SWT-UI Both webrefs won't address this case if not mistaken, but I have never seen an application like that ;-) Tom On 23.11.16 13:32, Semyon Sadetsky wrote: On 11/23/2016 12:38 PM, Tom Schindl wrote: From looking at the code I

Re: [9] Review request for 8157002: Toggle gtk version if SWT used via FXCanvas

2016-11-23 Thread Semyon Sadetsky
1.16 14:51, Semyon Sadetsky wrote: Hello Kevin & David, Please review the fix for jfx9: bug: https://bugs.openjdk.java.net/browse/JDK-8157002 webrev: http://cr.openjdk.java.net/~ssadetsky/8157002/webrev.00/ In JFX embeded into SWT scenarios JFX loads GTK primarily. So SWT GTK version cannot be

[9] Review request for 8156491: Autodetect GTK version for JFX

2016-11-23 Thread Semyon Sadetsky
Hello Kevin & David, Please review the fix for jfx9: bug: https://bugs.openjdk.java.net/browse/JDK-8156491 webrev: http://cr.openjdk.java.net/~ssadetsky/8156491/webrev.00/ The fix implements the autodetect feature which protects JFX Glass toolkit from the crash caused by loading dynamic libs

Re: [9] Review request for 8157002: Toggle gtk version if SWT used via FXCanvas

2016-11-23 Thread Semyon Sadetsky
Thanks, Doychin. The webrev is updated: http://cr.openjdk.java.net/~ssadetsky/8157002/webrev.01/ --Semyon On 11/23/2016 10:15 AM, Doychin Bondzhev wrote: Hi, I think this line is incorrect: if (ver < 2 && ver > 3) { It should be || instead of && On 22.11.20

[9] Review request for 8157002: Toggle gtk version if SWT used via FXCanvas

2016-11-22 Thread Semyon Sadetsky
Hello Kevin & David, Please review the fix for jfx9: bug: https://bugs.openjdk.java.net/browse/JDK-8157002 webrev: http://cr.openjdk.java.net/~ssadetsky/8157002/webrev.00/ In JFX embeded into SWT scenarios JFX loads GTK primarily. So SWT GTK version cannot be detected using the check for the

[9] Review request for 8169309: Migrate SwingNode to the new float API of JLightweightFrame

2016-11-07 Thread Semyon Sadetsky
Hello Kevin & Jim, Please review the fix for jfx9: webrev: http://cr.openjdk.java.net/~ssadetsky/8169309/webrev.00/ bug: https://bugs.openjdk.java.net/browse/JDK-8153522 --Semyon

[9] Review Request for 8162551: SwingNode scaling doesn't work

2016-07-26 Thread Semyon Sadetsky
Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8162551 webrev: http://cr.openjdk.java.net/~ssadetsky/8162551/webrev.00/ Upscaling is not needed to send coordinates to sun.swing.JLightweightFrame. --Semyon