Re: [Integrated] RFR: 8130738: TextFlow's tab width is static

2020-01-06 Thread Kevin Rushforth
Changeset: 8367e1a6 Author:Scott Palmer Committer: Kevin Rushforth Date: 2019-12-31 18:34:33 + URL: https://git.openjdk.java.net/jfx/commit/8367e1a6 8130738: Add tabSize property to Text and TextFlow Reviewed-by: prr, kcr ! modules/javafx.graphics/src/main/docs/javafx/scene/

Re: [Rev 02] RFR: 8130738: TextFlow's tab width is static

2019-11-27 Thread Jeanette Winzenburg
On Wed, 27 Nov 2019 00:58:22 GMT, Kevin Rushforth wrote: > On Tue, 26 Nov 2019 17:26:33 GMT, Scott Palmer wrote: > >> The pull request has been updated with a complete new set of changes >> (possibly due to a rebase). >> >> >> >> Commits: >> - 254c40de: Merge remote-trackin

Re: [Rev 02] RFR: 8130738: TextFlow's tab width is static

2019-11-26 Thread Kevin Rushforth
On Tue, 26 Nov 2019 17:26:33 GMT, Scott Palmer wrote: > The pull request has been updated with a complete new set of changes > (possibly due to a rebase). > > > > Commits: > - 254c40de: Merge remote-tracking branch 'upstream/master' > - a670c4f8: 8130738: TextFlow's tab widt

Re: RFR: 8130738: TextFlow's tab width is static

2019-11-26 Thread Kevin Rushforth
On Tue, 26 Nov 2019 18:40:10 GMT, Scott Palmer wrote: > On Thu, 7 Nov 2019 14:56:58 GMT, Kevin Rushforth wrote: > >> On Wed, 6 Nov 2019 19:11:48 GMT, Scott Palmer wrote: >> >>> Added tabSize property to Text and TextFlow and -fx-tab-size CSS attribute >>> to both. TextFlow's tab size overri

Re: RFR: 8130738: TextFlow's tab width is static

2019-11-26 Thread Scott Palmer
On Thu, 7 Nov 2019 14:56:58 GMT, Kevin Rushforth wrote: > On Wed, 6 Nov 2019 19:11:48 GMT, Scott Palmer wrote: > >> Added tabSize property to Text and TextFlow and -fx-tab-size CSS attribute >> to both. TextFlow's tab size overrides that of contained Text nodes. >> >> >> >>

Re: [Rev 02] RFR: 8130738: TextFlow's tab width is static

2019-11-26 Thread Phil Race
On Tue, 26 Nov 2019 17:26:33 GMT, Scott Palmer wrote: > The pull request has been updated with a complete new set of changes > (possibly due to a rebase). > > > > Commits: > - 254c40de: Merge remote-tracking branch 'upstream/master' > - a670c4f8: 8130738: TextFlow's tab widt

Re: [Rev 02] RFR: 8130738: TextFlow's tab width is static

2019-11-26 Thread Scott Palmer
The pull request has been updated with a complete new set of changes (possibly due to a rebase). Commits: - 254c40de: Merge remote-tracking branch 'upstream/master' - a670c4f8: 8130738: TextFlow's tab width is static - 68d221c7: 8130738: TextFlow's tab width is static Change

Re: RFR: 8130738: TextFlow's tab width is static

2019-11-07 Thread Scott Palmer
Yes, I suppose this should behave like anything else that uses an IntegerProperty as far as bindings are concerned. I'll wait for further review before reverting that last change. If tabSize=0 worked reasonably it would be much simpler. I'm not sure if I will have the time to hunt down why things

Re: RFR: 8130738: TextFlow's tab width is static

2019-11-07 Thread Kevin Rushforth
On Wed, 6 Nov 2019 19:11:48 GMT, Scott Palmer wrote: > Added tabSize property to Text and TextFlow and -fx-tab-size CSS attribute to > both. TextFlow's tab size overrides that of contained Text nodes. > > > > Commits: > - 68d221c7: 8130738: TextFlow's tab width is static >

Re: RFR: 8130738: TextFlow's tab width is static

2019-11-07 Thread Scott Palmer
o: openjfx-dev@openjdk.java.net >> Subject: RFR: 8130738: TextFlow's tab width is static >> >> Added tabSize property to Text and TextFlow and -fx-tab-size CSS attribute to >> both. TextFlow's tab size overrides that of contained Text nodes.

Re: [Rev 01] RFR: 8130738: TextFlow's tab width is static

2019-11-07 Thread Scott Palmer
The pull request has been updated with additional changes. Added commits: - a670c4f8: 8130738: TextFlow's tab width is static Changes: - all: https://git.openjdk.java.net/jfx/pull/32/files - new: https://git.openjdk.java.net/jfx/pull/32/files/68d221c7..a670c4f8 Webrevs: -

RE: RFR: 8130738: TextFlow's tab width is static

2019-11-06 Thread David Grieve
What happens if you do text.tabSizeProperty().setValue(null) ? > -Original Message- > From: openjfx-dev On Behalf Of > Scott Palmer > Sent: Wednesday, November 6, 2019 11:12 AM > To: openjfx-dev@openjdk.java.net > Subject: RFR: 8130738: TextFlow's tab width is st

RFR: 8130738: TextFlow's tab width is static

2019-11-06 Thread Scott Palmer
Added tabSize property to Text and TextFlow and -fx-tab-size CSS attribute to both. TextFlow's tab size overrides that of contained Text nodes. Commits: - 68d221c7: 8130738: TextFlow's tab width is static Changes: https://git.openjdk.java.net/jfx/pull/32/files Webrev: https: