Re: RFR: 8199592: Control labels truncated at certain DPI scaling levels [v2]

2020-11-24 Thread Ambarish Rapte
On Fri, 20 Nov 2020 11:30:18 GMT, Jose Pereda wrote: >> As commented in the [JBS >> issue](https://bugs.openjdk.java.net/browse/JDK-8199592), the default UI >> scale 1.0 is used to perform initial calculations of preferred sizes of the >> scene, even if the scale has already a different value

Re: RFR: 8199592: Control labels truncated at certain DPI scaling levels [v2]

2020-11-20 Thread Kevin Rushforth
On Fri, 20 Nov 2020 11:30:18 GMT, Jose Pereda wrote: >> As commented in the [JBS >> issue](https://bugs.openjdk.java.net/browse/JDK-8199592), the default UI >> scale 1.0 is used to perform initial calculations of preferred sizes of the >> scene, even if the scale has already a different value

Re: RFR: 8199592: Control labels truncated at certain DPI scaling levels [v2]

2020-11-20 Thread Jose Pereda
On Thu, 19 Nov 2020 02:12:05 GMT, Kevin Rushforth wrote: >> Jose Pereda has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Use assertTrue instead of try-catch > > tests/system/src/test/java/test/javafx/scene/UIRenderSceneTest.java line 83:

Re: RFR: 8199592: Control labels truncated at certain DPI scaling levels [v2]

2020-11-20 Thread Jose Pereda
> As commented in the [JBS > issue](https://bugs.openjdk.java.net/browse/JDK-8199592), the default UI > scale 1.0 is used to perform initial calculations of preferred sizes of the > scene, even if the scale has already a different value (i.e 175%). As a > workaround, calling

Re: RFR: 8199592: Control labels truncated at certain DPI scaling levels

2020-11-19 Thread Kevin Rushforth
On Thu, 19 Nov 2020 02:16:55 GMT, Kevin Rushforth wrote: >> As commented in the [JBS >> issue](https://bugs.openjdk.java.net/browse/JDK-8199592), the default UI >> scale 1.0 is used to perform initial calculations of preferred sizes of the >> scene, even if the scale has already a different

Re: RFR: 8199592: Control labels truncated at certain DPI scaling levels

2020-11-18 Thread Kevin Rushforth
On Mon, 9 Nov 2020 11:34:25 GMT, Jose Pereda wrote: > As commented in the [JBS > issue](https://bugs.openjdk.java.net/browse/JDK-8199592), the default UI > scale 1.0 is used to perform initial calculations of preferred sizes of the > scene, even if the scale has already a different value (i.e

Re: RFR: 8199592: Control labels truncated at certain DPI scaling levels

2020-11-18 Thread Kevin Rushforth
On Mon, 9 Nov 2020 11:34:25 GMT, Jose Pereda wrote: > As commented in the [JBS > issue](https://bugs.openjdk.java.net/browse/JDK-8199592), the default UI > scale 1.0 is used to perform initial calculations of preferred sizes of the > scene, even if the scale has already a different value (i.e

RFR: 8199592: Control labels truncated at certain DPI scaling levels

2020-11-09 Thread Jose Pereda
As commented in the [JBS issue](https://bugs.openjdk.java.net/browse/JDK-8199592), the default UI scale 1.0 is used to perform initial calculations of preferred sizes of the scene, even if the scale has already a different value (i.e 175%). As a workaround, calling `Stage::sizeToScene` fix it,

Re: RFR: 8199592: Control labels truncated at certain DPI scaling levels

2020-10-26 Thread Jeanette Winzenburg
On Sun, 25 Oct 2020 19:27:30 GMT, Jose Pereda wrote: >> curious: it this expected to fix the ellipsed checkBox texts? Can verify >> that the test fails/passes before/after the fix, but the example in the >> report looks still is eclipsed: same for 1.5, slightly better (in that only >> the

Re: RFR: 8199592: Control labels truncated at certain DPI scaling levels

2020-10-25 Thread Jose Pereda
On Sun, 25 Oct 2020 11:14:43 GMT, Jeanette Winzenburg wrote: >> The approach looks good. I'll review it early next week, and also ask >> @arapte to review. > > curious: it this expected to fix the ellipsed checkBox texts? Can verify that > the test fails/passes before/after the fix, but the

Re: RFR: 8199592: Control labels truncated at certain DPI scaling levels

2020-10-25 Thread Jeanette Winzenburg
On Sat, 24 Oct 2020 18:50:22 GMT, Kevin Rushforth wrote: >> As discussed in the [JBS >> issue](https://bugs.openjdk.java.net/browse/JDK-8199592), when snapping an >> already snapped value (either intentionally or by mistake), the result >> should be the same, otherwise we'll be jumping

Re: RFR: 8199592: Control labels truncated at certain DPI scaling levels

2020-10-24 Thread Kevin Rushforth
On Fri, 23 Oct 2020 08:32:59 GMT, Jose Pereda wrote: > As discussed in the [JBS > issue](https://bugs.openjdk.java.net/browse/JDK-8199592), when snapping an > already snapped value (either intentionally or by mistake), the result > should be the same, otherwise we'll be jumping unnecessary

RFR: 8199592: Control labels truncated at certain DPI scaling levels

2020-10-23 Thread Jose Pereda
As discussed in the [JBS issue](https://bugs.openjdk.java.net/browse/JDK-8199592), when snapping an already snapped value (either intentionally or by mistake), the result should be the same, otherwise we'll be jumping unnecessary from a valid pixel to another pixel. This PR provides a fix to