On Thu, 23 Jul 2020 12:34:43 GMT, Eric Bresie
wrote:
>> Marked as reviewed by arapte (Reviewer).
>
> Just curious and this may be OBE by now but... I see the check thread but
> when accessing the buffer itself, should it
> have some sort of synchronization of some type to make it more thread
On Fri, 10 Jul 2020 05:20:03 GMT, Ambarish Rapte wrote:
>> John Neffenger has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove assert statements
>
> Marked as reviewed by arapte (Reviewer).
Just curious and this may be OBE by now but.
On Tue, 30 Jun 2020 23:11:56 GMT, John Neffenger
wrote:
>> Fixes [JDK-8201567](https://bugs.openjdk.java.net/browse/JDK-8201567).
>
> John Neffenger has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Remove assert statements
Marked as review
On Tue, 30 Jun 2020 23:11:56 GMT, John Neffenger
wrote:
>> Fixes [JDK-8201567](https://bugs.openjdk.java.net/browse/JDK-8201567).
>
> John Neffenger has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Remove assert statements
Marked as review
On Wed, 8 Jul 2020 22:02:17 GMT, Kevin Rushforth wrote:
>> @jgneff this looks safe enough to get into 15. Go ahead an retarget it to
>> the `jfx15` branch.
>>
>> @arapte this will invalidate your review, so you will need to re-review it
>> once retargeted.
>
> Oh, and regarding the following:
On Wed, 8 Jul 2020 21:51:00 GMT, Kevin Rushforth wrote:
>> Marked as reviewed by arapte (Reviewer).
>
> @jgneff this looks safe enough to get into 15. Go ahead an retarget it to the
> `jfx15` branch.
>
> @arapte this will invalidate your review, so you will need to re-review it
> once retarget
On Wed, 8 Jul 2020 17:45:25 GMT, Ambarish Rapte wrote:
>> John Neffenger has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove assert statements
>
> Marked as reviewed by arapte (Reviewer).
@jgneff this looks safe enough to get into 15
On Tue, 30 Jun 2020 23:11:56 GMT, John Neffenger
wrote:
>> Fixes [JDK-8201567](https://bugs.openjdk.java.net/browse/JDK-8201567).
>
> John Neffenger has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Remove assert statements
Marked as review
On Thu, 2 Jul 2020 23:48:08 GMT, Kevin Rushforth wrote:
>>> Does this fix the years old Linux JavaFX buffer reset bug?
>>
>> Possibly. This is a race condition that can affect the use of
>> `UploadingPainter`, which is used by the SW pipeline.
>
> This fix might be a candidate for JavaFX 15, so
On Thu, 2 Jul 2020 12:41:34 GMT, Kevin Rushforth wrote:
>> I tested this pull request on all of the following platforms:
>>
>> * JavaFX desktop platforms (*amd64* architecture)
>> * Windows SDK on Windows 10 Pro Version 2004
>> * Mac OS X SDK on macOS 10.15.5 (Catalina)
>> * Linux SD
On Wed, 1 Jul 2020 05:43:29 GMT, John Neffenger
wrote:
>>> It will also need to be tested using the SW pipeline on all platforms.
>>
>> Thanks for the reminder. I managed to build JavaFX on Windows and macOS
>> today, so I'll test this pull request on those
>> platforms in addition to Linux de
On Tue, 30 Jun 2020 06:05:08 GMT, John Neffenger
wrote:
>> At first glance the fix looks fine (aside from the `assert` statements that
>> need to be removed). It will also need to
>> be tested using the SW pipeline on all platforms.
>
>> It will also need to be tested using the SW pipeline on a
On 6/25/20 10:56 PM, John Neffenger wrote:
Fixes [JDK-8201567](https://bugs.openjdk.java.net/browse/JDK-8201567).
-
Commit messages:
- 8201567: QuantumRenderer modifies buffer in use by JavaFX Application Thread
Changes: https://git.openjdk.java.net/jfx/pull/255/files
Webrev:
> Fixes [JDK-8201567](https://bugs.openjdk.java.net/browse/JDK-8201567).
John Neffenger has updated the pull request incrementally with one additional
commit since the last revision:
Remove assert statements
-
Changes:
- all: https://git.openjdk.java.net/jfx/pull/255/files
-
On Sun, 28 Jun 2020 02:35:16 GMT, John Neffenger
wrote:
>> modules/javafx.graphics/src/main/java/com/sun/glass/ui/Pixels.java line 194:
>>
>>> 193: public final Buffer getBuffer() {
>>> 194: assert this.bytes != null || this.ints != null;
>>> 195: return this.bytes != null ?
On Sat, 27 Jun 2020 15:37:52 GMT, Kevin Rushforth wrote:
> It will also need to be tested using the SW pipeline on all platforms.
Thanks for the reminder. I managed to build JavaFX on Windows and macOS today,
so I'll test this pull request on those
platforms in addition to Linux desktop and emb
The message from this sender included one or more files
which could not be scanned for virus detection; do not
open these files unless you are certain of the sender's intent.
--
On Sat, 27 Jun 2020 15:36:01 GMT, Kevin Rushforth w
On Fri, 26 Jun 2020 03:47:55 GMT, John Neffenger
wrote:
> Fixes [JDK-8201567](https://bugs.openjdk.java.net/browse/JDK-8201567).
At first glance the fix looks fine (aside from the `assert` statements that
need to be removed). It will also need to
be tested using the SW pipeline on all platform
On Fri, 26 Jun 2020 03:47:55 GMT, John Neffenger
wrote:
> Fixes [JDK-8201567](https://bugs.openjdk.java.net/browse/JDK-8201567).
The method `QueuedPixelSource.usesSameBuffer` calls `Pixels.getPixels` on the
QuantumRenderer thread while trying to
find a buffer that's not in use, yet in doing so
Fixes [JDK-8201567](https://bugs.openjdk.java.net/browse/JDK-8201567).
-
Commit messages:
- 8201567: QuantumRenderer modifies buffer in use by JavaFX Application Thread
Changes: https://git.openjdk.java.net/jfx/pull/255/files
Webrev: https://webrevs.openjdk.java.net/jfx/255/webrev.
20 matches
Mail list logo
