Re: RFR: 8202990: javafx webview css filter property with display scaling [v3]

2020-09-03 Thread Kevin Rushforth
On Thu, 3 Sep 2020 06:07:10 GMT, Bhawesh Choudhary wrote: >> ImageJava.cpp ignores CompositeOperator parameter in drawImage function due >> to which shadow was getting drawn on top of >> actual image. apply given composite operator to graphics context before >> drawing image to fix this

Re: RFR: 8202990: javafx webview css filter property with display scaling [v3]

2020-09-03 Thread Arun Joseph
On Thu, 3 Sep 2020 06:07:10 GMT, Bhawesh Choudhary wrote: >> ImageJava.cpp ignores CompositeOperator parameter in drawImage function due >> to which shadow was getting drawn on top of >> actual image. apply given composite operator to graphics context before >> drawing image to fix this

Re: RFR: 8202990: javafx webview css filter property with display scaling [v3]

2020-09-03 Thread Bhawesh Choudhary
> ImageJava.cpp ignores CompositeOperator parameter in drawImage function due > to which shadow was getting drawn on top of > actual image. apply given composite operator to graphics context before > drawing image to fix this issue. another issue > is into WCGraphicsPrismContext.java. while

Re: RFR: 8202990: javafx webview css filter property with display scaling [v2]

2020-09-01 Thread Arun Joseph
On Tue, 1 Sep 2020 06:29:17 GMT, Bhawesh Choudhary wrote: >> ImageJava.cpp ignores CompositeOperator parameter in drawImage function due >> to which shadow was getting drawn on top of >> actual image. apply given composite operator to graphics context before >> drawing image to fix this

Re: RFR: 8202990: javafx webview css filter property with display scaling [v2]

2020-09-01 Thread Arun Joseph
On Tue, 1 Sep 2020 06:29:17 GMT, Bhawesh Choudhary wrote: >> ImageJava.cpp ignores CompositeOperator parameter in drawImage function due >> to which shadow was getting drawn on top of >> actual image. apply given composite operator to graphics context before >> drawing image to fix this

Re: RFR: 8202990: javafx webview css filter property with display scaling [v2]

2020-09-01 Thread Kevin Rushforth
On Tue, 1 Sep 2020 06:29:17 GMT, Bhawesh Choudhary wrote: >> ImageJava.cpp ignores CompositeOperator parameter in drawImage function due >> to which shadow was getting drawn on top of >> actual image. apply given composite operator to graphics context before >> drawing image to fix this

Re: RFR: 8202990: javafx webview css filter property with display scaling [v2]

2020-09-01 Thread Bhawesh Choudhary
> ImageJava.cpp ignores CompositeOperator parameter in drawImage function due > to which shadow was getting drawn on top of > actual image. apply given composite operator to graphics context before > drawing image to fix this issue. another issue > is into WCGraphicsPrismContext.java. while

Re: RFR: 8202990: javafx webview css filter property with display scaling

2020-08-31 Thread Kevin Rushforth
On Sat, 29 Aug 2020 00:31:51 GMT, Kevin Rushforth wrote: >> The fix and test looks good. > > I spent some time this afternoon going over the fix in more detail and doing > extensive testing on both Windows and Mac. > > I believe the fix is good. Both by inspection and by instrumenting the

Re: RFR: 8202990: javafx webview css filter property with display scaling

2020-08-28 Thread Kevin Rushforth
On Fri, 28 Aug 2020 05:24:24 GMT, Arun Joseph wrote: >> ImageJava.cpp ignores CompositeOperator parameter in drawImage function due >> to which shadow was getting drawn on top of >> actual image. apply given composite operator to graphics context before >> drawing image to fix this issue.

Re: RFR: 8202990: javafx webview css filter property with display scaling

2020-08-27 Thread Arun Joseph
On Tue, 11 Aug 2020 16:18:37 GMT, Bhawesh Choudhary wrote: > ImageJava.cpp ignores CompositeOperator parameter in drawImage function due > to which shadow was getting drawn on top of > actual image. apply given composite operator to graphics context before > drawing image to fix this issue.

Re: RFR: 8202990: javafx webview css filter property with display scaling

2020-08-26 Thread Arun Joseph
On Wed, 12 Aug 2020 15:59:20 GMT, Kevin Rushforth wrote: > With your patch installed, I see a race condition that manifests in one of > two ways: I couldn't reproduce the race condition or crash with the fix. > I suspect this might be related to the gc.setCompositeOperation call. This may

Re: RFR: 8202990: javafx webview css filter property with display scaling

2020-08-12 Thread Kevin Rushforth
On Tue, 11 Aug 2020 16:18:37 GMT, Bhawesh Choudhary wrote: > ImageJava.cpp ignores CompositeOperator parameter in drawImage function due > to which shadow was getting drawn on top of > actual image. apply given composite operator to graphics context before > drawing image to fix this issue.

RFR: 8202990: javafx webview css filter property with display scaling

2020-08-11 Thread Bhawesh Choudhary
ImageJava.cpp ignores CompositeOperator parameter in drawImage function due to which shadow was getting drawn on top of actual image. apply given composite operator to graphics context before drawing image to fix this issue. another issue is into WCGraphicsPrismContext.java. while blending two