Re: RFR: 8236651: Simplify and update glass gtk backend

2021-01-27 Thread Thiago Milczarek Sayao
On Mon, 25 Jan 2021 23:49:38 GMT, Kevin Rushforth wrote: >> I would prefer this approach: >> https://github.com/openjdk/jfx/pull/367 > > Given the alternate approach that you propose to pursue (which I agree is a > better option), this PR should either be closed or moved to Draft. Closing it in

Re: RFR: 8236651: Simplify and update glass gtk backend

2021-01-25 Thread Kevin Rushforth
On Tue, 15 Dec 2020 12:24:01 GMT, Thiago Milczarek Sayao wrote: > This is a new approach to rewrite parts of gtk glass backend to be more clean. > > I will provide small "manageable" PR to incrementally make the backend better. > > This PR adresses cleanup of the Size and Positioning code. It

Re: RFR: 8236651: Simplify and update glass gtk backend

2021-01-25 Thread Kevin Rushforth
On Mon, 25 Jan 2021 01:18:30 GMT, Thiago Milczarek Sayao wrote: >> Tested on Ubuntu 20.04 >> >> 756 tests completed, 6 failed, 110 skipped >> >> Failed: >> test.robot.javafx.scene.ColorPickerTest > testColorPickerSceneChange FAILED >> java.lang.AssertionError: Timeout: Failed to receive on

Re: RFR: 8236651: Simplify and update glass gtk backend [v3]

2021-01-24 Thread Thiago Milczarek Sayao
> This is a new approach to rewrite parts of gtk glass backend to be more clean. > > I will provide small "manageable" PR to incrementally make the backend better. > > This PR adresses cleanup of the Size and Positioning code. It makes code more > "straightforward" and easier to maintain. > > C

Re: RFR: 8236651: Simplify and update glass gtk backend [v2]

2021-01-24 Thread Thiago Milczarek Sayao
> This is a new approach to rewrite parts of gtk glass backend to be more clean. > > I will provide small "manageable" PR to incrementally make the backend better. > > This PR adresses cleanup of the Size and Positioning code. It makes code more > "straightforward" and easier to maintain. > > C

Re: RFR: 8236651: Simplify and update glass gtk backend

2021-01-24 Thread Thiago Milczarek Sayao
On Tue, 22 Sep 2020 01:12:44 GMT, Thiago Milczarek Sayao wrote: >> Rebased onto "master" and squashed commits. > > Tested on Ubuntu 20.04 > > 756 tests completed, 6 failed, 110 skipped > > Failed: > test.robot.javafx.scene.ColorPickerTest > testColorPickerSceneChange FAILED > java.lang.Ass

Re: RFR: 8236651: Simplify and update glass gtk backend

2021-01-13 Thread Thiago Milczarek Sayao
On Mon, 21 Sep 2020 23:40:50 GMT, Thiago Milczarek Sayao wrote: >>> I would starting hooking gtk event signals >>> (https://developer.gnome.org/gtk3/stable/GtkWidget.html), specially the >>> "touch-event" to JavaFx events (probably need to add through JNI). Should >>> be simple. Contact me at

Re: RFR: 8236651: Simplify and update glass gtk backend

2021-01-13 Thread Thiago Milczarek Sayao
On Wed, 29 Jul 2020 21:01:42 GMT, Tor (torbuntu) wrote: >> @Torbuntu Not to this PR, I don't want to delay it too much. But can be done >> (I just do not own a touch device currently). > > Sounds good! I have a few devices I'd be more than excited to test on, and > even help add the feature my

Re: RFR: 8236651: Simplify and update glass gtk backend

2021-01-13 Thread Pankaj Bansal
On Fri, 12 Jun 2020 20:22:12 GMT, Thiago Milczarek Sayao wrote: >>> I had used two compilation parameters to limit Gtk on 3.8 (so it would >>> generate error if any symbol > 3.8 were used). But that does not seem to >>> work on 18.04, so I removed it. >> >> Good. I was going to ask you about

Re: RFR: 8236651: Simplify and update glass gtk backend

2021-01-13 Thread torbuntu
On Fri, 3 Jul 2020 13:49:54 GMT, Kevin Rushforth wrote: >> @pankaj-bansal Sorry for commiting again. Now the Tab Pane test works >> properly. > >> If you want these commits to be preserved when you integrate, you will need >> to make a 'merge-style' pull request. > > Please ignore this informa

Re: RFR: 8236651: Simplify and update glass gtk backend

2021-01-13 Thread Thiago Milczarek Sayao
On Fri, 12 Jun 2020 13:51:58 GMT, Kevin Rushforth wrote: >>> After the latest commit on June 10, this is not building for me on my >>> Ubuntu 18.04. I am attaching the build log for reference. >>> [build.log](https://github.com/openjdk/jfx/files/4770864/build.log) >> >> It's now fixed. I had us

Re: RFR: 8236651: Simplify and update glass gtk backend

2021-01-13 Thread Kevin Rushforth
On Mon, 6 Jan 2020 14:25:18 GMT, Kevin Rushforth wrote: >> ### Summary >> * Simplify and update the Gtk glass backend, making Linux a first-class >> OpenJFX platform. >> >> ### Goals >> * Make Linux a first-class OpenJFX platform (see Motivation); >> * Simplify the code and reduce it's size; >>

Re: RFR: 8236651: Simplify and update glass gtk backend

2021-01-13 Thread Thiago Milczarek Sayao
On Tue, 9 Jun 2020 23:14:31 GMT, Kevin Rushforth wrote: > I am running a full test using GTK 3 on Ubuntu 20.04 and will publish > results. I will later do the same for Oracle Linux 7.7. > > One thing to note is that this new GTK pipeline doesn't run on Ubuntu 16.04. > I get the following runni

Re: RFR: 8236651: Simplify and update glass gtk backend

2021-01-13 Thread Thiago Milczarek Sayao
On Sun, 14 Jun 2020 11:55:45 GMT, Pankaj Bansal wrote: >> Following are results in Ubuntu 18.04 after fix for tab pane tests. >> > src="https://user-images.githubusercontent.com/6153953/84587007-3abc2880-ae39-11ea-8b61-0cbb86e4d4b5.png";> > > This is the result on OL 82 with latest commit > src=

Re: RFR: 8236651: Simplify and update glass gtk backend

2021-01-13 Thread torbuntu
On Tue, 25 Aug 2020 14:12:14 GMT, Thiago Milczarek Sayao wrote: > I would starting hooking gtk event signals > (https://developer.gnome.org/gtk3/stable/GtkWidget.html), specially the > "touch-event" to JavaFx events (probably need to add through JNI). Should be > simple. Contact me at thiago.

Re: RFR: 8236651: Simplify and update glass gtk backend

2021-01-13 Thread Thiago Milczarek Sayao
On Wed, 29 Jul 2020 02:39:31 GMT, Tor (torbuntu) wrote: >>> If you want these commits to be preserved when you integrate, you will need >>> to make a 'merge-style' pull request. >> >> Please ignore this information from Skara. I don't know what caused it, but >> I've pinged the Skara folks ab

Re: RFR: 8236651: Simplify and update glass gtk backend

2021-01-13 Thread Thiago Milczarek Sayao
On Wed, 1 Apr 2020 03:21:31 GMT, Thiago Milczarek Sayao wrote: >> Ubuntu 20.04 Test Results >> >> Updated April 2nd. >> >> ![image](https://user-images.githubusercontent.com/30704286/78299385-28a23d80-750c-11ea-9edd-ac264f16c194.png) > > Test on 16.04 (without Webkit - it does not build on 16.

Re: RFR: 8236651: Simplify and update glass gtk backend

2021-01-13 Thread Thiago Milczarek Sayao
On Fri, 3 Apr 2020 15:21:29 GMT, Kevin Rushforth wrote: >> I will keep testing it, but I think it's looking good. > > I see a lot of work going into this. > > In order for this to progress beyond the prototype or concept phase, we will > need to have a discussion on the openjfx-dev mailing list

Re: RFR: 8236651: Simplify and update glass gtk backend

2021-01-13 Thread Thiago Milczarek Sayao
On Thu, 27 Aug 2020 21:21:39 GMT, Tor (torbuntu) wrote: >> I would starting hooking gtk event signals >> (https://developer.gnome.org/gtk3/stable/GtkWidget.html), specially the >> "touch-event" to JavaFx events (probably need to add through JNI). Should be >> simple. Contact me at thiago.saya

Re: RFR: 8236651: Simplify and update glass gtk backend

2021-01-13 Thread Kevin Rushforth
On Mon, 3 Feb 2020 17:26:32 GMT, Thiago Milczarek Sayao wrote: >> I understand. Will do that when the code works 100%. I have submitted the PR >> to avoid duplicated efforts and let people test it (if anyone is willing). > > **Code Changes** > > * glass_window.cpp / glass_window.h > * Remo

Re: RFR: 8236651: Simplify and update glass gtk backend

2021-01-13 Thread torbuntu
On Wed, 29 Jul 2020 20:46:16 GMT, Thiago Milczarek Sayao wrote: >> Would it be possible and related to add the gtk touch events to this PR as >> part of the Glass GTK3 update? Or would follow up update PR adding that be >> more appropriate? >> >> Currently linux desktop does not have touch

Re: RFR: 8236651: Simplify and update glass gtk backend

2021-01-13 Thread Pankaj Bansal
On Sun, 14 Jun 2020 06:49:42 GMT, Pankaj Bansal wrote: >> I have investigated the Tab Pane Drag Test and it works manually. >> >> import javafx.application.Application; >> import javafx.scene.Scene; >> import javafx.scene.control.Tab; >> import javafx.scene.control.TabPane; >> import javafx.sta

Re: RFR: 8236651: Simplify and update glass gtk backend

2021-01-13 Thread Thiago Milczarek Sayao
On Fri, 12 Jun 2020 12:49:42 GMT, Pankaj Bansal wrote: > After the latest commit on June 10, this is not building for me on my Ubuntu > 18.04. I am attaching the build log for reference. > [build.log](https://github.com/openjdk/jfx/files/4770864/build.log) It's now fixed. I had used two compila

Re: RFR: 8236651: Simplify and update glass gtk backend

2021-01-13 Thread Kevin Rushforth
On Fri, 12 Jun 2020 13:49:23 GMT, Thiago Milczarek Sayao wrote: > I had used two compilation parameters to limit Gtk on 3.8 (so it would > generate error if any symbol > 3.8 were used). But that does not seem to work > on 18.04, so I removed it. Good. I was going to ask you about that, so I'm

Re: RFR: 8236651: Simplify and update glass gtk backend

2021-01-13 Thread Pankaj Bansal
On Wed, 10 Jun 2020 13:11:29 GMT, Thiago Milczarek Sayao wrote: >>> I am running a full test using GTK 3 on Ubuntu 20.04 and will publish >>> results. I will later do the same for Oracle Linux 7.7. >>> >>> One thing to note is that this new GTK pipeline doesn't run on Ubuntu >>> 16.04. I get

Re: RFR: 8236651: Simplify and update glass gtk backend

2021-01-13 Thread Kevin Rushforth
On Tue, 9 Jun 2020 23:12:15 GMT, Kevin Rushforth wrote: >> I ran the systemTests on Ubuntu 18.04 using gradle >> -PEXTRA_TEST_ARGS='-Djavafx.gtk.experimental=true' -PFULL_TEST=true >> -PUSE_ROBOT=true :systemTests:cleanTest :systemTests:test. Following are the >> results >> >> > src="https://

Re: RFR: 8236651: Simplify and update glass gtk backend

2021-01-13 Thread Kevin Rushforth
On Sun, 14 Jun 2020 23:59:17 GMT, Thiago Milczarek Sayao wrote: >> This is the result on OL 82 with latest commit >> > src="https://user-images.githubusercontent.com/6153953/84592508-d82c5200-ae63-11ea-87d3-7f55671ed302.png";> > > @pankaj-bansal Sorry for commiting again. Now the Tab Pane test w

Re: RFR: 8236651: Simplify and update glass gtk backend

2021-01-13 Thread Pankaj Bansal
On Fri, 12 Jun 2020 11:55:47 GMT, Pankaj Bansal wrote: >> I have run the test on OL82 on updated code. Following are the results. I >> will rerun this on Ubuntu 18.04 and get back with the results >> > src="https://user-images.githubusercontent.com/6153953/84469824-918dfa80-ac9f-11ea-9494-362087

Re: RFR: 8236651: Simplify and update glass gtk backend

2021-01-13 Thread Thiago Milczarek Sayao
On Wed, 10 Jun 2020 02:25:00 GMT, Thiago Milczarek Sayao wrote: >> I am running a full test using GTK 3 on Ubuntu 20.04 and will publish >> results. I will later do the same for Oracle Linux 7.7. >> >> One thing to note is that this new GTK pipeline doesn't run on Ubuntu 16.04. >> I get the f

Re: RFR: 8236651: Simplify and update glass gtk backend

2021-01-13 Thread Pankaj Bansal
On Fri, 12 Jun 2020 05:56:41 GMT, Pankaj Bansal wrote: >> Here is the result on Ubuntu 20.04 with the latest changes: >> >> ![image](https://user-images.githubusercontent.com/30704286/84271590-abdea180-ab02-11ea-9d2d-dbca39755db0.png) >> >> Some tests seems intermittent. > > I have run the test

Re: RFR: 8236651: Simplify and update glass gtk backend

2021-01-13 Thread Kevin Rushforth
On Tue, 9 Jun 2020 23:14:31 GMT, Kevin Rushforth wrote: >> In case it is useful to those reviewing the code, I have created a [WIP pull >> request](https://github.com/kevinrushforth/jfx/pull/1) in my repo solely for >> the purpose of looking at the diffs between the existing gtk native code and

Re: RFR: 8236651: Simplify and update glass gtk backend

2021-01-13 Thread Thiago Milczarek Sayao
On Tue, 24 Mar 2020 13:33:33 GMT, Thiago Milczarek Sayao wrote: >> I have been testing this for several days on ubuntu 18.04 and it's working >> good. It pass system tests, runs Ensemble 8 and Scenebuilder. >> >> Will have to do some tests on 16.04. > > Ubuntu 20.04 Test Results > > Updated A

Re: RFR: 8236651: Simplify and update glass gtk backend

2021-01-13 Thread Kevin Rushforth
On Sat, 6 Jun 2020 13:03:36 GMT, Pankaj Bansal wrote: >> @kevinrushforth Ok, will do as the instructions. Thanks. > > I ran the systemTests on Ubuntu 18.04 using gradle > -PEXTRA_TEST_ARGS='-Djavafx.gtk.experimental=true' -PFULL_TEST=true > -PUSE_ROBOT=true :systemTests:cleanTest :systemTests:t

Re: RFR: 8236651: Simplify and update glass gtk backend

2021-01-13 Thread Kevin Rushforth
On Fri, 3 Apr 2020 02:11:12 GMT, Thiago Milczarek Sayao wrote: >> Test on 16.04 (without Webkit - it does not build on 16.04 anymore) >> >> Updated April 2nd. >> >> ![image](https://user-images.githubusercontent.com/30704286/78316727-c14db300-7536-11ea-86e9-4d5c56e4d92c.png) >> >> Note: DateP

Re: RFR: 8236651: Simplify and update glass gtk backend

2021-01-13 Thread Pankaj Bansal
On Fri, 3 Apr 2020 23:41:49 GMT, Thiago Milczarek Sayao wrote: >> I see a lot of work going into this. >> >> In order for this to progress beyond the prototype or concept phase, we will >> need to have a discussion on the openjfx-dev mailing list in a separate >> email thread that is not dire

Re: RFR: 8236651: Simplify and update glass gtk backend

2021-01-13 Thread Thiago Milczarek Sayao
On Thu, 13 Feb 2020 23:56:42 GMT, Kevin Rushforth wrote: >> **Code Changes** >> >> * glass_window.cpp / glass_window.h >> * Removed WindowContextPlug and WindowContextChild (that were used for >> applets / web start) and moved everything to >> one class named WindowContext (since inheritanc

Re: RFR: 8236651: Simplify and update glass gtk backend

2021-01-13 Thread Thiago Milczarek Sayao
On Tue, 3 Mar 2020 11:10:07 GMT, Thiago Milczarek Sayao wrote: >> This is going to need further discussion on the mailing list as indicated >> above, so it is still premature to review it (i.e., it should still be >> considered effectively a "WIP" until that discussion happens). Additionally,

Re: RFR: 8236651: Simplify and update glass gtk backend

2021-01-13 Thread Thiago Milczarek Sayao
On Mon, 6 Jan 2020 22:41:07 GMT, Kevin Rushforth wrote: >>> Please, mark it as WIP. >> >> You can do this by editing the title and adding `WIP: ` as a prefix. > > This sort of enhancement needs to be discussed on the openjfx-dev mailing > list first. While the WIP PR might be used to illustrate

RFR: 8236651: Simplify and update glass gtk backend

2021-01-13 Thread Thiago Milczarek Sayao
### Summary * Simplify and update the Gtk glass backend, making Linux a first-class OpenJFX platform. ### Goals * Make Linux a first-class OpenJFX platform (see Motivation); * Simplify the code and reduce it's size; * Update to gtk3 (it was originally a port from gtk2); * Remove unused code (such

Re: RFR: 8236651: Simplify and update glass gtk backend

2021-01-13 Thread Thiago Milczarek Sayao
On Mon, 6 Jan 2020 22:57:31 GMT, Thiago Milczarek Sayao wrote: >> This sort of enhancement needs to be discussed on the openjfx-dev mailing >> list first. While the WIP PR might be used to illustrate what you have in >> mind to propose, it is premature to actually review the implementation >>

Re: RFR: 8236651: Simplify and update glass gtk backend

2021-01-13 Thread Kevin Rushforth
On Mon, 6 Jan 2020 00:28:14 GMT, Thiago Milczarek Sayao wrote: > ### Summary > * Simplify and update the Gtk glass backend, making Linux a first-class > OpenJFX platform. > > ### Goals > * Make Linux a first-class OpenJFX platform (see Motivation); > * Simplify the code and reduce it's size; >

RFR: 8236651: Simplify and update glass gtk backend

2020-12-19 Thread Thiago Milczarek Sayao
This is a new approach to rewrite parts of gtk glass backend to be more clean. I will provide small "manageable" PR to incrementally make the backend better. This PR adresses cleanup of the Size and Positioning code. It makes code more "straightforward" and easier to maintain. Current status: !

Re: RFR: 8236651: Simplify and update glass gtk backend [v63]

2020-11-12 Thread Thiago Milczarek Sayao
> ### Summary > * Simplify and update the Gtk glass backend, making Linux a first-class > OpenJFX platform. > > ### Goals > * Make Linux a first-class OpenJFX platform (see Motivation); > * Simplify the code and reduce it's size; > * Update to gtk3 (it was originally a port from gtk2); > * Remove

Re: RFR: 8236651: Simplify and update glass gtk backend

2020-09-21 Thread Thiago Milczarek Sayao
On Mon, 21 Sep 2020 23:40:50 GMT, Thiago Milczarek Sayao wrote: >>> I would starting hooking gtk event signals >>> (https://developer.gnome.org/gtk3/stable/GtkWidget.html), specially the >>> "touch-event" to JavaFx events (probably need to add through JNI). Should >>> be simple. Contact me at

Re: RFR: 8236651: Simplify and update glass gtk backend [v62]

2020-09-21 Thread Thiago Milczarek Sayao
> ### Summary > * Simplify and update the Gtk glass backend, making Linux a first-class > OpenJFX platform. > > ### Goals > * Make Linux a first-class OpenJFX platform (see Motivation); > * Simplify the code and reduce it's size; > * Update to gtk3 (it was originally a port from gtk2); > * Remove

Re: RFR: 8236651: Simplify and update glass gtk backend

2020-09-21 Thread Thiago Milczarek Sayao
On Thu, 27 Aug 2020 21:21:39 GMT, Tor (torbuntu) wrote: >> I would starting hooking gtk event signals >> (https://developer.gnome.org/gtk3/stable/GtkWidget.html), specially the >> "touch-event" to JavaFx events (probably need to add through JNI). Should be >> simple. Contact me at thiago.sayao

Re: RFR: 8236651: Simplify and update glass gtk backend [v61]

2020-09-21 Thread Thiago Milczarek Sayao
> ### Summary > * Simplify and update the Gtk glass backend, making Linux a first-class > OpenJFX platform. > > ### Goals > * Make Linux a first-class OpenJFX platform (see Motivation); > * Simplify the code and reduce it's size; > * Update to gtk3 (it was originally a port from gtk2); > * Remove

Re: RFR: 8236651: Simplify and update glass gtk backend

2020-08-27 Thread torbuntu
On Tue, 25 Aug 2020 14:12:14 GMT, Thiago Milczarek Sayao wrote: > I would starting hooking gtk event signals > (https://developer.gnome.org/gtk3/stable/GtkWidget.html), specially the > "touch-event" to JavaFx events (probably need to add through JNI). Should be > simple. Contact me at thiago.s

Re: RFR: 8236651: Simplify and update glass gtk backend

2020-08-25 Thread Thiago Milczarek Sayao
On Wed, 29 Jul 2020 21:01:42 GMT, Tor (torbuntu) wrote: >> @Torbuntu Not to this PR, I don't want to delay it too much. But can be done >> (I just do not own a touch device >> currently). > > Sounds good! I have a few devices I'd be more than excited to test on, and > even help add the feature

Re: RFR: 8236651: Simplify and update glass gtk backend

2020-07-29 Thread torbuntu
On Wed, 29 Jul 2020 20:46:16 GMT, Thiago Milczarek Sayao wrote: >> Would it be possible and related to add the gtk touch events to this PR as >> part of the Glass GTK3 update? Or would >> follow up update PR adding that be more appropriate? >> Currently linux desktop does not have touch support

Re: RFR: 8236651: Simplify and update glass gtk backend

2020-07-29 Thread Thiago Milczarek Sayao
On Wed, 29 Jul 2020 02:39:31 GMT, Tor (torbuntu) wrote: >>> If you want these commits to be preserved when you integrate, you will need >>> to make a 'merge-style' pull request. >> >> Please ignore this information from Skara. I don't know what caused it, but >> I've pinged the Skara folks ab

Re: RFR: 8236651: Simplify and update glass gtk backend

2020-07-28 Thread torbuntu
On Fri, 3 Jul 2020 13:49:54 GMT, Kevin Rushforth wrote: >> @pankaj-bansal Sorry for commiting again. Now the Tab Pane test works >> properly. > >> If you want these commits to be preserved when you integrate, you will need >> to make a 'merge-style' pull request. > > Please ignore this informa

Re: RFR: 8236651: Simplify and update glass gtk backend

2020-07-03 Thread Kevin Rushforth
On Sun, 14 Jun 2020 23:59:17 GMT, Thiago Milczarek Sayao wrote: >> This is the result on OL 82 with latest commit >> > src="https://user-images.githubusercontent.com/6153953/84592508-d82c5200-ae63-11ea-87d3-7f55671ed302.png";> > > @pankaj-bansal Sorry for commiting again. Now the Tab Pane test w

Re: RFR: 8236651: Simplify and update glass gtk backend

2020-06-14 Thread Thiago Milczarek Sayao
On Sun, 14 Jun 2020 11:55:45 GMT, Pankaj Bansal wrote: >> Following are results in Ubuntu 18.04 after fix for tab pane tests. >> > src="https://user-images.githubusercontent.com/6153953/84587007-3abc2880-ae39-11ea-8b61-0cbb86e4d4b5.png";> > > This is the result on OL 82 with latest commit > src=

Re: [Rev 59] RFR: 8236651: Simplify and update glass gtk backend

2020-06-14 Thread Thiago Milczarek Sayao
> ### Summary > * Simplify and update the Gtk glass backend, making Linux a first-class > OpenJFX platform. > > ### Goals > * Make Linux a first-class OpenJFX platform (see Motivation); > * Simplify the code and reduce it's size; > * Update to gtk3 (it was originally a port from gtk2); > * Remove

Re: RFR: 8236651: Simplify and update glass gtk backend

2020-06-14 Thread Pankaj Bansal
On Sun, 14 Jun 2020 06:49:42 GMT, Pankaj Bansal wrote: >> I have investigated the Tab Pane Drag Test and it works manually. >> >> import javafx.application.Application; >> import javafx.scene.Scene; >> import javafx.scene.control.Tab; >> import javafx.scene.control.TabPane; >> import javafx.stag

Re: RFR: 8236651: Simplify and update glass gtk backend

2020-06-13 Thread Pankaj Bansal
On Fri, 12 Jun 2020 20:22:12 GMT, Thiago Milczarek Sayao wrote: >>> I had used two compilation parameters to limit Gtk on 3.8 (so it would >>> generate error if any symbol > 3.8 were used). >>> But that does not seem to work on 18.04, so I removed it. >> >> Good. I was going to ask you about t

Re: [Rev 58] RFR: 8236651: Simplify and update glass gtk backend

2020-06-12 Thread Thiago Milczarek Sayao
> ### Summary > * Simplify and update the Gtk glass backend, making Linux a first-class > OpenJFX platform. > > ### Goals > * Make Linux a first-class OpenJFX platform (see Motivation); > * Simplify the code and reduce it's size; > * Update to gtk3 (it was originally a port from gtk2); > * Remove

Re: RFR: 8236651: Simplify and update glass gtk backend

2020-06-12 Thread Thiago Milczarek Sayao
On Fri, 12 Jun 2020 13:51:58 GMT, Kevin Rushforth wrote: >>> After the latest commit on June 10, this is not building for me on my >>> Ubuntu 18.04. I am attaching the build log for >>> reference. >>> [build.log](https://github.com/openjdk/jfx/files/4770864/build.log) >> >> It's now fixed. I h

Re: [Rev 57] RFR: 8236651: Simplify and update glass gtk backend

2020-06-12 Thread Thiago Milczarek Sayao
> ### Summary > * Simplify and update the Gtk glass backend, making Linux a first-class > OpenJFX platform. > > ### Goals > * Make Linux a first-class OpenJFX platform (see Motivation); > * Simplify the code and reduce it's size; > * Update to gtk3 (it was originally a port from gtk2); > * Remove

Re: RFR: 8236651: Simplify and update glass gtk backend

2020-06-12 Thread Kevin Rushforth
On Fri, 12 Jun 2020 13:49:23 GMT, Thiago Milczarek Sayao wrote: > I had used two compilation parameters to limit Gtk on 3.8 (so it would > generate error if any symbol > 3.8 were used). > But that does not seem to work on 18.04, so I removed it. Good. I was going to ask you about that, so I'm

Re: RFR: 8236651: Simplify and update glass gtk backend

2020-06-12 Thread Thiago Milczarek Sayao
On Fri, 12 Jun 2020 12:49:42 GMT, Pankaj Bansal wrote: > After the latest commit on June 10, this is not building for me on my Ubuntu > 18.04. I am attaching the build log for > reference. [build.log](https://github.com/openjdk/jfx/files/4770864/build.log) It's now fixed. I had used two compila

Re: [Rev 56] RFR: 8236651: Simplify and update glass gtk backend

2020-06-12 Thread Thiago Milczarek Sayao
> ### Summary > * Simplify and update the Gtk glass backend, making Linux a first-class > OpenJFX platform. > > ### Goals > * Make Linux a first-class OpenJFX platform (see Motivation); > * Simplify the code and reduce it's size; > * Update to gtk3 (it was originally a port from gtk2); > * Remove

Re: [Rev 55] RFR: 8236651: Simplify and update glass gtk backend

2020-06-12 Thread Thiago Milczarek Sayao
> ### Summary > * Simplify and update the Gtk glass backend, making Linux a first-class > OpenJFX platform. > > ### Goals > * Make Linux a first-class OpenJFX platform (see Motivation); > * Simplify the code and reduce it's size; > * Update to gtk3 (it was originally a port from gtk2); > * Remove

Re: RFR: 8236651: Simplify and update glass gtk backend

2020-06-12 Thread Pankaj Bansal
On Fri, 12 Jun 2020 11:55:47 GMT, Pankaj Bansal wrote: >> I have run the test on OL82 on updated code. Following are the results. I >> will rerun this on Ubuntu 18.04 and get back >> with the results > src="https://user-images.githubusercontent.com/6153953/84469824-918dfa80-ac9f-11ea-9494-362087

Re: RFR: 8236651: Simplify and update glass gtk backend

2020-06-12 Thread Pankaj Bansal
On Fri, 12 Jun 2020 05:56:41 GMT, Pankaj Bansal wrote: >> Here is the result on Ubuntu 20.04 with the latest changes: >> >> ![image](https://user-images.githubusercontent.com/30704286/84271590-abdea180-ab02-11ea-9d2d-dbca39755db0.png) >> >> Some tests seems intermittent. > > I have run the test

Re: RFR: 8236651: Simplify and update glass gtk backend

2020-06-11 Thread Pankaj Bansal
On Wed, 10 Jun 2020 13:11:29 GMT, Thiago Milczarek Sayao wrote: >>> I am running a full test using GTK 3 on Ubuntu 20.04 and will publish >>> results. I will later do the same for Oracle >>> Linux 7.7. >>> One thing to note is that this new GTK pipeline doesn't run on Ubuntu >>> 16.04. I get t

Re: RFR: 8236651: Simplify and update glass gtk backend

2020-06-10 Thread Thiago Milczarek Sayao
On Wed, 10 Jun 2020 02:25:00 GMT, Thiago Milczarek Sayao wrote: >> I am running a full test using GTK 3 on Ubuntu 20.04 and will publish >> results. I will later do the same for Oracle >> Linux 7.7. >> One thing to note is that this new GTK pipeline doesn't run on Ubuntu 16.04. >> I get the fo

Re: RFR: 8236651: Simplify and update glass gtk backend

2020-06-09 Thread Thiago Milczarek Sayao
On Tue, 9 Jun 2020 23:14:31 GMT, Kevin Rushforth wrote: > I am running a full test using GTK 3 on Ubuntu 20.04 and will publish > results. I will later do the same for Oracle > Linux 7.7. > One thing to note is that this new GTK pipeline doesn't run on Ubuntu 16.04. > I get the following runnin

Re: [Rev 54] RFR: 8236651: Simplify and update glass gtk backend

2020-06-09 Thread Thiago Milczarek Sayao
> ### Summary > * Simplify and update the Gtk glass backend, making Linux a first-class > OpenJFX platform. > > ### Goals > * Make Linux a first-class OpenJFX platform (see Motivation); > * Simplify the code and reduce it's size; > * Update to gtk3 (it was originally a port from gtk2); > * Remove

Re: [Rev 53] RFR: 8236651: Simplify and update glass gtk backend

2020-06-09 Thread Thiago Milczarek Sayao
> ### Summary > * Simplify and update the Gtk glass backend, making Linux a first-class > OpenJFX platform. > > ### Goals > * Make Linux a first-class OpenJFX platform (see Motivation); > * Simplify the code and reduce it's size; > * Update to gtk3 (it was originally a port from gtk2); > * Remove

Re: RFR: 8236651: Simplify and update glass gtk backend

2020-06-09 Thread Kevin Rushforth
On Tue, 9 Jun 2020 23:14:31 GMT, Kevin Rushforth wrote: >> In case it is useful to those reviewing the code, I have created a [WIP pull >> request](https://github.com/kevinrushforth/jfx/pull/1) in my repo solely for >> the purpose of looking at the diffs >> between the existing gtk native code a

Re: [Rev 52] RFR: 8236651: Simplify and update glass gtk backend

2020-06-09 Thread Thiago Milczarek Sayao
> ### Summary > * Simplify and update the Gtk glass backend, making Linux a first-class > OpenJFX platform. > > ### Goals > * Make Linux a first-class OpenJFX platform (see Motivation); > * Simplify the code and reduce it's size; > * Update to gtk3 (it was originally a port from gtk2); > * Remove

Re: RFR: 8236651: Simplify and update glass gtk backend

2020-06-09 Thread Kevin Rushforth
On Tue, 9 Jun 2020 23:12:15 GMT, Kevin Rushforth wrote: >> I ran the systemTests on Ubuntu 18.04 using >> gradle -PEXTRA_TEST_ARGS='-Djavafx.gtk.experimental=true' -PFULL_TEST=true >> -PUSE_ROBOT=true :systemTests:cleanTest >> :systemTests:test. Following are the results > alt="Results_18 04" >

Re: RFR: 8236651: Simplify and update glass gtk backend

2020-06-09 Thread Kevin Rushforth
On Sat, 6 Jun 2020 13:03:36 GMT, Pankaj Bansal wrote: >> @kevinrushforth Ok, will do as the instructions. Thanks. > > I ran the systemTests on Ubuntu 18.04 using > gradle -PEXTRA_TEST_ARGS='-Djavafx.gtk.experimental=true' -PFULL_TEST=true > -PUSE_ROBOT=true :systemTests:cleanTest > :systemTests:

Re: RFR: 8236651: Simplify and update glass gtk backend

2020-06-06 Thread Pankaj Bansal
On Fri, 3 Apr 2020 23:41:49 GMT, Thiago Milczarek Sayao wrote: >> I see a lot of work going into this. >> >> In order for this to progress beyond the prototype or concept phase, we will >> need to have a discussion on the >> openjfx-dev mailing list in a separate email thread that is not direc

Re: [Rev 51] RFR: 8236651: Simplify and update glass gtk backend

2020-04-30 Thread Thiago Milczarek Sayao
> ### Summary > * Simplify and update the Gtk glass backend, making Linux a first-class > OpenJFX platform. > > ### Goals > * Make Linux a first-class OpenJFX platform (see Motivation); > * Simplify the code and reduce it's size; > * Update to gtk3 (it was originally a port from gtk2); > * Remove

Re: [Rev 50] RFR: 8236651: Simplify and update glass gtk backend

2020-04-30 Thread Thiago Milczarek Sayao
> ### Summary > * Simplify and update the Gtk glass backend, making Linux a first-class > OpenJFX platform. > > ### Goals > * Make Linux a first-class OpenJFX platform (see Motivation); > * Simplify the code and reduce it's size; > * Update to gtk3 (it was originally a port from gtk2); > * Remove

Re: [Rev 49] RFR: 8236651: Simplify and update glass gtk backend

2020-04-10 Thread Thiago Milczarek Sayao
> ### Summary > * Simplify and update the Gtk glass backend, making Linux a first-class > OpenJFX platform. > > ### Goals > * Make Linux a first-class OpenJFX platform (see Motivation); > * Simplify the code and reduce it's size; > * Update to gtk3 (it was originally a port from gtk2); > * Remove

Re: [Rev 48] RFR: 8236651: Simplify and update glass gtk backend

2020-04-07 Thread Thiago Milczarek Sayao
> ### Summary > * Simplify and update the Gtk glass backend, making Linux a first-class > OpenJFX platform. > > ### Goals > * Make Linux a first-class OpenJFX platform (see Motivation); > * Simplify the code and reduce it's size; > * Update to gtk3 (it was originally a port from gtk2); > * Remove

Re: [Rev 47] RFR: 8236651: Simplify and update glass gtk backend

2020-04-05 Thread Thiago Milczarek Sayao
> ### Summary > * Simplify and update the Gtk glass backend, making Linux a first-class > OpenJFX platform. > > ### Goals > * Make Linux a first-class OpenJFX platform (see Motivation); > * Simplify the code and reduce it's size; > * Update to gtk3 (it was originally a port from gtk2); > * Remove

Re: [Rev 46] RFR: 8236651: Simplify and update glass gtk backend

2020-04-05 Thread Thiago Milczarek Sayao
> ### Summary > * Simplify and update the Gtk glass backend, making Linux a first-class > OpenJFX platform. > > ### Goals > * Make Linux a first-class OpenJFX platform (see Motivation); > * Simplify the code and reduce it's size; > * Update to gtk3 (it was originally a port from gtk2); > * Remove

Re: [Rev 45] RFR: 8236651: Simplify and update glass gtk backend

2020-04-05 Thread Thiago Milczarek Sayao
> ### Summary > * Simplify and update the Gtk glass backend, making Linux a first-class > OpenJFX platform. > > ### Goals > * Make Linux a first-class OpenJFX platform (see Motivation); > * Simplify the code and reduce it's size; > * Update to gtk3 (it was originally a port from gtk2); > * Remove

Re: [Rev 44] RFR: 8236651: Simplify and update glass gtk backend

2020-04-04 Thread Thiago Milczarek Sayao
> ### Summary > * Simplify and update the Gtk glass backend, making Linux a first-class > OpenJFX platform. > > ### Goals > * Make Linux a first-class OpenJFX platform (see Motivation); > * Simplify the code and reduce it's size; > * Update to gtk3 (it was originally a port from gtk2); > * Remove

Re: [Rev 43] RFR: 8236651: Simplify and update glass gtk backend

2020-04-03 Thread Thiago Milczarek Sayao
> This proposed change does the following: > > - Ports DND target to use GTK reducing code size and adding extra text / > image formats (such as .gif); > - Use gtk signals instead of gdk events (also to reduce code size); > - Simplifies geometry (sizing/positioning) with a more straightforward co

Re: RFR: 8236651: Simplify and update glass gtk backend

2020-04-03 Thread Thiago Milczarek Sayao
On Fri, 3 Apr 2020 15:21:29 GMT, Kevin Rushforth wrote: >> I will keep testing it, but I think it's looking good. > > I see a lot of work going into this. > > In order for this to progress beyond the prototype or concept phase, we will > need to have a discussion on the > openjfx-dev mailing li

Re: RFR: 8236651: Simplify and update glass gtk backend

2020-04-03 Thread Kevin Rushforth
On Fri, 3 Apr 2020 02:11:12 GMT, Thiago Milczarek Sayao wrote: >> Test on 16.04 (without Webkit - it does not build on 16.04 anymore) >> >> Updated April 2nd. >> >> ![image](https://user-images.githubusercontent.com/30704286/78316727-c14db300-7536-11ea-86e9-4d5c56e4d92c.png) >> >> Note: DateP

Re: RFR: 8236651: Simplify and update glass gtk backend

2020-04-02 Thread Thiago Milczarek Sayao
On Wed, 1 Apr 2020 03:21:31 GMT, Thiago Milczarek Sayao wrote: >> Ubuntu 20.04 Test Results >> >> Updated April 2nd. >> >> ![image](https://user-images.githubusercontent.com/30704286/78299385-28a23d80-750c-11ea-9edd-ac264f16c194.png) > > Test on 16.04 (without Webkit - it does not build on 16.

Re: [Rev 42] RFR: 8236651: Simplify and update glass gtk backend

2020-04-02 Thread Thiago Milczarek Sayao
> This proposed change does the following: > > - Ports DND target to use GTK reducing code size and adding extra text / > image formats (such as .gif); > - Use gtk signals instead of gdk events (also to reduce code size); > - Simplifies geometry (sizing/positioning) with a more straightforward co

Re: [Rev 41] RFR: 8236651: Simplify and update glass gtk backend

2020-04-02 Thread Thiago Milczarek Sayao
> This proposed change does the following: > > - Ports DND target to use GTK reducing code size and adding extra text / > image formats (such as .gif); > - Use gtk signals instead of gdk events (also to reduce code size); > - Simplifies geometry (sizing/positioning) with a more straightforward co

Re: [Rev 40] RFR: 8236651: Simplify and update glass gtk backend

2020-04-02 Thread Thiago Milczarek Sayao
> This proposed change does the following: > > - Ports DND target to use GTK reducing code size and adding extra text / > image formats (such as .gif); > - Use gtk signals instead of gdk events (also to reduce code size); > - Simplifies geometry (sizing/positioning) with a more straightforward co

Re: [Rev 39] RFR: 8236651: Simplify and update glass gtk backend

2020-04-02 Thread Thiago Milczarek Sayao
> This proposed change does the following: > > - Ports DND target to use GTK reducing code size and adding extra text / > image formats (such as .gif); > - Use gtk signals instead of gdk events (also to reduce code size); > - Simplifies geometry (sizing/positioning) with a more straightforward co

Re: [Rev 38] RFR: 8236651: Simplify and update glass gtk backend

2020-04-02 Thread Thiago Milczarek Sayao
> This proposed change does the following: > > - Ports DND target to use GTK reducing code size and adding extra text / > image formats (such as .gif); > - Use gtk signals instead of gdk events (also to reduce code size); > - Simplifies geometry (sizing/positioning) with a more straightforward co

Re: RFR: 8236651: Simplify and update glass gtk backend

2020-03-31 Thread Thiago Milczarek Sayao
On Tue, 24 Mar 2020 13:33:33 GMT, Thiago Milczarek Sayao wrote: >> I have been testing this for several days on ubuntu 18.04 and it's working >> good. It pass system tests, runs Ensemble 8 >> and Scenebuilder. >> Will have to do some tests on 16.04. > > Ubuntu 20.04 Test Results > > Updated 31

Re: [Rev 37] RFR: 8236651: Simplify and update glass gtk backend

2020-03-31 Thread Thiago Milczarek Sayao
> This proposed change does the following: > > - Ports DND target to use GTK reducing code size and adding extra text / > image formats (such as .gif); > - Use gtk signals instead of gdk events (also to reduce code size); > - Simplifies geometry (sizing/positioning) with a more straightforward co

Re: [Rev 36] RFR: 8236651: Simplify and update glass gtk backend

2020-03-31 Thread Thiago Milczarek Sayao
> This proposed change does the following: > > - Ports DND target to use GTK reducing code size and adding extra text / > image formats (such as .gif); > - Use gtk signals instead of gdk events (also to reduce code size); > - Simplifies geometry (sizing/positioning) with a more straightforward co

Re: [Rev 35] RFR: 8236651: Simplify and update glass gtk backend

2020-03-31 Thread Thiago Milczarek Sayao
> This proposed change does the following: > > - Ports DND target to use GTK reducing code size and adding extra text / > image formats (such as .gif); > - Use gtk signals instead of gdk events (also to reduce code size); > - Simplifies geometry (sizing/positioning) with a more straightforward co

Re: [Rev 34] RFR: 8236651: Simplify and update glass gtk backend

2020-03-31 Thread Thiago Milczarek Sayao
> This proposed change does the following: > > - Ports DND target to use GTK reducing code size and adding extra text / > image formats (such as .gif); > - Use gtk signals instead of gdk events (also to reduce code size); > - Simplifies geometry (sizing/positioning) with a more straightforward co

Re: [Rev 33] RFR: 8236651: Simplify and update glass gtk backend

2020-03-31 Thread Thiago Milczarek Sayao
> This proposed change does the following: > > - Ports DND target to use GTK reducing code size and adding extra text / > image formats (such as .gif); > - Use gtk signals instead of gdk events (also to reduce code size); > - Simplifies geometry (sizing/positioning) with a more straightforward co

Re: [Rev 32] RFR: 8236651: Simplify and update glass gtk backend

2020-03-30 Thread Thiago Milczarek Sayao
> This proposed change does the following: > > - Ports DND target to use GTK reducing code size and adding extra text / > image formats (such as .gif); > - Use gtk signals instead of gdk events (also to reduce code size); > - Simplifies geometry (sizing/positioning) with a more straightforward co

  1   2   >