Re: [Rev 02] RFR: 8239822: Intermittent unit test failures in RegionCSSTest

2020-02-25 Thread Kevin Rushforth
On Tue, 25 Feb 2020 11:51:09 GMT, Ajit Ghaisas wrote: >> The pull request has been updated with 1 additional commit. > > Marked as reviewed by aghaisas (Reviewer). > Looks good to me. Just the dates in the copyright headers need to be updated. They will get updated when I update copyrights of

Re: [Integrated] RFR: 8239822: Intermittent unit test failures in RegionCSSTest

2020-02-25 Thread Kevin Rushforth
Changeset: c3ee1a30 Author:Kevin Rushforth Date: 2020-02-25 14:01:57 + URL: https://git.openjdk.java.net/jfx/commit/c3ee1a30 8239822: Intermittent unit test failures in RegionCSSTest Reviewed-by: aghaisas ! modules/javafx.graphics/src/test/java/test/com/sun/javafx/css/StyleM

Re: [Rev 02] RFR: 8239822: Intermittent unit test failures in RegionCSSTest

2020-02-25 Thread Ajit Ghaisas
On Mon, 24 Feb 2020 19:36:47 GMT, Kevin Rushforth wrote: >> This is a fix for an intermittent test failure affecting >> `test.javafx.scene.layout.RegionCSSTest`. This turns out to be a test bug in >> `test.javafx.scene.CssStyleHelperTest`, which was added as part of >> [JDK-8237469](https://bu

Re: [Rev 02] RFR: 8239822: Intermittent unit test failures in RegionCSSTest

2020-02-25 Thread Dean Wookey
On Mon, 24 Feb 2020 19:36:47 GMT, Kevin Rushforth wrote: >> This is a fix for an intermittent test failure affecting >> `test.javafx.scene.layout.RegionCSSTest`. This turns out to be a test bug in >> `test.javafx.scene.CssStyleHelperTest`, which was added as part of >> [JDK-8237469](https://bu

Re: RFR: 8239822: Intermittent unit test failures in RegionCSSTest

2020-02-24 Thread Kevin Rushforth
On Mon, 24 Feb 2020 16:00:31 GMT, Kevin Rushforth wrote: >> test.javafx.css.Node_cssStateTransition_Test may also need the same >> treatment. > > Thanks for pointing that out. In addition to > `test.javafx.css.Node_cssStateTransition_Test`, the following test has a > similar pattern: > > tes

Re: [Rev 02] RFR: 8239822: Intermittent unit test failures in RegionCSSTest

2020-02-24 Thread Kevin Rushforth
> This is a fix for an intermittent test failure affecting > `test.javafx.scene.layout.RegionCSSTest`. This turns out to be a test bug in > `test.javafx.scene.CssStyleHelperTest`, which was added as part of > [JDK-8237469](https://bugs.openjdk.java.net/browse/JDK-8237469). > RegionCSSTest is a

Re: RFR: 8239822: Intermittent unit test failures in RegionCSSTest

2020-02-24 Thread Kevin Rushforth
On Sat, 22 Feb 2020 20:23:38 GMT, Dean Wookey wrote: >> @aghaisas Can you review this? >> >> @DeanWookey You are also welcome to review it if you like. > > test.javafx.css.Node_cssStateTransition_Test may also need the same treatment. Thanks for pointing that out. In addition to `test.javafx.

Re: RFR: 8239822: Intermittent unit test failures in RegionCSSTest

2020-02-22 Thread Dean Wookey
On Sat, 22 Feb 2020 15:54:16 GMT, Kevin Rushforth wrote: >> This is a fix for an intermittent test failure affecting >> `test.javafx.scene.layout.RegionCSSTest`. This turns out to be a test bug in >> `test.javafx.scene.CssStyleHelperTest`, which was added as part of >> [JDK-8237469](https://bu

Re: [Rev 01] RFR: 8239822: Intermittent unit test failures in RegionCSSTest

2020-02-22 Thread Kevin Rushforth
> This is a fix for an intermittent test failure affecting > `test.javafx.scene.layout.RegionCSSTest`. This turns out to be a test bug in > `test.javafx.scene.CssStyleHelperTest`, which was added as part of > [JDK-8237469](https://bugs.openjdk.java.net/browse/JDK-8237469). > RegionCSSTest is a

Re: RFR: 8239822: Intermittent unit test failures in RegionCSSTest

2020-02-22 Thread Kevin Rushforth
On Sat, 22 Feb 2020 15:51:24 GMT, Kevin Rushforth wrote: > This is a fix for an intermittent test failure affecting > `test.javafx.scene.layout.RegionCSSTest`. This turns out to be a test bug in > `test.javafx.scene.CssStyleHelperTest`, which was added as part of > [JDK-8237469](https://bugs.o

RFR: 8239822: Intermittent unit test failures in RegionCSSTest

2020-02-22 Thread Kevin Rushforth
This is a fix for an intermittent test failure affecting `test.javafx.scene.layout.RegionCSSTest`. This turns out to be a test bug in `test.javafx.scene.CssStyleHelperTest`, which was added as part of [JDK-8237469](https://bugs.openjdk.java.net/browse/JDK-8237469). RegionCSSTest is a victim of