On Thu, 13 Aug 2020 19:49:45 GMT, Kevin Rushforth wrote:
>> The fix looks good now. I'll file a follow-up issue for the potential leak
>> on the other platforms.
>>
>> My thinking is that if `focusedWindow` is only used in Monocle, we should
>> push the tracking down to the platform rather
>>
On Thu, 13 Aug 2020 19:26:47 GMT, Kevin Rushforth wrote:
>> tests/system/src/test/java/test/javafx/stage/FocusedWindowMonocleTest.java
>> line 56:
>>
>>> 55: }
>>> 56: }
>>
>> Minor: Add missing newline
>
> I meant that the file should end with a newline (it doesn't matter whether or
> no
On Thu, 13 Aug 2020 19:31:57 GMT, Kevin Rushforth wrote:
>> They are called from the following static method:
>> @BeforeClass
>> public static void initFX() throws Exception {
>> initFXBase();
>> }
>
> No, these two are only used from `testClosedFocusedStageLeakBase`, which is
On Thu, 13 Aug 2020 19:40:02 GMT, Kevin Rushforth wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> JDK-8241840
>> The tests are now reused for native and monocle tests.
>
> The fix looks good now. I'll file a
On Fri, 7 Aug 2020 21:34:49 GMT, Kevin Rushforth wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> JDK-8241840
>> The tests are now reused for native and monocle tests.
>
> tests/system/src/test/java/test/javaf
On Sun, 9 Aug 2020 17:11:27 GMT, Florian Kirmaier wrote:
>> tests/system/src/test/java/test/javafx/stage/FocusedWindowTestBase.java line
>> 60:
>>
>>> 59: static WeakReference closedFocusedStageWeak = null;
>>> 60: static Stage closedFocusedStage = null;
>>> 61:
>>
>> These two can be
On Wed, 22 Apr 2020 12:03:34 GMT, Florian Kirmaier
wrote:
>> Closed focused Stages are not collected with Monocle
>>
>> This commit adds a unit-test and a fix for collecting focused closed stages.
>>
>> ticket: https://bugs.openjdk.java.net/browse/JDK-8241840
>
> Florian Kirmaier has updated t
On Fri, 7 Aug 2020 21:38:27 GMT, Kevin Rushforth wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> JDK-8241840
>> The tests are now reused for native and monocle tests.
>
> tests/system/src/test/java/test/javaf
On Fri, 7 Aug 2020 20:39:56 GMT, Kevin Rushforth wrote:
>> As mentioned - I don't have a good setup to test this code on Windows.
>>
>> But I've checked where focusedWindow/getFocusedWindow is used, and I can
>> verify your assumption. I've searched through
>> the whole project and the variable
On Wed, 22 Apr 2020 12:03:34 GMT, Florian Kirmaier
wrote:
>> Closed focused Stages are not collected with Monocle
>>
>> This commit adds a unit-test and a fix for collecting focused closed stages.
>>
>> ticket: https://bugs.openjdk.java.net/browse/JDK-8241840
>
> Florian Kirmaier has updated t
On Tue, 28 Apr 2020 14:32:37 GMT, Florian Kirmaier
wrote:
>> modules/javafx.graphics/src/main/java/com/sun/glass/ui/Window.java line 1325:
>>
>>> 1324: this.isFocused = focused;
>>> 1325: if (this.isFocused && this.isVisible) {
>>> 1326: setFocusedWindow(
On Fri, 17 Apr 2020 12:57:28 GMT, Ambarish Rapte wrote:
>> The previous version of test failed on my Windows 10 machine with below
>> exception, but the updated version does not
>> fail,
>> test.javafx.stage.FocusedWindowTest > testLeak FAILED
>> junit.framework.AssertionFailedError: Expecte
12 matches
Mail list logo
