Re: RFR: 8242861: Update ImagePattern to apply SVG pattern transforms [v7]

2020-11-06 Thread Ambarish Rapte
On Mon, 12 Oct 2020 03:11:18 GMT, Arun Joseph wrote: >> fillPath() and fillRect() functions in >> [GraphicsContextJava.cpp](https://github.com/openjdk/jfx/blob/master/modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/java/GraphicsContextJava.cpp) >> use Image::drawPattern() fo

Re: RFR: 8242861: Update ImagePattern to apply SVG pattern transforms [v7]

2020-11-05 Thread Kevin Rushforth
On Wed, 4 Nov 2020 15:41:12 GMT, Arun Joseph wrote: >> modules/javafx.graphics/src/main/java/com/sun/prism/impl/ps/PaintHelper.java >> line 754: >> >>> 752: >>> 753: BaseTransform paintXform = paint.getPatternTransformNoClone(); >>> 754: if (paintXform != null) { >> >> Minor:

Re: RFR: 8242861: Update ImagePattern to apply SVG pattern transforms [v7]

2020-11-04 Thread Arun Joseph
On Tue, 3 Nov 2020 12:01:38 GMT, Ambarish Rapte wrote: >> Arun Joseph has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix incorrect concat param order > > modules/javafx.graphics/src/main/java/com/sun/prism/impl/ps/PaintHelper.java > li

Re: RFR: 8242861: Update ImagePattern to apply SVG pattern transforms [v7]

2020-11-03 Thread Ambarish Rapte
On Mon, 12 Oct 2020 03:11:18 GMT, Arun Joseph wrote: >> fillPath() and fillRect() functions in >> [GraphicsContextJava.cpp](https://github.com/openjdk/jfx/blob/master/modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/java/GraphicsContextJava.cpp) >> use Image::drawPattern() fo

Re: RFR: 8242861: Update ImagePattern to apply SVG pattern transforms [v6]

2020-10-12 Thread Arun Joseph
On Mon, 12 Oct 2020 13:42:08 GMT, Kevin Rushforth wrote: >> Instead of negation, it should have been at the opposite positions. I have >> fixed this in the latest commit. The arg >> list order for >> [`concatenate`](https://github.com/openjdk/jfx/blob/a56ba63bef9b33c4ad5cc9e05ae5bdb0ee480a3f/mod

Re: RFR: 8242861: Update ImagePattern to apply SVG pattern transforms [v7]

2020-10-12 Thread Kevin Rushforth
On Mon, 12 Oct 2020 03:11:18 GMT, Arun Joseph wrote: >> fillPath() and fillRect() functions in >> [GraphicsContextJava.cpp](https://github.com/openjdk/jfx/blob/master/modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/java/GraphicsContextJava.cpp) >> use Image::drawPattern() for

Re: RFR: 8242861: Update ImagePattern to apply SVG pattern transforms [v6]

2020-10-12 Thread Kevin Rushforth
On Mon, 12 Oct 2020 03:23:29 GMT, Arun Joseph wrote: >> modules/javafx.web/src/main/java/com/sun/javafx/webkit/prism/WCGraphicsPrismContext.java >> line 790: >> >>> 788: Affine3D at = new Affine3D(); >>> 789: at.translate(phase.getX(), phase.getY()); >>>

Re: RFR: 8242861: Update ImagePattern to apply SVG pattern transforms [v6]

2020-10-11 Thread Arun Joseph
On Fri, 9 Oct 2020 22:14:15 GMT, Kevin Rushforth wrote: >> Arun Joseph has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Update copyright year >> - Minor refactoring > > modules/javafx.web/src/main/java/com/sun/javafx/webkit/prism/WCGra

Re: RFR: 8242861: Update ImagePattern to apply SVG pattern transforms [v6]

2020-10-11 Thread Arun Joseph
On Fri, 9 Oct 2020 21:48:40 GMT, Kevin Rushforth wrote: >> Arun Joseph has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Update copyright year >> - Minor refactoring > > modules/javafx.graphics/src/main/java/com/sun/prism/j2d/J2DPrismGr

Re: RFR: 8242861: Update ImagePattern to apply SVG pattern transforms [v7]

2020-10-11 Thread Arun Joseph
> fillPath() and fillRect() functions in > [GraphicsContextJava.cpp](https://github.com/openjdk/jfx/blob/master/modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/java/GraphicsContextJava.cpp) > use Image::drawPattern() for applying patterns as fill. But drawPattern() > doesn't us

Re: RFR: 8242861: Update ImagePattern to apply SVG pattern transforms [v6]

2020-10-09 Thread Kevin Rushforth
On Mon, 24 Aug 2020 07:48:27 GMT, Arun Joseph wrote: >> fillPath() and fillRect() functions in >> [GraphicsContextJava.cpp](https://github.com/openjdk/jfx/blob/master/modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/java/GraphicsContextJava.cpp) >> use Image::drawPattern() for

Re: RFR: 8242861: Update ImagePattern to apply SVG pattern transforms [v6]

2020-08-24 Thread Arun Joseph
> fillPath() and fillRect() functions in > [GraphicsContextJava.cpp](https://github.com/openjdk/jfx/blob/master/modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/java/GraphicsContextJava.cpp) > use Image::drawPattern() for applying patterns as fill. But drawPattern() > doesn't us

Re: RFR: 8242861: Update ImagePattern to apply SVG pattern transforms [v5]

2020-08-23 Thread Arun Joseph
> fillPath() and fillRect() functions in > [GraphicsContextJava.cpp](https://github.com/openjdk/jfx/blob/master/modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/java/GraphicsContextJava.cpp) > use Image::drawPattern() for applying patterns as fill. But drawPattern() > doesn't us

Re: RFR: 8242861: Update ImagePattern to apply SVG pattern transforms [v4]

2020-08-19 Thread Arun Joseph
> fillPath() and fillRect() functions in > [GraphicsContextJava.cpp](https://github.com/openjdk/jfx/blob/master/modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/java/GraphicsContextJava.cpp) > use Image::drawPattern() for applying patterns as fill. But drawPattern() > doesn't us

Re: RFR: 8242861: Update ImagePattern to apply SVG pattern transforms [v3]

2020-07-20 Thread Arun Joseph
> fillPath() and fillRect() functions in > [GraphicsContextJava.cpp](https://github.com/openjdk/jfx/blob/master/modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/java/GraphicsContextJava.cpp) > use Image::drawPattern() for applying patterns as fill. But drawPattern() > doesn't us

Re: [Rev 01] RFR: 8242861: Update ImagePattern to apply SVG pattern transforms

2020-05-09 Thread Kevin Rushforth
On Thu, 23 Apr 2020 12:31:34 GMT, Arun Joseph wrote: >> fillPath() and fillRect() functions in >> [GraphicsContextJava.cpp](https://github.com/openjdk/jfx/blob/master/modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/java/GraphicsContextJava.cpp) >> use Image::drawPattern() for

Re: RFR: 8242861: Update ImagePattern to apply SVG pattern transforms

2020-04-29 Thread Arun Joseph
On Wed, 29 Apr 2020 06:45:04 GMT, Arun Joseph wrote: >> Since this is in a common method used by all shapes, and not just WebView, >> we will need to ensure no regressions. > > All ImagePattern objects, other than the one from WebView, uses the second > constructor which assigns an identity > t

Re: RFR: 8242861: Update ImagePattern to apply SVG pattern transforms

2020-04-28 Thread Arun Joseph
On Mon, 27 Apr 2020 23:56:37 GMT, Kevin Rushforth wrote: >> fillPath() and fillRect() functions in >> [GraphicsContextJava.cpp](https://github.com/openjdk/jfx/blob/master/modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/java/GraphicsContextJava.cpp) >> use Image::drawPattern()

Re: RFR: 8242861: Update ImagePattern to apply SVG pattern transforms

2020-04-27 Thread Kevin Rushforth
On Mon, 20 Apr 2020 05:40:51 GMT, Arun Joseph wrote: > fillPath() and fillRect() functions in > [GraphicsContextJava.cpp](https://github.com/openjdk/jfx/blob/master/modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/java/GraphicsContextJava.cpp) > use Image::drawPattern() for app

Re: [Rev 01] RFR: 8242861: Update ImagePattern to apply SVG pattern transforms

2020-04-23 Thread Arun Joseph
> fillPath() and fillRect() functions in > [GraphicsContextJava.cpp](https://github.com/openjdk/jfx/blob/master/modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/java/GraphicsContextJava.cpp) > use Image::drawPattern() for applying patterns as fill. But drawPattern() > doesn't us

RFR: 8242861: Update ImagePattern to apply SVG pattern transforms

2020-04-22 Thread Arun Joseph
fillPath() and fillRect() functions in [GraphicsContextJava.cpp](https://github.com/openjdk/jfx/blob/master/modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/java/GraphicsContextJava.cpp) use Image::drawPattern() for applying patterns as fill. But drawPattern() doesn't use patter