Re: RFR: 8264064: Cross compile JavaFX graphics and controls modules for Windows AArch64 (ARM64) [v2]

2021-04-21 Thread Johan Vos
On Tue, 13 Apr 2021 08:43:07 GMT, Alexander Scherbatiy wrote: >> Alexander Scherbatiy has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove mt.exe from win.gradle build script > > I removed `ext.MC = cygpath("$winSdkBinDir/mt.exe")` li

Re: RFR: 8264064: Cross compile JavaFX graphics and controls modules for Windows AArch64 (ARM64) [v4]

2021-04-20 Thread Johan Vos
On Thu, 15 Apr 2021 17:37:08 GMT, Alexander Scherbatiy wrote: >> This is a proposal for cross compiling JavaFX base modules (excluding media >> and webkit) for Windows AArch64 (ARM64). >> >> Main changes: >> - prismES2 native compilation is moved under IS_INCLUDE_ES2 condition >> - HOST_ARCH a

Re: RFR: 8264064: Cross compile JavaFX graphics and controls modules for Windows AArch64 (ARM64) [v4]

2021-04-17 Thread Johan Vos
On Thu, 15 Apr 2021 17:37:08 GMT, Alexander Scherbatiy wrote: >> This is a proposal for cross compiling JavaFX base modules (excluding media >> and webkit) for Windows AArch64 (ARM64). >> >> Main changes: >> - prismES2 native compilation is moved under IS_INCLUDE_ES2 condition >> - HOST_ARCH a

Re: RFR: 8264064: Cross compile JavaFX graphics and controls modules for Windows AArch64 (ARM64) [v4]

2021-04-16 Thread Kevin Rushforth
On Thu, 15 Apr 2021 17:37:08 GMT, Alexander Scherbatiy wrote: >> This is a proposal for cross compiling JavaFX base modules (excluding media >> and webkit) for Windows AArch64 (ARM64). >> >> Main changes: >> - prismES2 native compilation is moved under IS_INCLUDE_ES2 condition >> - HOST_ARCH a

Re: RFR: 8264064: Cross compile JavaFX graphics and controls modules for Windows AArch64 (ARM64) [v3]

2021-04-15 Thread Alexander Scherbatiy
On Thu, 15 Apr 2021 15:57:32 GMT, Kevin Rushforth wrote: >> build.gradle line 264: >> >>> 262: case "amd64" : return "x64" >>> 263: default: return arch >>> 264: } >> >> I think a function that gets the "converted" arch is very useful, but I'm >> not sure what the resulting

Re: RFR: 8264064: Cross compile JavaFX graphics and controls modules for Windows AArch64 (ARM64) [v4]

2021-04-15 Thread Alexander Scherbatiy
> This is a proposal for cross compiling JavaFX base modules (excluding media > and webkit) for Windows AArch64 (ARM64). > > Main changes: > - prismES2 native compilation is moved under IS_INCLUDE_ES2 condition > - HOST_ARCH and TARGET_ARCH are retrieved from ext.OS_ARCH and > ext.TARGET_ARCH u

Re: RFR: 8264064: Cross compile JavaFX graphics and controls modules for Windows AArch64 (ARM64) [v3]

2021-04-15 Thread Kevin Rushforth
On Thu, 15 Apr 2021 15:34:42 GMT, Johan Vos wrote: >> Alexander Scherbatiy has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Add CONVERTED_OS_ARCH and CONVERTED_TARGET_ARCH variables > > build.gradle line 264: > >> 262: case "amd6

Re: RFR: 8264064: Cross compile JavaFX graphics and controls modules for Windows AArch64 (ARM64) [v3]

2021-04-15 Thread Johan Vos
On Thu, 15 Apr 2021 13:56:12 GMT, Alexander Scherbatiy wrote: >> This is a proposal for cross compiling JavaFX base modules (excluding media >> and webkit) for Windows AArch64 (ARM64). >> >> Main changes: >> - prismES2 native compilation is moved under IS_INCLUDE_ES2 condition >> - HOST_ARCH a

Re: RFR: 8264064: Cross compile JavaFX graphics and controls modules for Windows AArch64 (ARM64) [v2]

2021-04-15 Thread Alexander Scherbatiy
On Wed, 14 Apr 2021 15:02:06 GMT, Johan Vos wrote: >> Yes, this does seem like a better plan. Should this be done as a follow-on >> or do you want to see it done now? One reason I ask is that my PR #462 >> (which is now approved, but waiting re-review) does something similar to >> `getWinArch(

Re: RFR: 8264064: Cross compile JavaFX graphics and controls modules for Windows AArch64 (ARM64) [v3]

2021-04-15 Thread Alexander Scherbatiy
> This is a proposal for cross compiling JavaFX base modules (excluding media > and webkit) for Windows AArch64 (ARM64). > > Main changes: > - prismES2 native compilation is moved under IS_INCLUDE_ES2 condition > - HOST_ARCH and TARGET_ARCH are retrieved from ext.OS_ARCH and > ext.TARGET_ARCH u

Re: RFR: 8264064: Cross compile JavaFX graphics and controls modules for Windows AArch64 (ARM64) [v2]

2021-04-14 Thread Johan Vos
On Wed, 14 Apr 2021 14:56:16 GMT, Kevin Rushforth wrote: >> buildSrc/win.gradle line 46: >> >>> 44: def HOST_ARCH = getWinArch(ext.OS_ARCH) >>> 45: def TARGET_ARCH = getWinArch(ext.TARGET_ARCH) >>> 46: def IS_CROSS = HOST_ARCH != TARGET_ARCH >> >> can we move this to build.gradle? >> With the i

Re: RFR: 8264064: Cross compile JavaFX graphics and controls modules for Windows AArch64 (ARM64) [v2]

2021-04-14 Thread Kevin Rushforth
On Wed, 14 Apr 2021 14:38:05 GMT, Johan Vos wrote: >> Alexander Scherbatiy has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove mt.exe from win.gradle build script > > buildSrc/win.gradle line 46: > >> 44: def HOST_ARCH = getWinArch(e

Re: RFR: 8264064: Cross compile JavaFX graphics and controls modules for Windows AArch64 (ARM64) [v2]

2021-04-14 Thread Johan Vos
On Tue, 13 Apr 2021 08:41:12 GMT, Alexander Scherbatiy wrote: >> This is a proposal for cross compiling JavaFX base modules (excluding media >> and webkit) for Windows AArch64 (ARM64). >> >> Main changes: >> - prismES2 native compilation is moved under IS_INCLUDE_ES2 condition >> - HOST_ARCH a

Re: RFR: 8264064: Cross compile JavaFX graphics and controls modules for Windows AArch64 (ARM64) [v2]

2021-04-14 Thread Kevin Rushforth
On Tue, 13 Apr 2021 08:41:12 GMT, Alexander Scherbatiy wrote: >> This is a proposal for cross compiling JavaFX base modules (excluding media >> and webkit) for Windows AArch64 (ARM64). >> >> Main changes: >> - prismES2 native compilation is moved under IS_INCLUDE_ES2 condition >> - HOST_ARCH a

Re: RFR: 8264064: Cross compile JavaFX graphics and controls modules for Windows AArch64 (ARM64) [v2]

2021-04-14 Thread Kevin Rushforth
On Wed, 14 Apr 2021 13:44:49 GMT, Alexander Scherbatiy wrote: >> buildSrc/win.gradle line 474: >> >>> 472: boolean isExecutable(String file) { >>> 473: try { >>> 474: Runtime.runtime.exec(file) >> >> Is there a way other than to execute the command in question -- `rc` or >> `fxc`

Re: RFR: 8264064: Cross compile JavaFX graphics and controls modules for Windows AArch64 (ARM64) [v2]

2021-04-14 Thread Alexander Scherbatiy
On Tue, 13 Apr 2021 13:04:53 GMT, Kevin Rushforth wrote: >> Alexander Scherbatiy has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove mt.exe from win.gradle build script > > buildSrc/win.gradle line 474: > >> 472: boolean isExecutable

Re: RFR: 8264064: Cross compile JavaFX graphics and controls modules for Windows AArch64 (ARM64) [v2]

2021-04-14 Thread Alexander Scherbatiy
On Tue, 13 Apr 2021 13:13:50 GMT, Kevin Rushforth wrote: >> Alexander Scherbatiy has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove mt.exe from win.gradle build script > > buildSrc/win.gradle line 468: > >> 466: case "aarch6

Re: RFR: 8264064: Cross compile JavaFX graphics and controls modules for Windows AArch64 (ARM64) [v2]

2021-04-13 Thread Kevin Rushforth
On Tue, 13 Apr 2021 08:41:12 GMT, Alexander Scherbatiy wrote: >> This is a proposal for cross compiling JavaFX base modules (excluding media >> and webkit) for Windows AArch64 (ARM64). >> >> Main changes: >> - prismES2 native compilation is moved under IS_INCLUDE_ES2 condition >> - HOST_ARCH a

Re: RFR: 8264064: Cross compile JavaFX graphics and controls modules for Windows AArch64 (ARM64) [v2]

2021-04-13 Thread Alexander Scherbatiy
On Tue, 13 Apr 2021 08:41:12 GMT, Alexander Scherbatiy wrote: >> This is a proposal for cross compiling JavaFX base modules (excluding media >> and webkit) for Windows AArch64 (ARM64). >> >> Main changes: >> - prismES2 native compilation is moved under IS_INCLUDE_ES2 condition >> - HOST_ARCH a

Re: RFR: 8264064: Cross compile JavaFX graphics and controls modules for Windows AArch64 (ARM64) [v2]

2021-04-13 Thread Alexander Scherbatiy
> This is a proposal for cross compiling JavaFX base modules (excluding media > and webkit) for Windows AArch64 (ARM64). > > Main changes: > - prismES2 native compilation is moved under IS_INCLUDE_ES2 condition > - HOST_ARCH and TARGET_ARCH are retrieved from ext.OS_ARCH and > ext.TARGET_ARCH u

RFR: 8264064: Cross compile JavaFX graphics and controls modules for Windows AArch64 (ARM64)

2021-03-23 Thread Alexander Scherbatiy
This is a proposal for cross compiling JavaFX base modules (excluding media and webkit) for Windows AArch64 (ARM64). Main changes: - prismES2 native compilation is moved under IS_INCLUDE_ES2 condition - HOST_ARCH and TARGET_ARCH are retrieved from ext.OS_ARCH and ext.TARGET_ARCH using substitut