Re: RFR: 8268120: Allow hardware cursor to be used on Monocle-EGL platforms [v2]

2021-06-04 Thread Johan Vos
On Fri, 4 Jun 2021 12:55:36 GMT, Alexander Scherbatiy wrote: >> What would be the advantage of changing it? In any case, it seems unrelated >> to this fix. > > All other methods doEglChooseConfig, doEglCreateWindowSurface, > doEglCreateContext, doEglMakeCurrent, doEglSwapBuffers use `jlong >

Re: RFR: 8268120: Allow hardware cursor to be used on Monocle-EGL platforms [v2]

2021-06-04 Thread Kevin Rushforth
On Thu, 3 Jun 2021 11:41:02 GMT, Johan Vos wrote: >> Add EGL cursor implementation (Java + native) and the link to low-level >> drivers. >> Fix for JDK-8268120 > > Johan Vos has updated the pull request incrementally with one additional > commit since the last revision: > > fix typo after la

Re: RFR: 8268120: Allow hardware cursor to be used on Monocle-EGL platforms [v2]

2021-06-04 Thread Alexander Scherbatiy
On Fri, 4 Jun 2021 12:42:23 GMT, Kevin Rushforth wrote: >> modules/javafx.graphics/src/main/native-glass/monocle/egl/egl_ext.h line 39: >> >>> 37: >>> 38: // initialize the EGL system with the specified handle >>> 39: extern jboolean doEglInitialize(void* handle); >> >> Is it possible to decla

Re: RFR: 8268120: Allow hardware cursor to be used on Monocle-EGL platforms [v2]

2021-06-04 Thread Kevin Rushforth
On Fri, 4 Jun 2021 12:26:01 GMT, Alexander Scherbatiy wrote: >> Johan Vos has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fix typo after last-minute inversion (make hwcursor default instead of >> swcursor) > > modules/javafx.graphics/s

Re: RFR: 8268120: Allow hardware cursor to be used on Monocle-EGL platforms [v2]

2021-06-04 Thread Alexander Scherbatiy
On Thu, 3 Jun 2021 11:41:02 GMT, Johan Vos wrote: >> Add EGL cursor implementation (Java + native) and the link to low-level >> drivers. >> Fix for JDK-8268120 > > Johan Vos has updated the pull request incrementally with one additional > commit since the last revision: > > fix typo after la

Re: RFR: 8268120: Allow hardware cursor to be used on Monocle-EGL platforms [v2]

2021-06-04 Thread Jose Pereda
On Thu, 3 Jun 2021 11:41:02 GMT, Johan Vos wrote: >> Add EGL cursor implementation (Java + native) and the link to low-level >> drivers. >> Fix for JDK-8268120 > > Johan Vos has updated the pull request incrementally with one additional > commit since the last revision: > > fix typo after la

Re: RFR: 8268120: Allow hardware cursor to be used on Monocle-EGL platforms [v2]

2021-06-03 Thread Johan Vos
> Add EGL cursor implementation (Java + native) and the link to low-level > drivers. > Fix for JDK-8268120 Johan Vos has updated the pull request incrementally with one additional commit since the last revision: fix typo after last-minute inversion (make hwcursor default instead of swcursor)