Re: RFR: 8278134: Move static utility methods to infrastructure (EditAndScrollTest) [v2]

2021-12-16 Thread Ajit Ghaisas
On Thu, 16 Dec 2021 12:54:27 GMT, Jeanette Winzenburg wrote: >> Extracted static test utility methods from EditAndScrollTest into new >> VirtualizedControlTestUtils, added rudimentary tests for the methods. > > Jeanette Winzenburg has updated the pull request incrementally with one >

Re: RFR: 8278134: Move static utility methods to infrastructure (EditAndScrollTest) [v2]

2021-12-16 Thread Jeanette Winzenburg
> Extracted static test utility methods from EditAndScrollTest into new > VirtualizedControlTestUtils, added rudimentary tests for the methods. Jeanette Winzenburg has updated the pull request incrementally with one additional commit since the last revision: fixed c error in doc

Re: RFR: 8278134: Move static utility methods to infrastructure (EditAndScrollTest) [v2]

2021-12-16 Thread Jeanette Winzenburg
On Thu, 16 Dec 2021 11:00:39 GMT, Ajit Ghaisas wrote: >> Jeanette Winzenburg has updated the pull request incrementally with one >> additional commit since the last revision: >> >> fixed c error in doc > >

Re: RFR: 8278134: Move static utility methods to infrastructure (EditAndScrollTest)

2021-12-16 Thread Ajit Ghaisas
On Thu, 9 Dec 2021 12:43:54 GMT, Jeanette Winzenburg wrote: > Extracted static test utility methods from EditAndScrollTest into new > VirtualizedControlTestUtils, added rudimentary tests for the methods. This looks good except for a typo which is not introduced by you!

RFR: 8278134: Move static utility methods to infrastructure (EditAndScrollTest)

2021-12-10 Thread Jeanette Winzenburg
Extracted static test utility methods from EditAndScrollTest into new VirtualizedControlTestUtils, added rudimentary tests for the methods. - Commit messages: - 8278134: Move static utility methods to infrastructure Changes: https://git.openjdk.java.net/jfx/pull/690/files Webrev: